From nobody Tue Jun 9 00:50:06 2026 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 672833D1A99 for ; Mon, 25 May 2026 07:18:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779693488; cv=none; b=Ouci2sDcaDj2q6AITqZ2pSIGEaUolcZQemB5tx4crPZtATcIIzWZk+WZ253LeoE0Pqu2svUIsqdok0t5J8n9D00WXWzUgu6CSXreRRlYnnLY2eWEVg08JV4/lOsqoPbyTiLwDtIlkyhz0Hu1IC/O6fV6JWrjL1TgbLeCs1A3dSo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779693488; c=relaxed/simple; bh=elVZL+cFaEjt0H3zP2/DXuvpO4bj2FRLORne/b3aZF0=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=jV02H9RA0nt1tV2m7q7FmLZRctR3dxUVeAfXc0VzX2kJ2VevUztCPN+myIwA+42tg0d325bYUrmbJQ8+TwA6diHqtg1UyTdE4NSdjsq8V54St37VTB8mdNRQc5KX6ZhR8IVkNjpN+UPqvU4uczFIjp0SvXLFV4EViEPgYzLyzpk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ppYcIuOM; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ppYcIuOM" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-3664df32e91so10775616a91.3 for ; Mon, 25 May 2026 00:18:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779693485; x=1780298285; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=dY5VqgEpZOUQ9fXY91xibrPNtOIYayMgpf0o5tFN89Y=; b=ppYcIuOMHhHY2N9VZoXpdCDWzhzLXvmVxgrEnokp+vzWJwvxgNG1XEob/Riu6R4rdd ducLgXRxxITonUV0VqLvRlGh5WBij1t+HZjOgbSogUj0TApWJOx5QOyJ6fCuFmzcshWM GVjvi4IVLumj4KYnFc0RrGQKgZstyPmTAOB1tYanL6dYJtkQYFVVfPd1ZvjcdaehTFhn bWRrtiRVf1eyJ6SQArRnHmF7RdhR/VMsOApUJeDAZtnMGGpFsLwsjn1wVZr2I5s4kicP dyeg92fsiexSyNLS1kBUMNI3AQ5/ju0hAHQj0zCuTarVnML0PYi3Q31Aa9dytBJN7lv3 W3SA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779693485; x=1780298285; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=dY5VqgEpZOUQ9fXY91xibrPNtOIYayMgpf0o5tFN89Y=; b=H6qNl+weS6oQjC/mwWSbZ/YAN/zJb/IR71NvOshTesRmUA7WYygyfQFol2+9R2km5V EgRq6I4SQAEaY56OhX6Kzyf4WvvZI76mNl2tr2nExMoMpFLuDnvcrHc3OZfDs+BUGb1F JjYqpkmr7KW4O9dRnmBqffOn5Ht/ODgsJSgQ3uDgQxT8p4DswyevrTLxfr9BjZi6kje4 aqfmTAVxlWsMUoayzxHgydZGKBYxt7ed3fN42HdrIZIzKJtaD//orv6ZwAd7w5hSzgJa ZVfi2LTAsodkSqZkObs58/QkOQPb8z7xSGQsE8xOiG0rfByUrVJbONAtm4himXiNCdgV zhWg== X-Forwarded-Encrypted: i=1; AFNElJ8q2E0VjACSYFZLrefSZ5NMOcZUOqupH/2AMmMiTbth2j6QqRwvVnulM6LVZCyrCcyNhXO4z+wEkp+JJfs=@vger.kernel.org X-Gm-Message-State: AOJu0YyaVdFTu+vMUISS7wobkJ8Yjb20YswnjUQABZaphCyuOQjoLfDT LnQC5F95zz1GYSg7MJb+a2y5cakH6PKubaEk9m7s1gDTh3rGrxGp5UXc3kRNwQ== X-Gm-Gg: Acq92OG6V4nZZmbvN7HYycV933OPlZ8xbIb9mAr3E29rSxqSlwS7miCSH7OuKJboeJB NBsZ+9Gc+QfCVcb0uppP1k24w2BHdMqRwbg5agXkx8Q0sxaKY2m/A4v1Ow7d9YbagPgVRbzmcai QQkB2H9mMp6LWfipkz0ja5Gjj/zLymhNkPbNgXZvesEpeXD0ZtD6KVdDegjpsATJ8lkOObDI5fT TmPcFQ1CMI82/B/DDxmb735IARVTVm/O+IWuiFudYrZvUKFferdA1gDH7hBQUgMNelZh6UdEgsI z62FY50GZZaZoSSoMUqOFaA9yopmCPv2vOhNxoDZai6pXWD7Rvu8egJiBKVlCYZMavtmrQnAEie vRBrVMXSKoouGoTP9/OZgbRlaYdIVSOHNAsQhM89Y5EK9vxhVnWNE0MHAelRpZIX5hiRRQuxjwn 4DDbm9DaqqeMvInCYFrOkszdcjjlN4WBwBuwnHqATCNvbAE6UA6ZFhbW4xz/INt0BZlyqvnQ== X-Received: by 2002:a17:903:1a23:b0:2b4:5cea:f61c with SMTP id d9443c01a7336-2beb0631933mr154289955ad.4.1779693484605; Mon, 25 May 2026 00:18:04 -0700 (PDT) Received: from csl-conti-dell7858.ntu.edu.sg ([155.69.195.57]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2beb58dba7bsm83293895ad.66.2026.05.25.00.18.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 May 2026 00:18:04 -0700 (PDT) From: Maoyi Xie To: Ido Schimmel Cc: Petr Machata , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next] mlxsw: spectrum_fid: use a dedicated list head pointer for sorted insert Date: Mon, 25 May 2026 15:17:59 +0800 Message-Id: <20260525071759.1517576-1-maoyixie.tju@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" mlxsw_sp_fid_port_vid_list_add() inserts into a list sorted by local_port. It walks the list to find the first entry with a larger local_port, then inserts the new entry before it: list_add_tail(&port_vid->list, &tmp_port_vid->list); If the loop falls through (the new local_port is the largest), tmp_port_vid runs off the end of the list. &tmp_port_vid->list then ends up at the list head itself (container_of() offsets cancel), and list_add_tail() inserts at the tail. So the code works today. It is fragile though. Anyone who later adds a read of another field of tmp_port_vid will hit memory outside the list head. Track the insertion point with a dedicated list_head pointer. Initialise insert_before to &fid->port_vid_list, set it to &tmp_port_vid->list only on early break, and pass insert_before to list_add_tail(). The cursor is no longer touched after the loop. Behaviour is unchanged. Same shape as the Koschel cleanups from 2022 (e.g. 99d8ae4ec8a tracing, 2966a9918df clockevents, dc1acd5c946 dlm). Signed-off-by: Maoyi Xie Reviewed-by: Ido Schimmel --- drivers/net/ethernet/mellanox/mlxsw/spectrum_fid.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_fid.c b/drivers/n= et/ethernet/mellanox/mlxsw/spectrum_fid.c index 4f921bbc1e77..8d6cea43be61 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_fid.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_fid.c @@ -1021,6 +1021,7 @@ mlxsw_sp_fid_port_vid_list_add(struct mlxsw_sp_fid *f= id, u16 local_port, u16 vid) { struct mlxsw_sp_fid_port_vid *port_vid, *tmp_port_vid; + struct list_head *insert_before =3D &fid->port_vid_list; =20 port_vid =3D kzalloc_obj(*port_vid); if (!port_vid) @@ -1030,11 +1031,13 @@ mlxsw_sp_fid_port_vid_list_add(struct mlxsw_sp_fid = *fid, u16 local_port, port_vid->vid =3D vid; =20 list_for_each_entry(tmp_port_vid, &fid->port_vid_list, list) { - if (tmp_port_vid->local_port > local_port) + if (tmp_port_vid->local_port > local_port) { + insert_before =3D &tmp_port_vid->list; break; + } } =20 - list_add_tail(&port_vid->list, &tmp_port_vid->list); + list_add_tail(&port_vid->list, insert_before); return 0; } =20 --=20 2.34.1