From nobody Tue Jun 9 01:01:18 2026 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E16C0380FEA for ; Mon, 25 May 2026 06:15:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779689711; cv=none; b=eJMROekelpx3Se32+Psuun2/Pr9KNkk541JaBh74hz6XN5CFGqUi6Wm2rudJ4xXe2gEKOQHpx/dkuB0gkA0tn0hzCxKqEXlkA7/XTORNyJMkI8udxwD++jWkCBUXl8phXkFR4aJyJQAhs8WC6sHMSa3o3j1I2Nsvd6cK8RaMNPI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779689711; c=relaxed/simple; bh=VSMoAIEkfJohdFzr9Td2CnodOCaQEWoYxWMgDSGLdgo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=u1pej7jKSMtN40BhD1eEoI9GvkjE5scLh27HPHlTAJgjHrn2LXDu3Rh2T9y6XXKSRDiJjqnynRNyJNKEf/3HuHTwU8Rp6WTA0or4mg5V9qGSUiQQ5xdgIMPSk5hJbYZ+FYifeYsKN1euB4ZIlTwJggUIp9/XQ/76w41OpQtQXY4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FVBrPtgY; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FVBrPtgY" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2ba17c8cfacso97554915ad.2 for ; Sun, 24 May 2026 23:15:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779689703; x=1780294503; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=e524VIBtCoTvqSRyApwFpsXYxkWr/qEm71Ha8pUe2kQ=; b=FVBrPtgYnSebSVc4uy3Pm0U3FrrOI/c+GYLmi7kOFnVophG5I0DVbAk4PB2XutQTNl la6RsXeXBgs3s5vB9nVvMT5XVN/9VWuZ+lC150lwWyEevs5l13riYl27JUrHnSXfddOT LMTlJw1Zk8yYRa+28Bc3naLGyRA8vPeLjfJvDkrhghppBg2bpOeQRFykaiKw1dolgIXy 8CDUforp7Fj6JzEjh0ux3eIs9zwgeHuWSBMQ4irSzAbPPYCZt8Ayhgs/kZjjNQu39Uk6 iTlMk+yXMVQymy5/6E/AHsNJ2ISryRipP2RVdpdU2a2knfOu0dMNFLmg3DgUqBiTN7/h jCYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779689703; x=1780294503; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e524VIBtCoTvqSRyApwFpsXYxkWr/qEm71Ha8pUe2kQ=; b=A1Pv1ge8fN0vCoMIT+kscGfPqEVtJQAc7koCt4I/qSpf3VvueplakbdLDmP60Gtucr NNvAAqO0kUaiW2ltgdr+WvpRvc5xHcUI1dj8WrLvd6a7ONRRPBqtCyqH7v4mj03ikaB/ n6m4m3a3JUaH5d+MUXZbtaROMjrbOwKVbhKiPkqlxSIVXXISUlXF8wrczKvvYGu5WGei 3T5Pqb/v11b9niAba5zG0cwsAmL9AY1kQ9roZrriGJZJvjsnAtTknsgisBrXRdWPxqnU 0yDolcOpAAu1M2SUhgkZdaf3TfUvIW95HnKmkWANw/u+6uMcSo3DxX2JuZjMZNRFsjfA IgRw== X-Forwarded-Encrypted: i=1; AFNElJ/Y7/2tlPdaOjWjOQrY+wE+lPoMc5DJy9ELl4DlAce2zk58imb+5lIb8XhY+4gjYBhB9v5EYPOUVkhbT8s=@vger.kernel.org X-Gm-Message-State: AOJu0Yx8/WjivB8TiZndvJeQVPYg5zlQ7uQArDhEMHe6BD4kpsrHrqup klynslcDwQ4Q6I2iAwlG5z+YpNLTWHGdmdQDfhP0J7nm9qnWpLAtobwf X-Gm-Gg: Acq92OGZxKmO69g/ukbZ4Vdk29mzY+N1vsPAxdoOp7XXfum8eg/t5/GmELZ4g+vR1hq 9iAZupVA0Xy7PTyWoT6XRc+mD/65JuaIcEY4HI2bw4vnGy4DhSBHLOreTOzSLjn84qiJTyThKxu RIbhu1n3a2uIVwwA/YFMNcb8zLRb/gyZ1UfD02nkKCfGiOIGP1WbLqgKGe46bRZA0qk9NiT3WS3 V2/LIRU1urdBNiO04YYAwNy7P1omwkx+LxbYQxXLBOU9TvJ6RBQmcVvEDujmHGR4koc2wxoWVKx 0RpYPzTZpTKgxxSh908PI6sG/S4bSVy/wotVYyK21HIc+FkdpQSyN9g3NYU8mR6WrKTux4D7jNA IsiKbTCBhYr/kA3vfXzrIxzIfCbbTzMmRruyBZH5yM9E77DL1txp9xRP5fzjHLATSvg/OgYtrrj BgN+mQp+8d9RIy+B09ArAzqz8nLItGfwAzmRep9dvgcSmrRDd5ETALhbLy0xPBxIThDpax4Q== X-Received: by 2002:a17:902:f546:b0:2ae:ce35:2686 with SMTP id d9443c01a7336-2beb033f57emr145382605ad.5.1779689702651; Sun, 24 May 2026 23:15:02 -0700 (PDT) Received: from qiwenjie-ThinkCentre-M760t.mioffice.cn ([43.224.245.241]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2beb58b3058sm85611535ad.39.2026.05.24.23.15.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 May 2026 23:15:02 -0700 (PDT) From: Wenjie Qi X-Google-Original-From: Wenjie Qi To: jaegeuk@kernel.org, chao@kernel.org Cc: yuchao0@huawei.com, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, qiwenjie@xiaomi.com, qwjhust@gmail.com, stable@kernel.org Subject: [PATCH] f2fs: stop checkpoint on compressed write IO error Date: Mon, 25 May 2026 14:14:56 +0800 Message-ID: <20260525061456.231710-1-qiwenjie@xiaomi.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Compressed data writes are accounted as F2FS_WB_CP_DATA because they write compressed pages through fio->compressed_page. Their end_io path should therefore have the same checkpoint-stop behavior as ordinary F2FS_WB_CP_DATA writes. However, f2fs_compress_write_end_io() only records -EIO in the inode mapping when the bio fails. The filesystem can keep checkpointing after that failure, so a later checkpoint may persist metadata that points to compressed data blocks whose writeback failed. Stop checkpointing with STOP_CP_REASON_WRITE_FAIL for failed compressed F2FS_WB_CP_DATA writes, matching the ordinary data write end_io path. Fixes: 4c8ff7095bef ("f2fs: support data compression") Cc: stable@kernel.org Signed-off-by: Wenjie Qi Reviewed-by: Chao Yu --- fs/f2fs/compress.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c index caf522d667d6..9b1501004456 100644 --- a/fs/f2fs/compress.c +++ b/fs/f2fs/compress.c @@ -1488,8 +1488,11 @@ void f2fs_compress_write_end_io(struct bio *bio, str= uct folio *folio) f2fs_is_compressed_page(folio)); int i; =20 - if (unlikely(bio->bi_status !=3D BLK_STS_OK)) + if (unlikely(bio->bi_status !=3D BLK_STS_OK)) { mapping_set_error(cic->inode->i_mapping, -EIO); + if (type =3D=3D F2FS_WB_CP_DATA) + f2fs_stop_checkpoint(sbi, true, STOP_CP_REASON_WRITE_FAIL); + } =20 f2fs_compress_free_page(page); =20 --=20 2.43.0