From nobody Tue Jun 9 00:59:05 2026 Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3464223C503 for ; Mon, 25 May 2026 03:38:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779680332; cv=none; b=Pfw3mmw0mEzd4dyEmAxuRvoe2qdLKpZLK8Ny+lsupMeCds0W7aHutNs6qLHP3ZmMYdAwiGoMyeWLZ7hxRLPEI+fgxmtwTc0ui9CbN/Mx7Eqof42P9TFCiQcTVSWOD5we1J/5Lu5GOIyZ3tbGKuOgd96xhclqyjUP14FKCH60NCg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779680332; c=relaxed/simple; bh=egpO1BuTfCzILWiFOLfhF8m3WsekOEsuGrKkDO7Wxkk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=LjVIUgwsBygmulvh2bqEubZYZC2OkHs0cNmLNu35U3ZoaVYwuKEYz7+E1rB+zZWrPdA5VGlfEBYKBEmGJrrHh8zDK7RHuF0fubC+hvaMwNHsXL084d0sfYSaq8FjiG7cnbV+s2ZfSRsD/OXZdobb6pCa4g6mYzFu9bKP4PazRck= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UgrH9vua; arc=none smtp.client-ip=209.85.160.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UgrH9vua" Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-516da301e64so41512431cf.1 for ; Sun, 24 May 2026 20:38:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779680330; x=1780285130; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=R9RwqYB7r6bhFVqkJhACAFbElSFPJqjemhMeBFLCqnM=; b=UgrH9vuaPLqDauS9fK7A+o+/FuTlMJfFFf9jjp202PxdfNzghvUQ2fHkbraiqEwDW5 /YoZX7mdj4ycjIP2kB+ggtWSUza9N3fZ+UOB2EpLF7W36xZnc7Rii7UgB0MRHGQWntT/ BIxeBLfTHClZocKR8vBdVa0Iu1UCdpMbdPgaa51DtcIEFTsp/rXFzAiaDSaxIdOGy9lZ OuTzy4uj7coLJonac9s91UO6NpG/0PcEl7uqpB9xCld22dXl6kOIiWpKxH5kjqK3egbO Br/56dpdPyoEXwHdwMMonsbk7jnUJies1ZDp/68nMg2Em63HMyBIj+E8MSLol7uvFP7+ ic5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779680330; x=1780285130; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=R9RwqYB7r6bhFVqkJhACAFbElSFPJqjemhMeBFLCqnM=; b=fenLAE8Wa4yRKCNXXvQW/a8zlsqmNmFxKzWb3Vbriilqoup31Ha2ipbq7jW7THMyYV U32GEplAUWDW1He9zoZ36OOAnJ7UWgl3xSjbqfJ2QIZlDI5CL2lCku7zzcnMCKJ2sGr0 NrSeushSjF8M2KEJF0YXlV3WMsz3A1ma0WCjJf1uEwfWUq3jMIceZQ59rh1iaODvigOT du7jzGBJYVvQrGrE4prYIwXJQEJEyfVBlPtuaPMFOWpk1mj6sorR75eOkS+7Do0EJW79 sLoTI6pUrhQI6rJp9excwMk5uIq7C/CeJ0BmCe9gRz4SEEDD9F0aq0RxLayYUBr7hluE tlhg== X-Forwarded-Encrypted: i=1; AFNElJ+qc+goNwb5gg1fSqUGdVsVWw4t7nO8m3gSlApi2O81hIETJngxkEVsUkqZ+wlxRExau9/EPyKoRinjJF8=@vger.kernel.org X-Gm-Message-State: AOJu0YzOm18MEp2q4lIInE6LSoPvDh9pJ5vE8QmIviNV5W4u3s53adur uUhAEvEOkEFYaRaPl2UI+jbvzSZOpNJz+rA7zGRbS2PniaUB7MrAELg6 X-Gm-Gg: Acq92OF5tE+8DoIQPjEWboRokSK5z6wykM7YnXiZQ9VjzDYPu3HfUQb0DuBoWFoFtSd 4kzIoITeH+BKjb+khRwn4PT7WCUQ46ncWhcOFrATdvvxZF13sklQSKuoYsICmVqEz+P5jul695O BTBlvsaXQT0Gmjyp/pjmkUNBMuigp8ZgwKXJ4luzE47TZEmBk6B+d6aJH7jrc6f2XwqN7cFK2yS yMipNqUBg8CrgBUnclVZA5PJnXqSwWklcfD1gqEVJHtfZNymFgP6s8iG77WNAuOaDWC9eOS9fcY UUZW84+9+0a55vZJKhVk4Ds445Tua3X05msdxWaWoOXHyKyHfkgRe/4VSPsKLhbwU4GEPesP0Er x6MHms2O2amO8ofcbKp5autLRZQx+cXhodS+l74LmirbwN0VDAfapqBiMJ+S9Xba5I+ZELyZUzc f5SUeElGoHgXuWOgX1Y8iHEAl9ksydtBRgoT+3LbnjdquIEizeTx4= X-Received: by 2002:a05:622a:110c:b0:516:d83c:edb8 with SMTP id d75a77b69052e-516d83cfc3dmr157369111cf.27.1779680329955; Sun, 24 May 2026 20:38:49 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-516d8cb8da8sm83104691cf.20.2026.05.24.20.38.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 May 2026 20:38:49 -0700 (PDT) From: Yuho Choi To: Andrew Jeffery , Avi Fishman , Tomer Maimon , Tali Perry Cc: Patrick Venture , Nancy Yuen , Benjamin Fair , Russell King , openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Yuho Choi Subject: [PATCH v1] ARM: npcm: Fix OF node refcount leaks in SMP setup Date: Sun, 24 May 2026 23:38:46 -0400 Message-ID: <20260525033846.1346744-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" npcm7xx_smp_boot_secondary() and npcm7xx_smp_prepare_cpus() look up the GCR and SCU nodes with of_find_compatible_node(). The returned nodes are used for of_iomap(), but the node references are never released. of_iomap() does not consume the device node reference, and iounmap() only releases the MMIO mapping. Drop each node reference after the corresponding mapping attempt. Fixes: 7bffa14c9aed ("arm: npcm: add basic support for Nuvoton BMCs") Signed-off-by: Yuho Choi --- arch/arm/mach-npcm/platsmp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-npcm/platsmp.c b/arch/arm/mach-npcm/platsmp.c index 41891d3aa124..4c1fc9983746 100644 --- a/arch/arm/mach-npcm/platsmp.c +++ b/arch/arm/mach-npcm/platsmp.c @@ -32,6 +32,7 @@ static int npcm7xx_smp_boot_secondary(unsigned int cpu, goto out; } gcr_base =3D of_iomap(gcr_np, 0); + of_node_put(gcr_np); if (!gcr_base) { pr_err("could not iomap gcr"); ret =3D -ENOMEM; @@ -60,6 +61,7 @@ static void __init npcm7xx_smp_prepare_cpus(unsigned int = max_cpus) return; } scu_base =3D of_iomap(scu_np, 0); + of_node_put(scu_np); if (!scu_base) { pr_err("could not iomap scu"); return; --=20 2.43.0