From nobody Tue Jun 9 00:59:52 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 039A1296BD2 for ; Mon, 25 May 2026 03:33:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779680011; cv=none; b=s6PkmRwL0VTaluMEA+t6Xb4RaEQ9s43+WVNLgmo2FwaSr790fUQtHDDpEKel7/zTEBUBlV23MCY1RG89jyq3khD95epHPrF2t6gvtv3haEK7YSXUmgD10Kcg1mJoe/U6T+aTSRTul6W2YpturUflzgYY9cmV0fnHwCQLzUcKp+k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779680011; c=relaxed/simple; bh=WAyuds5HBkMBWh/IWc9YR1stn53VnWwH2uOyt5L8jIY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=NWBSyHSYOtfllEvZ3zlXc4tSN+ImyLfrNtafNn9Z0bVhijbTBPSgfvgS2HZ0D4h+fvMUGwwaHD3swK8eZm5luBBcLdg4RHaoUNbDm5n3oZSFhEW5giQOZMIYaCiPpqi9AjwqjxldiSVGWlCycLqQqjVrbfNSIHvjskKU3Bg/SdE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nx7OuZ3J; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nx7OuZ3J" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2ba6485d219so69976675ad.3 for ; Sun, 24 May 2026 20:33:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779680009; x=1780284809; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=9yiHvPwp6eaDY83CzuvonglxPr7tqfRwJOe2dfHrjDs=; b=nx7OuZ3J35vHQZlBy3yvsZYfloaLKUPqGzeyBrSrCTAw6RXcbKPtn8B6bvgZgifZz4 axuRfbzDiChwn/vwtQhuZBPpolayEnVowXUfGk5gocszoVM6fEbCsxu9cceaure/aWZQ oYSAV1Sp0u495Q10EuDx1fV7BNuKxLKaVJvGZmHg0exL5viJEiHOumlswbeeUZLIrrni CkO5vRTrET++V9Or/H8w3BBw/9ID7tXLvAvz/51Xh3OFHn4fEelf09yeJGHqHlOjFTjW dFsIqkBd1YaKU7gSdRpUG46NqRM1scZmP79CYtEadI+aoD0RKbBeeEIugy3dKZqyoRZB 0KSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779680009; x=1780284809; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9yiHvPwp6eaDY83CzuvonglxPr7tqfRwJOe2dfHrjDs=; b=LG3i7wBBhwesdALQ+Rr1521s9262oqJmWPlAOmiYVp8/LmNcdkO/bcgAskyJeIikkW tSv2nW0J9bFTs5bbqZ8U082dLw8yXrRGm/MrjjsSlTsQ+qsyEsdPusvCPXHRBv9t8gyq Hae648tPqvU3L8AhsMLmMl/f6iItaGDBVS7OUPD4+bxSwDhkVNocydp7GLmWjRX3nvBZ D0nNupNqGSIkBCtflDEWAwyne+81ef7WdLqM0WKwYK+A/ALaz+wRVcamDfW9Eb+duqhx 3ESlUlvuv9yjhfclT/3IYRpPeN/t2+U1Ut2hPP8HWzqEcLDlznASCii6IiXohY+LqAqj UZuw== X-Forwarded-Encrypted: i=1; AFNElJ8D8on6fxK87snaIXN2in/ZL9H8w7DWgOpnr618MznNsTZ5CKT1Rg1Jz/3NAplUJUhdKqNvgRY3AxidkEY=@vger.kernel.org X-Gm-Message-State: AOJu0YxpY0rxglDTSwwXxBbmcF+uwLBPDGml4MIpw+BEKMlRknk5D3Wf MGS6JGV+KgMeDhEJcWM077d+PFxX8LpGujb8P3HPreWGw/Lz7NF2GkwQ X-Gm-Gg: Acq92OGDTiE3LNsZeiBX++tDSnvVaxJG/ulaj/tIKFZEkesa//SbSDzc/d1gibZjMjH 4Q9WYLzS0Kx4xmfQkz02bXkdJTdducjKsTSUujNLroxulCUl2a3G3e+4m6TixzxzISRV4uB/pDt 27BINw2ssch3aOxvDRjWxnc5lbTOdc7oyJ4GHqM7fGWUJu67USv2Y6bhP5VC6C9XLRu1MnhdIbG ++GDOvh8wskYcsWxBoUufSuZpCSB3Wn17wcBKgVnUTpxyEQ0luy1VfvEPZXwTtXlIqn+Mpk4HUE Bi9AYEluuj0RHazQXBKGmt39DZceHVV32UaoZpWio3JKPqMy+xZIEJCfVWgHUH3e8sg+I11IcMr yERgoegyUYPSnsEHUtCGjFsIwBoQ9rpV91nn23MLANC2GzKCcOdju+l1+zs1ei5YeBt3EtgSrAY 5KCQr+fx8HD2i83x5fSyDbsBy5AiubhyvekjS/GhG6QsaHrOMjTOZ2DncX07e2kbKhKur++VIJS hws5uU= X-Received: by 2002:a17:903:19e7:b0:2b2:67ca:5ff9 with SMTP id d9443c01a7336-2beb026f4c4mr137314845ad.0.1779680009159; Sun, 24 May 2026 20:33:29 -0700 (PDT) Received: from fedora ([103.181.54.98]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2beb58d9fe9sm77391815ad.65.2026.05.24.20.33.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 May 2026 20:33:28 -0700 (PDT) From: Ninad Naik To: lee@kernel.org, pavel@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, jonas.gorski@gmail.com Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, me@brighamcampbell.com, linux-kernel-mentees@lists.linux.dev, skhan@linuxfoundation.org, Ninad Naik Subject: [PATCH] dt-bindings: leds: bcm6358: Convert to DT schema Date: Mon, 25 May 2026 09:02:58 +0530 Message-ID: <20260525033258.144291-1-ninadnaik07@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Convert the brcm,bcm6358 to DT schema. Signed-off-by: Ninad Naik --- Referred to this thread: https://lore.kernel.org/all/20250930-brcm6358-to-dt-v1-1-ba833ceb1575@thego= odpenguin.co.uk/ and added the fixes suggested. .../bindings/leds/brcm,bcm6358-leds.yaml | 98 ++++++++++++ .../devicetree/bindings/leds/leds-bcm6358.txt | 143 ------------------ 2 files changed, 98 insertions(+), 143 deletions(-) create mode 100644 Documentation/devicetree/bindings/leds/brcm,bcm6358-led= s.yaml delete mode 100644 Documentation/devicetree/bindings/leds/leds-bcm6358.txt diff --git a/Documentation/devicetree/bindings/leds/brcm,bcm6358-leds.yaml = b/Documentation/devicetree/bindings/leds/brcm,bcm6358-leds.yaml new file mode 100644 index 000000000000..a61417e5690b --- /dev/null +++ b/Documentation/devicetree/bindings/leds/brcm,bcm6358-leds.yaml @@ -0,0 +1,98 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/leds/brcm,bcm6358-leds.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: LEDs connected to Broadcom BCM6358 controller + +description: | + This controller is present on BCM6358 and BCM6368. + In these SoCs there are Serial LEDs (LEDs connected to a 74x164 controll= er), + which can either be controlled by software (exporting the 74x164 as spi-= gpio. + See Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml), or + by hardware using this driver. + +maintainers: + - Jonas Gorski + +properties: + compatible: + const: brcm,bcm6358-leds + + reg: + maxItems: 1 + + "#address-cells": + const: 1 + + "#size-cells": + const: 0 + + brcm,clk-div: + description: SCK signal divider. + default: 1 + $ref: /schemas/types.yaml#/definitions/uint32 + enum: [1, 2, 4, 8] + + brcm,clk-dat-low: + description: Makes clock and data signals active low. + type: boolean + +patternProperties: + "^led@(0|1?[0-9a-f])$": + type: object + $ref: common.yaml# + description: Each LED is represented as a sub-node of + this device. + + properties: + reg: + description: LED pin number. + minimum: 0 + maximum: 31 + + required: + - reg + + unevaluatedProperties: false + +required: + - compatible + - reg + - "#address-cells" + - "#size-cells" + +additionalProperties: false + +examples: + - | + #include + led-controller@fffe00d0 { + compatible =3D "brcm,bcm6358-leds"; + #address-cells =3D <1>; + #size-cells =3D <0>; + reg =3D <0xfffe00d0 0x8>; + + led@0 { + reg =3D <0>; + active-low; + label =3D "white:alarm"; + }; + led@2 { + reg =3D <2>; + active-low; + label =3D "white:tv"; + }; + led@3 { + reg =3D <3>; + active-low; + label =3D "white:tel"; + }; + led@4 { + reg =3D <4>; + active-low; + label =3D "white:adsl"; + }; + }; +... diff --git a/Documentation/devicetree/bindings/leds/leds-bcm6358.txt b/Docu= mentation/devicetree/bindings/leds/leds-bcm6358.txt deleted file mode 100644 index 211ffc3c4a20..000000000000 --- a/Documentation/devicetree/bindings/leds/leds-bcm6358.txt +++ /dev/null @@ -1,143 +0,0 @@ -LEDs connected to Broadcom BCM6358 controller - -This controller is present on BCM6358 and BCM6368. -In these SoCs there are Serial LEDs (LEDs connected to a 74x164 controller= ), -which can either be controlled by software (exporting the 74x164 as spi-gp= io. -See Documentation/devicetree/bindings/gpio/fairchild,74hc595.yaml), or -by hardware using this driver. - -Required properties: - - compatible : should be "brcm,bcm6358-leds". - - #address-cells : must be 1. - - #size-cells : must be 0. - - reg : BCM6358 LED controller address and size. - -Optional properties: - - brcm,clk-div : SCK signal divider. Possible values are 1, 2, 4 and 8. - Default : 1 - - brcm,clk-dat-low : Boolean, makes clock and data signals active low. - Default : false - -Each LED is represented as a sub-node of the brcm,bcm6358-leds device. - -LED sub-node required properties: - - reg : LED pin number (only LEDs 0 to 31 are valid). - -LED sub-node optional properties: - - label : see Documentation/devicetree/bindings/leds/common.txt - - default-state : see - Documentation/devicetree/bindings/leds/common.txt - - linux,default-trigger : see - Documentation/devicetree/bindings/leds/common.txt - -Examples: -Scenario 1 : BCM6358 - leds0: led-controller@fffe00d0 { - compatible =3D "brcm,bcm6358-leds"; - #address-cells =3D <1>; - #size-cells =3D <0>; - reg =3D <0xfffe00d0 0x8>; - - alarm_white { - reg =3D <0>; - active-low; - label =3D "white:alarm"; - }; - tv_white { - reg =3D <2>; - active-low; - label =3D "white:tv"; - }; - tel_white { - reg =3D <3>; - active-low; - label =3D "white:tel"; - }; - adsl_white { - reg =3D <4>; - active-low; - label =3D "white:adsl"; - }; - }; - -Scenario 2 : BCM6368 - leds0: led-controller@100000d0 { - compatible =3D "brcm,bcm6358-leds"; - #address-cells =3D <1>; - #size-cells =3D <0>; - reg =3D <0x100000d0 0x8>; - brcm,pol-low; - brcm,clk-div =3D <4>; - - power_red { - reg =3D <0>; - active-low; - label =3D "red:power"; - }; - power_green { - reg =3D <1>; - active-low; - label =3D "green:power"; - default-state =3D "on"; - }; - power_blue { - reg =3D <2>; - label =3D "blue:power"; - }; - broadband_red { - reg =3D <3>; - active-low; - label =3D "red:broadband"; - }; - broadband_green { - reg =3D <4>; - label =3D "green:broadband"; - }; - broadband_blue { - reg =3D <5>; - active-low; - label =3D "blue:broadband"; - }; - wireless_red { - reg =3D <6>; - active-low; - label =3D "red:wireless"; - }; - wireless_green { - reg =3D <7>; - active-low; - label =3D "green:wireless"; - }; - wireless_blue { - reg =3D <8>; - label =3D "blue:wireless"; - }; - phone_red { - reg =3D <9>; - active-low; - label =3D "red:phone"; - }; - phone_green { - reg =3D <10>; - active-low; - label =3D "green:phone"; - }; - phone_blue { - reg =3D <11>; - label =3D "blue:phone"; - }; - upgrading_red { - reg =3D <12>; - active-low; - label =3D "red:upgrading"; - }; - upgrading_green { - reg =3D <13>; - active-low; - label =3D "green:upgrading"; - }; - upgrading_blue { - reg =3D <14>; - label =3D "blue:upgrading"; - }; - }; --=20 2.54.0