From nobody Tue Jun 9 00:59:04 2026 Received: from mail-qv1-f42.google.com (mail-qv1-f42.google.com [209.85.219.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49AC6632 for ; Mon, 25 May 2026 02:31:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779676271; cv=none; b=jL3Iq4aESXbIfhxn/lW6Y8YT7ADMHL1cMyng50rpVJnr8k7su5eOy55iUl0jMuwIuhAluDBkYLmST2qM2vCgBvHgq44COvKki6RpikKGiDqNAcwexEG9ulTV933Vo33Vh2jxeBuxMFD/pl93Or8IFM1GCDRBj+TjIEOLUMhemGU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779676271; c=relaxed/simple; bh=caBy/myclJmcEhye5gLtqdAl4V5lKtWxzqGmKrtVvLk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=DkkJF3hnGres8Qn+xRv3/Grlb4wtN9Fy/+186pNlAKpsy0Dj/fsR44L27k8nMf87uOqmKmgcRTUNdWpjoDGXqc1o05OqDWyd0H+7kMsoDbj1uNejDACZeBDb9GeNOCpAI38AmyL2RncKM5xHHFo49oV/c2m55/RI43zpcRfZWgs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Use/eqhr; arc=none smtp.client-ip=209.85.219.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Use/eqhr" Received: by mail-qv1-f42.google.com with SMTP id 6a1803df08f44-8b1f2b7f1bcso141170376d6.1 for ; Sun, 24 May 2026 19:31:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779676269; x=1780281069; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=xaqNcv4CXQk4smv0jZmLI0c3iL1j6I7cH/uwpHLe1Gk=; b=Use/eqhrz3+xenl0BOAQ91GatWyvoLL1nuaVaM9ej7yxaVraebX24t8lRvwOd/kwvA OkZkYfLfZZxLpZn1gm6Y7K9vK7cc5ACusbvgZPdshNZkhcUkmIL0b++hQNuLobE5Uy2Y GJe0mTTQp9ChzKUW6bu8evhg5p4IyCN0GCBvonJPGsZsXENokWwy/QN/GN0lqEwVuhwA qPBDQK/xrFUJIBKri/Nhttdneq9ZJN0A6CtxX52R/lHxIqfDSfBUlmdZt6OE5D63OKOq mfSs+AQgQLbXgKeLtII1gBbUkdTM8Me3A/z0HtIzI+X7dBPhEbL3iJOswJLCfQJo/Bu1 B5oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779676269; x=1780281069; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xaqNcv4CXQk4smv0jZmLI0c3iL1j6I7cH/uwpHLe1Gk=; b=MjUSnQovPKqEnNGVgL01ZVo8NLZX7i82AnrxvNhqR+9EWcLfF9fZCLoBo/qdRKLK71 4b2Np+IqNxuq8rgFRhLxb9Kql8Qqta5rpHpDfCvJ1gRxKyWw8KdZmndpCV6mUJ+3bXr+ Jn+jFsRRhU2yoXWgmawhvjOf8xCPSz9hTUiSSP7DAwQcjekK2YVCo4dOjN3UXlps1nxk a2W6pFUGYff4goqL3MRCiD2CIz/JgvROiU95jhH1Qz7YeqTJM2ZSm+Xk+TpTuWpGekfA S9ru1kEPwEyTL0ywAGYDQrq7y42dtVXHfUwV81LrQjcwbBAfBrdwIkNRJxTZvtTmgmbJ IyOg== X-Forwarded-Encrypted: i=1; AFNElJ8uuj6WzmUGZqsi+man1K56+xmXsTqhgV3ivt0R0U1XqaEwXGNyeQFaimota2RMl20gHhcaFFfzxL9DQ/w=@vger.kernel.org X-Gm-Message-State: AOJu0YzBHCnD0YVoWt+JGRvxlSf2m2nQfrlEpO7XDbbcyAfM7VuIYqiN IZ8f7hKw6K2pNvOnxhQwn/KuUJyrNXX53JlNLeo0ZtrduwvKbZoWeinm X-Gm-Gg: Acq92OH0czDoIlSp1E49/yNLYK06c7cPYkBzm3cauDwcKFqdWAWMne6czDJK6MsQYBz evJjijKE0i4NfxRjTgbqS047Bl9lJ787tXRie+AOpJt8BK2pTIzvhu+TUeVHHRvfWlcOZQJRbEc VlPYocDh/MOSbUz/hBX+Fic4lAEzwqDvmxt0oXRx234nt6xHfaYGRANNfHsRULEEjrfBD+60nqs KPkvT9h5h+jbMeLAvWRdLL8n+OhjDoI/YDnSTwF+8AC/BAFLBWaGhf0WxF1lYeenFwDtegrj11H TjuEsKu/SlvEnF+KO2uibTuD3OuJT7M0gkUVj9CYLS/ePOG8lzGxBx7GVeTzA2WK6VUHKxhLFC9 mETfspLmZvQgbbYfKfmep7P8ZPeW7aWV5J++Y2gRuEE9Yhd9myRw6R9aMSt9Cc+REndHlhxENiC amp4qcTnIf4iXuZnZ7zqcCJypfO3YqyYdJzfW7Dcc+ X-Received: by 2002:a05:6214:242b:b0:8ca:10cc:aa44 with SMTP id 6a1803df08f44-8cc6e356819mr235419686d6.3.1779676269161; Sun, 24 May 2026 19:31:09 -0700 (PDT) Received: from i4-gl-tmk5904.ad.psu.edu ([130.203.156.186]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8cc81316d44sm97267086d6.42.2026.05.24.19.31.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 May 2026 19:31:08 -0700 (PDT) From: Yuho Choi To: Dinh Nguyen , Russell King Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Yuho Choi Subject: [PATCH v1] ARM: socfpga: Fix OF node refcount leak in SMP setup Date: Sun, 24 May 2026 22:31:01 -0400 Message-ID: <20260525023101.1329892-1-dbgh9129@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" socfpga_smp_prepare_cpus() looks up the Cortex-A9 SCU node with of_find_compatible_node(), which returns a node reference that must be released with of_node_put(). The function maps the SCU registers and then returns without dropping that reference, leaking the node on both the success path and the of_iomap() failure path. Drop the reference once the mapping attempt is complete. The returned MMIO mapping does not depend on keeping the device node reference held. Fixes: 122694a0c712 ("ARM: socfpga: use of_iomap to map the SCU") Signed-off-by: Yuho Choi --- arch/arm/mach-socfpga/platsmp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-socfpga/platsmp.c b/arch/arm/mach-socfpga/platsm= p.c index 201191cf68f3..349e6c54518e 100644 --- a/arch/arm/mach-socfpga/platsmp.c +++ b/arch/arm/mach-socfpga/platsmp.c @@ -78,6 +78,7 @@ static void __init socfpga_smp_prepare_cpus(unsigned int = max_cpus) } =20 socfpga_scu_base_addr =3D of_iomap(np, 0); + of_node_put(np); if (!socfpga_scu_base_addr) return; scu_enable(socfpga_scu_base_addr); --=20 2.43.0