From nobody Mon Jun 8 23:57:32 2026 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B44ED3D413C for ; Mon, 25 May 2026 08:27:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.69.126.157 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779697651; cv=none; b=bXVQvmyqhtxEOLj+8hW0rwEdg8uwzaRprdUSsAJJuvyyUsBOd9I5ns4HpmKjSO8LhiaH3ELlG43VTo/h2lmcJQjyQo/QtAAQwKG6O1N6GlrA9BifzwfJ6ZiDCpwEzTP5Fib88Dm5vCjjiiOHiozC7zHdXVjH5oImeABIUgQSovk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779697651; c=relaxed/simple; bh=OlpMn51MDbZYh1qKquNERfOTXrYKD5Lg5/coLlA1h4Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=oOC8iUDHsEvA9BiV4rNsNa7uyZQJM2A+6ZOaibSvxRFT2jnkPzT17aGKHex61W7ELEzlHIu+qou4qN0Gj7uqxAJsviwX2wxsqGMlXUL28Jb2JA9NCIltHCLMt9GpNJfXZGg3YmY+Adk/3ptUlNdpHeJYC5Tj740eHf1PoW81Dsk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net; spf=pass smtp.mailfrom=weissschuh.net; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b=cqHSMSMN; arc=none smtp.client-ip=159.69.126.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b="cqHSMSMN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1779697642; bh=OlpMn51MDbZYh1qKquNERfOTXrYKD5Lg5/coLlA1h4Y=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=cqHSMSMNV4K+w2Ufk4Zqh9D0jIDrsFqSiFxLuA3WjJybfBN9+PKs+Lac/0DvHzymo aS3JTv8dkr36Uu/ORASbvD+JO7GH1QA+RznQjJx5kvnCvr/VWDhLLq3ZH08BTsQWCW eZVOoNhdHkc13vI9S9RthRjc1j+s/YiolotkgFnU= From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= Date: Mon, 25 May 2026 10:27:15 +0200 Subject: [PATCH v2 1/3] tools/nolibc: cast default values of program_invocation_name Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260525-nolibc-write-strings-v2-1-ab5cc16c7b23@weissschuh.net> References: <20260525-nolibc-write-strings-v2-0-ab5cc16c7b23@weissschuh.net> In-Reply-To: <20260525-nolibc-write-strings-v2-0-ab5cc16c7b23@weissschuh.net> To: Willy Tarreau Cc: linux-kernel@vger.kernel.org, David Laight , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1779697641; l=1139; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=OlpMn51MDbZYh1qKquNERfOTXrYKD5Lg5/coLlA1h4Y=; b=pX9dzwttidu0dGNqzzQN5/ThCvfQ5wNSYk9SCDuSAh3X9YNmWpHT7bYNEIFRGETph9WYhK4rQ ZF7+rYqRMscC1zO+Wcyks4cVMyDWNzCJLc50Ip2gctEt9bQTHvqZ75F X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= With -Wwrite-strings the plain assignment triggers a warning as a 'const char *' is assigned to a 'char *', removing the const qualifier. Casting the const away is fine, as there is no valid modification that can be done to an empty string anyways. Signed-off-by: Thomas Wei=C3=9Fschuh Acked-by: Willy Tarreau --- tools/include/nolibc/errno.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/include/nolibc/errno.h b/tools/include/nolibc/errno.h index bab83692ea1c..a2325596d550 100644 --- a/tools/include/nolibc/errno.h +++ b/tools/include/nolibc/errno.h @@ -15,8 +15,8 @@ #ifndef NOLIBC_IGNORE_ERRNO #define SET_ERRNO(v) do { errno =3D (v); } while (0) int errno __attribute__((weak)); -char *program_invocation_name __attribute__((weak)) =3D ""; -char *program_invocation_short_name __attribute__((weak)) =3D ""; +char *program_invocation_name __attribute__((weak)) =3D (char *)""; +char *program_invocation_short_name __attribute__((weak)) =3D (char *)""; #else #define SET_ERRNO(v) do { } while (0) #define program_invocation_name "" --=20 2.54.0 From nobody Mon Jun 8 23:57:32 2026 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B442D233939 for ; Mon, 25 May 2026 08:27:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.69.126.157 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779697652; cv=none; b=uYOMU1BXercIJGdDcx7u5ee7lQtuwXWkSQ3JLcoIHMplP4urBoLwLrftY66noji/bRYSR2k7S3YXSRneL/QY6CAJBM7LqAIjwpeIN9GPl2TN3Jz38YzJkisAxjGLR1hhLBtNjRstxWy4/qJxyh0gH0oOMiYJdWrUFUjD/K4Jncs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779697652; c=relaxed/simple; bh=1RRbvVLuk5yyMQFrI+b53Odoz6NjlrM84HURcOZOY/Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Syx1ut7f1CDf/RmacPZUqOk3q5rJZ0GpW+Rjw2Ng1mZodT7snht8stZPh/Jh8eIVHhF5Dq6zSR/gGb89cc6wTTmM0CXVgTQerAuteLVXF4Nq567frZdLygMPPeekA+UOi4NAAXMJdala9jxXIozwU+mIcfXxGIb/RyKQP0zH6Ww= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net; spf=pass smtp.mailfrom=weissschuh.net; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b=d15p4UxT; arc=none smtp.client-ip=159.69.126.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b="d15p4UxT" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1779697641; bh=1RRbvVLuk5yyMQFrI+b53Odoz6NjlrM84HURcOZOY/Y=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=d15p4UxT/Kfxk7EC/eO0abjEvqyy4fW8wzp/LzbysryCohPAgiB6EK3l8/sxUhKya S18ZrMDcUVGhBFB0lYyCMO84761O9Jh2AOx0jkuzZIgUy3nhw0Jqk/wmx+BF+OhayG EvuRVi5SLVZ+ZXHJuOKsJ+lyilFzfhy2CdJ5dxiw= From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= Date: Mon, 25 May 2026 10:27:16 +0200 Subject: [PATCH v2 2/3] selftests/nolibc: use mutable buffer for execve() argv string Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260525-nolibc-write-strings-v2-2-ab5cc16c7b23@weissschuh.net> References: <20260525-nolibc-write-strings-v2-0-ab5cc16c7b23@weissschuh.net> In-Reply-To: <20260525-nolibc-write-strings-v2-0-ab5cc16c7b23@weissschuh.net> To: Willy Tarreau Cc: linux-kernel@vger.kernel.org, David Laight , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1779697641; l=1637; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=1RRbvVLuk5yyMQFrI+b53Odoz6NjlrM84HURcOZOY/Y=; b=+VqoKvy1DblMmx0HrLgt3TvDwkNrvjDbCMWj7rH1rbSXX+i0usTlmnYR7SPKvJBUiBiTZ9jPl 3rDNWLXRDUJAeGxvE6dZQmGRg8pH9ULz3EDoYHnMyDpbgeSI5ssj8c1 X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= The existing code would trigger a warning under -Wwrite-strings which is about to be enabled. Use a mutable buffer instead. While in this specific case, casting away the 'const' would be fine, let's avoid casts which are not really necessary. Signed-off-by: Thomas Wei=C3=9Fschuh Acked-by: Willy Tarreau --- tools/testing/selftests/nolibc/nolibc-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/nolibc/nolibc-test.c b/tools/testing/s= elftests/nolibc/nolibc-test.c index 7c3b711c125c..c1c1ce43a047 100644 --- a/tools/testing/selftests/nolibc/nolibc-test.c +++ b/tools/testing/selftests/nolibc/nolibc-test.c @@ -1584,7 +1584,7 @@ int run_syscall(int min, int max) CASE_TEST(dup2_m1); tmp =3D dup2(-1, 100); EXPECT_SYSER(1, tmp= , -1, EBADF); if (tmp !=3D -1) close(tmp); break; CASE_TEST(dup3_0); tmp =3D dup3(0, 100, 0); EXPECT_SYSNE(1, = tmp, -1); close(tmp); break; CASE_TEST(dup3_m1); tmp =3D dup3(-1, 100, 0); EXPECT_SYSER(1, = tmp, -1, EBADF); if (tmp !=3D -1) close(tmp); break; - CASE_TEST(execve_root); EXPECT_SYSER(1, execve("/", (char*[]){ [0]= =3D "/", [1] =3D NULL }, NULL), -1, EACCES); break; + CASE_TEST(execve_root); EXPECT_SYSER(1, execve("/", (char*[]){ [0]= =3D (char []){"/"}, [1] =3D NULL }, NULL), -1, EACCES); break; CASE_TEST(fchdir_stdin); EXPECT_SYSER(1, fchdir(STDIN_FILENO), -1, = ENOTDIR); break; CASE_TEST(fchdir_badfd); EXPECT_SYSER(1, fchdir(-1), -1, EBADF); br= eak; CASE_TEST(file_stream); EXPECT_SYSZR(1, test_file_stream()); break; --=20 2.54.0 From nobody Mon Jun 8 23:57:32 2026 Received: from todd.t-8ch.de (todd.t-8ch.de [159.69.126.157]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B46153E1719 for ; Mon, 25 May 2026 08:27:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=159.69.126.157 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779697652; cv=none; b=dU+8uNAg9A5qDX65DINxsy0JIqmyGoJ5g51n39TMVlDQq8bq/XveZ8aqy19I5a0Y/XvAWFlFdtahJCzMphrUGsuD0hB5sGIFlgPFTYLI86d51V+zDcx8C9kps4hYMS7djfMgZOISTw4zoUpqx08ILzU39Z9/aykP4ydKpEiq0DU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779697652; c=relaxed/simple; bh=hiEg6tQTSTmmjy2Qj11vgIHRAvK9wFDMw0l3xTxWlco=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=E66mZUPuYiAF7hwxQ3Z0R3gSbXVg4vdoNFnR8iABH1Iv81Ju+1hfT7s6lfjemra65M7MkCMzcUV4Ihp/m0KvTwmgMTEiVsoLvMLHux+SXko/EgMQHZUDH+YVuqTYn9Qr7RamnrSly/iBM6cko+y22YTL5Qb1642/rrSARCwLgY4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net; spf=pass smtp.mailfrom=weissschuh.net; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b=dKycbRkv; arc=none smtp.client-ip=159.69.126.157 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=weissschuh.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=weissschuh.net header.i=@weissschuh.net header.b="dKycbRkv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=weissschuh.net; s=mail; t=1779697641; bh=hiEg6tQTSTmmjy2Qj11vgIHRAvK9wFDMw0l3xTxWlco=; h=From:Date:Subject:References:In-Reply-To:To:Cc:From; b=dKycbRkvGFAqWwCoE0YrI/0zlvASF/HXwSqfVT/2dBpMpTK4VS/Uipxh73SS7cdmN zcRH7BPB5NJ7awZ6hSkaFVjIgzHPhV5RqUpu7tcHIQUWjABZnfUuVkbiPIbjImU/CH gevvf5eMAOBtvZVZTBNMPTJ7irsvbyD2PxVqhcpc= From: =?utf-8?q?Thomas_Wei=C3=9Fschuh?= Date: Mon, 25 May 2026 10:27:17 +0200 Subject: [PATCH v2 3/3] selftests/nolibc: test against -Wwrite-strings Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260525-nolibc-write-strings-v2-3-ab5cc16c7b23@weissschuh.net> References: <20260525-nolibc-write-strings-v2-0-ab5cc16c7b23@weissschuh.net> In-Reply-To: <20260525-nolibc-write-strings-v2-0-ab5cc16c7b23@weissschuh.net> To: Willy Tarreau Cc: linux-kernel@vger.kernel.org, David Laight , =?utf-8?q?Thomas_Wei=C3=9Fschuh?= X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1779697641; l=1083; i=linux@weissschuh.net; s=20221212; h=from:subject:message-id; bh=hiEg6tQTSTmmjy2Qj11vgIHRAvK9wFDMw0l3xTxWlco=; b=e/TFuaPodhcXQ9X0fvh12a65pWpfyT9h3KU/dnHBD8nW5MKHw8xHU0Ug3K+qItYpACSrCV19A oLi0T67f68xAHzqFl/s77vlolw1yLyzph2c2NnmPq/yBA7jnxpJ2NHC X-Developer-Key: i=linux@weissschuh.net; a=ed25519; pk=KcycQgFPX2wGR5azS7RhpBqedglOZVgRPfdFSPB1LNw= Users may use this warning when building their own applications. Make sure that nolibc does not trigger any such warnings. Signed-off-by: Thomas Wei=C3=9Fschuh Acked-by: Willy Tarreau --- tools/testing/selftests/nolibc/Makefile.include | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/nolibc/Makefile.include b/tools/testin= g/selftests/nolibc/Makefile.include index 96fe2bc2191e..c30ca3a9ef14 100644 --- a/tools/testing/selftests/nolibc/Makefile.include +++ b/tools/testing/selftests/nolibc/Makefile.include @@ -6,7 +6,7 @@ _CFLAGS_STACKPROTECTOR ?=3D $(call try-run, \ $(__CFLAGS_STACKPROTECTOR)) _CFLAGS_SANITIZER ?=3D $(call cc-option,-fsanitize=3Dundefined -fsanitize-= trap=3Dall) CFLAGS_NOLIBC_TEST ?=3D -Os -fno-ident -fno-asynchronous-unwind-tables -s= td=3Dc89 \ - -W -Wall -Wextra -Wundef \ + -W -Wall -Wextra -Wundef -Wwrite-strings \ $(call cc-option,-fno-stack-protector) $(call cc-option,-Wmissing-protot= ypes) \ $(_CFLAGS_STACKPROTECTOR) $(_CFLAGS_SANITIZER) =20 --=20 2.54.0