From nobody Mon Jun 8 22:55:06 2026 Received: from mx0a-00364e01.pphosted.com (mx0a-00364e01.pphosted.com [148.163.135.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58C2B2DAFBB for ; Mon, 25 May 2026 18:26:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.74 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779733581; cv=none; b=UuDesJSFG6hEbcqpPsmCm40evNsZjOGd3RALTNmSmbzRPIe9jXIH5PkyOrnMmjA+LVDfeVsaDw8sKwfF6z/Pv2o/qfjmVoux8x98J4lNWHm+ZuiQPioWcTEX6mM9UCt84o14hU6FARctWsoUwoSxZcCogJZDnIBl4UZT8NoBjV4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779733581; c=relaxed/simple; bh=YtvXsYoRDOxv5QVUHgUA7AG5V4yQxClrjbB9/DdVMv8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=EKUyWz71bhrM4UL5SqO7M6Aoa24Onon0X8ng4IX3wzEYacEjhDjY2AA7I/Zik05B0Ny8Mfywg5ShxeIEnaaAslAmt5MWaZYnd3ED/rDnnLXGJK9gGprMH3sZ+SMbyo4QHAmPJAsFbGe+TkwM9YcEH8C1z3iiuAn3TfUhw4gnIzg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=columbia.edu; spf=pass smtp.mailfrom=columbia.edu; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b=Pt5kihg2; arc=none smtp.client-ip=148.163.135.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=columbia.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=columbia.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b="Pt5kihg2" Received: from pps.filterd (m0499199.ppops.net [127.0.0.1]) by mx0a-00364e01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64PHPQEg723859 for ; Mon, 25 May 2026 14:26:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=columbia.edu; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=pps01; bh=7C6HfuZmXSjeoBm5rn0zZzKAlC x0pKJm+zmGOCOo9U8=; b=Pt5kihg25R92LZXoRVg9yt2HJQEwQCVmM4QbsJrqgX /s9/zMaJ+TtLTMVFql0ROLoBGHLE3V08V5j4/KOjpEUj+HK+C8xzfkDt8RpiS7gW 0Hg7oWlbdaJR3CXNwXJi+hWNnEJ3WXqHSr6avSIwvoJ286yj+34Wt0WnrqB2GeVd rV0XSjZoJ/N5Qisi8aw9ALx3aDga+8Z2ji5s9rdnMJyYt20dfXXDjU4n+to6NSjw iTI1SpRCwltIjPt8/NiII+QbUAW02gfVrpTjH6LCEBTDyqp63Zhe6Iuwnld6LiRU W1dM8kkCpMbUHMxO5GEBadocgkYNku8t9koAq2Dfvzqw== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-00364e01.pphosted.com (PPS) with ESMTPS id 4ecqt4hguh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 25 May 2026 14:26:19 -0400 (EDT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8ba9baef44cso130949446d6.0 for ; Mon, 25 May 2026 11:26:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779733578; x=1780338378; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=7C6HfuZmXSjeoBm5rn0zZzKAlCx0pKJm+zmGOCOo9U8=; b=hHTHRC7/yhE4xvwacrppq0Z0Vdul11nkHraOl7trY3xoLh7mNK3PJPz0cYZ9fn19pU O3Si7T7hPB6C3PRg2htdmATrKANq8h9rHMLWuiNr9qynUCNbptufxdlZgt9jdil3uxbB Kl/+WViWxUVdpUnivfx4mH5DMaq0pzjWoj/zOF3mfoiww4XobqGXgucVpa/uxn/i/j9W 9AGb6CHSflNMvSP+99jEsunuBXYhbCkicP7jStOqJqYp6JTDlcGTWeeemeKSpPtxX87G mmwcvApr6xCjra8tVfIf/GrqiC4hmrcQLkF4WCgOyLpvx74qdN4Nqb3WzOrpjWziSwLu bWQA== X-Forwarded-Encrypted: i=1; AFNElJ8MmnaY2Xnt+eQqV0SRcdMnaijTZZU76uivCkRQ+Tf+Xt+e1BLZ26Hl6PInsSrESqiOxaxasJp3443vC9k=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+Jgyokqd9irjSBBD5B/FXxun53YkfScKz/v4R7kddG+wgevxm /6t91V2F2r0+bbhqcaxHF7fIggafjVATX7HMBgomCUYTkulXcN4n6OoqkwkOfdXHprjC7rrvnGl AXCXI8EjAkwij6P7Os+foUTMKCbBLfB3tSGOtjZx9IXerrGek9lQTNFitAzLiwxGIMeJFHg== X-Gm-Gg: Acq92OF5JXkIP4i0e3waFkzE28ELAUs3Oyuz+v2ZwwD1b5OF9CVGsnSC/ermwVl334N 4LBTJCqe2PilkJkU8KFd5QY+W3AzP5+3SEnUShIVRjEfBTpAjwGyB3AD4xTQ9g1SO+ixGoY/3Pt 1XNFCMWZuAMuTdZBDbgMTmAAC9EXwCyExNMZ0i7U2kVhx3ouG2NkGFxHE4lx0sLtD0eV/uznkVY xDPS9CoqLJ4q5e0paw6pgoeuhlokiFUrCYV1WTTBS8ExAei+VHSvR+HTBMVJnSJo+buaOPAaGN4 ASkjyTCfZi2hbCehQM4An5TRo1u+1B+XXGXT3JqoPiiOwVRCZPGoEWfRB4r3MDJMpN4gglWrJ1e OoA3Qly5Yf92VmA/Da7HZAaTAxMQWC4R1DtImgbl1YPwlcek+0Bi/bVr1KWDSA4g76Zc= X-Received: by 2002:a05:6214:1d06:b0:8cb:e63e:2a45 with SMTP id 6a1803df08f44-8cc7b552029mr261898146d6.18.1779733578466; Mon, 25 May 2026 11:26:18 -0700 (PDT) X-Received: by 2002:a05:6214:1d06:b0:8cb:e63e:2a45 with SMTP id 6a1803df08f44-8cc7b552029mr261897736d6.18.1779733577943; Mon, 25 May 2026 11:26:17 -0700 (PDT) Received: from [127.0.1.1] (dyn-160-39-33-242.dyn.columbia.edu. [160.39.33.242]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8cc812e2018sm116790646d6.28.2026.05.25.11.26.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 May 2026 11:26:16 -0700 (PDT) From: Tal Zussman Date: Mon, 25 May 2026 14:25:55 -0400 Subject: [PATCH] block: remove blkdev_write_begin() and blkdev_write_end() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260525-blk-write-cleanup-v1-1-391c073e3831@columbia.edu> X-B4-Tracking: v=1; b=H4sIADKUFGoC/x3MSQqAMAxA0atI1gZqsSJeRVx0iBosVVonEO9uc fkW/z+QKDIl6IoHIp2ceA0ZVVmAnXWYCNllgxSyEUoqNH7BK/JOaD3pcGyoR3JGuUqbtobcbZF Gvv9nP7zvBw3pHKdjAAAA X-Change-ID: 20260525-blk-write-cleanup-afedb5d1ab84 To: Jens Axboe , Christoph Hellwig Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, Tal Zussman X-Mailer: b4 0.14.3-dev-d7477 X-Developer-Signature: v=1; a=ed25519-sha256; t=1779733576; l=1925; i=tz2294@columbia.edu; s=20250528; h=from:subject:message-id; bh=YtvXsYoRDOxv5QVUHgUA7AG5V4yQxClrjbB9/DdVMv8=; b=fKI503mymezaQ1bOj/gh7v8flGRod/Duvwa0KuFjAz5NnvQ3JoF3MBqpgTbW79CV77cSPhhba rMjKwqc6mkyB5z3t2qv7tplj9Q9Ge2CrDfISNb3S1SmTBbNYMHGHTwf X-Developer-Key: i=tz2294@columbia.edu; a=ed25519; pk=BIj5KdACscEOyAC0oIkeZqLB3L94fzBnDccEooxeM5Y= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTI1MDE4NCBTYWx0ZWRfX8qksUQCg1pg7 88pEBIzX3r81CvxTfN0pAVY5xWOBmalGmHoBd8405jrF6IQpkeOE/AbFxO2/wMkQyne0NNXZUUu Q90LAn9vzmH1bLP/cdVWY0PO8GQ6gkQaIH9rYxKH0ABFZ6asLBZLUrYVWnO1iQrWfiKNfBoW5VE tm5oWSQth2B4UMEIGST+n5wf+LwaujgOPfw1ZFYzzT28LUWrZjW773v1BY3FmPuunOcVNfJIcP4 HePa9hbk6B9qCm7flJpGG3vYD6SgvlVsb4JDziG8J64V0XCJJIFwXlWVmH64FAIuKKL+OxiCEbh hTz1k6+9/RhBBkHPab/3Pc8RtjFPhIn8pc/5eOvnJtfeFj/wO2UOouNtqiwSVI2rPNbBvsVyZP3 VZtCrpIqZCZ8bZllwTxYvjl4b0mKNWOobM4d8kRXN/l12uNfDXB3cz1yYzTxMddxYneOMpnkSRS eTNWM91dosvmp/VcEXA== X-Proofpoint-ORIG-GUID: 7y__cAiQixouMbgyXXo0i7BRwzNP9xAL X-Proofpoint-GUID: 7y__cAiQixouMbgyXXo0i7BRwzNP9xAL X-Authority-Analysis: v=2.4 cv=QJpYgALL c=1 sm=1 tr=0 ts=6a14944b cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=GaPK54s0Se3oFqK5NkZy0g==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=x7bEGLp0ZPQA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Da8U98TiO7q1upZEImrf:22 a=G--0XuH5328wxK7v7Suf:22 a=WHal4xhvaHetekjCY9QA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-Virus-Version: vendor=nai engine=6900 definitions=11797 signatures=596817 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 malwarescore=0 bulkscore=10 priorityscore=1501 impostorscore=10 spamscore=0 clxscore=1015 lowpriorityscore=10 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605250184 Remove blkdev_write_begin(), blkdev_write_end(), and their entries in def_blk_aops. These have been unreachable since commit 487c607df790 ("block: use iomap for writes to block devices") switched block device buffered writes from generic_perform_write() to iomap_file_buffered_write(), which bypasses aops->write_begin/end. Signed-off-by: Tal Zussman Reviewed-by: Christoph Hellwig --- block/fops.c | 24 ------------------------ 1 file changed, 24 deletions(-) diff --git a/block/fops.c b/block/fops.c index bb6642b45937..ffe7b2042f4e 100644 --- a/block/fops.c +++ b/block/fops.c @@ -499,36 +499,12 @@ static void blkdev_readahead(struct readahead_control= *rac) mpage_readahead(rac, blkdev_get_block); } =20 -static int blkdev_write_begin(const struct kiocb *iocb, - struct address_space *mapping, loff_t pos, - unsigned len, struct folio **foliop, - void **fsdata) -{ - return block_write_begin(mapping, pos, len, foliop, blkdev_get_block); -} - -static int blkdev_write_end(const struct kiocb *iocb, - struct address_space *mapping, - loff_t pos, unsigned len, unsigned copied, - struct folio *folio, void *fsdata) -{ - int ret; - ret =3D block_write_end(pos, len, copied, folio); - - folio_unlock(folio); - folio_put(folio); - - return ret; -} - const struct address_space_operations def_blk_aops =3D { .dirty_folio =3D block_dirty_folio, .invalidate_folio =3D block_invalidate_folio, .read_folio =3D blkdev_read_folio, .readahead =3D blkdev_readahead, .writepages =3D blkdev_writepages, - .write_begin =3D blkdev_write_begin, - .write_end =3D blkdev_write_end, .migrate_folio =3D buffer_migrate_folio_norefs, .is_dirty_writeback =3D buffer_check_dirty_writeback, }; --- base-commit: e7ae89a0c97ce2b68b0983cd01eda67cf373517d change-id: 20260525-blk-write-cleanup-afedb5d1ab84 Best regards, --=20 Tal Zussman