From nobody Mon Jun 8 23:56:40 2026 Received: from mail-dy1-f180.google.com (mail-dy1-f180.google.com [74.125.82.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7E7133B47D2 for ; Mon, 25 May 2026 14:16:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779718582; cv=none; b=jdmFBfYwOEZ84aO1IWHNyKoDJ2BQl38x9+5B3jl1XQzaEEK5T6rGOgSdw867OdF6e/673nAveLy9qRXdHP3z9HNWGHISJl6xLnP01rC2vZgX1YY8e9TnaWwMwLRUOz9v994kU7J7Aqjl03izP7o2El99YZ5bK0Ta3D0gm85jVME= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779718582; c=relaxed/simple; bh=MFdFeKm/G+G5nLzwp77/0tJ1+gU1siWkcfoiFBsseYo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=SD+npJRuKIEWbCTEp6miJIyFlXvoOAac8Mog/kxd57R7Cl6FIDddz4SCR735dBRQGVRssuM96GicCz/DiNGdKdM3VPFj0ipAiP/G09x7tQ6adMVDKL67bMrQCkIGASddEK+zm9ME1FPpDASufZEHh49GjFDKu7EX5GYgXYyN/qI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fLRHQwWV; arc=none smtp.client-ip=74.125.82.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fLRHQwWV" Received: by mail-dy1-f180.google.com with SMTP id 5a478bee46e88-2f03d6cf77bso9950741eec.0 for ; Mon, 25 May 2026 07:16:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779718577; x=1780323377; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=8Jre4CbO6KyJQQsc94Q4J1OErqD+LNWqXxRPcx+UzN0=; b=fLRHQwWVJaJ1pJlyg+U5/YKIStUM8L1WI3PoExPec8ipYDRVKk5bCHflPXHx/HFj9U Uoj9lKauC+YoFq3RemHMn4Ny3vDskIq/pUoX3drz1vd6ibqGXplZNJECTM/5dHgDwgiF jEUMnfyb6+17TNb2lDRO1V8YcwOouSVKhv90FZ2VQf5yJ8hhiWWCc668tmQhbeeJ5XKh Eu4iJx1yKVV/DnS2I6CcNNPrvU6HzFGahpK9qnVIFHr6SksprWpEf5Fodpk1rMaJ/nkb YOmPbTdMudT1cMpdy2ixgGqSgLGtRjEJ8P1/xxdvco0ql5xtdvSoU543vo7fkuTHDSK3 pMwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779718577; x=1780323377; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8Jre4CbO6KyJQQsc94Q4J1OErqD+LNWqXxRPcx+UzN0=; b=qPjgx6AKHQsKE3kmAHDvl3bWrj7gvOL6okqeG4w7LIPBEGk2oBPmV3XrXL5HgJUNZU L8YGjxbLT5+5R6ObuUaAWv/FYW30OPfm3Bz565EwwDtXlEY0v5D6lodFuyBSDVmk0LYn VVnU5gKB8NSF37ijGL+TxPzhpeoAM9CElnE7I3JYkEiYBRE14E5D1DXFL66d9bsrIhLd uX7OAaFEho37pQOEw+FbfcfsyxdKmGOHElT3weSjzUURH9JrCTFyOIrxphnjCzhq4P2A 1sMOY4E/MTgqyRmqQGkz2pd1p0w/mK+mZa6cAqpwoF3cWqDiB0YrP8DEnYX2BhFETMwg 6P2w== X-Forwarded-Encrypted: i=1; AFNElJ/Bm+W3KDJh1XEA5OIJh0Hmfy9eEDYt4S7jaEGHYFrC9wdLHmzCQCWrBlvipxZdlYQIY3k9oCiNhtsmrfs=@vger.kernel.org X-Gm-Message-State: AOJu0YwZaTGrvDh3VwuVZHGeLTPraCSsxIZ/rwkL3dAwtXG3v+dMetbF 7pwHaE/ERNOoiwI1WT8Ds2CQtj52knC5chR/b7ynsEokLiF82DF1GHwN X-Gm-Gg: Acq92OGGi6pZfsstZ4mshG+B0Dq/krfsmsegfqseNgH1Q3vX4f5fhkGAUUHEb8ugT/H cLKz5LeBeMRxdQfCXE97H9vffFEIfy1MBgu9+aJbK8wZIWJIGw7v/bM8R/hb3E+S8vXu25kJ74g JW1GdpMyQwf03r1fD1q7+lfHGkRoEl/ekgKmDxa5sRltOM5G6UKwdGVp8bwxIQYTPBWUDLzooBu AJmnbUxu21l+G2Uy88iGPcPvrcJe9zdPBx7/hpM2CySKOqEShlLAdi7pZZS+99fhP6JcxE2Q7sC ukkD2+2fMjUbfDr/3kp6VPB8Fo2AohcCsA3JgYekOSbYnjybXBgV6TZuXDd42eMQcpBkIOpTFRl KDE22aFapza5wyJQqSY01Yq6zounVXebCjL2uaEl8iYHM+PMaryKRRhj5rBigz2udMywH/YJzms 4gjKDCD98bXWJ/sa7tgBtXsEXl1hRPRza6ep+1N6FuCPIkhDs9JJDNb6W/UkWlcN6QkSXXi9q5a CGjI6HMzkii X-Received: by 2002:a05:7301:9bc8:b0:304:2eb0:2737 with SMTP id 5a478bee46e88-30449183b1cmr6971558eec.21.1779718576707; Mon, 25 May 2026 07:16:16 -0700 (PDT) Received: from [192.168.1.18] (177-4-162-74.user3p.v-tal.net.br. [177.4.162.74]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30451ef470dsm7994721eec.4.2026.05.25.07.16.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 May 2026 07:16:16 -0700 (PDT) From: =?utf-8?q?C=C3=A1ssio_Gabriel?= Date: Mon, 25 May 2026 11:16:09 -0300 Subject: [PATCH] ALSA: seq: Remove arbitrary prioq insertion limit Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260525-alsa-seq-prioq-limit-v1-1-16c348df5ff7@gmail.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/yXMSQqEQAxA0atI1h0o58arNC6iRk3jWFERxLtb6 vIt/j9A2QorZN4BljdRGQcH/+NB2dLQMErlDIEJEhP7X6ROCZVnnKyMM3bSy4IUpmHEcW0oKsC lk+Va9mf7y1/rWvy5XO4XnOcFWsvc/HgAAAA= X-Change-ID: 20260518-alsa-seq-prioq-limit-a3734e5f0a4b To: Takashi Iwai , Jaroslav Kysela Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, =?utf-8?q?C=C3=A1ssio_Gabriel?= X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2280; i=cassiogabrielcontato@gmail.com; h=from:subject:message-id; bh=MFdFeKm/G+G5nLzwp77/0tJ1+gU1siWkcfoiFBsseYo=; b=owGbwMvMwCV2IdZeKur/u2bG02pJDFkikesOufIr1WjzXonvF/tYrbzDYqf61MPnzuUckNr5Y U8YwzedjlIWBjEuBlkxRZbVSYss93Q9uFoft8IDZg4rE8gQBi5OAZiIWCwjwzS3lw9iD+9nlvC/ vvujW+7PF2z9Mzcxt+r9ZT/Ltft0ZifD/7K0OkfWcofaostiDKeDpJcnZ8+SPXJu5suNJ28G7XB 25QcA X-Developer-Key: i=cassiogabrielcontato@gmail.com; a=openpgp; fpr=AB62A239BC8AE0D57F5EA848D05D3F1A5AFFEE83 The sequencer priority queue insertion path uses a hardcoded traversal limit of 10000 entries. The value is intended to catch a corrupted list, but it also becomes a real limit for valid queues. The event pool limit is per client, while a sequencer queue can be shared by multiple clients. A queue can therefore legitimately contain more than 10000 events. In that case, inserting an event that has to be placed past the arbitrary limit fails with -EINVAL. Use the queue's own cell count as the traversal bound instead. This keeps the protection against inconsistent list accounting or cyclic lists without rejecting valid large queues. Signed-off-by: C=C3=A1ssio Gabriel --- sound/core/seq/seq_prioq.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/sound/core/seq/seq_prioq.c b/sound/core/seq/seq_prioq.c index 25c0ed8f9f0f..d5bad1c585f6 100644 --- a/sound/core/seq/seq_prioq.c +++ b/sound/core/seq/seq_prioq.c @@ -132,7 +132,7 @@ int snd_seq_prioq_cell_in(struct snd_seq_prioq * f, struct snd_seq_event_cell * cell) { struct snd_seq_event_cell *cur, *prev; - int count; + int remaining; int prior; =20 if (snd_BUG_ON(!f || !cell)) @@ -162,10 +162,16 @@ int snd_seq_prioq_cell_in(struct snd_seq_prioq * f, prev =3D NULL; /* previous cell */ cur =3D f->head; /* cursor */ =20 - count =3D 10000; /* FIXME: enough big, isn't it? */ + remaining =3D f->cells; while (cur !=3D NULL) { /* compare timestamps */ int rel =3D compare_timestamp_rel(&cell->event, &cur->event); + + if (remaining-- <=3D 0) { + pr_err("ALSA: seq: inconsistent prioq cell count\n"); + return -EINVAL; + } + if (rel < 0) /* new cell has earlier schedule time, */ break; @@ -176,10 +182,6 @@ int snd_seq_prioq_cell_in(struct snd_seq_prioq * f, /* move cursor to next cell */ prev =3D cur; cur =3D cur->next; - if (! --count) { - pr_err("ALSA: seq: cannot find a pointer.. infinite loop?\n"); - return -EINVAL; - } } =20 /* insert it before cursor */ --- base-commit: fa16304d1c5086bb8b537dd05d36ea68032228c7 change-id: 20260518-alsa-seq-prioq-limit-a3734e5f0a4b Best regards, -- =20 C=C3=A1ssio Gabriel