From nobody Tue Jun 9 00:59:52 2026 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D6031E1E16 for ; Sun, 24 May 2026 18:24:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779647043; cv=none; b=dKu3le8i+lnFnR6p+qCBQACNsURuMNHR/JA3dqftfRztnG/iQJZxMMu2KLIao7xx9rWVSFa0yXscnmiQhlS4qMiCyPzAvV2F+uNNb1S4isUyhLovr91TItWdMvQ8wOm4TmJlkoKWfcCYQ5pEoAXVXQf2B8wG0THvuKyAWqocvqg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779647043; c=relaxed/simple; bh=R+ElcQoZlMTaMjyb0gfctea/sh4vXsBf0F0G4P4BLk4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=nE633orz/f32M7taSxQ9ZoyxTehd0/MPsmtt4+ECFLYfkSlIrCg/mWKSrR0GXWUSo7Ey9wqcJhhhUadcpIoNMFuH7vz5qXUHYdWlnUVd2ixwTTTk3kgLbxJSJMWmqpgPTBvxzZ/EwKt9FZPlNRfBVcyaw39Qh/gVifxlktMAP3A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=n1D89wyA; arc=none smtp.client-ip=209.85.216.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="n1D89wyA" Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-367cbac9cb1so8667794a91.3 for ; Sun, 24 May 2026 11:24:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779647042; x=1780251842; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=b/VRKGhpClL2qx91sk96jvJ7Ms8mqjpuQNfM6bhiFpk=; b=n1D89wyA/25OwTCi1uGLn0ssL9VXUNEDvgo35J+DfKldJiCnYSYmo0WcNJZ9FqmNzX ljfTdM25ncH33x4suzTW2Y4vCb9rhjj2PnAQx9eyCrPYhw452Y+DQxa/VUw7aRXrEJSg zoCl7b3BzkPJ1o1rV0sWkLI3bUvxCmci81kEfINfhP3lfFHcsWFfx0FL03fzAaY5Irre LLLKC6Foqd8w0kDmNDS7gclHj9wfG6nO4Orny5FP3P1nWDwpFghV4qf37pGcCJrqGNSr 3q8NjxtwDnsa5m7X5QeiD8P6Ia8szOO08QTqeymbR7eNlEwqIjzrVm7NuaT7yDW4JEQx +8+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779647042; x=1780251842; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=b/VRKGhpClL2qx91sk96jvJ7Ms8mqjpuQNfM6bhiFpk=; b=nCT7wG+b68yg68s1a5TaXZfwaHo03sD7pVpxHb4R4jHB+EGEL1e4ECNgdwEIxXJXFR xnnqjwc5zFdeN3HXOZsyMsAPBkzVxItBb2O8uuJRJas4welHWm8VlIlH6EoSVvmnQaBJ ki2XwPo/liHV8pcJkwOwIu88Uxd+20XivFCVAYcvenowrpPGgNRRqal4MJEfds6QGJ95 +Q17fVbgVM8b+dCoUwl+eR9TBFTRlIlC1kyvw9Q0pMo+Ev+yBhDgekkYu0yhHvzuIvaZ 625u70O4u1QlGgXSA3yCXMk3c2Ri+Bp531bmD+yaXzIiiDWb8rwua9B4tSgwtPsLU+jL eWVQ== X-Forwarded-Encrypted: i=1; AFNElJ875osh90RDg2//TvNZUwCEynQE2gH5bRVDFmnFE93F75FREbjAWfB6xpvYixBLC9bbj/S0aQ1bGtkBqow=@vger.kernel.org X-Gm-Message-State: AOJu0Yyffnli/xyZMxjVlgUR8Ts2GbjjSgOmgFmjCstQ90VdoZUF3bCd kJsA3cC/haHSSkKqEuw88yt3ZALsV5I36ztV4gXmGj8CynvSMVzEuC4= X-Gm-Gg: Acq92OGFdaEccKr5/iDKa0pms696+c+uwGRbuImYBFi3WTWbJYIAqSU9R8WZRQ5Sc3a GZs9RPQ8fGPkIBFHHVU2JnEizSZCnBI2fmkpTyF02uq1jDtWiZTNPqY7v1dyv5kMxR+h2aWMiOB xC3SbgbkFJvW18+TjF/RKhOuUlkDIrLuBf7K4G/FVIB6ovfTp+fzRvHE2rlZoNOa/JQPbm9qWrr FGr3BSlcjJ4DmO2+hssfOJUaqnUAz4MintyWHcM1Sd5gcSqsJh13unXjRzk5VvNCERcOqCoqutx jUU3cbSzJ1igbC2KoEFOly6zU3S1vHXF2xAmb0rgtz7DiohC51SD4Ogf3PW/XJoVd0uCldXdpsD svavt6EOyEDcBqiRBCODlM/Tue6WH4vPmjbBwLx5WwawaDbjEFHAkZofzdAxui7IzR2bHvbKGPs 3pTPVEri8VKSDaa7hGGKpLDYNhuwNV1nKmnpIkPdod2S9nM7gzFYh+Sbbl9qjnnmNPv9x/YB0= X-Received: by 2002:a17:90b:5485:b0:36a:aeaf:ab2a with SMTP id 98e67ed59e1d1-36aaeafabf7mr3895058a91.19.1779647041960; Sun, 24 May 2026 11:24:01 -0700 (PDT) Received: from localhost.localdomain ([1.226.165.54]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36a6c7b4febsm4419208a91.5.2026.05.24.11.23.58 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 24 May 2026 11:24:00 -0700 (PDT) From: Myeonghun Pak To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Myeonghun Pak , stable@vger.kernel.org, Ijae Kim Subject: [PATCH] Input: rmi4 - release F54 queue on video registration failure Date: Mon, 25 May 2026 03:23:45 +0900 Message-ID: <20260524182351.27658-1-mhun512@gmail.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" rmi_f54_probe() initializes the videobuf2 queue before registering the video device. If video_register_device() fails, probe only unregisters the V4L2 device and leaves the initialized queue unwound by neither remove nor file release paths. Release the queue before continuing through the existing probe error path. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: 3a762dbd5347 ("[media] Input: synaptics-rmi4 - add support for F54 d= iagnostics") Cc: stable@vger.kernel.org Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak --- drivers/input/rmi4/rmi_f54.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/rmi4/rmi_f54.c b/drivers/input/rmi4/rmi_f54.c index 61909e1a39..fca7b9fec5 100644 --- a/drivers/input/rmi4/rmi_f54.c +++ b/drivers/input/rmi4/rmi_f54.c @@ -722,6 +722,7 @@ static int rmi_f54_probe(struct rmi_function *fn) ret =3D video_register_device(&f54->vdev, VFL_TYPE_TOUCH, -1); if (ret) { dev_err(&fn->dev, "Unable to register video subdevice."); + vb2_queue_release(&f54->queue); goto remove_v4l2; } =20 --=20 2.47.1