From nobody Sun May 24 18:41:09 2026 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 121053A1A3B for ; Sun, 24 May 2026 16:07:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779638826; cv=none; b=HhC7sLMeishVxS+KF4SQqhlEVNqAi+uEwizZVmuPSlhU8EuHduP7ZvQUjWBQKsvRMymaaZkGM3MNkxxYO5uFGnxZCdManL6+XkspdPp3uMh6AO038xFrkc7HYFfRRM0SoPi8UIqTnVkFsQGU0/YNQ1+IfPtjf3dm/fj8WkvFCmg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779638826; c=relaxed/simple; bh=oFecsmdHD5Cq5W5MDU8nNRtON2oDakO8PkdvCnvCWfY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=V++rQ9qYMJHmV5yF86c3hKIiZXpO/488mORSawaGF7hTIyxRKFYj0rn7bKzrepku+4J7uK1LvUOexarGyJTu4/+gxOJDPA1KdsPBQmpZIEJxc428TBGMFAB9kf0K6mZyCBgV2KkwjMtsEDWcchjU+k9u5RpcHNVVaihn6g0arLI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LBzNKn6R; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LBzNKn6R" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-36608b2f2dcso5799605a91.2 for ; Sun, 24 May 2026 09:07:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779638824; x=1780243624; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=18MxIR0tdVmzmTTCjfqveL+dgh6nwJgg/2YQDWJQQr8=; b=LBzNKn6Rl+YurdChLp+7qoPPZUGzmmxtMB4CQsSnh7eM1jaafMZ94USmZDxs4JFEg7 1wEkqusXooU7zIMRgsqr4VCbEi28VKNw9XqUuZh6MRFY8J6Cg24MhvtcvAZSe8QZcbaq ejGt34bV08cJG90EBssiNPqfrckxJcX2lBqKwryypTHWeyN/jcwWWZBe9cZHYPFIM6Vw +Oze503Rv1v1kSPDtHjppQnIJoBf7/PTOwG5I6/zBcRVils3t/TotaYGXRZ4qTr8HVve k8sYWESwOnKMbcRPOq9YKiqR949YXKFMT9NK41fubkkNJwPg+dfxgGMDcYbcDTVdLkHF aydg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779638824; x=1780243624; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=18MxIR0tdVmzmTTCjfqveL+dgh6nwJgg/2YQDWJQQr8=; b=OeoK6SDaGmd2LQrWTc/zbymjvu29FK/KGXnL3137mOs2w1rv+GJdlPHtbW+ov09V6a RXKxl7ZivzQfoIGK8FaUmOXR6ylMlrq2j6OMLY1Plu6yJ+7aKYfSS4hjHwYWRu37jlrh C4y7ytxnd1idEn6T5ql62fxssaqig1XCPbBZpaYTZ4oBAWY+6srfceqDySjMFj+lKMs9 QRm1F2fMP0NB8CIXxhZ8eZoS2kSBdDjwy5zkN0pXh5vLapN17sT+GyXuVm3az/Zou+P1 p3vsMHinLbX+Pn+x6DN+6PGLGjjF7rqw59NS5ARwQgGIxJxVfLJQnWLsrnwOozB7pHSo meug== X-Forwarded-Encrypted: i=1; AFNElJ9tWqs2ZtyQoxdQZFHNEdL3YRamaMKwRCJf2Pxk00iRpWsKOV7747afQLmAWQgEKwhPTE+YD73GFyY30hQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+8wliJC8jHQbD0usnlQdL3OOrmYbO/8IS5gqg3vQnCkZgVrD+ 5xbTHMKFpKhe63VYYrbM32bJ8OylO2C3q2DfKa2EY9uuOr2/UkdGHM4= X-Gm-Gg: Acq92OF79/ANyqjSYWe2LCBFwK7DBse1MKfQhLJGw6LpyO/Lu8DOJ3p2dY/doW4wuY4 BnEDiyfUGq1UhPnec2nV9he//nsP5VAifq2VL5j2mt45EpZz0DzqKfbSdNc/iZmA357U4U4omZN yZMLu2xjNgUUHbqDZHYKG4GbRnnErro6IOsBf2AQk2EnVDR9ijsP/cMUJeuOMVflkI6oT1OfO3U LjGYRFvDXVpU7HbA+DhgqAXWb55ANY8fLPRwEdGgxFU10D1vgw3V2zPycgVMKk57j6c5+hSDnn1 CWLMUuzAJPCNaUxJXO5yVQ7f/E4MuCBJ2zNf2wRkAyM211KlYYVjYWZcl/7I71hmhWsjVTaUPWO 672Aao9dA7J8lVKgT2sz9pnmYlP0LWpdAmuB1GgknYRKuAJMhOxm6W/N3YgTdZCqOyv9gfVThmt U1q1lgSEcn78qWM9uSBbkokn/ZiygyfbeX92J7nDdgIbV3NpqRdSDprPQMmqrTIwOGJ76uHJs= X-Received: by 2002:a17:90b:2585:b0:366:3ac:f730 with SMTP id 98e67ed59e1d1-36a6788e0abmr10212406a91.25.1779638824285; Sun, 24 May 2026 09:07:04 -0700 (PDT) Received: from localhost.localdomain ([1.226.165.54]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36aa73da32dsm2082541a91.4.2026.05.24.09.07.00 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 24 May 2026 09:07:03 -0700 (PDT) From: Myeonghun Pak To: Neil Armstrong Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Myeonghun Pak , stable@vger.kernel.org, Ijae Kim Subject: [PATCH] drm/meson: clean up KMS polling on register failure Date: Mon, 25 May 2026 01:01:39 +0900 Message-ID: <20260524160657.17802-1-mhun512@gmail.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" meson_drv_bind_master() starts the KMS polling helper before registering the DRM device. If drm_dev_register() fails, probe unwinds the IRQ and DRM device without stopping the polling helper. Call drm_kms_helper_poll_fini() on that failure path before freeing the IRQ. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: bbbe775ec5b5 ("drm: Add support for Amlogic Meson Graphic Controller= ") Cc: stable@vger.kernel.org Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak --- drivers/gpu/drm/meson/meson_drv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/meson/meson_drv.c b/drivers/gpu/drm/meson/meso= n_drv.c index 49ff9f1f16..e49de5df73 100644 --- a/drivers/gpu/drm/meson/meson_drv.c +++ b/drivers/gpu/drm/meson/meson_drv.c @@ -352,12 +352,14 @@ static int meson_drv_bind_master(struct device *dev, = bool has_components) =20 ret =3D drm_dev_register(drm, 0); if (ret) - goto uninstall_irq; + goto uninstall_poll; =20 drm_client_setup(drm, NULL); =20 return 0; =20 +uninstall_poll: + drm_kms_helper_poll_fini(drm); uninstall_irq: free_irq(priv->vsync_irq, drm); exit_afbcd: --=20 2.47.1