From nobody Sun May 24 18:41:09 2026 Received: from mail-pj1-f44.google.com (mail-pj1-f44.google.com [209.85.216.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6733F39B94D for ; Sun, 24 May 2026 15:57:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779638264; cv=none; b=JCDP+SkqYKuOb7I7+WP0wFejzBfpT9dhYp6ojlonZQT+8sHcReKXPjP1dcNM5e+54lVElyyaRiXf0oZ2DYbw/rD985j0nEu03yu8ab+tZR4bCHAhUXFrP7sTKbzF3wYfJGvp8xC6xJyM1shbkRB4LDO/K0kog8lyyjHvb8fB4r8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779638264; c=relaxed/simple; bh=4XyxSzDh/MH7gtFpuUEyWHv0AWwOrbUWrt5ubgaMhyU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=tzH2YsFmD0f5gNdaOX/6YGNWdS1Lw6BKNZl9ZAd7iwTYdp704nJvonylFlncdV6FMhSkU+HhcLrOUl3UPbdoB6lZqWMQjmgdWlZmJ5nKD+NJ4mgQfmLG0ay460Vl9pspptq5pymuGaG5Nt/HAoLxpAXeEGpL3/HVCfZJOSluDCM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GgS9ROuT; arc=none smtp.client-ip=209.85.216.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GgS9ROuT" Received: by mail-pj1-f44.google.com with SMTP id 98e67ed59e1d1-36a35e4eefeso2443979a91.1 for ; Sun, 24 May 2026 08:57:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779638263; x=1780243063; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=wuu4460x4/FBZThRE+KXHL2JDpzAJY9WR1Xg237ETeE=; b=GgS9ROuTljY3YJjiXSVO9t+CoodTfhdBmj1mI3Gf5qQ/0GmDJsAyK0PSuGdnTJcprY 3rSjj1Te3tnGvGHMLugwX1Wndbe5Y6roP4uI4BR/7IJToDssiV+D7xi+YUhSFFePFmjE TkuusQFlzSFRl1VHvo+lck49nG1576QyhGPbFvoJD4xa100qNlC2FJWarc3lAL4t6EBJ 6LI7nN5wthypgU6GShaO+m+e3XStFoPdjobpCkCBePHMQLled7eLtCzqXCrd8sj1zlzF v6GGv+6NXDaT9xRU6w3sWd3eRDJo1ms0KgKj6gJbPxxiVQ+QGceVFT0AXBVRmsr7KsBR 2RFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779638263; x=1780243063; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wuu4460x4/FBZThRE+KXHL2JDpzAJY9WR1Xg237ETeE=; b=BpLwCaFHGGiyRqaA+Jadmy/5AEe4jHx9x7QXUKqA6z2OJ1Xij4kLmDHqSn3jr5jvos ZFjZ8QS843EKwEiKlf+6Im0L/q9lczCQE9WC15SkbcdVEaBaHIc8aEKGPfIVG9KTE8GN +tWyDJrA2ALghVlvB52lWwHtje0aJsJajOP1k34WZ9fsgWAtctFzlMncQjKEjK6wJh9U 5Y/xoeoTcWhBd+X6qnFGcCsc3iYNIwZHtS+XDnN/zoS6kt6rf3lrjbfhfJQXxIpeIk1r 8t0Xb8ATbmWZyIev4tLfs//artmcHLS+wZp5gfxTPsWxCsw9sD5rp5AycXCyrG+T3Awj 71mQ== X-Forwarded-Encrypted: i=1; AFNElJ/oQNmwSRLzwobuwwGRyAS2UarqS2zvm6aS84c2qDtns6vS051gihDRg5EEvbgoqVZAFHYHs2zwr1k5PSw=@vger.kernel.org X-Gm-Message-State: AOJu0YwpSEXevLdKJhIT1i5UP+emJKR1BeVJLGv4Wn6MigVH2Wf9/z/8 nSexJrE3Ij/xl+HRJP5AFwohMwGkJvDI3dusaLul17nXvSdvud9nTy4= X-Gm-Gg: Acq92OGD0XpvXkBNeUlndMBYod8P592rVOGJPPz7w7Vn05xIx3erT9jBJcwvc6QKEQY 5eLkFSXsF6et1oWFVEthDo9vfUdkqU4uEDiUNsJODfrdSy75Ou8rpPzA4nOPjkhVtYaPn6Gd/n7 Kr+BgJtzX7Ll5IRh2xFzamWy8xk2Sbe9ROurFFHj/qfkjCeXsAzwixQuPQYobeI+nqlYsGuNIZb U8x4UjnyHNR6rVofguM/q91QHn3EK1sqcjqwfrfrh//Szk+LguYAVs8UnjFwgLh3duX/xoVv/yi Fr5QKfaMTIsNxot+FsueEoSkpa9T6CYb4L4rRBGB7NzrNpNg76fhLw7Gir5CWEaDrM66JF48HfU qM9tvvh4SDcKlMUgTJNtyjzoig4n5+Erz2oF05amt74xZozd+Nb5Ym+hlmPyJBD5TKDvBGV3Y7s AVxqD8W47aQALJLpqJrHwbC9E6vDfix+MAGQf3gfNdhDI4PAW7TWLsu5Cdkn0AX4IcHpgQtDM= X-Received: by 2002:a17:90b:544f:b0:36a:b560:5c61 with SMTP id 98e67ed59e1d1-36ab560606bmr3756342a91.7.1779638262720; Sun, 24 May 2026 08:57:42 -0700 (PDT) Received: from localhost.localdomain ([1.226.165.54]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36a71ecf799sm7169671a91.8.2026.05.24.08.57.39 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 24 May 2026 08:57:41 -0700 (PDT) From: Myeonghun Pak To: Patrik Jakobsson Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Myeonghun Pak , stable@vger.kernel.org, Ijae Kim Subject: [PATCH] drm/gma500: clean up modeset on backlight init failure Date: Mon, 25 May 2026 00:57:11 +0900 Message-ID: <20260524155735.13865-1-mhun512@gmail.com> X-Mailer: git-send-email 2.47.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" psb_driver_load() initializes KMS polling before it attempts to initialize backlight support. If gma_backlight_init() fails, the function returns directly and skips psb_driver_unload(), leaving drm_kms_helper_poll_fini() uncalled. Use the existing error path so the partially initialized modeset state is unwound before probe fails. This issue was identified during our ongoing static-analysis research while reviewing kernel code. Fixes: 1f90b1232773 ("drm/gma500: Refactor backlight support (v2)") Cc: stable@vger.kernel.org Co-developed-by: Ijae Kim Signed-off-by: Ijae Kim Signed-off-by: Myeonghun Pak --- drivers/gpu/drm/gma500/psb_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_= drv.c index 005ab7f535..7218026fe2 100644 --- a/drivers/gpu/drm/gma500/psb_drv.c +++ b/drivers/gpu/drm/gma500/psb_drv.c @@ -406,7 +406,7 @@ static int psb_driver_load(struct drm_device *dev, unsi= gned long flags) drm_connector_list_iter_end(&conn_iter); =20 if (ret) - return ret; + goto out_err; psb_intel_opregion_enable_asle(dev); =20 return devm_add_action_or_reset(dev->dev, psb_device_release, dev); --=20 2.47.1