From nobody Sun May 24 18:41:30 2026 Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59C0D23FC41 for ; Sun, 24 May 2026 02:59:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779591552; cv=none; b=t0JCcDvqyUeQuOgvjg+ppsxWkxHf9d0qHp9069C1NyGRjlPwy3OGtxmunAoUSQUhaX0JCsD8AeiJAzu25PmlTbFEYdKZDDpSZiDMaiE284/A9BDpUKO8u+ZSdOQMgmaSKMyClsTNQcyKtur+qo8w2vNij7JMJeThP+B0859pICY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779591552; c=relaxed/simple; bh=UbgCFgvmWaN3PxrtD/I70PhR4vT5giki3jZ1lSQlgl8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RJm+1McOemp46UVgotwbL0fu/3Cwi1Ey6XzNV0mFy3pNRQg4EF3aKE16UuP4HLucyWp+RgACze+2W9Hb036Op6+53+iRvMh7n+6Fe4jXvJdy0MiD88kQOp8FucDuaDxN5cgBjDQ2sBoycw0Fg9iCvyJePruV9kJEcJY8zIlQWWY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=rL99RfpL; arc=none smtp.client-ip=209.85.214.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="rL99RfpL" Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-2b4583f0a1aso59487005ad.3 for ; Sat, 23 May 2026 19:59:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779591550; x=1780196350; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=bYwNNVyWKj7ua+gpS+KEFegejp3wiD0Ae6Di3tktjdI=; b=rL99RfpLUyFCIcILAomGuyLHN/+3tqWIwETNEP9f78Gcl7XtyfCu4Nnu5la0Njssyd o9CjCXDrJAp7HOxkMbbPMYAyD+7sX4PyGxNILxQR5fz3YNlKS8wUlP+ccBwEh2mMJJ7d bzjwSA6s2NfAledFfrtjuNOWHnpVbaAE0ZBWZvUDNc1L+CnXfAgZqFgHerb9MCyyhiBr 6VLTW9PzvgN9CxCL3iRFWGe9TDondjfUpaWd76PXwny1WIJdbXdSlAs+jRR5jubtYtGo cp6Pw/5xIi01BDTBgNM4e1M3TNwilos50+FZJiGb+SFID6/ZPmyNF8wn5LdcSbuxLhCM F1LQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779591550; x=1780196350; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bYwNNVyWKj7ua+gpS+KEFegejp3wiD0Ae6Di3tktjdI=; b=UHhBt1WI+kaJQsT2pHrtbiqi8I9rxA4wxFQY05wachvqv+EnXcSnEp5iSkl4EuJO6s oWykn6Evida5qx26+FYKZYleO3dFc8wI9Ut9xu6Fk5fCx0TNLqniBf606dCeUIdAxDrT is68NUTxdaM+oP3xQGSr9MO+QvsyfQMIMTKrdJQ1OZyst/VCCdnt/SCbIx0yhYKnFWoU CV8CA10F/XUSKq/gkBxqq81Z5cDUe89XZAlq6VFQpOC8mdZuzOwhFe3Xc7v59d41aHv8 oqp1JyObACs/p7wgmjXzQX8GPEesifUOQ7YydApTIqC2SOQqDuDfSZXJpz4DROETFGsR LzqA== X-Gm-Message-State: AOJu0YzpBDzMNtYfMfTC529OOGG7sNOnQVYud1gpxU1CedV2n+qMThYJ 7vJ3lks9jnrwaWQoNlDUFRcy/r24tGGpao5MV7V4z9zYm5dwU3h1mtoc X-Gm-Gg: Acq92OFsdQGiQft8omWPrDb4yur0BGDEBurvDDZbF5EzXmFQwGkeSjJOfAdtFH4kw4X WJOarp6EPYCzwxFIzKL3GxsjA17ZNiTr3kdrwwYBVtU611/EgvIV1JzXwKf+u2wjd2XXxK30Eih wqeHLXCTW8SMbiz7UzqhX5DnCF6+blQw10cqXZbjSXvlCxn144uPa+LirMfDIXuNTtEuukmRhsc TeReUT9vSb/FHtNpPmHIAVlkSVhryjkEV8bjgGw0UBBVr2YdsTmEirdIMOgkNJX6E7OpIstSQM2 rnvh3y/MLFgFHQn7+paxV74knV0Vv7Ai4hu1eCqWVObxtnkjwtZZ5HoAucxGa3UZZ/iorEL2j6H GsF7JNPhykLv8frHm9Ske5aleRSMYg4cGDcBYd2+7JZCx904A2GM2lZsT0c97ydFJQ8ZbEDCFkn KDIP+70iQj3OTkXXWYt7p8SEkGrVykMho= X-Received: by 2002:a17:903:2450:b0:2be:3626:dd49 with SMTP id d9443c01a7336-2beb06eaa4bmr100475355ad.8.1779591550322; Sat, 23 May 2026 19:59:10 -0700 (PDT) Received: from archlinux ([205.254.163.44]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2beb58b386esm62212935ad.44.2026.05.23.19.59.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 May 2026 19:59:09 -0700 (PDT) From: Suchit Karunakaran To: andrii@kernel.org, eddyz87@gmail.com, ast@kernel.org, daniel@iogearbox.net, martin.lau@linux.dev, memxor@gmail.com, song@kernel.org, yonghong.song@linux.dev, shuah@kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Suchit Karunakaran Subject: [PATCH v2] bpf: replace pop/push emptiness check with bpf_list_empty() Date: Sun, 24 May 2026 08:28:53 +0530 Message-ID: <20260524025853.13786-1-suchitkarunakaran@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Simplify fq_flows_is_empty() by replacing the pop/push based emptiness check with a direct call to bpf_list_empty(). This avoids unnecessary list mutation and simplifies the code while preserving correctness. Signed-off-by: Suchit Karunakaran Changes since v1: - Removed unused variable node --- tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c b/tools/testi= ng/selftests/bpf/progs/bpf_qdisc_fq.c index 1a3233a275c7..8107f5934d2d 100644 --- a/tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c +++ b/tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c @@ -196,18 +196,13 @@ fq_flows_remove_front(struct bpf_list_head *head, str= uct bpf_spin_lock *lock, static bool fq_flows_is_empty(struct bpf_list_head *head, struct bpf_spin_lock *lock) { - struct bpf_list_node *node; + bool empty; =20 bpf_spin_lock(lock); - node =3D bpf_list_pop_front(head); - if (node) { - bpf_list_push_front(head, node); - bpf_spin_unlock(lock); - return false; - } + empty =3D bpf_list_empty(head); bpf_spin_unlock(lock); =20 - return true; + return empty; } =20 /* flow->age is used to denote the state of the flow (not-detached, detach= ed, throttled) --=20 2.54.0