From nobody Tue Jun 9 00:54:26 2026 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EF9037BE80 for ; Sun, 24 May 2026 21:56:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779659791; cv=none; b=czRt0rM9I3XNWNri0pLiq3gIOR+zdp6roA81nKn02HHyqpsuZ2W8ijeR2kYyrJ+lwR8/3pZXlbAxn5SyGPQdIwySWdqcfFDSBm4O0Hn1j1+iJGf41Cp5eht/mQgIxRtGryWuPrCnMOPIXuUCn1GtuuTgBa31xj8MpG6KEDd+Jb0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779659791; c=relaxed/simple; bh=hQjSMM6t3sxCSqcmkJ81Zbjq0q2FxI3vCZeoMcJ9WpE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=i3S42HSRSs/0jo/n5OynQ8M+wAU0hoqvMJuup+NVfM3kZ5W5ZpJVkiwAGgIrbRKKD1HX05YWKr07molqAkp2djC2zi+xky3PqXPzA59nvmCFYss2jtLqkJ8dw0H8qJ4J5pp3aH/87gghxwiA9Mjih8kZC2xAbrQXWHvGTWlCwTs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=meATpwqD; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="meATpwqD" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-49068493267so278265e9.1 for ; Sun, 24 May 2026 14:56:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779659787; x=1780264587; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=CHBYjKJssuWT+wJ7wjpQGIvdSHQM3QcFtzdTivvLnQo=; b=meATpwqDYRigVI/wz+1HVTInVg0zcOW0aLT/EhhuNC8LlLezx2P0ULYvDWycSDhQ2L 0ppuPDBwiC7kY04A06FDVWTMw9vGv2JQsg5a6FvgzlVhhbUKTEP3RzuBrXhLbqfTFCSX zIR1vtLZc0VuLCKUVxCq8hIQyMvhmA4yA87UJEX+uEQwMDEq1qOFXzEhdZGt7RGrsibk Q5f/z/sxQGMO65L5dqMBA2dGPUTYKJyRb5iFQmYyPvUCez7a7+Orh41aDUdGHtZnw9Vu BNVfboeOe/vqwI1Vj84pHD3YOlr5iU16kxweQxrq9neKJ0+HQNy6htHCmD5sh7T072bY WzUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779659787; x=1780264587; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=CHBYjKJssuWT+wJ7wjpQGIvdSHQM3QcFtzdTivvLnQo=; b=SAa91+e9HMlRKcL3886LRg6fL/Bp25rsd9mTRJP/Tp3L9LAVutigRiCNEZNzOQ0yMX sZGews71N+Ui9G4FXvx/ze0NlVvsu9IzuDSn/vFbL2Lhc9fvxnZg372Y/O0AoJkJSUhE snSwegeS883m+OKg3alW8a4/1mXPaS8OrMJRbef6JBsT6VQxCeSPBu9c+IgoJ6+MD4yH JmsL+/J+xxVN7KGGu8jKDNhy+MaSBHqpnX96tfWfGJpNhUn3QqEaF96FFuqsB+zgyFo8 ChIyj03VKwgc+5Vt7vYM9qbhSnouNnmMYpEu0/94UBDKf+h3asVW/smbLZM8guoCcomW J+XQ== X-Forwarded-Encrypted: i=1; AFNElJ8t8uu8biHG7kYpkJ3/WdwPMusW5dogHCEnFUPDdZNpj29hrprfK1Lyx5V1HqX4OJHn79pnp58ayHT5VDE=@vger.kernel.org X-Gm-Message-State: AOJu0YwQIMxcHdCQPzYCH7ClA40XGVNLkFabsPyc1yqmXbi5dfcC13r0 KjkDPV3xu5G211pQCLzin5uWkXTmkJtxorpxnAZNwj5RWpNvh5/coS+UMKNuhw== X-Gm-Gg: Acq92OE5lmAocL6Ag383b5de/q1PNiN3r7TLso8FbA9w74GeEJcqFE1QZalS4VGAiww RZaWqlxJIDzyNXD+crWq9ZfhnT/e2DN2IW4XYuHT2+U37Zda/Ky8wEIyWFE0fFVXy1nABY3VTR6 +lFYtHzWJ9kQ7zQW38LuxBKoNodqbjK0qbBuoNeNYOIssqkGthXfFHNPEmwrGhCYwY2oI6mJSQy u/7knilz5tLOX7RwkQ6ROC6MYH0eTAYXbUWgTJMwZixG2+vDelODuf0i1aDWHD0alMtLnM1J3uQ 90J8J1nMMM7Jpx4blg2OqamqSFB6tJtnUhkFVCTi8Z2VjhVQZdOw2mn1/GwoCkvdvQAWuD/wveP ihY21iah1t4yMfx7Au2xXDRfe0Z5XkjGtIm/UEQD8uH5q/F35LSXFg8nGitq0j0qyaF83CSDsD+ 2gf3Q1w5R39YGp7zAS1rWKV//ToovQTUTILfod60F+uO0RcvXBixYs3/dPAUVUbTi4o53how== X-Received: by 2002:a05:600c:8285:b0:490:601f:d766 with SMTP id 5b1f17b1804b1-490601fd959mr55022715e9.1.1779659787017; Sun, 24 May 2026 14:56:27 -0700 (PDT) Received: from [127.0.1.1] (213-225-2-150.nat.highway.a1.net. [213.225.2.150]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4904527f7f7sm300779285e9.7.2026.05.24.14.56.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 May 2026 14:56:26 -0700 (PDT) From: Javier Carrasco Date: Sun, 24 May 2026 23:53:55 +0200 Subject: [PATCH v3 1/4] dt-bindings: iio: light: veml6030: add veml6031x00 ALS series Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260524-veml6031x00-v3-1-29165609b2b5@gmail.com> References: <20260524-veml6031x00-v3-0-29165609b2b5@gmail.com> In-Reply-To: <20260524-veml6031x00-v3-0-29165609b2b5@gmail.com> To: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Rishi Gupta , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Matti Vaittinen Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Javier Carrasco , Jonathan Cameron , Krzysztof Kozlowski X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1779659783; l=3324; i=javier.carrasco.cruz@gmail.com; s=20260111; h=from:subject:message-id; bh=hQjSMM6t3sxCSqcmkJ81Zbjq0q2FxI3vCZeoMcJ9WpE=; b=uoheIXCm+3JGFAkvAyPTibOgSRYFB14l14N4pavWltkao6dcg+I5L6vpSOMV4gr0eTAbLxusD Y4AFxMMaZGECL4h20heu4GRDQ0WFyO/jdzU2vZXxVr8xH+cG1K4iBws X-Developer-Key: i=javier.carrasco.cruz@gmail.com; a=ed25519; pk=Lge8w8xidNSf/INy7JAIbAW+Hezkp3nsBh2OjKL7lLU= These ambient light sensors share their properties with the ones from the same manufacturer that are supported by this bindings. Note that only two datasheets are provided as every one of them covers two devices (veml6031x00/veml60311x00 and veml6031x01/veml60311x01). Reviewed-by: Krzysztof Kozlowski Signed-off-by: Javier Carrasco --- .../bindings/iio/light/vishay,veml6030.yaml | 23 ++++++++++++++++++= +++- MAINTAINERS | 5 +++++ 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/iio/light/vishay,veml6030.ya= ml b/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml index 4ea69f1fdd63..e01e8747e47c 100644 --- a/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml +++ b/Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml @@ -4,7 +4,9 @@ $id: http://devicetree.org/schemas/iio/light/vishay,veml6030.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# =20 -title: VEML3235, VEML6030, VEML6035 and VEML7700 Ambient Light Sensors (AL= S) +title: + VEML3235, VEML6030, VEML6031x00 series, VEML6035 and VEML7700 Ambient + Light Sensors (ALS) =20 maintainers: - Rishi Gupta @@ -22,12 +24,18 @@ description: | Specifications about the sensors can be found at: https://www.vishay.com/docs/80131/veml3235.pdf https://www.vishay.com/docs/84366/veml6030.pdf + https://www.vishay.com/docs/80007/veml6031x00.pdf + https://www.vishay.com/docs/80008/veml6031x01.pdf https://www.vishay.com/docs/84889/veml6035.pdf https://www.vishay.com/docs/84286/veml7700.pdf =20 properties: compatible: enum: + - vishay,veml6031x00 + - vishay,veml6031x01 + - vishay,veml60311x00 + - vishay,veml60311x01 - vishay,veml3235 - vishay,veml6030 - vishay,veml6035 @@ -67,6 +75,8 @@ allOf: properties: compatible: enum: + - vishay,veml6031x00 + - vishay,veml6031x01 - vishay,veml6035 then: properties: @@ -79,12 +89,23 @@ allOf: compatible: enum: - vishay,veml3235 + - vishay,veml60311x00 + - vishay,veml60311x01 - vishay,veml7700 then: properties: reg: enum: - 0x10 + + - if: + properties: + compatible: + enum: + - vishay,veml3235 + - vishay,veml7700 + then: + properties: interrupts: false =20 additionalProperties: false diff --git a/MAINTAINERS b/MAINTAINERS index 2fb1c75afd16..94a23bac568d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -28381,6 +28381,11 @@ S: Maintained F: Documentation/devicetree/bindings/iio/light/vishay,veml6046x00.yaml F: drivers/iio/light/veml6046x00.c =20 +VISHAY VEML6031X00 AMBIENT LIGHT SENSOR DRIVER +M: Javier Carrasco +S: Maintained +F: Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml + VISHAY VEML6075 UVA AND UVB LIGHT SENSOR DRIVER M: Javier Carrasco S: Maintained --=20 2.43.0 From nobody Tue Jun 9 00:54:26 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C26B37CD4B for ; Sun, 24 May 2026 21:56:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779659793; cv=none; b=PFTd4WbONw3J8hq+Xj2clACc0KNQ08BaPIUVlj/gesvg9wsereLtiLtmTX2ArpzrvrHYiAM9r7TBPJVMqUY1A+KPNbwQeQ8NgR1g4hhZHUUm6snVdzVLZHieFz8syiqZW4kF9oZo3v8ewmhVKRlPKYYJVsYhoA3zr/sDx3EF1KQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779659793; c=relaxed/simple; bh=JziZJoMiHB15dOlWp9Exj51fbL22V6FoXQj9Ec1n45k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=YrN/QIyAgtY49mbifGQvTZbqU4Pz8aVMmN2HuCLwVT/Clv3qJlFSfv53C104ZmoLleiKXRCMvFh4WqgYVYiLZpCoHPT57xYm6pGaGndoDrNjMmLV1hE8Rq3FrunrX1qxtFzooZFAjlImSXDXoHdMLgo3OEVeUA/1aE9UtpJw7yM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BB8GiVE+; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BB8GiVE+" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-49042aeeb75so35545925e9.1 for ; Sun, 24 May 2026 14:56:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779659789; x=1780264589; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=J0IwfiwSbLfrCDktVNrruMVR5P50dOmHJBxgfuqtt5s=; b=BB8GiVE+Zb82s+O9nGfmgsHwBtrerJtMsYHeFCzX3Dya7LeZ6RIdSFpOw8gWpO+R9Z M/Ht9+jp7p2UU3MBCKI3U1d6o1iUa5wrxrtZkoLuZI5TjHnuJdt2wsGZ8unmyMRoROUd McRVcIMemxgs0kQbkT17FuHGUUcQ/qIgOJxtJFroLPwhqqYs1+S3W3E+WcSAOjQZ0gg1 A96aC0loWZoM0GrYbaZyAX+AvYQU9S0y2+WXz0P8ONXybq+eBkOS2wiArysLkpgwLyNQ dm9vRDNNJL0cw8sm+lzRtr3xNLECajNdoCINNFdmmBsGAc633nh2bzzeEbWDHLl3xJdl kZFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779659789; x=1780264589; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=J0IwfiwSbLfrCDktVNrruMVR5P50dOmHJBxgfuqtt5s=; b=MikCmEoVlR3rrN/aLRcFJHMMMYjc0dtT7DVgHaTM5fwRzt+IDwLuwqwmmnlOMaNVKP pF7J1kQPY1N7888R55WTaGH6Z3jSMFKgpkBv6FQrShNVNVzI/rnkh5xZcikHvGnLFrio nOSr3gu1VuZJ8PweQ64jHXVCv/1Uc5jqS80BXdoy12qdVe8PPDQJQ2mlMglEPj+ip1MV r7zqyeNXrWGwejNTAx/xAIdWeAm5/wmPGNImImpa2ptG6p27zbg9GKpi5pO9bN68O42X PsEUmc2l5QwOIsfp2Aa5s4WSUTFtQZkTKZLZd9w/YbhpMSG/sTViO1VqrUu/c8RQRrQE DwBw== X-Forwarded-Encrypted: i=1; AFNElJ8ulGhDD2brPbE1YD0B/kdwuurl65xjS9IW7VQPzXGsYV7Kux080QbfZgA2Hg1cPunziL8cJ+8cXPnk3DI=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1UM5X4/7WAlvrpeFGuGmvaVCtrmOyHU5ElVfbboFzgJCAuYZd a81iBRgymr80fLTt3qHcpvs/hQlyFKfOyApOr8SPqmWKClIoEZHFPZ0y X-Gm-Gg: Acq92OEmeK+VTOjkhs78E5sjYSN+Sn/QNQAn5aHSx0Tuch+0mvMdj9uwu+n8ulLCAbO 7dFskXumkddk/N3bh5bB50oebZ1VWwCKtMtyoeB+GzIWT4F15gLms4OF+FhC785VRWooX0auI+A Ho5P9DPvwkcD53sIy8C+YUda2EDtvaMQXQAN33/xcMl0HaMf/lic84hIDzOsYwhHSc2Mi7rKahu ONPUgFwaguZnuPPO0u5X12S+Jn01FsBvpil4mFxyruNHFGkAEyjX9gvtD00xU/oRjO53cc6f2yJ avitwja9DAd4E4hlEHqF2RpL8BqOOl9r2Lpk6W+dytMVrGVdEWjhx2tnVNQO+izoYCK/2w100lP m9jF4mNSOUE/p+pAl1QVgK8KJUbm4Y/4diiSM2nqz2l4WHHU4Y/NvnW+J2pqfUhY+Mu+GChLajs WEKFtnzuJ7sK06w4iv/0zQUn2f8/eJqZprhuSejatk7vKqGre14P0Y26pxAw1Vdj4H9I6uCgO+9 8k9QzbE X-Received: by 2002:a05:600c:83c8:b0:490:601f:d783 with SMTP id 5b1f17b1804b1-490601fd8f3mr54198425e9.4.1779659788728; Sun, 24 May 2026 14:56:28 -0700 (PDT) Received: from [127.0.1.1] (213-225-2-150.nat.highway.a1.net. [213.225.2.150]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4904527f7f7sm300779285e9.7.2026.05.24.14.56.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 May 2026 14:56:28 -0700 (PDT) From: Javier Carrasco Date: Sun, 24 May 2026 23:53:56 +0200 Subject: [PATCH v3 2/4] iio: light: add support for veml6031x00 ALS series Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260524-veml6031x00-v3-2-29165609b2b5@gmail.com> References: <20260524-veml6031x00-v3-0-29165609b2b5@gmail.com> In-Reply-To: <20260524-veml6031x00-v3-0-29165609b2b5@gmail.com> To: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Rishi Gupta , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Matti Vaittinen Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Javier Carrasco , Jonathan Cameron X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1779659783; l=21157; i=javier.carrasco.cruz@gmail.com; s=20260111; h=from:subject:message-id; bh=JziZJoMiHB15dOlWp9Exj51fbL22V6FoXQj9Ec1n45k=; b=osq2VBimG5kRsm7DqfPNPsnlOu8cvWtypegnz/xnpmLe6WIenhBKs3yNeGzQTJP79J8LgXFkE jKlX0TxLSksC9m0PsF5/+ajEQxdVviWSMmZMkN00IU3qEkil+1TzwT1 X-Developer-Key: i=javier.carrasco.cruz@gmail.com; a=ed25519; pk=Lge8w8xidNSf/INy7JAIbAW+Hezkp3nsBh2OjKL7lLU= These sensors provide two light channels (ALS and IR), I2C communication and a multiplexed interrupt line to signal data ready and configurable threshold alarms. This first implementation provides basic functionality (measurement configuration, raw reads and ID validation) and defines the different register regions in preparation for extended features in the subsequent patches of the series. Signed-off-by: Javier Carrasco --- MAINTAINERS | 1 + drivers/iio/light/Kconfig | 12 + drivers/iio/light/Makefile | 1 + drivers/iio/light/veml6031x00.c | 657 ++++++++++++++++++++++++++++++++++++= ++++ 4 files changed, 671 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 94a23bac568d..47da46717c16 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -28385,6 +28385,7 @@ VISHAY VEML6031X00 AMBIENT LIGHT SENSOR DRIVER M: Javier Carrasco S: Maintained F: Documentation/devicetree/bindings/iio/light/vishay,veml6030.yaml +F: drivers/iio/light/veml6031x00.c =20 VISHAY VEML6075 UVA AND UVB LIGHT SENSOR DRIVER M: Javier Carrasco diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig index eff33e456c70..99a6ed80c7db 100644 --- a/drivers/iio/light/Kconfig +++ b/drivers/iio/light/Kconfig @@ -713,6 +713,18 @@ config VEML6030 To compile this driver as a module, choose M here: the module will be called veml6030. =20 +config VEML6031X00 + tristate "VEML6031X00 ambient light sensor series" + select REGMAP_I2C + select IIO_GTS_HELPER + depends on I2C + help + Say Y here if you want to build a driver for the Vishay VEML6031X00 + ambient light sensor series. + + To compile this driver as a module, choose M here: the + module will be called veml6031x00. + config VEML6040 tristate "VEML6040 RGBW light sensor" select REGMAP_I2C diff --git a/drivers/iio/light/Makefile b/drivers/iio/light/Makefile index c0048e0d5ca8..a8cc03cfb6c2 100644 --- a/drivers/iio/light/Makefile +++ b/drivers/iio/light/Makefile @@ -66,6 +66,7 @@ obj-$(CONFIG_VCNL4000) +=3D vcnl4000.o obj-$(CONFIG_VCNL4035) +=3D vcnl4035.o obj-$(CONFIG_VEML3235) +=3D veml3235.o obj-$(CONFIG_VEML6030) +=3D veml6030.o +obj-$(CONFIG_VEML6031X00) +=3D veml6031x00.o obj-$(CONFIG_VEML6040) +=3D veml6040.o obj-$(CONFIG_VEML6046X00) +=3D veml6046x00.o obj-$(CONFIG_VEML6070) +=3D veml6070.o diff --git a/drivers/iio/light/veml6031x00.c b/drivers/iio/light/veml6031x0= 0.c new file mode 100644 index 000000000000..50979d239230 --- /dev/null +++ b/drivers/iio/light/veml6031x00.c @@ -0,0 +1,657 @@ +// SPDX-License-Identifier: GPL-2.0+ +/* + * VEML6031X00 Ambient Light Sensor + * + * Copyright (c) 2026, Javier Carrasco + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +/* Device registers */ +#define VEML6031X00_REG_CONF0 0x00 +#define VEML6031X00_REG_CONF1 0x01 +#define VEML6031X00_REG_ALS_L 0x10 +#define VEML6031X00_REG_ALS_H 0x11 +#define VEML6031X00_REG_IR_L 0x12 +#define VEML6031X00_REG_IR_H 0x13 +#define VEML6031X00_REG_ID_L 0x14 +#define VEML6031X00_REG_ID_H 0x15 + +/* Bit masks for specific functionality */ +#define VEML6031X00_CONF0_SD BIT(0) +#define VEML6031X00_CONF1_IR_SD BIT(7) + +struct veml6031x00_rf { + struct regmap_field *gain; + struct regmap_field *it; + struct regmap_field *pd_div4; +}; + +struct veml6031x00_chip { + const char *name; + const int part_id; +}; + +struct veml6031x00_data { + struct device *dev; + struct iio_gts gts; + struct regmap *regmap; + struct veml6031x00_rf rf; + const struct veml6031x00_chip *chip; +}; + +static const struct iio_itime_sel_mul veml6031x00_it_sel[] =3D { + GAIN_SCALE_ITIME_US(3125, 0, 1), + GAIN_SCALE_ITIME_US(6250, 1, 2), + GAIN_SCALE_ITIME_US(12500, 2, 4), + GAIN_SCALE_ITIME_US(25000, 3, 8), + GAIN_SCALE_ITIME_US(50000, 4, 16), + GAIN_SCALE_ITIME_US(100000, 5, 32), + GAIN_SCALE_ITIME_US(200000, 6, 64), + GAIN_SCALE_ITIME_US(400000, 7, 128), +}; + +/* + * The gain selector encodes (PD_D4 << 2) | GAIN to identify each gain set= ting. + * Gains are multiplied by 8 to work with integers. The values in the iio-= gts + * tables don't need corrections because the maximum value of the scale re= fers + * to GAIN =3D x1, and the rest of the values are obtained from the result= ing + * linear function. + * TODO: add support for MILLI_GAIN_X165 and MILLI_GAIN_X660 + */ +#define VEML6031X00_SEL_MILLI_GAIN_X125 0x07 +#define VEML6031X00_SEL_MILLI_GAIN_X250 0x04 +#define VEML6031X00_SEL_MILLI_GAIN_X500 0x03 +#define VEML6031X00_SEL_MILLI_GAIN_X1000 0x00 +#define VEML6031X00_SEL_MILLI_GAIN_X2000 0x01 +static const struct iio_gain_sel_pair veml6031x00_gain_sel[] =3D { + GAIN_SCALE_GAIN(1, VEML6031X00_SEL_MILLI_GAIN_X125), + GAIN_SCALE_GAIN(2, VEML6031X00_SEL_MILLI_GAIN_X250), + GAIN_SCALE_GAIN(4, VEML6031X00_SEL_MILLI_GAIN_X500), + GAIN_SCALE_GAIN(8, VEML6031X00_SEL_MILLI_GAIN_X1000), + GAIN_SCALE_GAIN(16, VEML6031X00_SEL_MILLI_GAIN_X2000), +}; + +/* + * Two shutdown bits (SD and ALS_IR_SD) must be cleared to power on + * the device. + */ +static int veml6031x00_als_power_on(struct veml6031x00_data *data) +{ + int ret; + + ret =3D regmap_clear_bits(data->regmap, VEML6031X00_REG_CONF0, + VEML6031X00_CONF0_SD); + if (ret) + return ret; + + return regmap_clear_bits(data->regmap, VEML6031X00_REG_CONF1, + VEML6031X00_CONF1_IR_SD); +} + +/* + * Two shutdown bits (SD and ALS_IR_SD) must be set to power off + * the device. + */ +static int veml6031x00_als_shutdown(struct veml6031x00_data *data) +{ + int ret; + + ret =3D regmap_set_bits(data->regmap, VEML6031X00_REG_CONF0, + VEML6031X00_CONF0_SD); + if (ret) + return ret; + + return regmap_set_bits(data->regmap, VEML6031X00_REG_CONF1, + VEML6031X00_CONF1_IR_SD); +} + +static void veml6031x00_als_shutdown_action(void *data) +{ + veml6031x00_als_shutdown(data); +} + +static const struct iio_chan_spec veml6031x00_channels[] =3D { + { + .type =3D IIO_LIGHT, + .address =3D VEML6031X00_REG_ALS_L, + .info_mask_separate =3D BIT(IIO_CHAN_INFO_RAW) | + BIT(IIO_CHAN_INFO_SCALE), + .info_mask_shared_by_all =3D BIT(IIO_CHAN_INFO_INT_TIME), + .info_mask_shared_by_all_available =3D BIT(IIO_CHAN_INFO_INT_TIME), + .info_mask_separate_available =3D BIT(IIO_CHAN_INFO_SCALE), + }, + { + .type =3D IIO_INTENSITY, + .address =3D VEML6031X00_REG_IR_L, + .modified =3D 1, + .channel2 =3D IIO_MOD_LIGHT_IR, + .info_mask_separate =3D BIT(IIO_CHAN_INFO_RAW) | + BIT(IIO_CHAN_INFO_SCALE), + .info_mask_shared_by_all =3D BIT(IIO_CHAN_INFO_INT_TIME), + .info_mask_shared_by_all_available =3D BIT(IIO_CHAN_INFO_INT_TIME), + }, +}; + +static const struct regmap_range veml6031x00_readable_ranges[] =3D { + regmap_reg_range(VEML6031X00_REG_CONF0, VEML6031X00_REG_CONF1), + regmap_reg_range(VEML6031X00_REG_ALS_L, VEML6031X00_REG_ID_H), +}; + +static const struct regmap_access_table veml6031x00_readable_table =3D { + .yes_ranges =3D veml6031x00_readable_ranges, + .n_yes_ranges =3D ARRAY_SIZE(veml6031x00_readable_ranges), +}; + +static const struct regmap_range veml6031x00_writable_ranges[] =3D { + regmap_reg_range(VEML6031X00_REG_CONF0, VEML6031X00_REG_CONF1), +}; + +static const struct regmap_access_table veml6031x00_writable_table =3D { + .yes_ranges =3D veml6031x00_writable_ranges, + .n_yes_ranges =3D ARRAY_SIZE(veml6031x00_writable_ranges), +}; + +static const struct regmap_range veml6031x00_volatile_ranges[] =3D { + regmap_reg_range(VEML6031X00_REG_ALS_L, VEML6031X00_REG_IR_H), +}; + +static const struct regmap_access_table veml6031x00_volatile_table =3D { + .yes_ranges =3D veml6031x00_volatile_ranges, + .n_yes_ranges =3D ARRAY_SIZE(veml6031x00_volatile_ranges), +}; + +static const struct regmap_config veml6031x00_regmap_config =3D { + .name =3D "veml6031x00_regmap", + .reg_bits =3D 8, + .val_bits =3D 8, + .rd_table =3D &veml6031x00_readable_table, + .wr_table =3D &veml6031x00_writable_table, + .volatile_table =3D &veml6031x00_volatile_table, + .max_register =3D VEML6031X00_REG_ID_H, + .cache_type =3D REGCACHE_MAPLE, +}; + +static const struct reg_field veml6031x00_rf_it =3D + REG_FIELD(VEML6031X00_REG_CONF0, 4, 6); + +static const struct reg_field veml6031x00_rf_gain =3D + REG_FIELD(VEML6031X00_REG_CONF1, 3, 4); + +static const struct reg_field veml6031x00_rf_pd_div4 =3D + REG_FIELD(VEML6031X00_REG_CONF1, 6, 6); + +static int veml6031x00_regfield_init(struct veml6031x00_data *data) +{ + struct regmap *regmap =3D data->regmap; + struct device *dev =3D data->dev; + struct regmap_field *rm_field; + struct veml6031x00_rf *rf =3D &data->rf; + + rm_field =3D devm_regmap_field_alloc(dev, regmap, veml6031x00_rf_gain); + if (IS_ERR(rm_field)) + return PTR_ERR(rm_field); + rf->gain =3D rm_field; + + rm_field =3D devm_regmap_field_alloc(dev, regmap, veml6031x00_rf_it); + if (IS_ERR(rm_field)) + return PTR_ERR(rm_field); + rf->it =3D rm_field; + + rm_field =3D devm_regmap_field_alloc(dev, regmap, veml6031x00_rf_pd_div4); + if (IS_ERR(rm_field)) + return PTR_ERR(rm_field); + rf->pd_div4 =3D rm_field; + + return 0; +} + +static int veml6031x00_get_it(struct veml6031x00_data *data, int *val2) +{ + int ret, it_idx; + + ret =3D regmap_field_read(data->rf.it, &it_idx); + if (ret) + return ret; + + ret =3D iio_gts_find_int_time_by_sel(&data->gts, it_idx); + if (ret < 0) + return ret; + + *val2 =3D ret; + + return IIO_VAL_INT_PLUS_MICRO; +} + +static int veml6031x00_set_it(struct iio_dev *iio, int val, int val2) +{ + struct veml6031x00_data *data =3D iio_priv(iio); + int ret, gain_sel, gain_reg, pd_div4, it_idx, new_gain, prev_gain, prev_i= t; + bool in_range; + + if (val || !iio_gts_valid_time(&data->gts, val2)) + return -EINVAL; + + ret =3D regmap_field_read(data->rf.it, &it_idx); + if (ret) + return ret; + + ret =3D regmap_field_read(data->rf.gain, &gain_reg); + if (ret) + return ret; + + ret =3D regmap_field_read(data->rf.pd_div4, &pd_div4); + if (ret) + return ret; + + prev_it =3D iio_gts_find_int_time_by_sel(&data->gts, it_idx); + if (prev_it < 0) + return prev_it; + + if (prev_it =3D=3D val2) + return 0; + + prev_gain =3D iio_gts_find_gain_by_sel(&data->gts, (pd_div4 << 2) | gain_= reg); + if (prev_gain < 0) + return prev_gain; + + ret =3D iio_gts_find_new_gain_by_gain_time_min(&data->gts, prev_gain, pre= v_it, + val2, &new_gain, &in_range); + if (ret) + return ret; + + if (!in_range) + dev_dbg(data->dev, "Optimal gain out of range\n"); + + ret =3D iio_gts_find_sel_by_int_time(&data->gts, val2); + if (ret < 0) + return ret; + + ret =3D regmap_field_write(data->rf.it, ret); + if (ret) + return ret; + + gain_sel =3D iio_gts_find_sel_by_gain(&data->gts, new_gain); + if (gain_sel < 0) + return gain_sel; + + ret =3D regmap_field_write(data->rf.pd_div4, gain_sel >> 2); + if (ret) + return ret; + + return regmap_field_write(data->rf.gain, gain_sel & 0x03); +} + +static int veml6031x00_set_scale(struct iio_dev *iio, int val, int val2) +{ + struct veml6031x00_data *data =3D iio_priv(iio); + int gain_sel, it_sel, ret; + + ret =3D iio_gts_find_gain_time_sel_for_scale(&data->gts, val, val2, + &gain_sel, &it_sel); + if (ret) + return ret; + + ret =3D regmap_field_write(data->rf.it, it_sel); + if (ret) + return ret; + + ret =3D regmap_field_write(data->rf.pd_div4, gain_sel >> 2); + if (ret) + return ret; + + return regmap_field_write(data->rf.gain, gain_sel & 0x03); +} + +static int veml6031x00_get_scale(struct veml6031x00_data *data, int *val, + int *val2) +{ + int gain, it, gain_reg, pd_div4, it_reg, ret, sel; + + ret =3D regmap_field_read(data->rf.gain, &gain_reg); + if (ret) + return ret; + + ret =3D regmap_field_read(data->rf.pd_div4, &pd_div4); + if (ret) + return ret; + + sel =3D (pd_div4 << 2) | gain_reg; + gain =3D iio_gts_find_gain_by_sel(&data->gts, sel); + if (gain < 0) + return gain; + + ret =3D regmap_field_read(data->rf.it, &it_reg); + if (ret) + return ret; + + it =3D iio_gts_find_int_time_by_sel(&data->gts, it_reg); + if (it < 0) + return it; + + ret =3D iio_gts_get_scale(&data->gts, gain, it, val, val2); + if (ret) + return ret; + + return IIO_VAL_INT_PLUS_NANO; +} + +static int veml6031x00_single_read(struct iio_dev *iio, enum iio_chan_type= type, + int *val) +{ + struct veml6031x00_data *data =3D iio_priv(iio); + int addr, it_usec, ret; + __le16 reg; + + switch (type) { + case IIO_LIGHT: + addr =3D VEML6031X00_REG_ALS_L; + break; + case IIO_INTENSITY: + addr =3D VEML6031X00_REG_IR_L; + break; + default: + return -EINVAL; + } + + IIO_DEV_ACQUIRE_DIRECT_MODE(iio, claim); + if (IIO_DEV_ACQUIRE_FAILED(claim)) + return -EBUSY; + + PM_RUNTIME_ACQUIRE_AUTOSUSPEND(data->dev, pm); + ret =3D PM_RUNTIME_ACQUIRE_ERR(&pm); + if (ret) + return ret; + + ret =3D veml6031x00_get_it(data, &it_usec); + if (ret < 0) + return ret; + + /* integration time + 10 % to ensure completion */ + fsleep(it_usec + (it_usec / 10)); + + ret =3D regmap_bulk_read(data->regmap, addr, ®, sizeof(reg)); + if (ret) + return ret; + + *val =3D le16_to_cpu(reg); + return IIO_VAL_INT; +} + +static int veml6031x00_read_raw(struct iio_dev *iio, + struct iio_chan_spec const *chan, int *val, + int *val2, long mask) +{ + struct veml6031x00_data *data =3D iio_priv(iio); + + switch (mask) { + case IIO_CHAN_INFO_RAW: + return veml6031x00_single_read(iio, chan->type, val); + case IIO_CHAN_INFO_INT_TIME: + *val =3D 0; + return veml6031x00_get_it(data, val2); + case IIO_CHAN_INFO_SCALE: + return veml6031x00_get_scale(data, val, val2); + default: + return -EINVAL; + } +} + +static int veml6031x00_read_avail(struct iio_dev *iio, + struct iio_chan_spec const *chan, + const int **vals, int *type, int *length, + long mask) +{ + struct veml6031x00_data *data =3D iio_priv(iio); + + switch (mask) { + case IIO_CHAN_INFO_INT_TIME: + return iio_gts_avail_times(&data->gts, vals, type, length); + case IIO_CHAN_INFO_SCALE: + return iio_gts_all_avail_scales(&data->gts, vals, type, length); + default: + return -EINVAL; + } +} + +static int veml6031x00_write_raw(struct iio_dev *iio, + struct iio_chan_spec const *chan, + int val, int val2, long mask) +{ + IIO_DEV_ACQUIRE_DIRECT_MODE(iio, claim); + if (IIO_DEV_ACQUIRE_FAILED(claim)) + return -EBUSY; + + switch (mask) { + case IIO_CHAN_INFO_INT_TIME: + return veml6031x00_set_it(iio, val, val2); + case IIO_CHAN_INFO_SCALE: + return veml6031x00_set_scale(iio, val, val2); + default: + return -EINVAL; + } +} + +static int veml6031x00_write_raw_get_fmt(struct iio_dev *indio_dev, + struct iio_chan_spec const *chan, + long mask) +{ + switch (mask) { + case IIO_CHAN_INFO_SCALE: + return IIO_VAL_INT_PLUS_NANO; + case IIO_CHAN_INFO_INT_TIME: + return IIO_VAL_INT_PLUS_MICRO; + default: + return -EINVAL; + } +} + +static const struct iio_info veml6031x00_info =3D { + .read_raw =3D veml6031x00_read_raw, + .read_avail =3D veml6031x00_read_avail, + .write_raw =3D veml6031x00_write_raw, + .write_raw_get_fmt =3D veml6031x00_write_raw_get_fmt, +}; + +static int veml6031x00_validate_part_id(struct veml6031x00_data *data) +{ + int part_id, ret; + __le16 reg; + + ret =3D regmap_bulk_read(data->regmap, VEML6031X00_REG_ID_L, ®, + sizeof(reg)); + if (ret) + return dev_err_probe(data->dev, ret, "Failed to read ID\n"); + + part_id =3D le16_to_cpu(reg); + if (part_id !=3D data->chip->part_id) + dev_warn(data->dev, "Unknown ID %04x\n", part_id); + + return 0; +} + +static int veml6031x00_hw_init(struct iio_dev *iio) +{ + struct veml6031x00_data *data =3D iio_priv(iio); + struct device *dev =3D data->dev; + int ret; + + /* Max resolution =3D 6.9632 lx/cnt for gain =3D 0.125 and IT =3D 3.125ms= */ + ret =3D devm_iio_init_iio_gts(dev, 6, 963200000, + veml6031x00_gain_sel, + ARRAY_SIZE(veml6031x00_gain_sel), + veml6031x00_it_sel, + ARRAY_SIZE(veml6031x00_it_sel), + &data->gts); + if (ret) + return dev_err_probe(dev, ret, "failed to init iio gts\n"); + + return 0; +} + +static int veml6031x00_probe(struct i2c_client *i2c) +{ + struct device *dev =3D &i2c->dev; + struct veml6031x00_data *data; + struct iio_dev *iio; + struct regmap *regmap; + int ret; + + regmap =3D devm_regmap_init_i2c(i2c, &veml6031x00_regmap_config); + if (IS_ERR(regmap)) + return dev_err_probe(dev, PTR_ERR(regmap), + "Failed to set regmap\n"); + + iio =3D devm_iio_device_alloc(dev, sizeof(*data)); + if (!iio) + return -ENOMEM; + + data =3D iio_priv(iio); + i2c_set_clientdata(i2c, iio); + data->dev =3D dev; + data->regmap =3D regmap; + + ret =3D veml6031x00_regfield_init(data); + if (ret) + return dev_err_probe(dev, ret, "Failed to init regfield\n"); + + ret =3D devm_regulator_get_enable(dev, "vdd"); + if (ret) + return dev_err_probe(dev, ret, "Failed to enable regulator\n"); + + data->chip =3D i2c_get_match_data(i2c); + if (!data->chip) + return dev_err_probe(dev, -EINVAL, "Failed to get chip data\n"); + + ret =3D devm_add_action_or_reset(dev, veml6031x00_als_shutdown_action, da= ta); + if (ret) + return dev_err_probe(dev, ret, "Failed to add shutdown action\n"); + + /* The device starts in power down mode by default */ + ret =3D veml6031x00_als_power_on(data); + if (ret) + return dev_err_probe(dev, ret, "Failed to power on the device\n"); + + pm_runtime_set_autosuspend_delay(dev, 2000); + pm_runtime_use_autosuspend(dev); + ret =3D devm_pm_runtime_set_active_enabled(dev); + if (ret) + return dev_err_probe(dev, ret, "Failed to enable runtime PM\n"); + + ret =3D devm_pm_runtime_get_noresume(dev); + if (ret) + return dev_err_probe(dev, ret, "Failed to get runtime PM\n"); + + ret =3D veml6031x00_validate_part_id(data); + if (ret) + return ret; + + iio->name =3D data->chip->name; + iio->channels =3D veml6031x00_channels; + iio->num_channels =3D ARRAY_SIZE(veml6031x00_channels); + iio->modes =3D INDIO_DIRECT_MODE; + iio->info =3D &veml6031x00_info; + + ret =3D veml6031x00_hw_init(iio); + if (ret) + return ret; + + pm_runtime_put_autosuspend(dev); + + ret =3D devm_iio_device_register(dev, iio); + if (ret) + return dev_err_probe(dev, ret, "Failed to register iio device\n"); + + return 0; +} + +static int veml6031x00_runtime_suspend(struct device *dev) +{ + struct veml6031x00_data *data =3D iio_priv(dev_get_drvdata(dev)); + + return veml6031x00_als_shutdown(data); +} + +static int veml6031x00_runtime_resume(struct device *dev) +{ + struct veml6031x00_data *data =3D iio_priv(dev_get_drvdata(dev)); + + return veml6031x00_als_power_on(data); +} + +static DEFINE_RUNTIME_DEV_PM_OPS(veml6031x00_pm_ops, veml6031x00_runtime_s= uspend, + veml6031x00_runtime_resume, NULL); + +static const struct veml6031x00_chip veml6031x00_chip =3D { + .name =3D "veml6031x00", + .part_id =3D 0x0001, +}; + +static const struct veml6031x00_chip veml6031x01_chip =3D { + .name =3D "veml6031x01", + .part_id =3D 0x0001, +}; + +static const struct veml6031x00_chip veml60311x00_chip =3D { + .name =3D "veml60311x00", + .part_id =3D 0x1001, +}; + +static const struct veml6031x00_chip veml60311x01_chip =3D { + .name =3D "veml60311x01", + .part_id =3D 0x1001, +}; + +static const struct of_device_id veml6031x00_of_match[] =3D { + { + .compatible =3D "vishay,veml6031x00", + .data =3D &veml6031x00_chip, + }, + { + .compatible =3D "vishay,veml6031x01", + .data =3D &veml6031x01_chip, + }, + { + .compatible =3D "vishay,veml60311x00", + .data =3D &veml60311x00_chip, + }, + { + .compatible =3D "vishay,veml60311x01", + .data =3D &veml60311x01_chip, + }, + { } +}; +MODULE_DEVICE_TABLE(of, veml6031x00_of_match); + +static const struct i2c_device_id veml6031x00_id[] =3D { + { .name =3D "veml6031x00", .driver_data =3D (kernel_ulong_t)&veml6031x00_= chip }, + { .name =3D "veml6031x01", .driver_data =3D (kernel_ulong_t)&veml6031x01_= chip }, + { .name =3D "veml60311x00", .driver_data =3D (kernel_ulong_t)&veml60311x0= 0_chip }, + { .name =3D "veml60311x01", .driver_data =3D (kernel_ulong_t)&veml60311x0= 1_chip }, + { } +}; +MODULE_DEVICE_TABLE(i2c, veml6031x00_id); + +static struct i2c_driver veml6031x00_driver =3D { + .driver =3D { + .name =3D "veml6031x00", + .of_match_table =3D veml6031x00_of_match, + .pm =3D pm_ptr(&veml6031x00_pm_ops), + }, + .probe =3D veml6031x00_probe, + .id_table =3D veml6031x00_id, +}; +module_i2c_driver(veml6031x00_driver); + +MODULE_AUTHOR("Javier Carrasco "); +MODULE_DESCRIPTION("VEML6031X00 Ambient Light Sensor"); +MODULE_LICENSE("GPL"); +MODULE_IMPORT_NS("IIO_GTS_HELPER"); --=20 2.43.0 From nobody Tue Jun 9 00:54:26 2026 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3171737F759 for ; Sun, 24 May 2026 21:56:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779659794; cv=none; b=VkYNHn5mSwnfDlaK2EwwMtTDx0xlFUkjGdy5E4ukoaxTbN4m+sdJZP8vRsS8l10laGI6FJKSNVVsVb7/xn3I54IeVynB2dRvtARB5h40i4+Ht/G5Ic9xk0TCbOyVnOyTWYNOGZuXF60hZWCB5p3ceP2Ax0JPxJiFWtR/I9zMDh4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779659794; c=relaxed/simple; bh=EldXhoOy/ocJoEbIRKaCNHRHFeAW9if50k40sNRnv8s=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Ra6Kn9Zfjz+wOEwHiXDV+razS1jMbIa8ebQ+N8FA99gHubsMfmnyqqfuJrKNFYhjyq8z0wHZchwyWQFWS5u/eIp5/k9caN4kiqrTF4hPP4Ljw7tGQpVhmGPKehC9CeeiR4F9xNFkDy939L+vdQOjpt1+5TpsSraw8mZsKN1v21w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=acaBE8Ma; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="acaBE8Ma" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-49050ff7cbdso13479905e9.2 for ; Sun, 24 May 2026 14:56:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779659790; x=1780264590; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9w7wtW0oXd/rh6Ow5Q7vpAkedbI875pqYp77tyfe1GY=; b=acaBE8MaLlGJtE63qGUcUnQQ3JRV9eoO7lBJGPTyRrekIV5LiIEAkr2f5F/0f9a/2o 8cKkALbVIUxS2K91AD7mlgcUABNlS1wiApwujk+6pSi3ViV+M9+MFeZZnHw2iEt8N5gY wuV7Pwj9TmJPnlQWfazN2A2Gx5YMc2LYc8QOLManLUSzUdKMZWJawkVGrZx2PhPXkHK4 +i3H0Y7O2ANDLyafiymBZT8s2asio0b5EQ+I4Dmo0vCBG3/Ex+thBsNzkC1ynEuji3G/ 26x6OYAO7956Z6rNrKu47dcl7GTc0gGolMLx/Kf/NcBiN5sUEJxYxacwgwL3Ys0io/9j PCpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779659790; x=1780264590; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=9w7wtW0oXd/rh6Ow5Q7vpAkedbI875pqYp77tyfe1GY=; b=hquFeZ47P7twCAfVSFn5UpJO9EWbrAnKegsxWJJoQP9IwsLeCMTa/ifJxR/pn3BKiC 1obPxtRfX2YghFlPxhI6gpQ9zSJXY8k2sZ99MiH3h6m4sOcw5cNNMb6kZ1kxfasVnDRx 0UcyEZrHbvPuiQArOsx0MrOHJSygExyOv8CmlL77bzxEjCGSN9VOtGujvjWGtyAwviCo ZjjaSWyLh+qTT1aX7Wvt+D4A46A4KKzYUdGqb3E/NV76jPU8N5O8NBgrIEHChfedq7k1 iJHIX0iDmDUaw53LpY2mTwGjLXA5qaK/FIdg0RuWzB6CvpMix688x+S35zZl/HHSlTf8 lWLg== X-Forwarded-Encrypted: i=1; AFNElJ8ir8skINZYO4Sk70Rlnu/qo1V13yGZg4ZsiIKNtGlV9NazbPyPot1rJcmzSSxNH48iIIb2gP5CLoTate4=@vger.kernel.org X-Gm-Message-State: AOJu0Yzz2W9v9btfSaKUTufZqwUo4fQZUF1NHM8Xrvd4MTptRKlFKgaf Dtg3J/W34IA9AzcSQRK7o+KD7eJsHdWnuOwmnv2Hx5CUMOM3BUPHIrnh X-Gm-Gg: Acq92OEjnP0BKMpywr9CKl2OfXNQHsAreqV8Uuxr+BlRzQy46Gr/2+yXIsJUUOwn8ZL RHfLBciGzzewGMHQEVk8M28DsAmMCqClyhF5ymNvsNAsc+A26VBfhOEzj0ernNLxHWth0seqkLK zbOW9aGGHBKp9HFGJGVGoaAoF+yO6bZqbd9Oi3lgOUL/CaSKBwhD4cYEOpmvBXL4lU0A0LqnqjA 4qpF/sXSQatfK+QNeO5hEaeISHNnjoB4CJIrZS+2y7XXQS5kFKjF6da+W30b/nFPwT0GoV2lQqu u76Uj7NFmDhfxTwWZ0afhUacoGE7UNyjJNnCQ91GeBBAS/6ne1BrEEbIXVSDrSQOilsJCqn6njC 5Qh3WI65wQdMaOJuayIOJIGXEsI5Du5kvqnidb22H1OKVwSk1LlXQdHf1GxnL1r22BpNOdbQ241 6ubU6sZNFckiyYWUf4cKTaKmoRrWeRpKDCRulqowI4PZj02UrefOGNZu3O20CeAx0BqDoGoCmow fLMVCBI X-Received: by 2002:a05:600c:3488:b0:490:6869:7d8b with SMTP id 5b1f17b1804b1-49068697e08mr1475135e9.15.1779659790489; Sun, 24 May 2026 14:56:30 -0700 (PDT) Received: from [127.0.1.1] (213-225-2-150.nat.highway.a1.net. [213.225.2.150]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4904527f7f7sm300779285e9.7.2026.05.24.14.56.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 May 2026 14:56:30 -0700 (PDT) From: Javier Carrasco Date: Sun, 24 May 2026 23:53:57 +0200 Subject: [PATCH v3 3/4] iio: light: veml6031x00: add support for triggered buffers Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260524-veml6031x00-v3-3-29165609b2b5@gmail.com> References: <20260524-veml6031x00-v3-0-29165609b2b5@gmail.com> In-Reply-To: <20260524-veml6031x00-v3-0-29165609b2b5@gmail.com> To: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Rishi Gupta , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Matti Vaittinen Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Javier Carrasco , Jonathan Cameron X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1779659783; l=5184; i=javier.carrasco.cruz@gmail.com; s=20260111; h=from:subject:message-id; bh=EldXhoOy/ocJoEbIRKaCNHRHFeAW9if50k40sNRnv8s=; b=b8yWldFNyDBKMxjKkKWPD50pzA8fRKIzVQIrFBCvvvSbhKbjQT65892CBfW/sxkFzZp075VQh EEuRoNnSAJ3Ar+m7frF8VMPPZLmceu8PesB0oSlH1yN4NKERsKjwLwJ X-Developer-Key: i=javier.carrasco.cruz@gmail.com; a=ed25519; pk=Lge8w8xidNSf/INy7JAIbAW+Hezkp3nsBh2OjKL7lLU= Add triggered buffer functionality for the two channels the device provides (ALS and IR). Signed-off-by: Javier Carrasco --- drivers/iio/light/Kconfig | 2 + drivers/iio/light/veml6031x00.c | 106 ++++++++++++++++++++++++++++++++++++= ++++ 2 files changed, 108 insertions(+) diff --git a/drivers/iio/light/Kconfig b/drivers/iio/light/Kconfig index 99a6ed80c7db..ff71de8454bd 100644 --- a/drivers/iio/light/Kconfig +++ b/drivers/iio/light/Kconfig @@ -717,6 +717,8 @@ config VEML6031X00 tristate "VEML6031X00 ambient light sensor series" select REGMAP_I2C select IIO_GTS_HELPER + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER depends on I2C help Say Y here if you want to build a driver for the Vishay VEML6031X00 diff --git a/drivers/iio/light/veml6031x00.c b/drivers/iio/light/veml6031x0= 0.c index 50979d239230..9968d4414dc9 100644 --- a/drivers/iio/light/veml6031x00.c +++ b/drivers/iio/light/veml6031x00.c @@ -14,6 +14,8 @@ #include #include #include +#include +#include =20 /* Device registers */ #define VEML6031X00_REG_CONF0 0x00 @@ -29,6 +31,12 @@ #define VEML6031X00_CONF0_SD BIT(0) #define VEML6031X00_CONF1_IR_SD BIT(7) =20 +enum veml6031x00_scan { + VEML6031X00_SCAN_ALS, + VEML6031X00_SCAN_IR, + VEML6031X00_SCAN_TIMESTAMP, +}; + struct veml6031x00_rf { struct regmap_field *gain; struct regmap_field *it; @@ -128,6 +136,13 @@ static const struct iio_chan_spec veml6031x00_channels= [] =3D { .info_mask_shared_by_all =3D BIT(IIO_CHAN_INFO_INT_TIME), .info_mask_shared_by_all_available =3D BIT(IIO_CHAN_INFO_INT_TIME), .info_mask_separate_available =3D BIT(IIO_CHAN_INFO_SCALE), + .scan_index =3D VEML6031X00_SCAN_ALS, + .scan_type =3D { + .sign =3D 'u', + .realbits =3D 16, + .storagebits =3D 16, + .endianness =3D IIO_LE, + }, }, { .type =3D IIO_INTENSITY, @@ -138,7 +153,15 @@ static const struct iio_chan_spec veml6031x00_channels= [] =3D { BIT(IIO_CHAN_INFO_SCALE), .info_mask_shared_by_all =3D BIT(IIO_CHAN_INFO_INT_TIME), .info_mask_shared_by_all_available =3D BIT(IIO_CHAN_INFO_INT_TIME), + .scan_index =3D VEML6031X00_SCAN_IR, + .scan_type =3D { + .sign =3D 'u', + .realbits =3D 16, + .storagebits =3D 16, + .endianness =3D IIO_LE, + }, }, + IIO_CHAN_SOFT_TIMESTAMP(VEML6031X00_SCAN_TIMESTAMP), }; =20 static const struct regmap_range veml6031x00_readable_ranges[] =3D { @@ -461,6 +484,82 @@ static const struct iio_info veml6031x00_info =3D { .write_raw_get_fmt =3D veml6031x00_write_raw_get_fmt, }; =20 +static int veml6031x00_buffer_preenable(struct iio_dev *iio) +{ + struct veml6031x00_data *data =3D iio_priv(iio); + int ret, it_usec; + + ret =3D pm_runtime_resume_and_get(data->dev); + if (ret) + return ret; + + ret =3D veml6031x00_get_it(data, &it_usec); + if (ret < 0) { + pm_runtime_put_autosuspend(data->dev); + return ret; + } + + /* + * Wait one integration period + 10% margin so the first triggered + * read does not race with the sensor completing its first conversion + * after power-on. + */ + fsleep(it_usec + (it_usec / 10)); + + return 0; +} + +static int veml6031x00_buffer_postdisable(struct iio_dev *iio) +{ + struct veml6031x00_data *data =3D iio_priv(iio); + + pm_runtime_put_autosuspend(data->dev); + + return 0; +} + +static const struct iio_buffer_setup_ops veml6031x00_buffer_setup_ops =3D { + .preenable =3D veml6031x00_buffer_preenable, + .postdisable =3D veml6031x00_buffer_postdisable, +}; + +static irqreturn_t veml6031x00_trig_handler(int irq, void *p) +{ + struct iio_poll_func *pf =3D p; + struct iio_dev *iio =3D pf->indio_dev; + struct veml6031x00_data *data =3D iio_priv(iio); + int ch, ret, i =3D 0; + struct { + __le16 chans[2]; + aligned_s64 timestamp; + } scan =3D { }; + + if (*iio->active_scan_mask =3D=3D (BIT(VEML6031X00_SCAN_ALS) | + BIT(VEML6031X00_SCAN_IR))) { + ret =3D regmap_bulk_read(data->regmap, + VEML6031X00_REG_ALS_L, + &scan.chans, sizeof(scan.chans)); + if (ret) + goto done; + } else { + iio_for_each_active_channel(iio, ch) { + ret =3D regmap_bulk_read(data->regmap, + iio->channels[ch].address, + &scan.chans[i++], + sizeof(*scan.chans)); + if (ret) + goto done; + } + } + + iio_push_to_buffers_with_ts(iio, &scan, sizeof(scan), pf->timestamp); + +done: + iio_trigger_notify_done(iio->trig); + + return IRQ_HANDLED; +} + static int veml6031x00_validate_part_id(struct veml6031x00_data *data) { int part_id, ret; @@ -564,6 +663,13 @@ static int veml6031x00_probe(struct i2c_client *i2c) if (ret) return ret; =20 + ret =3D devm_iio_triggered_buffer_setup(dev, iio, NULL, + veml6031x00_trig_handler, + &veml6031x00_buffer_setup_ops); + if (ret) + return dev_err_probe(dev, ret, + "Failed to register triggered buffer\n"); + pm_runtime_put_autosuspend(dev); =20 ret =3D devm_iio_device_register(dev, iio); --=20 2.43.0 From nobody Tue Jun 9 00:54:26 2026 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E847B3806DB for ; Sun, 24 May 2026 21:56:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779659796; cv=none; b=o6Ig28rvlteJcHE5nlvxu76pDorncx81FGqDjPurpKWRfEN3Id7XlNgJbD3tvXGYfaPH1ca6KD+S6R3eAhF7opQSWudJlbBk/I+t6xBNXma1tpbkVigVtcjZSXqOKeHZyruec/t1Wvx7jeEv/nsd9CLEQ28vSBFjQpj4PO8MtUM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779659796; c=relaxed/simple; bh=Zw8f5Wm7witufhXEpKjWVeHqRA7CE8TpbWK1NknESs4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fnYnwg5xCD5QKuX2EvMrzyBtOl9xsI3MZzyQ8qL1O948u2i2kdZN0KFMPAQmX32+zvZxHPTLiArYDfDzh1h8DwzsV6RZ21L865dJbHje24aT2zXxeXD11CDFFClghot8zS1W61C6NhUV5rlSODrTHLiOcgIJpjF9xJIVy4jk08c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Rvns/tAZ; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Rvns/tAZ" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-490426d72f7so22766725e9.3 for ; Sun, 24 May 2026 14:56:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779659792; x=1780264592; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=BPEvGZVdB78nhQxjKZAaARniz89YsiEBNtfAphISK20=; b=Rvns/tAZ4wnrs9hYmm0TpFMfqm2HXYKMcbmDf73tw1MfcFRxtN8JkURUGtubyJDkb0 EznHF2EKkGZnLcjH2mUkS7zKBekHjk8xPlKhglt88o8qL/7Hrrs/NHYs4y9RzG+W7e9I NzR4wNTV9XjT1unC//qLquM8qM4nb37RG342BdgbzoQq2lazczaFRDxL22plbRwGEV6f R9lRGg0oIlfZ9RauwJ4xKluybkIy//0ZuQKMCO01k13NrSKq2LaEGfkd99TZ56UVM4Gm vWdRPmlTO90SCwsFPlYWSSuyiNUjHjbhlukhJOr+0NPEfcEoEsCZk0BE7UNfm3k68I39 kvCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779659792; x=1780264592; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=BPEvGZVdB78nhQxjKZAaARniz89YsiEBNtfAphISK20=; b=Za+OHxTUsSnOz2lVMfj3tee1yZpgAcGFFgAjcSteDc+OBZySFTsmagSyGeI1TM9Tw9 Ee1K9qWppKonnJbcV6oF4plXvxJqRE2dnx/BHh7fcvhBwRao6DfC9BanlxO/PjqWnhmn IM3z2AdUw3oNghyrJWt5F6RpiiKzLTqS7Roh5R7lZMdwjSFLYTphNgrvAwYb3sdxCiaD I8YhwA2uzIOPPF+d6/LFq0U7nO6fIl7+PBPjIrWfpO9MhK5o5Pll4ml4iNi8/Zk5o36p 2KMboP8J1LST8H9AuhIK6xBH15q40vRIUpmpf0xVNV4AJA34pQFEkPUuv+TFFyhbjL7j ctJw== X-Forwarded-Encrypted: i=1; AFNElJ+wyc58lfYDD1oYE9iTrFlf7yEOc3LF90RVoTDZhN1LMTfCVtaP2E6F77a4O/pK0Mcw5frCccR62M/Xpkk=@vger.kernel.org X-Gm-Message-State: AOJu0YwE2XbHSNoqIubn3rT6O66NoPTFx7Oqhha1OoK8LvAa10S0y3Ns 3OMPdQtcerD+CnrOiNOX38fhvnV/J3xR0JO7Qo656WiUV/nJMEyiBJFR X-Gm-Gg: Acq92OEzmFE5A1iq4R6aSz9I78pQZ6H5T18z0CyZIm0W5WRoCMXfCLwi8hjaKEa/4VT CrVmRTuR9DW2ksIyFelTw+sri1Fgvd76uOb7WmWSJGYJFi/MjtprZ+U3WMV9u5hb/OwE9kAqTSF KF3XHYGs82WuwsDEB+qQpHFtgG3/LSZq596+BwcOVex3+WdiH/MFOd23uTlDsqc59QdB7wx8cig VKaTU0zIHx/KU04wzsYlIFWBpqzH0Ifu2RmO8XANN3muo2VOXLf6HZLu42NhMecFS4B7pfNPxEZ xhgD2Il3lFyH3koBaodmn0pqlqgY6QRcR/CjiULjh0phjj38OTd5gJqG18zIdsonTVYs5sQrbQE +Lgy/GluRiez4msJVA+Aa3C0IPkFYbBa9QScARzkZ4FzE/CH4WvdybQNipAQlLHbsU3NlxeMD22 Du7OWyl8h8QTC6IU6LLuE482ZGxGvvhpJL4OFDJ3D3oa0OHdee5Vsk1RGuSE5q883zqYi8UA== X-Received: by 2002:a7b:cde1:0:b0:489:1f04:96c3 with SMTP id 5b1f17b1804b1-4904248b137mr121322745e9.2.1779659792219; Sun, 24 May 2026 14:56:32 -0700 (PDT) Received: from [127.0.1.1] (213-225-2-150.nat.highway.a1.net. [213.225.2.150]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4904527f7f7sm300779285e9.7.2026.05.24.14.56.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 May 2026 14:56:31 -0700 (PDT) From: Javier Carrasco Date: Sun, 24 May 2026 23:53:58 +0200 Subject: [PATCH v3 4/4] iio: light: veml6031x00: add support for events and trigger Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260524-veml6031x00-v3-4-29165609b2b5@gmail.com> References: <20260524-veml6031x00-v3-0-29165609b2b5@gmail.com> In-Reply-To: <20260524-veml6031x00-v3-0-29165609b2b5@gmail.com> To: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Rishi Gupta , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko , Matti Vaittinen Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Javier Carrasco , Jonathan Cameron X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1779659783; l=19949; i=javier.carrasco.cruz@gmail.com; s=20260111; h=from:subject:message-id; bh=Zw8f5Wm7witufhXEpKjWVeHqRA7CE8TpbWK1NknESs4=; b=P9pBJS5i/fggXlVwdN0WLVwOmTZJfUKW+2uVmfE6fM+BjS2IaM0hz+/BDIsAjrsSKGu40pvtp 2nTvCHFXxL9D+KUD/W83wqFUK8GhulM9gssR8z1dRWRHXeeBy1G+ANx X-Developer-Key: i=javier.carrasco.cruz@gmail.com; a=ed25519; pk=Lge8w8xidNSf/INy7JAIbAW+Hezkp3nsBh2OjKL7lLU= The device provides a shared interrupt line for to notify events and data ready, which can be used as a trigger. The interrupt line is not a requirement for the device to work. Implement variants for the cases whether the interrupt line is provided or not. Signed-off-by: Javier Carrasco --- drivers/iio/light/veml6031x00.c | 442 ++++++++++++++++++++++++++++++++++++= +++- 1 file changed, 438 insertions(+), 4 deletions(-) diff --git a/drivers/iio/light/veml6031x00.c b/drivers/iio/light/veml6031x0= 0.c index 9968d4414dc9..c57aaa29abf3 100644 --- a/drivers/iio/light/veml6031x00.c +++ b/drivers/iio/light/veml6031x00.c @@ -7,12 +7,16 @@ =20 #include #include +#include #include +#include #include #include #include #include +#include #include +#include #include #include #include @@ -20,16 +24,29 @@ /* Device registers */ #define VEML6031X00_REG_CONF0 0x00 #define VEML6031X00_REG_CONF1 0x01 +#define VEML6031X00_REG_WH_L 0x04 +#define VEML6031X00_REG_WH_H 0x05 +#define VEML6031X00_REG_WL_L 0x06 +#define VEML6031X00_REG_WL_H 0x07 #define VEML6031X00_REG_ALS_L 0x10 #define VEML6031X00_REG_ALS_H 0x11 #define VEML6031X00_REG_IR_L 0x12 #define VEML6031X00_REG_IR_H 0x13 #define VEML6031X00_REG_ID_L 0x14 #define VEML6031X00_REG_ID_H 0x15 +#define VEML6031X00_REG_INT 0x17 =20 /* Bit masks for specific functionality */ #define VEML6031X00_CONF0_SD BIT(0) +#define VEML6031X00_CONF0_AF_TRIG BIT(2) +#define VEML6031X00_CONF0_AF BIT(3) #define VEML6031X00_CONF1_IR_SD BIT(7) +#define VEML6031X00_INT_TH_H BIT(1) +#define VEML6031X00_INT_TH_L BIT(2) +#define VEML6031X00_INT_DRDY BIT(3) +#define VEML6031X00_INT_MASK (VEML6031X00_INT_TH_L | \ + VEML6031X00_INT_TH_H | \ + VEML6031X00_INT_DRDY) =20 enum veml6031x00_scan { VEML6031X00_SCAN_ALS, @@ -39,8 +56,10 @@ enum veml6031x00_scan { =20 struct veml6031x00_rf { struct regmap_field *gain; + struct regmap_field *int_en; struct regmap_field *it; struct regmap_field *pd_div4; + struct regmap_field *pers; }; =20 struct veml6031x00_chip { @@ -52,8 +71,14 @@ struct veml6031x00_data { struct device *dev; struct iio_gts gts; struct regmap *regmap; + struct iio_trigger *trig; struct veml6031x00_rf rf; const struct veml6031x00_chip *chip; + /* serialize access to irq enable/disable by events and trigger */ + struct mutex lock; + int int_users; + bool ev_en; + bool trig_en; }; =20 static const struct iio_itime_sel_mul veml6031x00_it_sel[] =3D { @@ -88,6 +113,17 @@ static const struct iio_gain_sel_pair veml6031x00_gain_= sel[] =3D { GAIN_SCALE_GAIN(16, VEML6031X00_SEL_MILLI_GAIN_X2000), }; =20 +static IIO_CONST_ATTR(in_illuminance_thresh_either_period_available, "1 2 = 4 8"); + +static struct attribute *veml6031x00_event_attributes[] =3D { + &iio_const_attr_in_illuminance_thresh_either_period_available.dev_attr.at= tr, + NULL +}; + +static const struct attribute_group veml6031x00_event_attr_group =3D { + .attrs =3D veml6031x00_event_attributes, +}; + /* * Two shutdown bits (SD and ALS_IR_SD) must be cleared to power on * the device. @@ -127,6 +163,23 @@ static void veml6031x00_als_shutdown_action(void *data) veml6031x00_als_shutdown(data); } =20 +static const struct iio_event_spec veml6031x00_event_spec[] =3D { + { + .type =3D IIO_EV_TYPE_THRESH, + .dir =3D IIO_EV_DIR_RISING, + .mask_separate =3D BIT(IIO_EV_INFO_VALUE), + }, { + .type =3D IIO_EV_TYPE_THRESH, + .dir =3D IIO_EV_DIR_FALLING, + .mask_separate =3D BIT(IIO_EV_INFO_VALUE), + }, { + .type =3D IIO_EV_TYPE_THRESH, + .dir =3D IIO_EV_DIR_EITHER, + .mask_separate =3D BIT(IIO_EV_INFO_PERIOD) | + BIT(IIO_EV_INFO_ENABLE), + }, +}; + static const struct iio_chan_spec veml6031x00_channels[] =3D { { .type =3D IIO_LIGHT, @@ -136,6 +189,8 @@ static const struct iio_chan_spec veml6031x00_channels[= ] =3D { .info_mask_shared_by_all =3D BIT(IIO_CHAN_INFO_INT_TIME), .info_mask_shared_by_all_available =3D BIT(IIO_CHAN_INFO_INT_TIME), .info_mask_separate_available =3D BIT(IIO_CHAN_INFO_SCALE), + .event_spec =3D veml6031x00_event_spec, + .num_event_specs =3D ARRAY_SIZE(veml6031x00_event_spec), .scan_index =3D VEML6031X00_SCAN_ALS, .scan_type =3D { .sign =3D 'u', @@ -166,7 +221,9 @@ static const struct iio_chan_spec veml6031x00_channels[= ] =3D { =20 static const struct regmap_range veml6031x00_readable_ranges[] =3D { regmap_reg_range(VEML6031X00_REG_CONF0, VEML6031X00_REG_CONF1), + regmap_reg_range(VEML6031X00_REG_WH_L, VEML6031X00_REG_WL_H), regmap_reg_range(VEML6031X00_REG_ALS_L, VEML6031X00_REG_ID_H), + regmap_reg_range(VEML6031X00_REG_INT, VEML6031X00_REG_INT), }; =20 static const struct regmap_access_table veml6031x00_readable_table =3D { @@ -175,7 +232,7 @@ static const struct regmap_access_table veml6031x00_rea= dable_table =3D { }; =20 static const struct regmap_range veml6031x00_writable_ranges[] =3D { - regmap_reg_range(VEML6031X00_REG_CONF0, VEML6031X00_REG_CONF1), + regmap_reg_range(VEML6031X00_REG_CONF0, VEML6031X00_REG_WL_H), }; =20 static const struct regmap_access_table veml6031x00_writable_table =3D { @@ -185,6 +242,7 @@ static const struct regmap_access_table veml6031x00_wri= table_table =3D { =20 static const struct regmap_range veml6031x00_volatile_ranges[] =3D { regmap_reg_range(VEML6031X00_REG_ALS_L, VEML6031X00_REG_IR_H), + regmap_reg_range(VEML6031X00_REG_INT, VEML6031X00_REG_INT), }; =20 static const struct regmap_access_table veml6031x00_volatile_table =3D { @@ -192,6 +250,15 @@ static const struct regmap_access_table veml6031x00_vo= latile_table =3D { .n_yes_ranges =3D ARRAY_SIZE(veml6031x00_volatile_ranges), }; =20 +static const struct regmap_range veml6031x00_precious_ranges[] =3D { + regmap_reg_range(VEML6031X00_REG_INT, VEML6031X00_REG_INT), +}; + +static const struct regmap_access_table veml6031x00_precious_table =3D { + .yes_ranges =3D veml6031x00_precious_ranges, + .n_yes_ranges =3D ARRAY_SIZE(veml6031x00_precious_ranges), +}; + static const struct regmap_config veml6031x00_regmap_config =3D { .name =3D "veml6031x00_regmap", .reg_bits =3D 8, @@ -199,13 +266,20 @@ static const struct regmap_config veml6031x00_regmap_= config =3D { .rd_table =3D &veml6031x00_readable_table, .wr_table =3D &veml6031x00_writable_table, .volatile_table =3D &veml6031x00_volatile_table, - .max_register =3D VEML6031X00_REG_ID_H, + .precious_table =3D &veml6031x00_precious_table, + .max_register =3D VEML6031X00_REG_INT, .cache_type =3D REGCACHE_MAPLE, }; =20 +static const struct reg_field veml6031x00_rf_int_en =3D + REG_FIELD(VEML6031X00_REG_CONF0, 1, 1); + static const struct reg_field veml6031x00_rf_it =3D REG_FIELD(VEML6031X00_REG_CONF0, 4, 6); =20 +static const struct reg_field veml6031x00_rf_pers =3D + REG_FIELD(VEML6031X00_REG_CONF1, 1, 2); + static const struct reg_field veml6031x00_rf_gain =3D REG_FIELD(VEML6031X00_REG_CONF1, 3, 4); =20 @@ -224,6 +298,11 @@ static int veml6031x00_regfield_init(struct veml6031x0= 0_data *data) return PTR_ERR(rm_field); rf->gain =3D rm_field; =20 + rm_field =3D devm_regmap_field_alloc(dev, regmap, veml6031x00_rf_int_en); + if (IS_ERR(rm_field)) + return PTR_ERR(rm_field); + rf->int_en =3D rm_field; + rm_field =3D devm_regmap_field_alloc(dev, regmap, veml6031x00_rf_it); if (IS_ERR(rm_field)) return PTR_ERR(rm_field); @@ -234,6 +313,11 @@ static int veml6031x00_regfield_init(struct veml6031x0= 0_data *data) return PTR_ERR(rm_field); rf->pd_div4 =3D rm_field; =20 + rm_field =3D devm_regmap_field_alloc(dev, regmap, veml6031x00_rf_pers); + if (IS_ERR(rm_field)) + return PTR_ERR(rm_field); + rf->pers =3D rm_field; + return 0; } =20 @@ -313,6 +397,30 @@ static int veml6031x00_set_it(struct iio_dev *iio, int= val, int val2) return regmap_field_write(data->rf.gain, gain_sel & 0x03); } =20 +static int veml6031x00_read_period(struct iio_dev *iio, int *val) +{ + struct veml6031x00_data *data =3D iio_priv(iio); + int ret, reg; + + ret =3D regmap_field_read(data->rf.pers, ®); + if (ret) + return ret; + + *val =3D 1 << reg; + + return IIO_VAL_INT; +} + +static int veml6031x00_write_period(struct iio_dev *iio, int val) +{ + struct veml6031x00_data *data =3D iio_priv(iio); + + if (val < 0 || val > 8 || hweight8(val) !=3D 1) + return -EINVAL; + + return regmap_field_write(data->rf.pers, ffs(val) - 1); +} + static int veml6031x00_set_scale(struct iio_dev *iio, int val, int val2) { struct veml6031x00_data *data =3D iio_priv(iio); @@ -367,6 +475,51 @@ static int veml6031x00_get_scale(struct veml6031x00_da= ta *data, int *val, return IIO_VAL_INT_PLUS_NANO; } =20 +static int veml6031x00_read_th(struct iio_dev *iio, int *val, int *val2, i= nt dir) +{ + struct veml6031x00_data *data =3D iio_priv(iio); + __le16 reg; + int ret; + + if (dir =3D=3D IIO_EV_DIR_RISING) + ret =3D regmap_bulk_read(data->regmap, VEML6031X00_REG_WH_L, + ®, sizeof(reg)); + else + ret =3D regmap_bulk_read(data->regmap, VEML6031X00_REG_WL_L, + ®, sizeof(reg)); + if (ret) + return ret; + + *val =3D le16_to_cpu(reg); + + return IIO_VAL_INT; +} + +static int veml6031x00_write_th(struct iio_dev *iio, int val, int val2, in= t dir) +{ + struct veml6031x00_data *data =3D iio_priv(iio); + struct device *dev =3D data->dev; + __le16 reg =3D cpu_to_le16(val); + int ret; + + if (val < 0 || val > U16_MAX || val2) + return -EINVAL; + + if (dir =3D=3D IIO_EV_DIR_RISING) { + ret =3D regmap_bulk_write(data->regmap, VEML6031X00_REG_WH_L, + ®, sizeof(reg)); + if (ret) + dev_dbg(dev, "Failed to set high threshold %d\n", ret); + } else { + ret =3D regmap_bulk_write(data->regmap, VEML6031X00_REG_WL_L, + ®, sizeof(reg)); + if (ret) + dev_dbg(dev, "Failed to set low threshold %d\n", ret); + } + + return ret; +} + static int veml6031x00_single_read(struct iio_dev *iio, enum iio_chan_type= type, int *val) { @@ -477,13 +630,189 @@ static int veml6031x00_write_raw_get_fmt(struct iio_= dev *indio_dev, } } =20 +static int veml6031x00_set_interrupt(struct veml6031x00_data *data, bool s= tate) + __must_hold(&data->lock) +{ + int ret; + + if (state) { + data->int_users++; + if (data->int_users > 1) + return 0; + } else { + data->int_users--; + if (data->int_users > 0) + return 0; + } + + ret =3D regmap_field_write(data->rf.int_en, state); + if (ret) { + if (state) + data->int_users--; + else + data->int_users++; + } + + return ret; +} + +static int veml6031x00_read_event_val(struct iio_dev *iio, + const struct iio_chan_spec *chan, + enum iio_event_type type, + enum iio_event_direction dir, + enum iio_event_info info, + int *val, int *val2) +{ + switch (type) { + case IIO_EV_TYPE_THRESH: + if (dir =3D=3D IIO_EV_DIR_EITHER && info =3D=3D IIO_EV_INFO_PERIOD) + return veml6031x00_read_period(iio, val); + + return veml6031x00_read_th(iio, val, val2, dir); + default: + return -EINVAL; + } +} + +static int veml6031x00_write_event_val(struct iio_dev *iio, + const struct iio_chan_spec *chan, + enum iio_event_type type, + enum iio_event_direction dir, + enum iio_event_info info, + int val, int val2) +{ + switch (info) { + case IIO_EV_INFO_VALUE: + return veml6031x00_write_th(iio, val, val2, dir); + case IIO_EV_INFO_PERIOD: + return veml6031x00_write_period(iio, val); + default: + return -EINVAL; + } +} + +static int veml6031x00_read_event_config(struct iio_dev *iio, + const struct iio_chan_spec *chan, + enum iio_event_type type, + enum iio_event_direction dir) +{ + struct veml6031x00_data *data =3D iio_priv(iio); + + guard(mutex)(&data->lock); + + return data->ev_en; +} + +static int veml6031x00_write_event_config(struct iio_dev *iio, + const struct iio_chan_spec *chan, + enum iio_event_type type, + enum iio_event_direction dir, + bool state) +{ + struct veml6031x00_data *data =3D iio_priv(iio); + int ret; + + guard(mutex)(&data->lock); + + /* avoid multiple increments/decrements from one source */ + if (state =3D=3D data->ev_en) + return 0; + + if (state) { + ret =3D pm_runtime_resume_and_get(data->dev); + if (ret) + return ret; + } + + ret =3D veml6031x00_set_interrupt(data, state); + if (ret) { + if (state) + pm_runtime_put_autosuspend(data->dev); + return ret; + } + + data->ev_en =3D state; + + if (!state) + pm_runtime_put_autosuspend(data->dev); + + return 0; +} + static const struct iio_info veml6031x00_info =3D { .read_raw =3D veml6031x00_read_raw, .read_avail =3D veml6031x00_read_avail, .write_raw =3D veml6031x00_write_raw, .write_raw_get_fmt =3D veml6031x00_write_raw_get_fmt, + .read_event_value =3D veml6031x00_read_event_val, + .write_event_value =3D veml6031x00_write_event_val, + .read_event_config =3D veml6031x00_read_event_config, + .write_event_config =3D veml6031x00_write_event_config, + .event_attrs =3D &veml6031x00_event_attr_group, +}; + +static const struct iio_info veml6031x00_info_no_irq =3D { + .read_raw =3D veml6031x00_read_raw, + .read_avail =3D veml6031x00_read_avail, + .write_raw =3D veml6031x00_write_raw, + .write_raw_get_fmt =3D veml6031x00_write_raw_get_fmt, }; =20 +/* AF_TRIG is reset by hardware, but the rest of the fields are persistent= */ +static int veml6031x00_set_af_trig(struct veml6031x00_data *data, bool sta= te) +{ + regcache_drop_region(data->regmap, VEML6031X00_REG_CONF0, + VEML6031X00_REG_CONF0); + + return regmap_update_bits(data->regmap, VEML6031X00_REG_CONF0, + VEML6031X00_CONF0_AF_TRIG, + FIELD_PREP(VEML6031X00_CONF0_AF_TRIG, state)); +} + +static irqreturn_t veml6031x00_interrupt(int irq, void *private) +{ + struct iio_dev *iio =3D private; + struct veml6031x00_data *data =3D iio_priv(iio); + s64 timestamp; + int ret, reg; + + ret =3D regmap_read(data->regmap, VEML6031X00_REG_INT, ®); + if (ret) { + dev_err(data->dev, + "Failed to read interrupt register %d\n", ret); + return IRQ_NONE; + } + + if (!(reg & VEML6031X00_INT_MASK)) + return IRQ_NONE; + + guard(mutex)(&data->lock); + + if ((reg & (VEML6031X00_INT_TH_H | VEML6031X00_INT_TH_L)) && data->ev_en)= { + timestamp =3D iio_get_time_ns(iio); + + if (reg & VEML6031X00_INT_TH_H) + iio_push_event(iio, IIO_UNMOD_EVENT_CODE(IIO_LIGHT, 0, + IIO_EV_TYPE_THRESH, + IIO_EV_DIR_RISING), + timestamp); + if (reg & VEML6031X00_INT_TH_L) + iio_push_event(iio, IIO_UNMOD_EVENT_CODE(IIO_LIGHT, 0, + IIO_EV_TYPE_THRESH, + IIO_EV_DIR_FALLING), + timestamp); + } + + if ((reg & VEML6031X00_INT_DRDY) && data->trig_en) { + iio_trigger_poll_nested(data->trig); + ret =3D veml6031x00_set_af_trig(data, true); + if (ret) + dev_err(data->dev, "Failed to set trigger %d\n", ret); + } + + return IRQ_HANDLED; +} + static int veml6031x00_buffer_preenable(struct iio_dev *iio) { struct veml6031x00_data *data =3D iio_priv(iio); @@ -518,11 +847,54 @@ static int veml6031x00_buffer_postdisable(struct iio_= dev *iio) return 0; } =20 +static int veml6031x00_set_trigger_state(struct iio_trigger *trig, bool st= ate) +{ + struct iio_dev *iio =3D iio_trigger_get_drvdata(trig); + struct veml6031x00_data *data =3D iio_priv(iio); + int ret; + + guard(mutex)(&data->lock); + + if (state =3D=3D data->trig_en) + return 0; + + ret =3D veml6031x00_set_interrupt(data, state); + if (ret) + return ret; + + /* The AF bit must be set before setting AF_TRIG */ + ret =3D regmap_update_bits(data->regmap, VEML6031X00_REG_CONF0, + VEML6031X00_CONF0_AF, + FIELD_PREP(VEML6031X00_CONF0_AF, state)); + if (ret) + goto err_disable_interrupt; + + ret =3D veml6031x00_set_af_trig(data, state); + if (ret) + goto err_clear_af; + + data->trig_en =3D state; + + return 0; + +err_clear_af: + regmap_update_bits(data->regmap, VEML6031X00_REG_CONF0, + VEML6031X00_CONF0_AF, + FIELD_PREP(VEML6031X00_CONF0_AF, !state)); +err_disable_interrupt: + veml6031x00_set_interrupt(data, !state); + return ret; +} + static const struct iio_buffer_setup_ops veml6031x00_buffer_setup_ops =3D { .preenable =3D veml6031x00_buffer_preenable, .postdisable =3D veml6031x00_buffer_postdisable, }; =20 +static const struct iio_trigger_ops veml6031x00_trigger_ops =3D { + .set_trigger_state =3D veml6031x00_set_trigger_state, +}; + static irqreturn_t veml6031x00_trig_handler(int irq, void *p) { struct iio_poll_func *pf =3D p; @@ -581,7 +953,8 @@ static int veml6031x00_hw_init(struct iio_dev *iio) { struct veml6031x00_data *data =3D iio_priv(iio); struct device *dev =3D data->dev; - int ret; + int ret, val; + __le16 reg; =20 /* Max resolution =3D 6.9632 lx/cnt for gain =3D 0.125 and IT =3D 3.125ms= */ ret =3D devm_iio_init_iio_gts(dev, 6, 963200000, @@ -593,6 +966,54 @@ static int veml6031x00_hw_init(struct iio_dev *iio) if (ret) return dev_err_probe(dev, ret, "failed to init iio gts\n"); =20 + reg =3D 0; + ret =3D regmap_bulk_write(data->regmap, VEML6031X00_REG_WL_L, ®, sizeo= f(reg)); + if (ret) + return dev_err_probe(dev, ret, "Failed to set low threshold\n"); + + reg =3D cpu_to_le16(U16_MAX); + ret =3D regmap_bulk_write(data->regmap, VEML6031X00_REG_WH_L, ®, sizeo= f(reg)); + if (ret) + return dev_err_probe(dev, ret, "Failed to set high threshold\n"); + + ret =3D regmap_field_write(data->rf.int_en, 0); + if (ret) + return ret; + + ret =3D regmap_read(data->regmap, VEML6031X00_REG_INT, &val); + if (ret) + return dev_err_probe(dev, ret, "Failed to clear interrupts\n"); + + return 0; +} + +static int veml6031x00_setup_irq(struct i2c_client *i2c, struct iio_dev *i= io) +{ + struct veml6031x00_data *data =3D iio_priv(iio); + struct device *dev =3D data->dev; + int ret; + + data->trig =3D devm_iio_trigger_alloc(dev, "%s-drdy%d", iio->name, + iio_device_id(iio)); + if (!data->trig) + return -ENOMEM; + + data->trig->ops =3D &veml6031x00_trigger_ops; + iio_trigger_set_drvdata(data->trig, iio); + + ret =3D devm_iio_trigger_register(dev, data->trig); + if (ret) + return ret; + + iio->trig =3D iio_trigger_get(data->trig); + ret =3D devm_request_threaded_irq(dev, i2c->irq, NULL, + veml6031x00_interrupt, + IRQF_ONESHOT, + iio->name, iio); + if (ret) + return dev_err_probe(dev, ret, "Failed to request irq %d\n", + i2c->irq); + return 0; } =20 @@ -618,6 +1039,10 @@ static int veml6031x00_probe(struct i2c_client *i2c) data->dev =3D dev; data->regmap =3D regmap; =20 + ret =3D devm_mutex_init(dev, &data->lock); + if (ret) + return ret; + ret =3D veml6031x00_regfield_init(data); if (ret) return dev_err_probe(dev, ret, "Failed to init regfield\n"); @@ -657,12 +1082,21 @@ static int veml6031x00_probe(struct i2c_client *i2c) iio->channels =3D veml6031x00_channels; iio->num_channels =3D ARRAY_SIZE(veml6031x00_channels); iio->modes =3D INDIO_DIRECT_MODE; - iio->info =3D &veml6031x00_info; =20 ret =3D veml6031x00_hw_init(iio); if (ret) return ret; =20 + if (i2c->irq) { + ret =3D veml6031x00_setup_irq(i2c, iio); + if (ret) + return ret; + + iio->info =3D &veml6031x00_info; + } else { + iio->info =3D &veml6031x00_info_no_irq; + } + ret =3D devm_iio_triggered_buffer_setup(dev, iio, NULL, veml6031x00_trig_handler, &veml6031x00_buffer_setup_ops); --=20 2.43.0