From nobody Sun May 24 18:45:51 2026 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 451372E65D for ; Sun, 24 May 2026 10:44:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779619503; cv=none; b=ss3UgmRGPlIbvudlWB7aPH+E+ygkBRIyMuOs0O9LV81t8wLrHM8YMSUcm2MZdF0NzBIqgEt41TF9UcPwYLmpp2WpF/kJk7SEUdJngYnf8zTU+U02Uh9GQFGtdvni656yOYVD463BFIMWQqn8KJid6MYfZokR27lYVOnSr7jC5L4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779619503; c=relaxed/simple; bh=R0YcoyCM3cB+fPEBMl3+P/amDiK/k9Nbz39/MrAIn28=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=rjr49yHaFDE7URRy6NljGj7VZe2nwbjeVK9GujQAGO+Of9VyE/2rANkTT3zwBamC+NBrqA/m6n0YrcSxw2riMk9rsHC0quVMmoAUlacVlkpm9nDpC7EJEs+axj0zasYktIb1c9E3nraUscfvCXzJcWaYwV6vZilWO+PSElhiZmY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=s/cQo0jX; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="s/cQo0jX" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4893940bb5eso47492845e9.3 for ; Sun, 24 May 2026 03:44:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779619494; x=1780224294; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=65RWI5unXcapVvUdFUIqa1siyn6oOE01r03j8xlWPns=; b=s/cQo0jX4Q212BQve5VK/90iBds9qN5WwwimKdu+dluggCVhfqfYtlWAcbFokX+rWc M2+uJHlAlcpf38sVnDNwAotWJjw26/BQVihW3rQiDufq8vVa5xAdN9xm4znV3dzWUcJb uytvTXpAWAXB6ow2lzfsGyrVXGwXOAhaZ/gfAM4yx0E3MLkRtLLNQJa0bFe3vrA3UUN7 cnP4BZdbPX/c31p4/1TQF0R9dP+55QDe0p/URVn9BGtrcO8I7vdxQDNAlPltKepeZeVi BO4NeuhKt3GNHU22074Q+6x0YC3zZPFDgH3WgTZ13w0ByDt2S/aGsrI3LHTX/JORAnvp yYcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779619494; x=1780224294; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=65RWI5unXcapVvUdFUIqa1siyn6oOE01r03j8xlWPns=; b=osUrOkeT7ZPnzqy/lYMFSG5AOpB1AW5gYVp8jxCjYbgjIi9KWYywc6v0ISsXOT8NDu 6Hvw4wxceD+xkPdX+TB/uf+MujiTiWe6uIzANxoGPmeZtQUDUJuUtlVqSgM9a04GglJN NKdekz+32zbt1xFE1qGv9ECaD0dJsdc2c+yDpxNnLDjOxmkxr6Q+Fd3UqwqwzTc4j+Qh 1MCLSXF+vSqwJ+Fm1G0g/OTxuEELQ1B9xp/yt4leNSUgoUTQnQJ6RpXfYlcQa4Rf7Pks Z+T8c6rmsRlnCV0FrTsxDpxlYrWKvk+ClNTe4AiN8KHywBN7OJHbn7HfTQNqqbl8FXBd BUCQ== X-Forwarded-Encrypted: i=1; AFNElJ8IsUXy4JTei9dyb+UZuYVQO4dkmOAt1vGZf1peyv0sIDCLavUo26KgCrLGh4LoiEm1A5UaQbmoFGJblaw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw7lWrznPauqrDNsgaR2WNsPe0aUMUkj3XFZO8k7d7X3OOF0IF+ JMv6v0QhSUoffaOgJyGhImOsHVG8l5iIupLhRw27ioQKd9QU89A1BbZF X-Gm-Gg: Acq92OFisq67QR70bbSCocCEkvqDZaWul2kZGGCYLlN+gPDohTzsS2lTD9ajS614XEM acHfnU8GZ3tWLXoPx7BdCHr17ukvOITaVtbXXHBx0D1e/dT10dKQtltcvr3mONb9fAeLXYpPA0w KnRZ8HpOsNzgrb0UdRYDVjHcGk9gZawApzZgFqWBZO1AN5m/GRkYkT0wPQu0yOwhQX93HB0eJch 488vKoB4PVF9l3ZvrYukwtpP25OFzOgW/s1AzdSivYHvNqBWd96eJ80NxKwfuCrDnfMGF6bMCgz WGj581wXZ3D9NHxvE5jfvGOZPfuKl+nuhw8s+M9EcdieW93FXByfw7YiSJ6cNfP26ZE4sFb52St A7dT/HfotWnIEqQU6v8jLBaZBd3BgVcGiwMXrFVC+ZrCbgXrk3aYmzqrVuxoSGRMVTRjh2pgrw2 WNdpbED7kmvD30Q+4ra2mm/81y6d1mgPuUHKT13nYwEnCWWAizFCC6mv0cDDbtLMH6o8KGQ8Ui6 HJj2tGVDi9jQo4Q1/OT X-Received: by 2002:a05:600c:3b02:b0:48a:5821:5ff2 with SMTP id 5b1f17b1804b1-490425aa70fmr170767525e9.8.1779619494470; Sun, 24 May 2026 03:44:54 -0700 (PDT) Received: from [127.0.1.1] (2a01cb0c131d7300e352009073da06b6.ipv6.abo.wanadoo.fr. [2a01:cb0c:131d:7300:e352:90:73da:6b6]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4904527f7f7sm258967105e9.7.2026.05.24.03.44.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 May 2026 03:44:54 -0700 (PDT) From: Fidelio Lawson X-Google-Original-From: Fidelio Lawson Date: Sun, 24 May 2026 12:44:24 +0200 Subject: [PATCH net-next v7 1/3] net: dsa: microchip: implement KSZ87xx Module 3 low-loss cable errata Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260524-ksz87xx_errata_low_loss_connections-v7-1-1cd49cfa24f0@exotec.com> References: <20260524-ksz87xx_errata_low_loss_connections-v7-0-1cd49cfa24f0@exotec.com> In-Reply-To: <20260524-ksz87xx_errata_low_loss_connections-v7-0-1cd49cfa24f0@exotec.com> To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marek Vasut , Maxime Chevallier , Simon Horman , Heiner Kallweit , Russell King , Tristram Ha Cc: Woojung Huh , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Fidelio Lawson X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1779619492; l=7230; i=fidelio.lawson@exotec.com; s=20260326; h=from:subject:message-id; bh=R0YcoyCM3cB+fPEBMl3+P/amDiK/k9Nbz39/MrAIn28=; b=8imlxrE8KTBvq56L22UQFyEPNhGuG969EK8dsW36ZQmF9OT9VscMv8+gsCdySBY5jllMLQODT AwbSOHj0NpNBli977uKi4VuIbGkR9NKYXqWwMVFFz7I+oysze6efnV/ X-Developer-Key: i=fidelio.lawson@exotec.com; a=ed25519; pk=866eH9Bmmpjc+ctgkr5T1uXxBefZzob3tEEuiVWZ6BI= Implement the "Module 3: Equalizer fix for short cables" erratum from Microchip document DS80000687C for KSZ87xx switches. The issue affects short or low-loss cable links (e.g. CAT5e/CAT6), where the PHY receiver equalizer may amplify high-amplitude signals excessively, resulting in internal distortion and link establishment failures. KSZ87xx devices require a workaround for the Module 3 low-loss cable condition, controlled through the switch TABLE_LINK_MD_V indirect registers. This change models the erratum handling as vendor-specific Clause 22 PHY registers, virtualized by the KSZ8 DSA driver and accessed via ksz8_r_phy() / ksz8_w_phy(). The following controls are provided: - A boolean =E2=80=9Cshort-cable=E2=80=9D preset, which applies a documente= d and conservative configuration (LPF 62 MHz bandwidth and DSP EQ initial value 0), and is the recommended interface for typical use cases. - Separate LPF bandwidth and DSP EQ initial value controls intended for advanced or experimental tuning. These are orthogonal and independent, and override the corresponding settings without requiring any specific ordering. The preset and tunables act as simple setters with no implicit state machine or invalid combinations, keeping the API predictable and aligned with the KISS principle. The erratum affects the shared PHY analog front-end and therefore applies globally to the switch. Fixes: e66f840c08a2 ("net: dsa: ksz: Add Microchip KSZ8795 DSA driver") Signed-off-by: Fidelio Lawson --- drivers/net/dsa/microchip/ksz8.c | 76 ++++++++++++++++++++++++++++++= ++++ drivers/net/dsa/microchip/ksz8_reg.h | 23 +++++++++- drivers/net/dsa/microchip/ksz_common.h | 4 ++ 3 files changed, 102 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/microchip/ksz8.c b/drivers/net/dsa/microchip/k= sz8.c index 0f84b2e7d25d..715b4463538e 100644 --- a/drivers/net/dsa/microchip/ksz8.c +++ b/drivers/net/dsa/microchip/ksz8.c @@ -798,6 +798,37 @@ static int ksz879x_set_loopback(struct ksz_device *dev= , u16 port, u16 val) stat3); } =20 +static int ksz87xx_apply_low_loss_preset(struct ksz_device *dev, bool enab= le) +{ + /* Apply the Microchip erratum short-cable preset (LPF 62 MHz, EQ init 0) + * providing a conservative configuration for short or low-loss cables. + */ + u8 lpf_bw, eq_init; + int ret; + + lpf_bw =3D KSZ87XX_PHY_LPF_62MHZ; + eq_init =3D KSZ87XX_DSP_EQ_INIT_LOW_LOSS; + + if (!ksz_is_ksz87xx(dev)) + return -EOPNOTSUPP; + + if (!enable) + return 0; + + ret =3D ksz8_ind_write8(dev, TABLE_LINK_MD, KSZ87XX_REG_PHY_LPF, lpf_bw); + if (ret) + return ret; + + dev->lpf_bw =3D lpf_bw; + ret =3D ksz8_ind_write8(dev, TABLE_LINK_MD, KSZ87XX_REG_DSP_EQ, eq_init); + if (ret) + return ret; + + dev->eq_init =3D eq_init; + + return ret; +} + /** * ksz8_r_phy_ctrl - Translates and reads from the SMI interface to a MIIM= PHY * Control register (Reg. 31). @@ -1046,6 +1077,22 @@ static int ksz8_r_phy(struct ksz_device *dev, u16 ph= y, u16 reg, u16 *val) if (ret) return ret; =20 + break; + case PHY_REG_KSZ87XX_SHORT_CABLE: + if (!ksz_is_ksz87xx(dev)) + return -EOPNOTSUPP; + data =3D !!(dev->lpf_bw =3D=3D KSZ87XX_PHY_LPF_62MHZ && + dev->eq_init =3D=3D KSZ87XX_DSP_EQ_INIT_LOW_LOSS); + break; + case PHY_REG_KSZ87XX_LPF_BW: + if (!ksz_is_ksz87xx(dev)) + return -EOPNOTSUPP; + data =3D dev->lpf_bw; + break; + case PHY_REG_KSZ87XX_EQ_INIT: + if (!ksz_is_ksz87xx(dev)) + return -EOPNOTSUPP; + data =3D dev->eq_init; break; default: processed =3D false; @@ -1272,6 +1319,35 @@ static int ksz8_w_phy(struct ksz_device *dev, u16 ph= y, u16 reg, u16 val) if (ret) return ret; break; + case PHY_REG_KSZ87XX_SHORT_CABLE: + if (!ksz_is_ksz87xx(dev)) + return -EOPNOTSUPP; + ret =3D ksz87xx_apply_low_loss_preset(dev, !!val); + if (ret) + return ret; + break; + case PHY_REG_KSZ87XX_LPF_BW: + if (!ksz_is_ksz87xx(dev)) + return -EOPNOTSUPP; + /* Only accept LPF bandwidth bits [7:6] */ + if (val & ~KSZ87XX_PHY_LPF_MASK) + return -EINVAL; + ret =3D ksz8_ind_write8(dev, TABLE_LINK_MD, KSZ87XX_REG_PHY_LPF, (u8)val= ); + if (ret) + return ret; + dev->lpf_bw =3D val; + break; + case PHY_REG_KSZ87XX_EQ_INIT: + if (!ksz_is_ksz87xx(dev)) + return -EOPNOTSUPP; + /* Only accept DSP EQ initial value bits [5:0] */ + if (val & ~KSZ87XX_DSP_EQ_VALID_MASK) + return -EINVAL; + ret =3D ksz8_ind_write8(dev, TABLE_LINK_MD, KSZ87XX_REG_DSP_EQ, (u8)val); + if (ret) + return ret; + dev->eq_init =3D val; + break; default: break; } diff --git a/drivers/net/dsa/microchip/ksz8_reg.h b/drivers/net/dsa/microch= ip/ksz8_reg.h index 332408567b47..981ab441d9b7 100644 --- a/drivers/net/dsa/microchip/ksz8_reg.h +++ b/drivers/net/dsa/microchip/ksz8_reg.h @@ -202,6 +202,10 @@ #define REG_PORT_3_STATUS_0 0x38 #define REG_PORT_4_STATUS_0 0x48 =20 +/* KSZ87xx LinkMD registers (TABLE_LINK_MD_V) */ +#define KSZ87XX_REG_DSP_EQ 0x08 /* DSP EQ initial value */ +#define KSZ87XX_REG_PHY_LPF 0x4C /* RX LPF bandwidth */ + /* For KSZ8765. */ #define PORT_REMOTE_ASYM_PAUSE BIT(5) #define PORT_REMOTE_SYM_PAUSE BIT(4) @@ -342,7 +346,7 @@ #define TABLE_EEE (TABLE_EEE_V << TABLE_EXT_SELECT_S) #define TABLE_ACL (TABLE_ACL_V << TABLE_EXT_SELECT_S) #define TABLE_PME (TABLE_PME_V << TABLE_EXT_SELECT_S) -#define TABLE_LINK_MD (TABLE_LINK_MD << TABLE_EXT_SELECT_S) +#define TABLE_LINK_MD (TABLE_LINK_MD_V << TABLE_EXT_SELECT_S) #define TABLE_READ BIT(4) #define TABLE_SELECT_S 2 #define TABLE_STATIC_MAC_V 0 @@ -729,6 +733,23 @@ #define PHY_POWER_SAVING_ENABLE BIT(2) #define PHY_REMOTE_LOOPBACK BIT(1) =20 +/* Vendor-specific Clause 22 PHY registers (virtualized) */ +#define PHY_REG_KSZ87XX_SHORT_CABLE 0x1A +#define PHY_REG_KSZ87XX_LPF_BW 0x1B +#define PHY_REG_KSZ87XX_EQ_INIT 0x1C + +/* LPF bandwidth bits [7:6]: 00 =3D 90MHz (default), 01 =3D 62MHz, 10 =3D = 55MHz, 11 =3D 44MHz */ +#define KSZ87XX_PHY_LPF_MASK GENMASK(7, 6) +#define KSZ87XX_PHY_LPF_90MHZ FIELD_PREP(KSZ87XX_PHY_LPF_MASK, 0) +#define KSZ87XX_PHY_LPF_62MHZ FIELD_PREP(KSZ87XX_PHY_LPF_MASK, 1) +#define KSZ87XX_PHY_LPF_55MHZ FIELD_PREP(KSZ87XX_PHY_LPF_MASK, 2) +#define KSZ87XX_PHY_LPF_44MHZ FIELD_PREP(KSZ87XX_PHY_LPF_MASK, 3) + +/* Low-loss workaround DSP EQ INIT VALUE */ +#define KSZ87XX_DSP_EQ_VALID_MASK GENMASK(5, 0) +#define KSZ87XX_DSP_EQ_INIT_LOW_LOSS 0x00 +#define KSZ87XX_DSP_EQ_INIT_FACTORY 0x0F + /* KSZ8463 specific registers. */ #define P1MBCR 0x4C #define P1MBSR 0x4E diff --git a/drivers/net/dsa/microchip/ksz_common.h b/drivers/net/dsa/micro= chip/ksz_common.h index b67038cf1bd0..45613b9aeb1e 100644 --- a/drivers/net/dsa/microchip/ksz_common.h +++ b/drivers/net/dsa/microchip/ksz_common.h @@ -222,6 +222,10 @@ struct ksz_device { * the switch=E2=80=99s internal PHYs, bypassing the main SPI interface. */ struct mii_bus *parent_mdio_bus; + + /* KSZ87xx low-loss tuning state */ + u8 lpf_bw; /* KSZ87XX_PHY_LPF_* */ + u8 eq_init; /* DSP EQ initial value */ }; =20 /* List of supported models */ --=20 2.54.0 From nobody Sun May 24 18:45:51 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5FE87391E73 for ; Sun, 24 May 2026 10:44:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779619503; cv=none; b=KcnJiEgzl2wMQuBExK+cGnMijf3O8JxgvbKViXzGQZP3ZnJFJeY8Td8hM9povl1Kt9sfvHBSWIqwMb1IxbFuiQMgx40j4nf73bPEvaEj5sR7Uka8lAOgiF/KmXog1G9Kw2bvdZoVRLf87U5X1xU77XVXWncn+W5B1Kt4IIBjJdI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779619503; c=relaxed/simple; bh=weMwyhsBK/y7RsspN0KWN1ceSl6cDFrR3kYlEQ7OtRU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IJU3vNB6uAhXuZdGUbJK70K+u/eLnUVhdBPALOwncdZRKT/Z2JuWfR86eq42AKEWS9aw6A0ToHxsU3nBS3MXNRJ4x8RA5ZWw7nLr+9YY1cFqI8b+rzOHakqUHZkOet4so8bSOHyZpUjnFUgZeQWRRU37E7H2x1fbnlE4b8RO2+0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EYfnCYPQ; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EYfnCYPQ" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-4906238c62eso1049185e9.3 for ; Sun, 24 May 2026 03:44:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779619496; x=1780224296; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=k6Ilw3lJxE3L7HPaKc4glBNQa4+87Odew/GEo8ssTuM=; b=EYfnCYPQc1u2/Pu3u1vrXBdiN3mpCEWMPyqKJvAypIz1dLGbPXR3j+VmaXJPu+GUVM yV9V4ibt2EiXxPejJS4wTeYCxNqXE7+xOaPbLPhgGGDx22J/NUfL+DN6VX7I+/3hSwA2 D+p2EnlqJ/BMQ30WM78daTNW9YfWgcUUXPP4oIlFfwLyGbKy0QGsF/fe7j8xZQ39d+5C tJh1JOtDkWYgZiIro6Vt/BQU/IVjPKoJtdPtIko8CmLzfVD5TbPAVK+7bAOT5JWYocbD goar4pXVJCbednS+nidYnfqy5Q8ALnFQBxkyTail+tIUnaMPi7ueRvohx8TCb+Oa3g/2 RrNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779619496; x=1780224296; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=k6Ilw3lJxE3L7HPaKc4glBNQa4+87Odew/GEo8ssTuM=; b=hFh7KsMGDuz7ysgXiI9T+oSnuFeipIUPlZqkc/Oh4lTZqv8UFMtCKkrjp0NlvOt8mj jwE7dr/6b2yG4/saj21uPzI0zQSVslrmGP0XkststU982h654IeK/w16wV8fd8PyXZOc 8OWM3yHymKXVqnqez4jGdSpAv4N0PzACQJUnP1IstprKckIsEWGqwYhek+b95V6FdZX3 fNUl69jd5H/VqVdWudXu3wwK4Y5U75bBdoF7J8wczesYyiCV9FT7zWSQS8S3q84f7NEz 6qAhw77otfhp7txdvJqaS0iU2m5xb4/WTPqlXvWPTrEfhB/jVTmVU3HwHBK34bwBk0oP JGSA== X-Forwarded-Encrypted: i=1; AFNElJ8UAzQ6phZXz5jGQr6CZG/CZVH37NJZpqQUKngG76lmO86Kd3k+bbBSNzpeEux8rRPqmSuo7dobXjC22fI=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4eumCj+VLQ12p5BGiB855+BnP96wtNx9SfTbWmPaxIOn6pVnI v6V311rcykNZMzw+d8BGD5Qnp1z9blIcWWClXxIj3aQ1o/7cF9mwse8A X-Gm-Gg: Acq92OEdITNrQcYCnPPg90IyC6GLyKvg2ZzOSEay0DinPwhficU/MmWBsYceGnLMxWy 1kqFP9gVzebkE1ezGlfX1qHrbH2zgEImEuZjrg6XUEASJgrRsESu/w32jMKw76ru7b10O0q6TRl lE9b4bET+kz0fm0NI6zX4MX2c2lhKs3oGibIHwLPWIN+eEL2aIYMa2JgjFLkgtXdl/GKDCJaOkQ xS2J4jtiKtV2Y8cqtEA6+zbk4cM+izOVt1Bng0R0UDhSpXNk2CgkERoDFUtRVC5vdsrJy4Vbvpp k+tcbjmlWgFzGRwWiKIkyAN0aaeQ8A1k2nFG91qDc4BD9uXFiRg/Fy4pWdj+K9+/7Slj7P9U1eZ Fo2YCchFyvUZEIj0LwR9sLgjhpfc/+JrUg2Iu1LLtgC3bdPzyRdEiAqgzGNbhUMNOT4q+W2XO8w fZdTDEbgQqygS4BS9Umxvd/EM+/Wlpr66Uk+iTTavEQ5F3f2ljKYGXJcS9Yo640iHqbLJ5wxRcc ejVzlDq2zlCQdp/Ka94 X-Received: by 2002:a05:600c:4510:b0:48f:d5a0:284e with SMTP id 5b1f17b1804b1-490428e03b8mr163927125e9.28.1779619495411; Sun, 24 May 2026 03:44:55 -0700 (PDT) Received: from [127.0.1.1] (2a01cb0c131d7300e352009073da06b6.ipv6.abo.wanadoo.fr. [2a01:cb0c:131d:7300:e352:90:73da:6b6]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4904527f7f7sm258967105e9.7.2026.05.24.03.44.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 May 2026 03:44:55 -0700 (PDT) From: Fidelio Lawson X-Google-Original-From: Fidelio Lawson Date: Sun, 24 May 2026 12:44:25 +0200 Subject: [PATCH net-next v7 2/3] net: ethtool: add KSZ87xx low-loss cable PHY tunables Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260524-ksz87xx_errata_low_loss_connections-v7-2-1cd49cfa24f0@exotec.com> References: <20260524-ksz87xx_errata_low_loss_connections-v7-0-1cd49cfa24f0@exotec.com> In-Reply-To: <20260524-ksz87xx_errata_low_loss_connections-v7-0-1cd49cfa24f0@exotec.com> To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marek Vasut , Maxime Chevallier , Simon Horman , Heiner Kallweit , Russell King , Tristram Ha Cc: Woojung Huh , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Fidelio Lawson X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1779619492; l=2581; i=fidelio.lawson@exotec.com; s=20260326; h=from:subject:message-id; bh=weMwyhsBK/y7RsspN0KWN1ceSl6cDFrR3kYlEQ7OtRU=; b=WDmQMt2K0Srh5o0np0OvB2YWL9e4ZVEmmhlhs5WWXPu3WA/fLSCshvH75sA8sFH9sSnU+RFRy RkofLLQU5euC1tHErbSALRS59fnwS2BwzV5QDExwZjLeXHNpuvuiIGK X-Developer-Key: i=fidelio.lawson@exotec.com; a=ed25519; pk=866eH9Bmmpjc+ctgkr5T1uXxBefZzob3tEEuiVWZ6BI= Introduce vendor-specific PHY tunable identifiers to control the KSZ87xx low-loss cable erratum handling through the ethtool PHY tunable interface. The following tunables are added: - a boolean "short-cable" tunable, applying a documented and conservative preset intended for short or low-loss Ethernet cables; - an integer LPF bandwidth tunable, allowing advanced adjustment of the receiver low-pass filter bandwidth; - an integer DSP EQ initial value tunable, allowing advanced tuning of the PHY equalizer initialization. The actual behavior is implemented by the corresponding PHY and switch drivers. Signed-off-by: Fidelio Lawson --- include/uapi/linux/ethtool.h | 3 +++ net/ethtool/common.c | 3 +++ net/ethtool/ioctl.c | 3 +++ 3 files changed, 9 insertions(+) diff --git a/include/uapi/linux/ethtool.h b/include/uapi/linux/ethtool.h index 1cdfb8341df2..a2091d4e00f3 100644 --- a/include/uapi/linux/ethtool.h +++ b/include/uapi/linux/ethtool.h @@ -291,6 +291,9 @@ enum phy_tunable_id { ETHTOOL_PHY_DOWNSHIFT, ETHTOOL_PHY_FAST_LINK_DOWN, ETHTOOL_PHY_EDPD, + ETHTOOL_PHY_SHORT_CABLE_PRESET, + ETHTOOL_PHY_LPF_BW, + ETHTOOL_PHY_DSP_EQ_INIT_VALUE, /* * Add your fresh new phy tunable attribute above and remember to update * phy_tunable_strings[] in net/ethtool/common.c diff --git a/net/ethtool/common.c b/net/ethtool/common.c index 84ec88dee05c..a24d3a8a9ec1 100644 --- a/net/ethtool/common.c +++ b/net/ethtool/common.c @@ -101,6 +101,9 @@ phy_tunable_strings[__ETHTOOL_PHY_TUNABLE_COUNT][ETH_GS= TRING_LEN] =3D { [ETHTOOL_PHY_DOWNSHIFT] =3D "phy-downshift", [ETHTOOL_PHY_FAST_LINK_DOWN] =3D "phy-fast-link-down", [ETHTOOL_PHY_EDPD] =3D "phy-energy-detect-power-down", + [ETHTOOL_PHY_SHORT_CABLE_PRESET] =3D "phy-short-cable-preset", + [ETHTOOL_PHY_LPF_BW] =3D "phy-lpf-bandwidth", + [ETHTOOL_PHY_DSP_EQ_INIT_VALUE] =3D "phy-dsp-eq-init-value", }; =20 #define __LINK_MODE_NAME(speed, type, duplex) \ diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c index bd97f9b9bf18..fc2542422824 100644 --- a/net/ethtool/ioctl.c +++ b/net/ethtool/ioctl.c @@ -3114,6 +3114,9 @@ static int ethtool_phy_tunable_valid(const struct eth= tool_tunable *tuna) switch (tuna->id) { case ETHTOOL_PHY_DOWNSHIFT: case ETHTOOL_PHY_FAST_LINK_DOWN: + case ETHTOOL_PHY_SHORT_CABLE_PRESET: + case ETHTOOL_PHY_LPF_BW: + case ETHTOOL_PHY_DSP_EQ_INIT_VALUE: if (tuna->len !=3D sizeof(u8) || tuna->type_id !=3D ETHTOOL_TUNABLE_U8) return -EINVAL; --=20 2.54.0 From nobody Sun May 24 18:45:51 2026 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A34413921CC for ; Sun, 24 May 2026 10:44:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779619503; cv=none; b=Q6SoOfA7mnqqQQ57LIGQZBQjwnNNBB0Q1RuH07E+lIOCZjq187suVKgI/YRqmG4qt+39PObYWNfbVO5KHREpAwayOTe5JB4HtZXrr5GFa1AGb0smwh1nv9kk8Fl3nalRljGleK/DyZdEdg9RSsyaphZsi/JbtB+mAqmNvLMARX8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779619503; c=relaxed/simple; bh=rRle6VHq43rybdBxKovEgxEbnVv8lomEAMrTysrLkQM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=d9e7LiMP7oIgFX5JLY74PhCywjPtWAZJdX0bOZavr54tywZBScl+umy8fvLJXVG69pila1t5ZXr5CevqJjteLwqtr+ge9rxK5LX1Nyi1C7KuNQIQO5n31PZVG6Ye5701fgFh4JlbPG897GS4h90kkoupG6CbSsgo09gbQYEhvZQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Zs0QgsUy; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Zs0QgsUy" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4896c22fcbaso73124485e9.0 for ; Sun, 24 May 2026 03:44:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779619496; x=1780224296; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Zm/GwOmcvY0qOSCGXEdJb6NNauNokk7/UCTOiBwcXzY=; b=Zs0QgsUyDk0NHG4XoiQICsVkAiXxwgDF636BVTruNtRFRZUnCG6T7W/OzMaImKrSZP TkF0SmQh8iSKUajP6IcvLfvloLxmxyIOVF7X2RmxcmA8GXCw0saC0iYhYdRxnuX4fLio kxmIHFbPuob4aaXSUyPx2RcOwp2ujqIygruVblmoInp9EYKKsACInHDLK3wmwIo4ej7J kf8y63/Zt7NRX2skrp5DbtNWiyEwKf7IzIhzZDE8hgcpm4gtgD+o4TXOaZEeVrZqxHz6 cu/Kpzpyls+dS/EEqzumcNJ6rsyxNmoZA9rggl58qnCJzfQa2fKz4RigVleFcCkaJ+O9 T/8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779619496; x=1780224296; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Zm/GwOmcvY0qOSCGXEdJb6NNauNokk7/UCTOiBwcXzY=; b=GOmmhkvMjmWji/64SBtjnM8zENS5ZbHc8FaTG7FM5Q9BIMVatkIudxtY7fG65+i8/9 jxOafKDnFVsZ6z11lY3NABXcNV0/XFCTe7RZVc0gbf3NUS6F/sdw7UqzRCrVUaBUTpLR Ih5jMsfkMdoJ6cdaUD03jEzygmaxzrfGgmhGU6NnkyT3CP5kdDB+OrSNx0Veo1RyiTIC QCR5EgmrXiNHaYNSUwGifLH6FFmIc+LY1dPb8WoWP+QpKKZ6NGWrmXS/YGspsvVIkY1J TFfhkFrpQ6Pw4H04zJgOESF4DWDVVdXWlkLQAKP+s3rnBuYGmKPjTyo1qB9DsAD4sBWJ XrnQ== X-Forwarded-Encrypted: i=1; AFNElJ/RD7Xaf/TdC7W0Greoaoak4XjX3yxp6oL7oueBkwG/h4eiNDvqkPvu19tOrByElhwQ05dOCCqBbRYx3cc=@vger.kernel.org X-Gm-Message-State: AOJu0YyBaiINjSssUtTPhAcJkMINZ8AMvuCDporLOYZVt87e20kD9yNE BNfLiIvwA0dST506s6C5ydJSM6pYw5gu0LSXfrDv/GH/09fiiNyY62ha X-Gm-Gg: Acq92OGODDc4Cc8+Jl5S9utPCXZYf44nUirSTuN0UH8nXo1nu4xyOaPq1sZbtv7AYUs 5SamvPE94esMw6JZExBjSu08sDMrwYrMoQF4+ABZXF8TWf+qeDeqWxP+7LYopZoY8u95LY3GxHH CEUAqGy9JTKWWRqbxaeQem6Fvt41YsQ5RJYXILN+gRZW9dhGLWPoJ9Q2Yc9/LxCc1oyyT9pwHga PyRF6r/4ajfqeH7dvZLEZndqkKqQ5ofRAHPAqfmwqWTJgOo4FlD9mKQFfIvJyMw1OVc3MAcRtLq R3BNVtw7sZi4vyryGRUddMFaeza8puUyVLGeB2iVpxA/6uHv3B1d/cpH8t+IIxjFMbZf9UyilmL GXuPzv9//sS84eh6diHgzxl7N915my2mgbKa68IQLQ7Gglck5Mk+ufLwPgnzEFPoiOB4JCU6ujk WlIqd5ZuVwEmZ+YWT4UmnYBK92tU5cK54RMXNJk70QBPhvGcw0IOj2ssReJUQH71xxHANXEpGYN gOkCOvPP3WlQACFUTYr X-Received: by 2002:a05:600c:4ecc:b0:48a:557e:6b4f with SMTP id 5b1f17b1804b1-490426d2805mr155632375e9.23.1779619496392; Sun, 24 May 2026 03:44:56 -0700 (PDT) Received: from [127.0.1.1] (2a01cb0c131d7300e352009073da06b6.ipv6.abo.wanadoo.fr. [2a01:cb0c:131d:7300:e352:90:73da:6b6]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4904527f7f7sm258967105e9.7.2026.05.24.03.44.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 24 May 2026 03:44:56 -0700 (PDT) From: Fidelio Lawson X-Google-Original-From: Fidelio Lawson Date: Sun, 24 May 2026 12:44:26 +0200 Subject: [PATCH net-next v7 3/3] net: phy: micrel: expose KSZ87xx low-loss cable tunables Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260524-ksz87xx_errata_low_loss_connections-v7-3-1cd49cfa24f0@exotec.com> References: <20260524-ksz87xx_errata_low_loss_connections-v7-0-1cd49cfa24f0@exotec.com> In-Reply-To: <20260524-ksz87xx_errata_low_loss_connections-v7-0-1cd49cfa24f0@exotec.com> To: Woojung Huh , UNGLinuxDriver@microchip.com, Andrew Lunn , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marek Vasut , Maxime Chevallier , Simon Horman , Heiner Kallweit , Russell King , Tristram Ha Cc: Woojung Huh , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Fidelio Lawson X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1779619492; l=3380; i=fidelio.lawson@exotec.com; s=20260326; h=from:subject:message-id; bh=rRle6VHq43rybdBxKovEgxEbnVv8lomEAMrTysrLkQM=; b=IhoZMRrufbEFkhpcXfKrI3wcV+/FZnLOl2mFCErfOeoUaqqWYeJnXmEbmCrgjTfjRJBwpUG0H l3Dmnjcwka+AcDf8SKfpcL349AsTxlpcixDzRMzJODQ1EQ8ny93rwvH X-Developer-Key: i=fidelio.lawson@exotec.com; a=ed25519; pk=866eH9Bmmpjc+ctgkr5T1uXxBefZzob3tEEuiVWZ6BI= Add support for the KSZ87xx low-loss cable PHY tunables in the Micrel PHY driver by implementing get_tunable and set_tunable callbacks. These callbacks expose vendor-specific PHY tunables used to control the KSZ87xx embedded PHY receiver behavior when operating with short or low-loss Ethernet cables. The tunables provide: - a boolean short-cable preset applying known good settings; - an integer LPF bandwidth control; - an integer DSP EQ initial value control. The Micrel PHY driver forwards these tunables via standard phy_read() / phy_write() operations, which are virtualized by the KSZ8 DSA driver and translated into the appropriate indirect switch register accesses. Signed-off-by: Fidelio Lawson --- drivers/net/phy/micrel.c | 54 ++++++++++++++++++++++++++++++++++++++++++++= ++++ 1 file changed, 54 insertions(+) diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c index e211a523c258..bb8f3054e257 100644 --- a/drivers/net/phy/micrel.c +++ b/drivers/net/phy/micrel.c @@ -287,6 +287,12 @@ /* PHY Control 2 / PHY Control (if no PHY Control 1) */ #define MII_KSZPHY_CTRL_2 0x1f #define MII_KSZPHY_CTRL MII_KSZPHY_CTRL_2 + +/* Vendor-specific Clause 22 register, virtualized by KSZ87xx embedded PHY= s DSA driver */ +#define MII_KSZ87XX_SHORT_CABLE 0x1a +#define MII_KSZ87XX_LPF_BW 0x1b +#define MII_KSZ87XX_EQ_INIT 0x1c + /* bitmap of PHY register to set interrupt mode */ #define KSZ8081_CTRL2_HP_MDIX BIT(15) #define KSZ8081_CTRL2_MDI_MDI_X_SELECT BIT(14) @@ -940,6 +946,52 @@ static int ksz8795_match_phy_device(struct phy_device = *phydev, return ksz8051_ksz8795_match_phy_device(phydev, false); } =20 +static int ksz8795_get_tunable(struct phy_device *phydev, + struct ethtool_tunable *tuna, void *data) +{ + int ret; + + switch (tuna->id) { + case ETHTOOL_PHY_SHORT_CABLE_PRESET: + ret =3D phy_read(phydev, MII_KSZ87XX_SHORT_CABLE); + if (ret < 0) + return ret; + *(u8 *)data =3D ret; + return 0; + case ETHTOOL_PHY_LPF_BW: + ret =3D phy_read(phydev, MII_KSZ87XX_LPF_BW); + if (ret < 0) + return ret; + *(u8 *)data =3D ret; + return 0; + case ETHTOOL_PHY_DSP_EQ_INIT_VALUE: + ret =3D phy_read(phydev, MII_KSZ87XX_EQ_INIT); + if (ret < 0) + return ret; + *(u8 *)data =3D ret; + return 0; + default: + return -EOPNOTSUPP; + } +} + +static int ksz8795_set_tunable(struct phy_device *phydev, + struct ethtool_tunable *tuna, const void *data) +{ + u8 val =3D *(const u8 *)data; + + switch (tuna->id) { + case ETHTOOL_PHY_SHORT_CABLE_PRESET: + return phy_write(phydev, MII_KSZ87XX_SHORT_CABLE, val); + case ETHTOOL_PHY_LPF_BW: + return phy_write(phydev, MII_KSZ87XX_LPF_BW, val); + case ETHTOOL_PHY_DSP_EQ_INIT_VALUE: + return phy_write(phydev, MII_KSZ87XX_EQ_INIT, val); + default: + return -EOPNOTSUPP; + } +} + static int ksz9021_load_values_from_of(struct phy_device *phydev, const struct device_node *of_node, u16 reg, @@ -6961,6 +7013,8 @@ static struct phy_driver ksphy_driver[] =3D { /* PHY_BASIC_FEATURES */ .config_init =3D kszphy_config_init, .match_phy_device =3D ksz8795_match_phy_device, + .get_tunable =3D ksz8795_get_tunable, + .set_tunable =3D ksz8795_set_tunable, .suspend =3D genphy_suspend, .resume =3D genphy_resume, }, { --=20 2.54.0