From nobody Sun May 24 18:41:13 2026 Received: from mail-yx1-f46.google.com (mail-yx1-f46.google.com [74.125.224.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CAA81DF748 for ; Sat, 23 May 2026 21:15:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779570933; cv=none; b=oCIXJ+TSbEGEoHg08X8tSaQPeCFTugk8gl05oOd18WwUV41qad/ZJVjcMkuYjbmpllRTqtf+KQvtPLa1H4kG6h4S0Ukk7vqCpJIOGjmYlr4N5Ef3zSSKgREVa9+FPqSXUCncm6h3vginyXQcF1TCq9Gd/15gQPJc55AxQUa2Lv0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779570933; c=relaxed/simple; bh=rutS1RQikpnjyL+eNqGL1WNo/BebSsTm+9s0H7lfchc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=FKVH0DPVErtesc/7ndxGLA+Nqnr54YZ3CpDmfVr+5LVmPtycBlUgp2JX007sFS86Dphs5X+xnF87jJBta1ic6l3k7stpO74cSJD/QcO5wu5Dc2gLOHxty3qWKw3DNfcmPNatkyMbZJat8lzbS65AwEJztyNw5kJZhSThZ8IovsU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QpyX5z4X; arc=none smtp.client-ip=74.125.224.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QpyX5z4X" Received: by mail-yx1-f46.google.com with SMTP id 956f58d0204a3-651d6347a69so9002681d50.0 for ; Sat, 23 May 2026 14:15:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779570931; x=1780175731; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KocvSnRR4xwqM/7p6szeLx88yfSIAZF4LMX54OxwjhA=; b=QpyX5z4XOFXrKTpl5Dsd7gu2T0m7hLrVOneO76pgv8r/YX8bq4J1heK8hG93wqjU/2 mb+fVkSXMQLwAaNK/9KP4S/nltnz3rINZ9+kCXSOihgGZ4GitVb2HeA3JQNfB6wV90JE To/pL7gQW5fyP0mPZ0K9YNC+cuoJj/I5AQm1hwkF3X8fokiGnh229Cse3G04r/A6M4Np r3gFh9cyezCLd44BSc870GZjMujDy+3oxeWKa9Cy+29n9bBhIjNUfmFujOV+4grm+Epd pACOLVHUbOqG5cOR+kdqHfyWt9WyiyBwoe7vQC8/bwKRZ03bNLml0g51Zp4ExqzNaLNp SGaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779570931; x=1780175731; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KocvSnRR4xwqM/7p6szeLx88yfSIAZF4LMX54OxwjhA=; b=hdkwQs97hcMgUhN9z7sqSChKLZ2txvY6THRJwRaI9Ez8xQw33ABUMsl8I4VcJzNt4K srlnMoheE+ygJJDQpDYORDdbayDdnggwLX6dC3lcA9Aw8srhXPZdw/guDH/CNSgFKHrw BXDrIc3uBo3JDcrRkBQN22ixEstf8B294ruQEXX2VVeep9WJ/e6FN3Z2gQsVGWIe0QNc lH680m4Np8Ja4hd6DQb9V9KQrbNbT4NxbQmTnG3yOxsxkgwzb70Q8FnGSRF44MgSwxHX VgFUQ7/zuVRJY+TPANWyIAk71Q2mALVGw7+uEJ46dNPnEOtaJv2+YVUBpS3DOKDwiO3W OGRg== X-Forwarded-Encrypted: i=1; AFNElJ9TapI8g096yUyBGKojl8ogcbKPBiFWJxd2m8ZvpMEWO+HBH2YB3hllBKS1sez9HJ1nKzW8Y1xZrvgK24w=@vger.kernel.org X-Gm-Message-State: AOJu0YwDiTw+Cgg4s048mhhpAQCJR7ckYLbZVX2OzlPdQCI2Y4tbqQX6 XLcBBQNy922U7v0S/H3lgnFN9WWF+a5/4p6Hwg29/bU8CS/JuhB7l7/r X-Gm-Gg: Acq92OHxsKhqsv6im8lw464/hjGfRCTSR+vLjl5Zu+aWM2TYzDj1I2up56TOrBzL/5t cD/9gaZFe/YNd6hOgNB2B7mrkw0rgw03O1BNJplXgHjLLgxxLt3lyH3wGQvZyJxIBd1O7b9waOb xAU4OVdUEOT++NLR+16eS7+AOhjsFmk1o0dJTt0olenQSI985zDmMQSJ7nnGdFxCGdTOPPwvMZM 91+LJ/EZmU5LIXJ0GK3TDZWoQt2oNdHa+dNNJhK0xdi4bYsPB2IkRVNmb+SMnjOwclSQ73Q5Jrd VkRav7u7+6ZTN7hgljG3TVtbMfri4DWk6+I/kCTCOdxsZXJND/kz++MV9AkegrbiSSiq6JGA2Zo JfZsmQB2RET2py7h93UZsCFBSdYSJ3ugFpmoxZpodawWg4yKPbpAvumuVZxvJu9h9Z9oXKpvCzC n1VLJk+ME93ZdmtVj6XO2luKBkzumRxZ266fc1dkDQgJk/iTD5S2A3MF+tt45EjPlLx63T6jZGp jVjplbRCJwGgP4iWNw82pK4p0la7CRRMMY= X-Received: by 2002:a53:e19c:0:b0:65e:15fb:2413 with SMTP id 956f58d0204a3-65ead070579mr7417282d50.48.1779570931156; Sat, 23 May 2026 14:15:31 -0700 (PDT) Received: from tux ([2601:7c0:c37e:2360::111d]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-65ecf698e8asm2419199d50.0.2026.05.23.14.15.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 May 2026 14:15:30 -0700 (PDT) From: Ethan Tidmore To: Mark Brown , Liam Girdwood Cc: David Rhodes , Richard Fitzgerald , Jaroslav Kysela , Takashi Iwai , patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, Ethan Tidmore Subject: [PATCH] ASoC: cs35l56-shared-test: Fix possible null pointer dereference Date: Sat, 23 May 2026 16:15:22 -0500 Message-ID: <20260523211522.522616-1-ethantidmore06@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The struct regmap_config is dereferenced before its check. Also, after it is checked priv->reg_offset is assigned to regmap_config->reg_base, making the removed line redundant. Detected by Smatch: sound/soc/codecs/cs35l56-shared-test.c:681 cs35l56_shared_test_case_base_in= it() warn: variable dereferenced before check 'regmap_config' (see line 665) Fixes: a6f7c21accb5f ("ASoC: cs35l56-shared-test: Subtract reg_base offset = in dummy regmap") Signed-off-by: Ethan Tidmore --- sound/soc/codecs/cs35l56-shared-test.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/codecs/cs35l56-shared-test.c b/sound/soc/codecs/cs35= l56-shared-test.c index 5b2b915559a9..4f52c8a192e5 100644 --- a/sound/soc/codecs/cs35l56-shared-test.c +++ b/sound/soc/codecs/cs35l56-shared-test.c @@ -662,7 +662,6 @@ static int cs35l56_shared_test_case_base_init(struct ku= nit *test, u8 type, u8 re =20 test->priv =3D priv; priv->test =3D test; - priv->reg_offset =3D regmap_config->reg_base; =20 /* Create dummy amp driver dev */ priv->amp_dev =3D faux_device_create("cs35l56_shared_test_drv", NULL, NUL= L); --=20 2.54.0