[PATCH] ASoC: cs35l56-shared-test: Fix possible null pointer dereference

Ethan Tidmore posted 1 patch 20 hours ago
sound/soc/codecs/cs35l56-shared-test.c | 1 -
1 file changed, 1 deletion(-)
[PATCH] ASoC: cs35l56-shared-test: Fix possible null pointer dereference
Posted by Ethan Tidmore 20 hours ago
The struct regmap_config is dereferenced before its check. Also, after
it is checked priv->reg_offset is assigned to regmap_config->reg_base,
making the removed line redundant.

Detected by Smatch:
sound/soc/codecs/cs35l56-shared-test.c:681 cs35l56_shared_test_case_base_init()
warn: variable dereferenced before check 'regmap_config' (see line 665)

Fixes: a6f7c21accb5f ("ASoC: cs35l56-shared-test: Subtract reg_base offset in dummy regmap")
Signed-off-by: Ethan Tidmore <ethantidmore06@gmail.com>
---
 sound/soc/codecs/cs35l56-shared-test.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/codecs/cs35l56-shared-test.c b/sound/soc/codecs/cs35l56-shared-test.c
index 5b2b915559a9..4f52c8a192e5 100644
--- a/sound/soc/codecs/cs35l56-shared-test.c
+++ b/sound/soc/codecs/cs35l56-shared-test.c
@@ -662,7 +662,6 @@ static int cs35l56_shared_test_case_base_init(struct kunit *test, u8 type, u8 re
 
 	test->priv = priv;
 	priv->test = test;
-	priv->reg_offset = regmap_config->reg_base;
 
 	/* Create dummy amp driver dev */
 	priv->amp_dev = faux_device_create("cs35l56_shared_test_drv", NULL, NULL);
-- 
2.54.0