From nobody Sun May 24 18:41:00 2026 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D8E226F2BF for ; Sat, 23 May 2026 21:09:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779570573; cv=none; b=MKLZqOUItm4/5dCibJVkU3j4n8LL6ZJCURDyRmiDuKFPH2hAKjaJCfj5eUomjGbzqvss8va6EjcOMOdOoHpwYP7tjX47o805gxmPl4ir+g789kj6XFIurfMG90SVvCpaTmWFPmjnZYiF5KRRDkXrRURI/Wp6RrEg5PHR9gG4lCo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779570573; c=relaxed/simple; bh=+lRJD2b0ZjqK9badvBf2tzZfwwSC1/C8unjjkSYiDBQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=WGlIcv8yDkUJOu4hsj6eVZFOJsmaC+gS/pgY3pQ3OwXnWSeXw4Wrp+8wCzEu1xTA9KnoR4p6tsrf8Thtg8YDGy40kfZcCQHlFQ7eBtnK0YURsSN3UhLMm7FrHO8isw+C+mbbieiBcXcxE1yI9Lg+QWiKwSOMcdY7BAOQmY/JJqI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=f+EyJyQJ; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="f+EyJyQJ" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-82f8b60e485so3530566b3a.0 for ; Sat, 23 May 2026 14:09:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779570571; x=1780175371; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Lm8UJ4hOarUlviQr2levKNdmrXnb21bQJ59ovlralbM=; b=f+EyJyQJdl0ZTXVsdg31I5sGl8ZoIclMJIBzV1wntWRZ87wAHg7wSy1GbEMl0AXRkq 1jejAYx7axBYLo1dkPWTo+ofYn+iNnCHXFbtDHCTbq5esHlxS9btYrSmsCnVjVJI3pTB 5XHN1249BUcsj73JMcWV9BTXc0EU5CM4BA6UefpgpdEqXptOafEuMetNEZgZo5RRtap1 QEJwmZV4I/U8TkONt+P/z9Z53QfbYkjPY8eCVqoO2aXLht+bZq/FEdX3HBC7uYveZPOV JdAQH6U36mqKmmLIaf/dEWgfFDfR2wzM5B/fYu49kyFzrIbt6DgFzae5lzZwD8M7p/0P JenQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779570571; x=1780175371; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Lm8UJ4hOarUlviQr2levKNdmrXnb21bQJ59ovlralbM=; b=WzynHCEBtfn8cZg6yTOnbNgdSAmkS2E9LyuCXTHdQ2wluKYpJZCmwYbX6ybuHC9fyT vu7j24+5oC6rASLusne50yu14PDFDR7Imott7cdpgKo8141+KiARznpI2Mgcxgb339Y3 /PvmtO1OFyOAiIvjl7fnRbM+SFyCJSFqwLSYmQoZmWVzAsg/SRCI0S6NTZ0EfzJoj+U0 gByKgkW5xdRYGdGObpGpLl5KCOAdh2AcMsm6pGNl1j/8thBQPbTNYZ5wozBmxDUFpmEp fKdKn5oRDH5Q+OimdhyUT/VOva6DDCGflyNm4ofFABxPE39lLBcehYQw00HB01658k7h MMXw== X-Forwarded-Encrypted: i=1; AFNElJ+Bhd1Y/dltVFT2aLRL5P4/7xKezbQ0qzzufeuk/FEb11FdM2Dwo16n7uHerrCKxaaSlsRZ4HBcN1cDKak=@vger.kernel.org X-Gm-Message-State: AOJu0YzAFgMRXt6CqpvikPzzWKlg9yHNVT1VmBsQL3Wc9bP1wnpgzzBX jR1JTxX4Jg9kxpspCLi7+ltIgqgU3QFY49ZnidzCYiMbe9zhQQ35/LJS X-Gm-Gg: Acq92OFwMLC75HR/04r/hIi576+aoF9voQ8nfMRHBHGXv0k/e4PKOZ7udotrYC2qNju fLNltsthvty7u25lLHnFwu4lC66KIQZ75IQLjg/KUrkbLjBucmsIUBgnKaD0fdw7/wV5fkzeRpw qbT4HJYOSWO3CHhrHOzFrlWw2W4FkhcAvn8PD4K73sgMcu402lhr7HnIu7KOVw3LDTCHq4zWe5j v8Bn+kMMDaHSpVEcloqc8Z8VkMw/25z/AgMRD/g0CpeJfiiQVoI2Nu+ccJoGVLwtfoOOnSjl31D Sxu9ReyPypoCcT2uC6TedpsP+HcDpxyiXY6qr0w25orkisr3v0QY0tRxAjxLxoyg+P8tFU+WSA1 9j6vluGlkVbVR9Hmj9ZAL1B1uyW+Uy8XGocI3m8oIOjMgt1uX/9eecyZBIHLg7k8bglp/1V6KH7 TW28p8VNVPKciCGFxnPNBCPg1QyKFeZECZaZNhYLmqZHUu5g8ndj8b+S8YdkEeBkEW7RB9lPl+R nwdDs4QSoScF1lhQ5uL4rLw8R0bTTf7WdQ04+15nUNMNv99rQy73Gt1nQ0jY4sHrRILue8YfxDF Y7z+DI650Pg= X-Received: by 2002:a05:6a00:2d90:b0:82c:eb46:acb9 with SMTP id d2e1a72fcca58-8415f308ba8mr8634533b3a.24.1779570571492; Sat, 23 May 2026 14:09:31 -0700 (PDT) Received: from codespaces-78f0a7.mimvmn1ww3huhhjmzljqefhnig.rx.internal.cloudapp.net ([4.240.39.195]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84164fc646bsm5406884b3a.46.2026.05.23.14.09.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 May 2026 14:09:29 -0700 (PDT) From: Muhammad Bilal To: robh@kernel.org Cc: tomeu@tomeuvizoso.net, ogabbay@kernel.org, tzimmermann@suse.de, Frank.Li@nxp.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Muhammad Bilal Subject: [PATCH 1/2] accel/ethosu: reject NPU_OP_RESIZE commands from userspace Date: Sat, 23 May 2026 21:07:52 +0000 Message-ID: <20260523210840.92039-2-meatuni001@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260523210840.92039-1-meatuni001@gmail.com> References: <20260523210840.92039-1-meatuni001@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" NPU_OP_RESIZE is a U85-only command that the driver does not yet implement. The existing WARN_ON(1) placeholder fires unconditionally whenever userspace submits this command via DRM_IOCTL_ETHOSU_GEM_CREATE, causing unbounded kernel log spam. If panic_on_warn is set the kernel panics, giving any unprivileged user with access to the DRM device a trivial denial-of-service primitive. Replace the WARN_ON(1) with an explicit -EINVAL return so the ioctl rejects the command before it reaches hardware. Fixes: 5a5e9c0228e6 ("accel: Add Arm Ethos-U NPU driver") Cc: stable@vger.kernel.org Signed-off-by: Muhammad Bilal --- drivers/accel/ethosu/ethosu_gem.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/accel/ethosu/ethosu_gem.c b/drivers/accel/ethosu/ethos= u_gem.c index 80d4bc21c28f..043541407a8f 100644 --- a/drivers/accel/ethosu/ethosu_gem.c +++ b/drivers/accel/ethosu/ethosu_gem.c @@ -433,8 +433,7 @@ static int ethosu_gem_cmdstream_copy_and_validate(struc= t drm_device *ddev, return ret; break; case NPU_OP_RESIZE: // U85 only - WARN_ON(1); // TODO - break; + return -EINVAL; case NPU_SET_KERNEL_WIDTH_M1: st.ifm.width =3D param; break; --=20 2.53.0 From nobody Sun May 24 18:41:00 2026 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFB1426F2BF for ; Sat, 23 May 2026 21:09:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779570578; cv=none; b=P+hVvtM1AkID/srS1FsCmVPUmZOBHX9fh/oob1ku0WeZFrC7PhxjnIZ3pXMr+bvpMfFCQRyVjYhl8EhUcov84/1VRu3pUs58XMgGSOvbco97OoBUVste5ur81L1lXaZyreaEmB4ob03pwQLAmLcPsprBKPt1LOF+MRwGdKs+NrA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779570578; c=relaxed/simple; bh=oHGjU5VtT4Nj+CBqr98cWbGax9+xfd2+ZbclZmJ2Mcg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IMFjalYoD/o1IYFivuzsTbAVOTCet/rVRqWOuhKZRyXGXd5/wtD6EDiMOTYcxMVY87lp9koByx7Im+Gy/Nm/KjFZC2pz31SjbyceKUjvjTxpQW0dNHa5h5GEIBnAtUQy3VrC/Xa9yQFYvPGO0kqbspG4LSK/6ypIpBogvU2gPlU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mUyjo+eM; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mUyjo+eM" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-824c9da9928so3713822b3a.3 for ; Sat, 23 May 2026 14:09:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779570576; x=1780175376; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=m75pjVJH9fVWqs1GIsLd17VZCLb6FKMxe/bCaTR72AE=; b=mUyjo+eMK96GNqUxTYUzivC6+za2Dd54zXz/zSoA5B6hA6y2DfdCqV31+ZpYZLOfCc KqgIigz787tnD4hjSZ3JAIddwTqJhb/352gS9po/MtpLcEUBDy0a3+dV41Egyk7P+Yy3 i0Hatd+BFayL2LZ+9RzvrYwxWEKlY2GfEGTaj+QYZUnN5w87nG5dy/tEA1UFqNrjc/NM xbmftJOHFy8eFrVkck0+38L585V4xmu0f0BkxJRAn3gvYXabpmuVLCa6f356vF8e4b3m ouL3GR3HI8mHlfvoNz5GmogcV1gZCKORot0oZ1ts7enh85dwNXzg1hor2x4pjz8QCok2 CcUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779570576; x=1780175376; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=m75pjVJH9fVWqs1GIsLd17VZCLb6FKMxe/bCaTR72AE=; b=CSR6zlCVcwZEDhwECXCeVOW7AJnfI7bohFLXSXOYHIRHBARHLZYESwJHuDYpsp7y6Z iAYs7AI+6aQA9eF1h6+WET+BG0UPkHmwhWSSBVaP3d7cV5IbdsOhdJajxtD6y0TEDC3d VzDY3fSDFXcn7GNmwwRdC3UnrbbIllJGIAAzUIIInCRhKaKbT2KoaTcbDJwGzV7yhCwh CxEroJlm14oL07kpaECimXI/epvRwwfKqwLqSaK2SomHYCb6KjH2kUYBRCaJZ7lH8nkg g8NstLDsKphjqv2Pzkew8VQIeWSQxDi/qvX0qmKKOYhf+C2qxZmCBNO239P/ZbQ6W4I0 C/ww== X-Forwarded-Encrypted: i=1; AFNElJ+x7jWqpQ0rkN79RUBeRQl0UFT0D12FrRXZFep/ALKmxciGd0DoMGSCvbTDvr/LpsfqLAL4/F1/i42+qnM=@vger.kernel.org X-Gm-Message-State: AOJu0Yw03HFvTt+CHr//jB/cfsn1eeK8Om7f1/1kJMFLI/itQFo7g3uD YmT3j6bgSM4KjaRtGASmQQyzrZFIIGppvHtwe4UJnaZXYgzh8SN3aUlA X-Gm-Gg: Acq92OEEkW7lsCMNGuYZVBYVjgOLdCm1oKx1ERdDuDXdSbGZaymja7ilNMAc/nbKgLZ /nfCtsKm1XMouu5XT2ah8NKd2pyybAXJmwK1+ah8yINfpPLiwUN3Z8cqM9CO0bFwuTjOGYoXLbR g/uXY3QBbmeJpQBDPtJsLHSPZBcyoLR5U/tEK5R71lYMZwgjdwX7LPE6W2BL3qjSMo05MgVA4kD WtksDbLWnle3HS6uh9otbx1R/KX+ZOuHHrZk4tBGaBI5HwgtI3EGdoMZJo7Ae/2b8zMkNrpkrQL Ad71oQmcaE8rHVHyYIG3i6RRgD66pH32ai8XjM/WrAigHyemgQI+KdNeThu1ima3uq5gnbnj6Sk Bb0Mfgv66QWw2wtC3VF/S3U1BmpjOvSbAn6QYscVIb5es5rtjZ9PtP60R39CfvRWk8EYNSOwN4s MtQi0CC8itgnmIBh3JN79zISnm8U89wmzsSStZMc5xdrYoIBKiPuiHi5GGnPnqFkrArtnptBhcO M7TKHSwfodTXgVbVSDkrzoj8yMLjQ7RnZf9PxwsW2EB5WUTCZWy1ZGTDxVT/3phwgfa7ptS6z34 os69HzcigM0= X-Received: by 2002:a05:6a00:348a:b0:837:e9cc:d460 with SMTP id d2e1a72fcca58-8415f15b4dcmr8301554b3a.18.1779570576015; Sat, 23 May 2026 14:09:36 -0700 (PDT) Received: from codespaces-78f0a7.mimvmn1ww3huhhjmzljqefhnig.rx.internal.cloudapp.net ([4.240.39.195]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84164fc646bsm5406884b3a.46.2026.05.23.14.09.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 May 2026 14:09:34 -0700 (PDT) From: Muhammad Bilal To: robh@kernel.org Cc: tomeu@tomeuvizoso.net, ogabbay@kernel.org, tzimmermann@suse.de, Frank.Li@nxp.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Muhammad Bilal Subject: [PATCH 2/2] accel/ethosu: fix wrong weight index in NPU_SET_SCALE1_LENGTH on U85 Date: Sat, 23 May 2026 21:07:53 +0000 Message-ID: <20260523210840.92039-3-meatuni001@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260523210840.92039-1-meatuni001@gmail.com> References: <20260523210840.92039-1-meatuni001@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" On non-U65 hardware (e.g. U85), opcode 0x4093 is NPU_SET_WEIGHT2_LENGTH. The BASE handler for the same opcode correctly assigns to st.weight[2].base, but the LENGTH handler mistakenly assigns cmds[1] to st.weight[1].length instead of st.weight[2].length. This leaves weight[2].length at its initialised sentinel value of 0xffffffff and corrupts weight[1].length with the user-supplied value, breaking the software bounds-check state for both weight buffers on U85. Fix the index to match the BASE handler. Fixes: 5a5e9c0228e6 ("accel: Add Arm Ethos-U NPU driver") Cc: stable@vger.kernel.org Signed-off-by: Muhammad Bilal --- drivers/accel/ethosu/ethosu_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/accel/ethosu/ethosu_gem.c b/drivers/accel/ethosu/ethos= u_gem.c index 043541407a8f..5a02285a4986 100644 --- a/drivers/accel/ethosu/ethosu_gem.c +++ b/drivers/accel/ethosu/ethosu_gem.c @@ -600,7 +600,7 @@ static int ethosu_gem_cmdstream_copy_and_validate(struc= t drm_device *ddev, if (ethosu_is_u65(edev)) st.scale[1].length =3D cmds[1]; else - st.weight[1].length =3D cmds[1]; + st.weight[2].length =3D cmds[1]; break; case NPU_SET_WEIGHT3_BASE: st.weight[3].base =3D addr; --=20 2.53.0