From nobody Sun May 24 18:41:53 2026 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7F29274FD1 for ; Sat, 23 May 2026 19:40:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779565228; cv=none; b=TNz2H0v6dulCBckYNAb+d+pXc7+n06wvu+nMMJDHw3kUrN/uKmll2DvrSPmlROZdWaU2P4pPDg+GkaqOM/5CqJR+d4VrITvYtSR1eO/MpbCxNBKo7ihBoa573ensqLsn36t2C/ypaJBRjzmqBY/gMsrD7snSHHrDAV64EoMDjhc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779565228; c=relaxed/simple; bh=OFz9MRAFVyo1qunEfMUsFxgX838/ZzvtmxxVaA436zg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ek6wDbsKB712KKdgYPg6E/aYelsFLPlhruwu47GeijkE48bgdDi/t3NbZWw4WjeZebShRmuPU4sH9cjmG/9qfX4ZGfjrrwqoDbDSTisGTGbcWms4ibwzln8s3YQQjutId/bQqGxW3+Z/4HdJ62Tiw8HYzXCwCmoSQUYUMezK+vY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=htIUAPAn; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="htIUAPAn" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-8383fb7143aso3772838b3a.3 for ; Sat, 23 May 2026 12:40:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779565226; x=1780170026; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=hZzmbhO1XUfYujg4JdeubQMEAzDIUtBPSSN88sAPcro=; b=htIUAPAntSG3wbhOyOinkoHjOL11IVPZC5zoaEWTfLgLARvhvJTUb5020kS8TCN9g/ SPz5wqv3L1IH8g/iKTB8YlTDGB/OdqKUq9ByLGONPqPuLIfln74nvjEKFHvNvZAtvZmg A8X5+935lUmu/y3Y9T28T3TkY3d7Tlh2+cPp4mgcTmQoOGJ8zcDwRfHXEPWoZx403s7V Fop1nAXWB30rrZlCZY1fKNFafsYCvfy6sN+CNMuJg2XpFMMyCucAMSpQ0+1PD3SoXgKN NhyfV06IMd3GRmZaYqJ0KPN5wuzkYE2I/pfigakPCyfeEy9KZliqnV5lKAwpH+TB8R4S MGOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779565226; x=1780170026; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hZzmbhO1XUfYujg4JdeubQMEAzDIUtBPSSN88sAPcro=; b=kUuZAVfYX/3KQv6BTE3vurG1rdiEfE+i6Xt8erqld0/ORVBOUlQa3+srGTQvZL+sXD +mUMf6B5SZbtfHd+w9H60bB5k+Y8pljGI/czAHE/7XvcuFWXcCy5zG4UsFxPfSmPn54X yL2wzrlGkAf3FVR2E3GABnD6B8i6Cv7aZk3OyB1iP4bccp1KVtzUGe27NkmAGEjYVTpp J0xgnXqrtbn3RD9oY0b0MtGEQC69U9/vd00ATVTXkQa2ygLSKj2Rao8Zs0lEb0lsNpbT 76RFIEcob4p0W/Z67SwE4OOFlw0ALS3n9AWAUNgPI2D/gjpMNuxR237HBcJ3aYHbkMo+ goIQ== X-Forwarded-Encrypted: i=1; AFNElJ9HKtSEouvEHXU3x3wnOv/Zwuu1XLCxKmvJwIlKYnXe/GztZ0BNWH8hE5FUbdffpQRgUF0jeF/gt85vNas=@vger.kernel.org X-Gm-Message-State: AOJu0YxOGWQ8o4lf9AJmX2nI2dCpNvxUiKYO7b2x3sWvxa61bueamyuA qvrQ/3tEH1lGR3PN+adViJaKtRoJ0vU8EiXaFKHTHN3nd0wZFUuLeFGHXE52M3yk6SM= X-Gm-Gg: Acq92OHUQxuYwhElPGBKZup9iRj1PLWgcadjN+u/+ZfpJvw14BkO+qwLrGLrjmHbOR8 rmtyosnJh4FE38wlyRVoSTniVtC7Iagf0GiJg3RqB1OgQTAI2QAy5rzppZR42E9h8EbV2lsoocP lYWoanqIuG4XDNDcbbFRBK8Rnc6NGDGTEHC/Dy47VLyfRqgehoHmDL1JUbcdmZOK4bhuqTREztp QijW/xF+q2Z6cOm69xyNbQPOZTWZSA3FuthfuUzOotfN45XlF2URLdJj8P0oELCm6IzPhAQgoVf h9je7baULk/BvnPZqbJDk4dEa+RLVJVuS8qxuZ8nBxfYmT8RP9FynUxZ3m9yPv9R5cJb61ppgaF vQCZVnzxu4mm0Df/pe194wMPZNBdKvq6GxkQwUbc02eLbzskfPRECjwT6m3Mrmd476O+gnG46B3 OHP6bx9T3bjaYiURB8ONJ84MRN4D+Ra6GUHy7stHEy X-Received: by 2002:a05:6a00:1888:b0:838:20b7:40ed with SMTP id d2e1a72fcca58-8415f6141a7mr9106820b3a.42.1779565225935; Sat, 23 May 2026 12:40:25 -0700 (PDT) Received: from localhost.localdomain ([2405:201:d008:80b:a00:27ff:feb6:42dd]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84164fe3c9bsm5092868b3a.52.2026.05.23.12.40.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 May 2026 12:40:25 -0700 (PDT) From: Pramod Maurya To: gregkh@linuxfoundation.org Cc: jacobsfeder@gmail.com, ovidiu.panait.oss@gmail.com, gustavopiazdasilva2102@gmail.com, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Pramod Maurya Subject: [PATCH] staging: axis-fifo: use stream accessors for FIFO data transfers Date: Sat, 23 May 2026 15:40:09 -0400 Message-ID: <20260523194009.195538-1-pramod.nexgen@gmail.com> X-Mailer: git-send-email 2.52.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" To: Greg Kroah-Hartman Cc: Jacob Feder Cc: Ovidiu Panait Cc: Gustavo Piaz da Silva Cc: linux-staging@lists.linux.dev Cc: linux-kernel@vger.kernel.org The driver uses iowrite32()/ioread32() to transfer payload data to and from the transmit (XLLF_TDFD_OFFSET) and receive (XLLF_RDFD_OFFSET) data FIFOs. On big-endian architectures iowrite32() maps to writel() and ioread32() maps to readl(), both of which perform CPU-to-device byte-swapping. For AXI-Stream FIFOs, which carry opaque byte streams, this byte-swapping silently corrupts the payload. Replace the per-word iowrite32()/ioread32() loops with writesl()/readsl(), which transfer data without byte-swapping, preserving memory byte order as required by AXI-Stream FIFO semantics. Also convert the err_flush_rx drain loop to use batched readsl() with min_t(unsigned int, ...) to match the types of words_available and READ_BUF_SIZE, reusing the existing local variable copy. Fixes: 4a965c5f89de ("staging: add driver for Xilinx AXI-Stream FIFO v4.1 I= P core") Signed-off-by: Pramod Maurya --- drivers/staging/axis-fifo/axis-fifo.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-f= ifo/axis-fifo.c index 1c34de020cf8..38e4a691b6dc 100644 --- a/drivers/staging/axis-fifo/axis-fifo.c +++ b/drivers/staging/axis-fifo/axis-fifo.c @@ -125,7 +125,6 @@ static ssize_t axis_fifo_read(struct file *f, char __us= er *buf, unsigned int words_available; unsigned int copied; unsigned int copy; - unsigned int i; int ret; u32 tmp_buf[READ_BUF_SIZE]; =20 @@ -167,10 +166,7 @@ static ssize_t axis_fifo_read(struct file *f, char __u= ser *buf, while (words_available > 0) { copy =3D min(words_available, READ_BUF_SIZE); =20 - for (i =3D 0; i < copy; i++) { - tmp_buf[i] =3D ioread32(fifo->base_addr + - XLLF_RDFD_OFFSET); - } + readsl(fifo->base_addr + XLLF_RDFD_OFFSET, tmp_buf, copy); words_available -=3D copy; =20 if (copy_to_user(buf + copied * sizeof(u32), tmp_buf, @@ -186,8 +182,11 @@ static ssize_t axis_fifo_read(struct file *f, char __u= ser *buf, return bytes_available; =20 err_flush_rx: - while (words_available--) - ioread32(fifo->base_addr + XLLF_RDFD_OFFSET); + while (words_available > 0) { + copy =3D min_t(unsigned int, words_available, READ_BUF_SIZE); + readsl(fifo->base_addr + XLLF_RDFD_OFFSET, tmp_buf, copy); + words_available -=3D copy; + } =20 end_unlock: mutex_unlock(&fifo->read_lock); @@ -258,8 +257,7 @@ static ssize_t axis_fifo_write(struct file *f, const ch= ar __user *buf, goto end_unlock; } =20 - for (int i =3D 0; i < words_to_write; ++i) - iowrite32(txbuf[i], fifo->base_addr + XLLF_TDFD_OFFSET); + writesl(fifo->base_addr + XLLF_TDFD_OFFSET, txbuf, words_to_write); =20 iowrite32(len, fifo->base_addr + XLLF_TLR_OFFSET); =20 --=20 2.52.0