From nobody Sun May 24 18:41:29 2026 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 57170145A1F for ; Sat, 23 May 2026 18:34:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779561276; cv=none; b=YmwsSwrmWM+L1zxVqiSvGj9y7dQVV6lTqxl7iKfGxyF/wG1Mi5Ga2B+k3kkMcsRvXCOxxu+9jXFIMMIjZ7Oq5JZFRjskulY0/wYAkb/xeCDUGKrLIhZC4ksYChauqJGEHknzXmNQhiD4SnWDHYNbacwP8x5VvHGXO77IDyDWrzk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779561276; c=relaxed/simple; bh=ayLCEJxKGv6lRLSreqbdQbMAe8lnt/uLy918tHXWCX4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=VV4dGBg0J0Dz98JsEjpn072hZlvPqVrl6w+6r6uGhy4p8fCZs7snZKUQQNIkVkEn2200CwhPk9nEtkuBU5OGSPPPKG+ESdohVMzBe5fo5N9tC+Ss14hWYGVs5NNDBimnDALqpBSHybJa4CqzIvcSjUh4zJU+dNGDKVwc1wqNJFg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=sF8TwgSK; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="sF8TwgSK" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-367c26471f5so5412031a91.1 for ; Sat, 23 May 2026 11:34:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779561274; x=1780166074; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=T0H1SzqM6T6ZRCLW8lQs1DB+o83qlxULhZJ1jgh3dmY=; b=sF8TwgSKJ1B5HbzUvGHuTbTE+u03LgDZPO6UuVVxkqqH6088/jewZJtsS/u/Rq9b2b LiK+2YlOjUKnzZB0ERBbAM6qCADSmrViAkRz9ha1mK4eE6CglyaNDe4Ud6CrLmz062LW OjE/alYV/AgUvxuHSrYi7J9UzwYAeUR/R1NS/iYyc+6E4NHePcos7rVwlw9QhBAJSK5j jxJm7Pil+acRz7LqOoGXedPd4WdFTv7rwzv4B8GKbHtcXFCQAkAvDXso5tryNVcCIPBa h5+aQvyPnOYAQM0LsdizB6EXmqWNi8nD8pFgywjX1nWZ4xdAJoljD3DLqmgmdv6wTydD 8fKA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779561274; x=1780166074; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=T0H1SzqM6T6ZRCLW8lQs1DB+o83qlxULhZJ1jgh3dmY=; b=JABXxJWGEBT/3hE2xUaaE/yFlUynaIjIyGEruXYf4E0W5ElrHW4RNkosX9XU52x84o I9RD4LTuSnA52mRNEbwGAA+ZWBOwL4W77VmVtRRKVG1sKfe/I4oyTN4egRxVybe2HMUZ VuL0U3O2ydCPitMl+KQOTe7abfZ5I8Zhf19FWWYCxtC3UTLntn5XMGV9D6EvP+CIpneC z2K4TmQE2ONQGaNmneNXNUkZ2Ue8OiaWyIgak0YomjokP+NeVW6uueLkN3WwK2IONRjw iu4bVzRWtSSVOvCrbV8x8BwaQHY1u9MqThKNWvt8iQY0tlQKSiXOvWmtjvVXwSARdPl2 IB3A== X-Gm-Message-State: AOJu0Yw8kN5Xzhq15HlH+lHbE+rSFnAMAgvsw+cDecw1iUq1EvMZw7Yt jHi6ebx4msgwwss1onpoZ/c10bdhvtdxt6BJ2YVyO7cuke87pM0cvEVl X-Gm-Gg: Acq92OGHtAyHUmsNQk0T15SfXxby4cpC9ht8uyWQWnjcNPOwS9mG91br3+/+LOvrDVy yqLsTC6WOnY8dpewdhiKb6XO5IHheuTHrtKs4n1/4B1OY3DD5O8y0vDpk9v4cFy6eC9q9ChwC7p uJuJ3hT1k/IcbIQGIP4TnGJKPKaPoGOsSEegzuvYhVHKDek16KA0e6743nY6zKWYfsRbiJkgwQ/ bY9IrdggyWYzf8xlcbY5W+eHxK3WXGybEKncIGfdDe50A5tcS1eHy3xcLmTptMfquckDw3AqdZz BjvZDIc2oKNAG8JT04y2w2m6Tl5Cx0Lslf9pxJlXq8C4iAjP4Dj//4BdMF8x6NuBHtTCyh56S39 f5Tg+d0AluCbwiy9lDGos1u+4DdmnT1kXrOYlWkU/TAXzZJs8WFQUorNhLV6a8DRG/zWYsRqXcM 4jJ1r/SFGKKxHTUnJR0BtFC0Dl84hjaW52V71CyePwiA== X-Received: by 2002:a17:90b:33c1:b0:366:decb:d119 with SMTP id 98e67ed59e1d1-36a677303ccmr7921073a91.11.1779561274537; Sat, 23 May 2026 11:34:34 -0700 (PDT) Received: from archlinux ([205.254.163.44]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36a721c7baasm7002057a91.9.2026.05.23.11.34.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 May 2026 11:34:34 -0700 (PDT) From: Suchit Karunakaran To: andrii@kernel.org, eddyz87@gmail.com, ast@kernel.org, daniel@iogearbox.net, martin.lau@linux.dev, memxor@gmail.com, song@kernel.org, yonghong.song@linux.dev, shuah@kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Suchit Karunakaran Subject: [PATCH] bpf: replace pop/push emptiness check with bpf_list_empty() Date: Sun, 24 May 2026 00:04:22 +0530 Message-ID: <20260523183422.124105-1-suchitkarunakaran@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Simplify fq_flows_is_empty() by replacing the pop/push based emptiness check with a direct call to bpf_list_empty(). This avoids unnecessary list mutation and simplifies the code while preserving correctness. Signed-off-by: Suchit Karunakaran --- tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c b/tools/testi= ng/selftests/bpf/progs/bpf_qdisc_fq.c index 1a3233a275c7..3b05ac1d7c77 100644 --- a/tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c +++ b/tools/testing/selftests/bpf/progs/bpf_qdisc_fq.c @@ -197,17 +197,13 @@ static bool fq_flows_is_empty(struct bpf_list_head *head, struct bpf_spin_lock *lock) { struct bpf_list_node *node; + bool empty; =20 bpf_spin_lock(lock); - node =3D bpf_list_pop_front(head); - if (node) { - bpf_list_push_front(head, node); - bpf_spin_unlock(lock); - return false; - } + empty =3D bpf_list_empty(head); bpf_spin_unlock(lock); =20 - return true; + return empty; } =20 /* flow->age is used to denote the state of the flow (not-detached, detach= ed, throttled) --=20 2.54.0