From nobody Sun May 24 18:41:02 2026 Received: from mail-lj1-f170.google.com (mail-lj1-f170.google.com [209.85.208.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 099853016EE for ; Sat, 23 May 2026 16:54:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779555244; cv=none; b=YbCFzSZ9EtPjYKrLNv+ArLkZLWRhIvEMIGPPCyX8x4YaS7keYFC4xAgvCSsp/tdpAivXgW2fvBpFrPVp6KRV9DCNymCcw6rZgAEA8DF88h7izi0WysnJH7OIH95gSzht+KFfnnQtKQ/K2mkia3j2/dwA7sATWVP+EComDaWtNR0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779555244; c=relaxed/simple; bh=0MwoAX/J5bzYEqSgxGhyDDvWiurQkDJFryudRPqqyec=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FU38Q4PXGVjAcC30IHkPYBg3+4eGjqOLguKH144Y/Sh6cXaaybF+dqFRqJQhrk2ydh0Ry/Rflm0gqFFgM0DQgzrGNE3CtFJIea9TtYBahnMG7ADXPbTLFTpaSzpiHkJOsCWdiaUE0gdyAIylfiAHpnTnE8QsMHbLwRyhXjIHGXs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eBzvroCc; arc=none smtp.client-ip=209.85.208.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eBzvroCc" Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-39394e1e8f3so80117061fa.1 for ; Sat, 23 May 2026 09:54:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779555241; x=1780160041; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dUFxLs9xayiDL27YZLOgJaat3erm/tdOdPXhQ8ySemg=; b=eBzvroCcbMaioE1zTmmGAAnKkWj4XziwtoppjBPSUBHNYHhg3qi9Gr7E4g8wZFVOI4 ALMeVu73nA43EsF/pRe4mkwoV994r0VTNuts1NXsKIn954nW7koCN3vxRMpvbfxKu80w xycee3g/DQ1wJdk4Gvggg52Tl9GCgp8uVcKV9GpDx75STxoWMmYaDC2wZcyDaF3lWv1u HKsOR6yusvCSw1CCgHUg7opcGZmaKT68NehG9qh7dRmTS/4FcDL1vSHCbeM2H3zuF2Z4 BncHO7uvwvCjdO2C56tEpR/7QGuJKE9ES6B+NsFSwfxMnyVJ+EWtvOPLHiilwP4Rjg3b cBRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779555241; x=1780160041; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dUFxLs9xayiDL27YZLOgJaat3erm/tdOdPXhQ8ySemg=; b=b6+LF20i0x/SAW+ZUnAy410eFGrCA1BsjOveEUA7UwB9TSP9YHGvL6ccARP2XYGPxM lP24YUZX0HybcIBYtac3cOSVhRbwWfg1VhlK4rNlP/b0+ssGk2+97x1i0kEWQbbAk0bW 6mtVbiPNJzgQEA+0Zk95kr3wEYLsKo+r0ZCFzl66CQijn7Ua1Ro6XH4ynC22bDJ44ij5 SQ0//GP91xr9bfzC4VqdxEYD1kIw+VR8Mm7tCTRxESS66pqDk4bmBxPbnvDtnZ6rpaKj gigW4rXIWdMys00jiNXfe9o7TjXJ1edvQIKzEHe67flCbub15mhI0l9h7iGK2Cu6mKpt 41Kw== X-Forwarded-Encrypted: i=1; AFNElJ8hQGttbOunHmCgfj8YcFtrKZj76hP0S/R/7ME3Ik0NAX1Q0A/22uRpkPF1QarqJWdCgj1SARdXiAdspT8=@vger.kernel.org X-Gm-Message-State: AOJu0YxK7+tF7S/RUIVikKk4lylLn8FTnv5gn7dcrcrNM4j8EVlJC0hL asr3SQUOojLORAWeZdBsm31mtkNhoCwimqXbdzHuPPb5v4vszw5THPqHod0Su+ugO0bwaz5k X-Gm-Gg: Acq92OGD2MxxJ+IFJC49I7I3P/pPuM3hSTCUtcxsAuq7MWynBR/aUl6en62KXNz2SKf mXBCdzR9kFAE1+rILqX2X8CAHXOucAq3zdpJm+PQwUVtrLOCJAZ8PMlmk5znx0fzzk/z5Bm32bz imr8U0xe/sxGLTWOnD8F5lULNN78EJyIDxz6FPnICuK9F2B5PLvzNRBDjB/YBsyJeCZT8X5/bM4 nGKtd7FauT7ga08BU6bLHx2GcDZu4a9/vjArXYchUi3puGhG1MkhPzTbOA3EZl+Xj92Yd2HKY8k QbgBs59DhC+dTwRJBbx/oFUxIXYDrHTywK4uK0w0GqI7Tzsw7brqsTp1Vj22BJfe7xCN52Eim7m prV4feYqF785XL8+7nv5LIR7R9YNbV0+Q28KfYbI7Zz4fXsmf9TmcqzgoGTkmnC927hgySm07Q+ Gflx2pIjm/ZNNrZcOf9JC682C+9rzxY1CJ3b+qlCATxu5eJ4lQa69Ehk5iztWqZzo59emw4A== X-Received: by 2002:a05:651c:222c:b0:393:a4f5:3e0f with SMTP id 38308e7fff4ca-395d8c35f3fmr27895731fa.2.1779555241189; Sat, 23 May 2026 09:54:01 -0700 (PDT) Received: from va-HP-Pavilion-Desktop-595-p0xxx.mshome.net ([193.0.150.248]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-395dcc2c6efsm12092981fa.29.2026.05.23.09.54.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 May 2026 09:54:00 -0700 (PDT) From: Valery Borovsky To: mchehab@kernel.org, crope@iki.fi Cc: hverkuil+cisco@kernel.org, linux-media@vger.kernel.org, stable@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] media: rtl2832_sdr: release URBs and stream buffers on start_streaming() failure Date: Sat, 23 May 2026 19:53:58 +0300 Message-ID: <20260523165358.286293-1-vebohr@gmail.com> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260513055733.146905-1-vebohr@gmail.com> References: <20260513055733.146905-1-vebohr@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" rtl2832_sdr_start_streaming() calls rtl2832_sdr_alloc_stream_bufs(), rtl2832_sdr_alloc_urbs() and rtl2832_sdr_submit_urbs() in sequence and shares a single err: label that only unlocks the mutex and returns. When alloc_urbs() succeeds but submit_urbs() fails, or when alloc_urbs() itself returns -ENOMEM after alloc_stream_bufs() has already succeeded, the URBs and/or the coherent DMA stream buffers stay allocated while streaming reports failure to vb2. Two latent defects follow on the next VIDIOC_STREAMON: 1) rtl2832_sdr_alloc_stream_bufs() unconditionally resets dev->buf_num to 0 and overwrites dev->buf_list[]/dev->dma_addr[], permanently leaking the coherent DMA memory allocated by the previous attempt. 2) rtl2832_sdr_alloc_urbs() never resets dev->urbs_initialized and only increments it. After a second successful pass urbs_initialized can exceed MAX_BULK_BUFS, so the subsequent rtl2832_sdr_free_urbs() walks from urbs_initialized - 1 down to 0 and reads past the end of dev->urb_list[], passing garbage pointers to usb_free_urb(). Mirror the teardown that stop_streaming() already performs: on the error path call rtl2832_sdr_free_urbs() and rtl2832_sdr_free_stream_bufs() before unlocking. Both helpers are idempotent (free_urbs kills and zeros urbs_initialized; free_stream_bufs is gated on URB_BUF and clears the buf_num counter), so partial-failure paths and the no-allocation paths remain safe. Issue identified by automated review of the INV-003 series at https://sashiko.dev/ Fixes: 771138920eaf ("[media] rtl2832_sdr: Realtek RTL2832 SDR driver modul= e") Cc: stable@vger.kernel.org Signed-off-by: Valery Borovsky --- Changes since v1 (https://lore.kernel.org/linux-media/20260513055733.146905-1-vebohr@gmail.c= om/): - Rebased on media-committers/next. The err: label in rtl2832_sdr_start_streaming() now also calls rtl2832_sdr_cleanup_queued_bufs(dev, VB2_BUF_STATE_QUEUED) from commit 33ca0aab6f4b ("media: rtl2832_sdr: Return queued buffers on start_streaming() failure"); free_urbs()/free_stream_bufs() are placed before that cleanup, matching the order in stop_streaming(). No semantic change to v1. drivers/media/dvb-frontends/rtl2832_sdr.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/dvb-frontends/rtl2832_sdr.c b/drivers/media/dvb-= frontends/rtl2832_sdr.c index c564485e3bbb..036b67a17b7a 100644 --- a/drivers/media/dvb-frontends/rtl2832_sdr.c +++ b/drivers/media/dvb-frontends/rtl2832_sdr.c @@ -906,9 +906,12 @@ static int rtl2832_sdr_start_streaming(struct vb2_queu= e *vq, unsigned int count) goto err; =20 mutex_unlock(&dev->v4l2_lock); + return 0; =20 err: + rtl2832_sdr_free_urbs(dev); + rtl2832_sdr_free_stream_bufs(dev); rtl2832_sdr_cleanup_queued_bufs(dev, VB2_BUF_STATE_QUEUED); mutex_unlock(&dev->v4l2_lock); =20 --=20 2.51.0