From nobody Sun May 24 18:41:29 2026 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B126425B0B7 for ; Sat, 23 May 2026 15:41:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779550892; cv=none; b=q2kmIA6vW2QDIk0XK6h/9lgspkjAcDKwQqcJhAtFfgQyiRuxXU3mdQNDbsfISQT14vBv6qLn4dRWovFrDaaqQD8fUUPkQnbBK1cgXoOdHK0pGKtAGTbNfvbz4Ut9cGLgdDhQWZkb8TCZySTP/N8CFpCC3mdxEXNOFygJwqH1aIw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779550892; c=relaxed/simple; bh=k9DQFLyOPZaMcem5KR9RRkES9NlfScV5dCabMyfVUWU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=tAk5LLM/eg9ZgXSdUPktvLIu6PZ4zudx0YhGIJVMIXYyMsHfiyCvLDweSzsAoVguaXUlvs7UlWJ9SFe2LFt58nFoRQXGYwc1UcFkgL7wRCOCumGAiiL++X5TBrlf8HijcoaOtjulezJTNuKoNElQMxuRT3Athc0rwWyBLUOcZWA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XoN56uo/; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XoN56uo/" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-367d88b9940so5477257a91.1 for ; Sat, 23 May 2026 08:41:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779550890; x=1780155690; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=tlfATX24+gOXKKLMuPk5Ufobg0T/xx+iuzrEcxjjNAY=; b=XoN56uo/T2W1Clm4grdYdjDCrRqw3AxxZYhSdZtOsUJXKrjq8S/BJ+gkv4aBepvOpz T5qJg9wP8kSxWe7gYF3atGPUF9EFMN2j49l7KdITBov3RsYhUXjEyF1YGF9KJC28mru5 rM3fh19tH8PhvxkN4fAWWafC2XpncsNY+3WuWddXFsY953ic5Dwr+OFjlcRi4B0rqURq b1oSZEOxE8i7HhmVYqcXyzdykzyzCWl4exi7k0TSdm/R/JbLEafmdwtm5SsIzZ8VG1Ji XjprnvDckPd79h+3JcTqFJJJUarad36DaqaEy2wzIpM9GKUYDkCUm/Ht01GI36yjMQAJ 2URQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779550890; x=1780155690; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=tlfATX24+gOXKKLMuPk5Ufobg0T/xx+iuzrEcxjjNAY=; b=BrNsTttOTXIHavbLv2IqKbQjcT9BTw623TFmNz/8gsjVSfC9WTut10xnd7p4anmFQD I3bYpL+oCbJRyLbrnqjGzfcYD+kcEd0THXX76mbWIWEG5C/cPukIX9OtygJJ6i3tbM/U eXs/4jYfHjh5/IrYp9cSeDfgJdhjbNXn8PeonY0Nd/wFZ04hGAEHLH3C3GvNX7zhUNcH 1vWM/oPh8VoWw8Nav797nkkbTNEQ0sClVziDYIMOwc2JX4pcguRCNmY9x5NC0YyYCumF EXUAH6QFODVCCAUdPsdmjesRpn41FNiDNGjN/CztiOSv3MAhE4fY47aFHsSvjBiT3FiM lyzQ== X-Forwarded-Encrypted: i=1; AFNElJ9RfkPU5lbZOERywFy/DRQG2onnuB1okXRAT3QN5AgNgUjZrJ5c8k/vsvCiNSTmQmpQ/U5IIcP9PzmhIsg=@vger.kernel.org X-Gm-Message-State: AOJu0YzAn60ld77tKfPju5uhUj+3nxdeGG61MbD5Yqv1qzMxf2m9NaM1 0Em0lxqKs8tR+Ua+/kjzLrLTtEEUOaHXIby9FBeG/g1JOgNd8L5P9TbZ X-Gm-Gg: Acq92OF9c4LGcjhcV4wEztHxQZC1guh84zir4mfyPoWfEIG+I9S8v+EQkSMM96+ASIY SqtKiXcVbFbPxBGsXvI0uZm20sR9KKL/HonVAQgn8Om0b8tIYKNgu+Gh4uqLE2Qm5QrctqHea5e Wzmek30TzH7BlJbcwVUpKcAB4v6508KjjrR/J3p+2BH9sIGlwwLqhkLm8eoFuyIkUoe36iKW0wt qbdosodDNbvTumpQOFDtJEOcvKb3dFxWg2GK0IMV67ZihQS8aIZmznPM9LNRa0qCq63oP0Aj+C9 P9HG6f6f1eXsB2rYvg+vQ2d+v0Jxlg5lZxwj09anrXgUjevCXxdUJitZwX+gKsPqQ2WEo9rXKqG kHDEWzc54WYX6dlQQlhHoNIKZxHtVNA58CYGhQGJgXFqrZb/6zdUNNxNhrfiS7Rhfns1czy7jcN LiR1WoEDjJQ8d1GDMWVZrH8BHA4S75sCCvq6juWOJW5vXzRTMVZ5G7yIVB5mqeP+NwizpGWLc/o 6o= X-Received: by 2002:a17:903:19e8:b0:2b0:6e4a:32d0 with SMTP id d9443c01a7336-2beb06a6053mr89764875ad.35.1779550889927; Sat, 23 May 2026 08:41:29 -0700 (PDT) Received: from nixos-office (mx-ll-171.5.30-148.dynamic.3bb.co.th. [171.5.30.148]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2beb5695c40sm45239765ad.5.2026.05.23.08.41.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 May 2026 08:41:28 -0700 (PDT) Sender: Julian Braha From: Julian Braha To: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, airlied@gmail.com, simona@ffwll.ch Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Julian Braha Subject: [PATCH v2] drm/i915: use 'depends on' with visible DEBUG_OBJECTS for DRM_I915_DEBUG and DRM_I915_SW_FENCE_DEBUG_OBJECTS Date: Sat, 23 May 2026 16:41:21 +0100 Message-ID: <20260523154121.147103-1-julianbraha@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" A previous version of this patch[1] accidentally introduced an unmet dependency bug, because DRM_I915_DEBUG selects DRM_I915_SW_FENCE_DEBUG_OBJECTS without also depending on DEBUG_OBJECTS. DRM_I915_SW_FENCE_DEBUG_OBJECTS currently selects DEBUG_OBJECTS even though DEBUG_OBJECTS is visible to users. Other config options use 'depends on' for DEBUG_OBJECTS, so let's do the same here. This select-visible Kconfig misusage was detected by Kconfirm, a static analysis tool for Kconfig. Link 1: https://lore.kernel.org/all/20260502191932.4491-1-julianbraha@gmail= .com/ Signed-off-by: Julian Braha --- v2: - select PREEMPT_COUNT, avoid recursive dependency drivers/gpu/drm/i915/Kconfig.debug | 3 ++- lib/Kconfig.debug | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kcon= fig.debug index 3562a02ef7ad..657cdf49181e 100644 --- a/drivers/gpu/drm/i915/Kconfig.debug +++ b/drivers/gpu/drm/i915/Kconfig.debug @@ -35,6 +35,7 @@ config DRM_I915_REPLAY_GPU_HANGS_API =20 config DRM_I915_DEBUG bool "Enable additional driver debugging" + depends on DEBUG_OBJECTS depends on DRM_I915 depends on EXPERT # only for developers depends on !COMPILE_TEST # never built by robots @@ -153,7 +154,7 @@ config DRM_I915_TRACE_GTT config DRM_I915_SW_FENCE_DEBUG_OBJECTS bool "Enable additional driver debugging for fence objects" depends on DRM_I915 - select DEBUG_OBJECTS + depends on DEBUG_OBJECTS default n help Choose this option to turn on extra driver debugging that may affect diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 8ff5adcfe1e0..6501b7040706 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -760,7 +760,7 @@ source "mm/Kconfig.debug" =20 config DEBUG_OBJECTS bool "Debug object operations" - depends on PREEMPT_COUNT || !DEFERRED_STRUCT_PAGE_INIT + select PREEMPT_COUNT if !DEFERRED_STRUCT_PAGE_INIT depends on DEBUG_KERNEL help If you say Y here, additional code will be inserted into the --=20 2.54.0