From nobody Sun May 24 19:33:15 2026 Received: from mail-dy1-f193.google.com (mail-dy1-f193.google.com [74.125.82.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4F7692F1FDE for ; Sat, 23 May 2026 11:04:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.193 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779534247; cv=none; b=qkOXuJ0NsEiZwocEiRFb20dT5dvSIbwm+w6EMVuDzOAJIB88Gm1ApYjWizq7+dJSra5RuNGa0d+Ckwc+lV2OXBGsFXoX2vc1bD/X1pQ0Ix5pz+FKzAjP5EYSr2ngJPSw4Erjk5R6ztSjlzUO/xIYYGyYDmbpjPtNJuMI0uA6j1g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779534247; c=relaxed/simple; bh=Z6sRU9iMcF8zzNfNxCjZZ938y76nz9plm87nRXx0LvA=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=Tx7nsx2iHO7G4ZSrfi5R4ivV0ttDMIUF1I1MKIxI3NJBPpzgM7Fsa+6UR3Ta8VeRSLvjJLqgIO25R4s2JwSfcNLLYAkdDWCas8cc+zx59o5qCcYL3u8gmxY7ipRWP0IWx8oCkv/IJK1zQgNJdBU2StBHrJPS9HgW2zAzVsNdZCY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nr4CMXJj; arc=none smtp.client-ip=74.125.82.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nr4CMXJj" Received: by mail-dy1-f193.google.com with SMTP id 5a478bee46e88-2ef2a1cc06dso12928950eec.0 for ; Sat, 23 May 2026 04:04:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779534245; x=1780139045; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=qv+Kb9SdkLktiClnXVwCIDMjCalpuoRwuQC/kT8PQ9o=; b=nr4CMXJj+NI9V3PUWAR1efgDMJfO9jL41IxoJpYjw6c0DhSwlSJJXgaTtf1aqi8dr8 j3HRBLRdNYtYRVK+YwrVDf0qPLubJhVVZeD1Bk5Wl9Q1iQd9K0sWrD3CNoFXIpItpvUA lfXrZ1xZecvIhayanbgW8pGs8FueKsOUB/1vCzAM/qAOO3CoHvZ/C1AD+rwWZ4nrA+Mu QuQ5gXl9mTh7lRdvJ4LJRdvi7con+L5KxlwTgBMF/Mw3kT8mg/NxRSfPUt9YTcpBpgJC ZDLzANw9Q0ldUlBRjLrjJF6Yc8Gt7sbLOSwJGcvtMKoDR3CKblzFcAUi7Xwm8DlLqIhp EixQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779534245; x=1780139045; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=qv+Kb9SdkLktiClnXVwCIDMjCalpuoRwuQC/kT8PQ9o=; b=RumQ5n5Chy3P696ttYLx16oc9LLRYwPwjizhelXPQ4zcl0JSxFCfWez7WRigunAXmH ejHrOTFErXh6ZLniVtfIDbJKpMKyAxpCzF+Ei/3ImzMBaGaAswCsvUw339IIDK3EoM0P +ObFT357+9hvtoqt/giBs0nESRX2U1FWZOmDdi087mE8bnVDOqLog1IRhIa32u3ReWSJ tROibgqVIEre8gFRRyOpo8hgjTYstXiFpiX6WVOYPjY9tUVuChODvEJFHDnJQNctyfuQ GwVsXzNWGDA+XIOJD+mPnLm8uPf/56WmrxPATUBIHgvTCoI8I7wTwWvHrVghzXkWmtX8 sKew== X-Forwarded-Encrypted: i=1; AFNElJ8tgPRNMgw1Vgc3t1wvGY+1GigEcoZqjPLynIIYXStGBIA/s7HsTgZBXPfr4AqTYKd6f9M2Q2W/5vsmHUk=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0VQkbfGSDonT7nsq/DSKmJMfXgIuXkDQ65xEPpdmJ92QEqUo7 /HmMjdle61Tk97OPXBvdo2QD1QnVOz0sPbi5GQ6DTfUp6F1t2i8k25yX X-Gm-Gg: Acq92OEQxhxLACbKu644neb7qI5MsB/2j0PnaQWTs11r/VtgcjZkSoQe8OQD6IPPfGh ICoDhS6HpWWh1Uej/VDcSbPLrJovYguhjBsSYc6ExRdO9C84l7DSjteDl/QUrbG4tVGYXMm/bqR tQYZM6D7A4NPIWWPpJmOdCYkxuydKn4/udi1z70qMyEnEuRI2z89yGE+5o+mHw3mdCgyLaqf6Xi yE6NAV3FJ6UHPmDDDcU9bm5sCPVkS6FTvV3r2z2N6hC4iyepPj/e2yxpOnyuTFgg91PaH9T1vyY re32+VXL1Me8I025e6ZQQQ47aJLfn+0nEihtk/VqXtuMtHvPGC+7aWUvO9AG2x9i4ElGh9Dvtso HSCgeTeDJ4/T15PdP8bUM/Enc9HvkNhWAHgET4X1pWNMi42UdXSfeXfIxbxUIjRrVo0oxcAsakK v3gruUFbgLJCYn6hxyB4ysjs4LdDy/zWaNCg5WJ0aWe2PRwyK8GZ++2gRhS8sa29WdsQ== X-Received: by 2002:a05:7301:1f06:b0:304:2c71:3f65 with SMTP id 5a478bee46e88-304491fbcc0mr3959114eec.33.1779534245433; Sat, 23 May 2026 04:04:05 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30451f20e71sm3139962eec.12.2026.05.23.04.04.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 May 2026 04:04:05 -0700 (PDT) From: Hungyu Lin To: subash.a.kasiviswanathan@oss.qualcomm.com, sean.tranchetti@oss.qualcomm.com Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Hungyu Lin Subject: [PATCH] net: qualcomm: rmnet: clarify MAP command ACK behavior Date: Sat, 23 May 2026 11:03:46 +0000 Message-Id: <20260523110346.1672-1-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" rmnet_map_command() only sends ACK responses for supported commands. Unsupported commands are dropped without sending a response. Update the comment to reflect the current behavior. Signed-off-by: Hungyu Lin --- drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c b/driv= ers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c index add0f5ade2e6..c1c3d4fc7a99 100644 --- a/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c +++ b/drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c @@ -69,8 +69,8 @@ static void rmnet_map_send_ack(struct sk_buff *skb, netif_tx_unlock(dev); } =20 -/* Process MAP command frame and send N/ACK message as appropriate. Messag= e cmd - * name is decoded here and appropriate handler is called. +/* Process MAP command frame and send ACK message for supported commands. + * Message cmd name is decoded here and the appropriate handler is called. */ void rmnet_map_command(struct sk_buff *skb, struct rmnet_port *port) { --=20 2.34.1