From nobody Sun May 24 20:33:20 2026
Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com
 [209.85.216.47])
	(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7329922157B
	for <linux-kernel@vger.kernel.org>; Sat, 23 May 2026 03:57:43 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org;
 arc=none smtp.client-ip=209.85.216.47
ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1779508665; cv=none;
 b=HdDoJGptn1PlcKkaybut2iDRb2PvgKX48m55F9ckqdjTNFc40DlqHFCiUP/PWUPecnP1c4w0DEuvBID/vMegxQXF8l++Rrz2UExjVxSmFUsWBZQQPVjeuS+dYkv06lD+YSOD/XR5d6V2e3mO5ufr6JvkMZ2y6QMyqeLRrA2ceIs=
ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1779508665; c=relaxed/simple;
	bh=iedao6Ygs4sHh2fxSj1MwXr8IXw5fQoHXVO5DORa55Q=;
	h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type;
 b=JLKVU+Ti/PIhw8PRsCWlU+VqN4oPJbk8OxO95aYK2p+R7dZ+oq3e/246pyk3XTgtHhjQPp4TzvkuEGjqX727y39cSnji1W5nR/tlL0C+eqpt3pdJ5BfdjF3a7HXO1PRbdj9/T5SZGUOPM0CKUKNEV2wdRliaLKzG08Odtg9tWDw=
ARC-Authentication-Results: i=1; smtp.subspace.kernel.org;
 dmarc=pass (p=none dis=none) header.from=gmail.com;
 spf=pass smtp.mailfrom=gmail.com;
 dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b=B5v919ys; arc=none smtp.client-ip=209.85.216.47
Authentication-Results: smtp.subspace.kernel.org;
 dmarc=pass (p=none dis=none) header.from=gmail.com
Authentication-Results: smtp.subspace.kernel.org;
 spf=pass smtp.mailfrom=gmail.com
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com
 header.b="B5v919ys"
Received: by mail-pj1-f47.google.com with SMTP id
 98e67ed59e1d1-367cbac9cb1so7586214a91.3
        for <linux-kernel@vger.kernel.org>;
 Fri, 22 May 2026 20:57:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=20251104; t=1779508663; x=1780113463;
 darn=vger.kernel.org;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:from:to:cc:subject:date:message-id:reply-to;
        bh=zaTsiEXwtDm0P7DS42R5+7UDMEhgxJ2oBOfUIkmvUIk=;
        b=B5v919ysoPB0j1tkgb9nYLN0InUVPpskoFGpP/6uN4LBGHF9ZVaIlljiw3ux86UD/W
         Y/SGvrB6gjwEEFjs01N0zYymyfU5ZHi3iUKp2nVRtSPN/0p7E/fOUFwJfK+nVX/qJ7rE
         U7oCIEuClnh2rn3K+Xn6yY/UJOQ59w85ocFsI/LKy/F4I/fheWiim+l2dSokRsmhvxaV
         TRYkiuMHSytcKi2D9WPS5PKGcB9GgsX1DrnEHoxARWRve12N3FPXfMADF68gA40viMSU
         gr5tGXJHyqPWec+MHiyD3GjySaQz1n22PrXtijoB6ViMzgOtS+t7irE6p8IdnV+gm6QY
         oQCQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20251104; t=1779508663; x=1780113463;
        h=content-transfer-encoding:mime-version:message-id:date:subject:cc
         :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date
         :message-id:reply-to;
        bh=zaTsiEXwtDm0P7DS42R5+7UDMEhgxJ2oBOfUIkmvUIk=;
        b=CwE7iuJiylUrDlU8U5qmADXyRNOjX81BJTcYg8aqspe5lwfmAbVO0ba09OLH71Oyfh
         c0C6tuuMjhjY/zCP6IhGQNxeAh2L4Pmt67foNTmiW8bUoPO3fadghNr64stK7PDGvYbf
         oEKp7++V4zEOcDTqizM4ctaXCJvTtRBvx5VDUIUy40MecbmWoY+6gxzvzXxMkqbaUSvh
         0wziFnxuZGyUl4VdX1AsWQbQHqmyS7dCA72kYwYkVmAfONqGD+RAdj70CNF3unJBvtNz
         hm+72Cn7C8Jd9Lln0NrRPCvHwJXJ/Xtg2kDrriL6FgHOeBqP8Ox4E/pwuFRItg0+DukF
         MRCw==
X-Forwarded-Encrypted: i=1;
 AFNElJ8s8cOZ4loQlAOUeg2AApExpKuVjH8HZ8TZa83dJYhH6g8axlP/fZo7C+8gMkXvdspDMYG3quyfMhAVBjo=@vger.kernel.org
X-Gm-Message-State: AOJu0YxEUvTL4HmKcP1YQsdpCcvLWkejIeQhKNW0rxJ2R/PiwnPbtCAk
	sd7XGrv9wpbr7BJ4vCQBasHN4UE1pDVf/Z9hvN3G0+Xf9JhkDbZoivZN
X-Gm-Gg: Acq92OGE6SJGP/a3IgfU/KNtN20gyC4cd/WMsrV640hgIyM+63zcpax3u8jrwEa0FIu
	KwcdhQiJ8xTStcOKFHAm5t+rNkeS9g6ZFYrRY7syTznp857AVPn3mWN5+w2q8JAdpGZ0HKqZ+zI
	YkE+3OJA3gp0BDn3ySPHaGU9iFxWriqM4jb+WidS7htE/ciExjkHBA4PwDy5O/T6WXxnfx/3Lj+
	fiW3FutkpWzt8OJrFCwh68q0kouHA2P1FfrzE1m2pPpzn0iQq4UcCw4uW9V7neXXZLs7Q/w4vOX
	FQjO1btTxA8WYGwv5whQscjYpy60hZBcruntR5QDNc1Oqxsc4pKCLOIaNcbL9xXvk1gjVm7K64F
	236KKS7XGGa9sjzUpfQF8Xn90d5rslGmqsPty5SsD/02ITmHPuWDNYo9EAZL1F16Wf0+adOCQlM
	RfQYyRuSmu+6w0xwyB9ECoH1/MRYMlltWh5aJ2eO35zzeyxErdAZ3ckS9r/KAjTXNBfSjczmPpQ
	DsLat1LKuNhAVXVv6U07dl/uKYaCgpdi5LvRE9bkQllu4ilLGFF7XNwoW++v8iLsc4nVX8u/RX0
	nFvTsqNaK4R3Aw==
X-Received: by 2002:a17:90b:3791:b0:36a:a16b:5f65 with SMTP id
 98e67ed59e1d1-36aa16b65e4mr391911a91.11.1779508662455;
        Fri, 22 May 2026 20:57:42 -0700 (PDT)
Received: from cmpatel-home.hsd1.or.comcast.net
 ([2601:1c0:5780:9200:108d:469b:1b:5f15])
        by smtp.gmail.com with ESMTPSA id
 98e67ed59e1d1-36a721c7cf9sm3280702a91.10.2026.05.22.20.57.41
        (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
        Fri, 22 May 2026 20:57:42 -0700 (PDT)
From: Chintan Patel <chintanlike@gmail.com>
To: sumit.semwal@linaro.org,
	neil.armstrong@linaro.org
Cc: dianders@chromium.org,
	jesszhan0024@gmail.com,
	maarten.lankhorst@linux.intel.com,
	mripard@kernel.org,
	tzimmermann@suse.de,
	airlied@gmail.com,
	simona@ffwll.ch,
	dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org,
	Chintan Patel <chintanlike@gmail.com>
Subject: [PATCH v3] drm/panel: novatek-nt36672a: Inline panel init sequences
Date: Fri, 22 May 2026 20:57:34 -0700
Message-ID: <20260523035734.6602-1-chintanlike@gmail.com>
X-Mailer: git-send-email 2.43.0
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Inline the panel initialization command sequences and remove the
table-based command abstraction used by the NT36672A panel driver.

Replace the nt36672a_panel_cmd tables and nt36672a_send_cmds()
helper with explicit initialization functions using
mipi_dsi_dcs_write_seq_multi() and
mipi_dsi_dcs_write_var_seq_multi() directly.

This improves readability by making the panel programming sequence
explicit in code and allows future sharing of common command
subsequences between panels. It also removes an unnecessary wrapper
around the MIPI DSI helpers.

Additionally, compress repeated register writes into small loops where
appropriate to reduce duplication in the initialization sequences.

Add:
tianma_fhd_video_send_init_cmds_1()
tianma_fhd_video_send_init_cmds_2()
tianma_fhd_video_send_deinit_cmds()

Update nt36672a_panel_desc to use function pointers for panel init
sequences and invoke them directly from prepare/unprepare paths.

Signed-off-by: Chintan Patel <chintanlike@gmail.com>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
---
Changes in v3:
- Rename on_init_1/on_init_2/off_init to send_init_cmds_1/send_init_cmds_2/=
send_deinit_cmds
- Convert all hex values to lowercase (0xFF =E2=86=92 0xff) per kernel codi=
ng standards

Changes in v2:
- Replace command tables with explicit init functions
- Remove nt36672a_send_cmds() helper entirely
- Use mipi_dsi_dcs_write_seq_multi() directly
- Use mipi_dsi_dcs_write_var_seq_multi() loops for repeated register writes
- Convert nt36672a_panel_desc command table fields to function pointers
---
 .../gpu/drm/panel/panel-novatek-nt36672a.c    | 522 +++++++-----------
 1 file changed, 186 insertions(+), 336 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c b/drivers/gpu/d=
rm/panel/panel-novatek-nt36672a.c
index 7e8b5e059575..464d9ce47d87 100644
--- a/drivers/gpu/drm/panel/panel-novatek-nt36672a.c
+++ b/drivers/gpu/drm/panel/panel-novatek-nt36672a.c
@@ -28,10 +28,6 @@
=20
 #include <video/mipi_display.h>
=20
-struct nt36672a_panel_cmd {
-	const char data[2];
-};
-
 static const char * const nt36672a_regulator_names[] =3D {
 	"vddio",
 	"vddpos",
@@ -55,13 +51,9 @@ struct nt36672a_panel_desc {
 	enum mipi_dsi_pixel_format format;
 	unsigned int lanes;
=20
-	unsigned int num_on_cmds_1;
-	const struct nt36672a_panel_cmd *on_cmds_1;
-	unsigned int num_on_cmds_2;
-	const struct nt36672a_panel_cmd *on_cmds_2;
-
-	unsigned int num_off_cmds;
-	const struct nt36672a_panel_cmd *off_cmds;
+	void (*send_init_cmds_1)(struct mipi_dsi_multi_context *dsi_ctx);
+	void (*send_init_cmds_2)(struct mipi_dsi_multi_context *dsi_ctx);
+	void (*send_deinit_cmds)(struct mipi_dsi_multi_context *dsi_ctx);
 };
=20
 struct nt36672a_panel {
@@ -79,19 +71,6 @@ static inline struct nt36672a_panel *to_nt36672a_panel(s=
truct drm_panel *panel)
 	return container_of(panel, struct nt36672a_panel, base);
 }
=20
-static void nt36672a_send_cmds(struct mipi_dsi_multi_context *dsi_ctx,
-			       const struct nt36672a_panel_cmd *cmds, int num)
-{
-	unsigned int i;
-
-	for (i =3D 0; i < num; i++) {
-		const struct nt36672a_panel_cmd *cmd =3D &cmds[i];
-
-		/* cmd->data[0] is the DCS command, cmd->data[1] is the parameter */
-		mipi_dsi_dcs_write_buffer_multi(dsi_ctx, cmd->data, sizeof(cmd->data));
-	}
-}
-
 static void nt36672a_panel_power_off(struct drm_panel *panel)
 {
 	struct nt36672a_panel *pinfo =3D to_nt36672a_panel(panel);
@@ -110,8 +89,8 @@ static int nt36672a_panel_unprepare(struct drm_panel *pa=
nel)
 	struct mipi_dsi_multi_context dsi_ctx =3D { .dsi =3D pinfo->link };
=20
 	/* send off cmds */
-	nt36672a_send_cmds(&dsi_ctx, pinfo->desc->off_cmds,
-			   pinfo->desc->num_off_cmds);
+	if (pinfo->desc->send_deinit_cmds)
+		pinfo->desc->send_deinit_cmds(&dsi_ctx);
=20
 	/* Reset error to continue with display off even if send_cmds failed */
 	dsi_ctx.accum_err =3D 0;
@@ -162,8 +141,8 @@ static int nt36672a_panel_prepare(struct drm_panel *pan=
el)
 	dsi_ctx.accum_err =3D nt36672a_panel_power_on(pinfo);
=20
 	/* send first part of init cmds */
-	nt36672a_send_cmds(&dsi_ctx, pinfo->desc->on_cmds_1,
-			   pinfo->desc->num_on_cmds_1);
+	if (pinfo->desc->send_init_cmds_1)
+		pinfo->desc->send_init_cmds_1(&dsi_ctx);
=20
 	mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx);
=20
@@ -173,8 +152,8 @@ static int nt36672a_panel_prepare(struct drm_panel *pan=
el)
 	mipi_dsi_dcs_set_display_on_multi(&dsi_ctx);
=20
 	/* Send rest of the init cmds */
-	nt36672a_send_cmds(&dsi_ctx, pinfo->desc->on_cmds_2,
-			   pinfo->desc->num_on_cmds_2);
+	if (pinfo->desc->send_init_cmds_2)
+		pinfo->desc->send_init_cmds_2(&dsi_ctx);
=20
 	mipi_dsi_msleep(&dsi_ctx, 120);
=20
@@ -213,310 +192,184 @@ static const struct drm_panel_funcs panel_funcs =3D=
 {
 	.get_modes =3D nt36672a_panel_get_modes,
 };
=20
-static const struct nt36672a_panel_cmd tianma_fhd_video_on_cmds_1[] =3D {
+static void tianma_fhd_video_send_init_cmds_1(struct mipi_dsi_multi_contex=
t *dsi_ctx)
+{
+	u8 reg;
+
 	/* skin enhancement mode */
-	{ .data =3D {0xFF, 0x22} },
-	{ .data =3D {0x00, 0x40} },
-	{ .data =3D {0x01, 0xC0} },
-	{ .data =3D {0x02, 0x40} },
-	{ .data =3D {0x03, 0x40} },
-	{ .data =3D {0x04, 0x40} },
-	{ .data =3D {0x05, 0x40} },
-	{ .data =3D {0x06, 0x40} },
-	{ .data =3D {0x07, 0x40} },
-	{ .data =3D {0x08, 0x40} },
-	{ .data =3D {0x09, 0x40} },
-	{ .data =3D {0x0A, 0x40} },
-	{ .data =3D {0x0B, 0x40} },
-	{ .data =3D {0x0C, 0x40} },
-	{ .data =3D {0x0D, 0x40} },
-	{ .data =3D {0x0E, 0x40} },
-	{ .data =3D {0x0F, 0x40} },
-	{ .data =3D {0x10, 0x40} },
-	{ .data =3D {0x11, 0x50} },
-	{ .data =3D {0x12, 0x60} },
-	{ .data =3D {0x13, 0x70} },
-	{ .data =3D {0x14, 0x58} },
-	{ .data =3D {0x15, 0x68} },
-	{ .data =3D {0x16, 0x78} },
-	{ .data =3D {0x17, 0x77} },
-	{ .data =3D {0x18, 0x39} },
-	{ .data =3D {0x19, 0x2D} },
-	{ .data =3D {0x1A, 0x2E} },
-	{ .data =3D {0x1B, 0x32} },
-	{ .data =3D {0x1C, 0x37} },
-	{ .data =3D {0x1D, 0x3A} },
-	{ .data =3D {0x1E, 0x40} },
-	{ .data =3D {0x1F, 0x40} },
-	{ .data =3D {0x20, 0x40} },
-	{ .data =3D {0x21, 0x40} },
-	{ .data =3D {0x22, 0x40} },
-	{ .data =3D {0x23, 0x40} },
-	{ .data =3D {0x24, 0x40} },
-	{ .data =3D {0x25, 0x40} },
-	{ .data =3D {0x26, 0x40} },
-	{ .data =3D {0x27, 0x40} },
-	{ .data =3D {0x28, 0x40} },
-	{ .data =3D {0x2D, 0x00} },
-	{ .data =3D {0x2F, 0x40} },
-	{ .data =3D {0x30, 0x40} },
-	{ .data =3D {0x31, 0x40} },
-	{ .data =3D {0x32, 0x40} },
-	{ .data =3D {0x33, 0x40} },
-	{ .data =3D {0x34, 0x40} },
-	{ .data =3D {0x35, 0x40} },
-	{ .data =3D {0x36, 0x40} },
-	{ .data =3D {0x37, 0x40} },
-	{ .data =3D {0x38, 0x40} },
-	{ .data =3D {0x39, 0x40} },
-	{ .data =3D {0x3A, 0x40} },
-	{ .data =3D {0x3B, 0x40} },
-	{ .data =3D {0x3D, 0x40} },
-	{ .data =3D {0x3F, 0x40} },
-	{ .data =3D {0x40, 0x40} },
-	{ .data =3D {0x41, 0x40} },
-	{ .data =3D {0x42, 0x40} },
-	{ .data =3D {0x43, 0x40} },
-	{ .data =3D {0x44, 0x40} },
-	{ .data =3D {0x45, 0x40} },
-	{ .data =3D {0x46, 0x40} },
-	{ .data =3D {0x47, 0x40} },
-	{ .data =3D {0x48, 0x40} },
-	{ .data =3D {0x49, 0x40} },
-	{ .data =3D {0x4A, 0x40} },
-	{ .data =3D {0x4B, 0x40} },
-	{ .data =3D {0x4C, 0x40} },
-	{ .data =3D {0x4D, 0x40} },
-	{ .data =3D {0x4E, 0x40} },
-	{ .data =3D {0x4F, 0x40} },
-	{ .data =3D {0x50, 0x40} },
-	{ .data =3D {0x51, 0x40} },
-	{ .data =3D {0x52, 0x40} },
-	{ .data =3D {0x53, 0x01} },
-	{ .data =3D {0x54, 0x01} },
-	{ .data =3D {0x55, 0xFE} },
-	{ .data =3D {0x56, 0x77} },
-	{ .data =3D {0x58, 0xCD} },
-	{ .data =3D {0x59, 0xD0} },
-	{ .data =3D {0x5A, 0xD0} },
-	{ .data =3D {0x5B, 0x50} },
-	{ .data =3D {0x5C, 0x50} },
-	{ .data =3D {0x5D, 0x50} },
-	{ .data =3D {0x5E, 0x50} },
-	{ .data =3D {0x5F, 0x50} },
-	{ .data =3D {0x60, 0x50} },
-	{ .data =3D {0x61, 0x50} },
-	{ .data =3D {0x62, 0x50} },
-	{ .data =3D {0x63, 0x50} },
-	{ .data =3D {0x64, 0x50} },
-	{ .data =3D {0x65, 0x50} },
-	{ .data =3D {0x66, 0x50} },
-	{ .data =3D {0x67, 0x50} },
-	{ .data =3D {0x68, 0x50} },
-	{ .data =3D {0x69, 0x50} },
-	{ .data =3D {0x6A, 0x50} },
-	{ .data =3D {0x6B, 0x50} },
-	{ .data =3D {0x6C, 0x50} },
-	{ .data =3D {0x6D, 0x50} },
-	{ .data =3D {0x6E, 0x50} },
-	{ .data =3D {0x6F, 0x50} },
-	{ .data =3D {0x70, 0x07} },
-	{ .data =3D {0x71, 0x00} },
-	{ .data =3D {0x72, 0x00} },
-	{ .data =3D {0x73, 0x00} },
-	{ .data =3D {0x74, 0x06} },
-	{ .data =3D {0x75, 0x0C} },
-	{ .data =3D {0x76, 0x03} },
-	{ .data =3D {0x77, 0x09} },
-	{ .data =3D {0x78, 0x0F} },
-	{ .data =3D {0x79, 0x68} },
-	{ .data =3D {0x7A, 0x88} },
-	{ .data =3D {0x7C, 0x80} },
-	{ .data =3D {0x7D, 0x80} },
-	{ .data =3D {0x7E, 0x80} },
-	{ .data =3D {0x7F, 0x00} },
-	{ .data =3D {0x80, 0x00} },
-	{ .data =3D {0x81, 0x00} },
-	{ .data =3D {0x83, 0x01} },
-	{ .data =3D {0x84, 0x00} },
-	{ .data =3D {0x85, 0x80} },
-	{ .data =3D {0x86, 0x80} },
-	{ .data =3D {0x87, 0x80} },
-	{ .data =3D {0x88, 0x40} },
-	{ .data =3D {0x89, 0x91} },
-	{ .data =3D {0x8A, 0x98} },
-	{ .data =3D {0x8B, 0x80} },
-	{ .data =3D {0x8C, 0x80} },
-	{ .data =3D {0x8D, 0x80} },
-	{ .data =3D {0x8E, 0x80} },
-	{ .data =3D {0x8F, 0x80} },
-	{ .data =3D {0x90, 0x80} },
-	{ .data =3D {0x91, 0x80} },
-	{ .data =3D {0x92, 0x80} },
-	{ .data =3D {0x93, 0x80} },
-	{ .data =3D {0x94, 0x80} },
-	{ .data =3D {0x95, 0x80} },
-	{ .data =3D {0x96, 0x80} },
-	{ .data =3D {0x97, 0x80} },
-	{ .data =3D {0x98, 0x80} },
-	{ .data =3D {0x99, 0x80} },
-	{ .data =3D {0x9A, 0x80} },
-	{ .data =3D {0x9B, 0x80} },
-	{ .data =3D {0x9C, 0x80} },
-	{ .data =3D {0x9D, 0x80} },
-	{ .data =3D {0x9E, 0x80} },
-	{ .data =3D {0x9F, 0x80} },
-	{ .data =3D {0xA0, 0x8A} },
-	{ .data =3D {0xA2, 0x80} },
-	{ .data =3D {0xA6, 0x80} },
-	{ .data =3D {0xA7, 0x80} },
-	{ .data =3D {0xA9, 0x80} },
-	{ .data =3D {0xAA, 0x80} },
-	{ .data =3D {0xAB, 0x80} },
-	{ .data =3D {0xAC, 0x80} },
-	{ .data =3D {0xAD, 0x80} },
-	{ .data =3D {0xAE, 0x80} },
-	{ .data =3D {0xAF, 0x80} },
-	{ .data =3D {0xB7, 0x76} },
-	{ .data =3D {0xB8, 0x76} },
-	{ .data =3D {0xB9, 0x05} },
-	{ .data =3D {0xBA, 0x0D} },
-	{ .data =3D {0xBB, 0x14} },
-	{ .data =3D {0xBC, 0x0F} },
-	{ .data =3D {0xBD, 0x18} },
-	{ .data =3D {0xBE, 0x1F} },
-	{ .data =3D {0xBF, 0x05} },
-	{ .data =3D {0xC0, 0x0D} },
-	{ .data =3D {0xC1, 0x14} },
-	{ .data =3D {0xC2, 0x03} },
-	{ .data =3D {0xC3, 0x07} },
-	{ .data =3D {0xC4, 0x0A} },
-	{ .data =3D {0xC5, 0xA0} },
-	{ .data =3D {0xC6, 0x55} },
-	{ .data =3D {0xC7, 0xFF} },
-	{ .data =3D {0xC8, 0x39} },
-	{ .data =3D {0xC9, 0x44} },
-	{ .data =3D {0xCA, 0x12} },
-	{ .data =3D {0xCD, 0x80} },
-	{ .data =3D {0xDB, 0x80} },
-	{ .data =3D {0xDC, 0x80} },
-	{ .data =3D {0xDD, 0x80} },
-	{ .data =3D {0xE0, 0x80} },
-	{ .data =3D {0xE1, 0x80} },
-	{ .data =3D {0xE2, 0x80} },
-	{ .data =3D {0xE3, 0x80} },
-	{ .data =3D {0xE4, 0x80} },
-	{ .data =3D {0xE5, 0x40} },
-	{ .data =3D {0xE6, 0x40} },
-	{ .data =3D {0xE7, 0x40} },
-	{ .data =3D {0xE8, 0x40} },
-	{ .data =3D {0xE9, 0x40} },
-	{ .data =3D {0xEA, 0x40} },
-	{ .data =3D {0xEB, 0x40} },
-	{ .data =3D {0xEC, 0x40} },
-	{ .data =3D {0xED, 0x40} },
-	{ .data =3D {0xEE, 0x40} },
-	{ .data =3D {0xEF, 0x40} },
-	{ .data =3D {0xF0, 0x40} },
-	{ .data =3D {0xF1, 0x40} },
-	{ .data =3D {0xF2, 0x40} },
-	{ .data =3D {0xF3, 0x40} },
-	{ .data =3D {0xF4, 0x40} },
-	{ .data =3D {0xF5, 0x40} },
-	{ .data =3D {0xF6, 0x40} },
-	{ .data =3D {0xFB, 0x1} },
-	{ .data =3D {0xFF, 0x23} },
-	{ .data =3D {0xFB, 0x01} },
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xff, 0x22);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x00, 0x40);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x01, 0xc0);
+	for (reg =3D 0x02; reg <=3D 0x10; reg++)
+		mipi_dsi_dcs_write_var_seq_multi(dsi_ctx, reg, 0x40);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x11, 0x50);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x12, 0x60);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x13, 0x70);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x14, 0x58);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x15, 0x68);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x16, 0x78);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x17, 0x77);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x18, 0x39);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x19, 0x2d);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x1a, 0x2e);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x1b, 0x32);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x1c, 0x37);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x1d, 0x3a);
+	for (reg =3D 0x1e; reg <=3D 0x28; reg++)
+		mipi_dsi_dcs_write_var_seq_multi(dsi_ctx, reg, 0x40);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x2d, 0x00);
+	for (reg =3D 0x2f; reg <=3D 0x3b; reg++)
+		mipi_dsi_dcs_write_var_seq_multi(dsi_ctx, reg, 0x40);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x3d, 0x40);
+	for (reg =3D 0x3f; reg <=3D 0x52; reg++)
+		mipi_dsi_dcs_write_var_seq_multi(dsi_ctx, reg, 0x40);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x53, 0x01);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x54, 0x01);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x55, 0xfe);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x56, 0x77);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x58, 0xcd);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x59, 0xd0);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x5a, 0xd0);
+	for (reg =3D 0x5b; reg <=3D 0x6f; reg++)
+		mipi_dsi_dcs_write_var_seq_multi(dsi_ctx, reg, 0x50);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x70, 0x07);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x71, 0x00);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x72, 0x00);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x73, 0x00);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x74, 0x06);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x75, 0x0c);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x76, 0x03);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x77, 0x09);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x78, 0x0f);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x79, 0x68);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x7a, 0x88);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x7c, 0x80);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x7d, 0x80);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x7e, 0x80);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x7f, 0x00);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x80, 0x00);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x81, 0x00);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x83, 0x01);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x84, 0x00);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x85, 0x80);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x86, 0x80);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x87, 0x80);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x88, 0x40);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x89, 0x91);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x8a, 0x98);
+	for (reg =3D 0x8b; reg <=3D 0x9f; reg++)
+		mipi_dsi_dcs_write_var_seq_multi(dsi_ctx, reg, 0x80);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xa0, 0x8a);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xa2, 0x80);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xa6, 0x80);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xa7, 0x80);
+	for (reg =3D 0xa9; reg <=3D 0xaf; reg++)
+		mipi_dsi_dcs_write_var_seq_multi(dsi_ctx, reg, 0x80);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xb7, 0x76);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xb8, 0x76);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xb9, 0x05);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xba, 0x0d);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xbb, 0x14);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xbc, 0x0f);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xbd, 0x18);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xbe, 0x1f);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xbf, 0x05);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xc0, 0x0d);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xc1, 0x14);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xc2, 0x03);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xc3, 0x07);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xc4, 0x0a);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xc5, 0xa0);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xc6, 0x55);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xc7, 0xff);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xc8, 0x39);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xc9, 0x44);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xca, 0x12);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xcd, 0x80);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xdb, 0x80);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xdc, 0x80);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xdd, 0x80);
+	for (reg =3D 0xe0; reg <=3D 0xe4; reg++)
+		mipi_dsi_dcs_write_var_seq_multi(dsi_ctx, reg, 0x80);
+	for (reg =3D 0xe5; reg <=3D 0xf6; reg++)
+		mipi_dsi_dcs_write_var_seq_multi(dsi_ctx, reg, 0x40);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xfb, 0x01);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xff, 0x23);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xfb, 0x01);
 	/* dimming enable */
-	{ .data =3D {0x01, 0x84} },
-	{ .data =3D {0x05, 0x2D} },
-	{ .data =3D {0x06, 0x00} },
-	 /* resolution 1080*2246 */
-	{ .data =3D {0x11, 0x01} },
-	{ .data =3D {0x12, 0x7B} },
-	{ .data =3D {0x15, 0x6F} },
-	{ .data =3D {0x16, 0x0B} },
-	 /* UI mode */
-	{ .data =3D {0x29, 0x0A} },
-	{ .data =3D {0x30, 0xFF} },
-	{ .data =3D {0x31, 0xFF} },
-	{ .data =3D {0x32, 0xFF} },
-	{ .data =3D {0x33, 0xFF} },
-	{ .data =3D {0x34, 0xFF} },
-	{ .data =3D {0x35, 0xFF} },
-	{ .data =3D {0x36, 0xFF} },
-	{ .data =3D {0x37, 0xFF} },
-	{ .data =3D {0x38, 0xFC} },
-	{ .data =3D {0x39, 0xF8} },
-	{ .data =3D {0x3A, 0xF4} },
-	{ .data =3D {0x3B, 0xF1} },
-	{ .data =3D {0x3D, 0xEE} },
-	{ .data =3D {0x3F, 0xEB} },
-	{ .data =3D {0x40, 0xE8} },
-	{ .data =3D {0x41, 0xE5} },
-	 /* STILL mode */
-	{ .data =3D {0x2A, 0x13} },
-	{ .data =3D {0x45, 0xFF} },
-	{ .data =3D {0x46, 0xFF} },
-	{ .data =3D {0x47, 0xFF} },
-	{ .data =3D {0x48, 0xFF} },
-	{ .data =3D {0x49, 0xFF} },
-	{ .data =3D {0x4A, 0xFF} },
-	{ .data =3D {0x4B, 0xFF} },
-	{ .data =3D {0x4C, 0xFF} },
-	{ .data =3D {0x4D, 0xED} },
-	{ .data =3D {0x4E, 0xD5} },
-	{ .data =3D {0x4F, 0xBF} },
-	{ .data =3D {0x50, 0xA6} },
-	{ .data =3D {0x51, 0x96} },
-	{ .data =3D {0x52, 0x86} },
-	{ .data =3D {0x53, 0x76} },
-	{ .data =3D {0x54, 0x66} },
-	 /* MOVING mode */
-	{ .data =3D {0x2B, 0x0E} },
-	{ .data =3D {0x58, 0xFF} },
-	{ .data =3D {0x59, 0xFF} },
-	{ .data =3D {0x5A, 0xFF} },
-	{ .data =3D {0x5B, 0xFF} },
-	{ .data =3D {0x5C, 0xFF} },
-	{ .data =3D {0x5D, 0xFF} },
-	{ .data =3D {0x5E, 0xFF} },
-	{ .data =3D {0x5F, 0xFF} },
-	{ .data =3D {0x60, 0xF6} },
-	{ .data =3D {0x61, 0xEA} },
-	{ .data =3D {0x62, 0xE1} },
-	{ .data =3D {0x63, 0xD8} },
-	{ .data =3D {0x64, 0xCE} },
-	{ .data =3D {0x65, 0xC3} },
-	{ .data =3D {0x66, 0xBA} },
-	{ .data =3D {0x67, 0xB3} },
-	{ .data =3D {0xFF, 0x25} },
-	{ .data =3D {0xFB, 0x01} },
-	{ .data =3D {0x05, 0x04} },
-	{ .data =3D {0xFF, 0x26} },
-	{ .data =3D {0xFB, 0x01} },
-	{ .data =3D {0x1C, 0xAF} },
-	{ .data =3D {0xFF, 0x10} },
-	{ .data =3D {0xFB, 0x01} },
-	{ .data =3D {0x51, 0xFF} },
-	{ .data =3D {0x53, 0x24} },
-	{ .data =3D {0x55, 0x00} },
-};
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x01, 0x84);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x05, 0x2d);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x06, 0x00);
+	/* resolution 1080*2246 */
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x11, 0x01);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x12, 0x7b);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x15, 0x6f);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x16, 0x0b);
+	/* UI mode */
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x29, 0x0a);
+	for (reg =3D 0x30; reg <=3D 0x37; reg++)
+		mipi_dsi_dcs_write_var_seq_multi(dsi_ctx, reg, 0xff);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x38, 0xfc);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x39, 0xf8);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x3a, 0xf4);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x3b, 0xf1);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x3d, 0xee);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x3f, 0xeb);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x40, 0xe8);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x41, 0xe5);
+	/* STILL mode */
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x2a, 0x13);
+	for (reg =3D 0x45; reg <=3D 0x4c; reg++)
+		mipi_dsi_dcs_write_var_seq_multi(dsi_ctx, reg, 0xff);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x4d, 0xed);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x4e, 0xd5);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x4f, 0xbf);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x50, 0xa6);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x51, 0x96);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x52, 0x86);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x53, 0x76);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x54, 0x66);
+	/* MOVING mode */
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x2b, 0x0e);
+	for (reg =3D 0x58; reg <=3D 0x5f; reg++)
+		mipi_dsi_dcs_write_var_seq_multi(dsi_ctx, reg, 0xff);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x60, 0xf6);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x61, 0xea);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x62, 0xe1);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x63, 0xd8);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x64, 0xce);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x65, 0xc3);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x66, 0xba);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x67, 0xb3);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xff, 0x25);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xfb, 0x01);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x05, 0x04);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xff, 0x26);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xfb, 0x01);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x1c, 0xaf);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xff, 0x10);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xfb, 0x01);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x51, 0xff);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x53, 0x24);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0x55, 0x00);
+}
=20
-static const struct nt36672a_panel_cmd tianma_fhd_video_on_cmds_2[] =3D {
-	{ .data =3D {0xFF, 0x24} },
-	{ .data =3D {0xFB, 0x01} },
-	{ .data =3D {0xC3, 0x01} },
-	{ .data =3D {0xC4, 0x54} },
-	{ .data =3D {0xFF, 0x10} },
-};
+static void tianma_fhd_video_send_init_cmds_2(struct mipi_dsi_multi_contex=
t *dsi_ctx)
+{
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xff, 0x24);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xfb, 0x01);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xc3, 0x01);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xc4, 0x54);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xff, 0x10);
+}
=20
-static const struct nt36672a_panel_cmd tianma_fhd_video_off_cmds[] =3D {
-	{ .data =3D {0xFF, 0x24} },
-	{ .data =3D {0xFB, 0x01} },
-	{ .data =3D {0xC3, 0x01} },
-	{ .data =3D {0xFF, 0x10} },
-};
+static void tianma_fhd_video_send_deinit_cmds(struct mipi_dsi_multi_contex=
t *dsi_ctx)
+{
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xff, 0x24);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xfb, 0x01);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xc3, 0x01);
+	mipi_dsi_dcs_write_seq_multi(dsi_ctx, 0xff, 0x10);
+}
=20
 static const struct drm_display_mode tianma_fhd_video_panel_default_mode =
=3D {
 	.clock		=3D 161331,
@@ -546,12 +399,9 @@ static const struct nt36672a_panel_desc tianma_fhd_vid=
eo_panel_desc =3D {
 			| MIPI_DSI_MODE_VIDEO_BURST,
 	.format =3D MIPI_DSI_FMT_RGB888,
 	.lanes =3D 4,
-	.on_cmds_1 =3D tianma_fhd_video_on_cmds_1,
-	.num_on_cmds_1 =3D ARRAY_SIZE(tianma_fhd_video_on_cmds_1),
-	.on_cmds_2 =3D tianma_fhd_video_on_cmds_2,
-	.num_on_cmds_2 =3D ARRAY_SIZE(tianma_fhd_video_on_cmds_2),
-	.off_cmds =3D tianma_fhd_video_off_cmds,
-	.num_off_cmds =3D ARRAY_SIZE(tianma_fhd_video_off_cmds),
+	.send_init_cmds_1 =3D tianma_fhd_video_send_init_cmds_1,
+	.send_init_cmds_2 =3D tianma_fhd_video_send_init_cmds_2,
+	.send_deinit_cmds =3D tianma_fhd_video_send_deinit_cmds,
 };
=20
 static int nt36672a_panel_add(struct nt36672a_panel *pinfo)
--=20
2.43.0