From nobody Sun May 24 19:33:56 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EA3FF37754E for ; Fri, 22 May 2026 18:52:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779475963; cv=pass; b=H/5JBjE/l0pCs7NWFieK0qqTt6KVe++Q8c0LmKn7Ka8A3SW4Vx9bXP0tLQa/Aff+6yKzsMyothYkZ6rsu/ka9g7dwKYWWPBj7dBK8NqSDgLudv42Nt3mIxYS2OFo/Y249viO0CP4oFwO+is4nkHoPAMSfryVmQphDvdle4QHI/8= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779475963; c=relaxed/simple; bh=pRwTHsXlD7qad0gm67yX3zP3PYp5qiTvGlt2871hB2c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Hy+b0+SGZU4DSVUMBedfxjAWJp+82b3BxEVDPl3OrLW1lXN+SW9kzz9qsJWUKJyMFb3Q64UjhvCgJ6PAZJCX+J3zFrxmR0OieRKtoIfY0z4yowvBC9XXuh154UkFyOoFhI4Ew0YgLI0SwqqOrJl4DXQo8hcIUDNRuNy9W9o1dPI= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=RapDNsz2; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="RapDNsz2" ARC-Seal: i=1; a=rsa-sha256; t=1779475945; cv=none; d=zohomail.com; s=zohoarc; b=Ja07j6cgUyEny1FhtrGSU8fMx9pGzzsDe688mAyaYvVQq/sGFSgSf7pY7YvTvElUJQIpENv5SMk81JWIFtPAKZXplZEoq6ChX5htSoTFsnyhe5NtNRqYz4IE0BkMLZP5xeN91TIOoCEWy+1lJtkSGLGGOwtZIyuqZ/Aq9yYN1yw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779475945; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=EfjCy2BVplWmVofRr3phBJpfErYYqQ0OAw8WLwN7lYI=; b=U7szOlotau5xOCi5edHQikbWCs03CgfVirxNDfZZ99rA9eHwK0/ShC/e5SYnTnHUxBV2mg/HOU0xs6YfmXr5XzEZTspwioZF6JQjnODclREp7Pnu7am3YtaVIzWXjRBAgqaiSgQCkomzDA4WltA85appK3+qxQS/F1PwZiUgzIQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1779475945; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=EfjCy2BVplWmVofRr3phBJpfErYYqQ0OAw8WLwN7lYI=; b=RapDNsz26z1YOpYWHt9Eneka6vXyGjxuT7q4lH68A9rcboYgj2rM4BxrJx64d7Bl dsmzTjMCX04q0KsawV2EbaIvvppFwKQUgKSBFCDZjwxYzTdMWNv077LLm2PnRd2o7zY i0zPO5EKC+qjNWRCUdo3liaTcW7Ifw1LCQNDO0NM= Received: by mx.zohomail.com with SMTPS id 1779475944861705.0064399594058; Fri, 22 May 2026 11:52:24 -0700 (PDT) From: =?UTF-8?q?Adri=C3=A1n=20Larumbe?= To: linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Steven Price , Boris Brezillon , kernel@collabora.com, =?UTF-8?q?Adri=C3=A1n=20Larumbe?= , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Daniel Almeida , Alice Ryhl Subject: [PATCH v13 1/6] drm/panthor: Expose GPU page sizes to UM Date: Fri, 22 May 2026 19:51:55 +0100 Message-ID: <20260522185206.2798288-2-adrian.larumbe@collabora.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260522185206.2798288-1-adrian.larumbe@collabora.com> References: <20260522185206.2798288-1-adrian.larumbe@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable In future commits that will implement repeated mappings, only repeat values multiple of GPU page sizes will be tolerated. That means these values must be made known to UM. Do it through a queriable GPU info value. Reviewed-by: Steven Price Reviewed-by: Boris Brezillon Signed-off-by: Adri=C3=A1n Larumbe --- drivers/gpu/drm/panthor/panthor_device.h | 3 +++ drivers/gpu/drm/panthor/panthor_drv.c | 8 ++++++++ drivers/gpu/drm/panthor/panthor_mmu.c | 9 ++++++++- include/uapi/drm/panthor_drm.h | 13 +++++++++++++ 4 files changed, 32 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panthor/panthor_device.h b/drivers/gpu/drm/pan= thor/panthor_device.h index 4e4607bca7cc..72bf48ee635b 100644 --- a/drivers/gpu/drm/panthor/panthor_device.h +++ b/drivers/gpu/drm/panthor/panthor_device.h @@ -161,6 +161,9 @@ struct panthor_device { /** @csif_info: Command stream interface information. */ struct drm_panthor_csif_info csif_info; =20 + /** @mmu_info: MMU info */ + struct drm_panthor_mmu_info mmu_info; + /** @hw: GPU-specific data. */ struct panthor_hw *hw; =20 diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/pantho= r/panthor_drv.c index e8dc4096c1d2..bfb49fe2a306 100644 --- a/drivers/gpu/drm/panthor/panthor_drv.c +++ b/drivers/gpu/drm/panthor/panthor_drv.c @@ -175,6 +175,7 @@ panthor_get_uobj_array(const struct drm_panthor_obj_arr= ay *in, u32 min_stride, _Generic(_obj_name, \ PANTHOR_UOBJ_DECL(struct drm_panthor_gpu_info, tiler_present), \ PANTHOR_UOBJ_DECL(struct drm_panthor_csif_info, pad), \ + PANTHOR_UOBJ_DECL(struct drm_panthor_mmu_info, page_size_bitmap), \ PANTHOR_UOBJ_DECL(struct drm_panthor_timestamp_info, current_timestamp)= , \ PANTHOR_UOBJ_DECL(struct drm_panthor_group_priorities_info, pad), \ PANTHOR_UOBJ_DECL(struct drm_panthor_sync_op, timeline_value), \ @@ -954,6 +955,10 @@ static int panthor_ioctl_dev_query(struct drm_device *= ddev, void *data, struct d args->size =3D sizeof(priorities_info); return 0; =20 + case DRM_PANTHOR_DEV_QUERY_MMU_INFO: + args->size =3D sizeof(ptdev->mmu_info); + return 0; + default: return -EINVAL; } @@ -984,6 +989,9 @@ static int panthor_ioctl_dev_query(struct drm_device *d= dev, void *data, struct d panthor_query_group_priorities_info(file, &priorities_info); return PANTHOR_UOBJ_SET(args->pointer, args->size, priorities_info); =20 + case DRM_PANTHOR_DEV_QUERY_MMU_INFO: + return PANTHOR_UOBJ_SET(args->pointer, args->size, ptdev->mmu_info); + default: return -EINVAL; } diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/pantho= r/panthor_mmu.c index 452d0b6d4668..46fadb487679 100644 --- a/drivers/gpu/drm/panthor/panthor_mmu.c +++ b/drivers/gpu/drm/panthor/panthor_mmu.c @@ -2782,7 +2782,7 @@ panthor_vm_create(struct panthor_device *ptdev, bool = for_mcu, refcount_set(&vm->as.active_cnt, 0); =20 pgtbl_cfg =3D (struct io_pgtable_cfg) { - .pgsize_bitmap =3D SZ_4K | SZ_2M, + .pgsize_bitmap =3D ptdev->mmu_info.page_size_bitmap, .ias =3D va_bits, .oas =3D pa_bits, .coherent_walk =3D ptdev->coherent, @@ -3227,6 +3227,11 @@ static void panthor_mmu_release_wq(struct drm_device= *ddev, void *res) destroy_workqueue(res); } =20 +static void panthor_mmu_info_init(struct panthor_device *ptdev) +{ + ptdev->mmu_info.page_size_bitmap =3D SZ_4K | SZ_2M; +} + /** * panthor_mmu_init() - Initialize the MMU logic. * @ptdev: Device. @@ -3239,6 +3244,8 @@ int panthor_mmu_init(struct panthor_device *ptdev) struct panthor_mmu *mmu; int ret, irq; =20 + panthor_mmu_info_init(ptdev); + mmu =3D drmm_kzalloc(&ptdev->base, sizeof(*mmu), GFP_KERNEL); if (!mmu) return -ENOMEM; diff --git a/include/uapi/drm/panthor_drm.h b/include/uapi/drm/panthor_drm.h index 0e455d91e77d..b462752c793d 100644 --- a/include/uapi/drm/panthor_drm.h +++ b/include/uapi/drm/panthor_drm.h @@ -253,6 +253,9 @@ enum drm_panthor_dev_query_type { * @DRM_PANTHOR_DEV_QUERY_GROUP_PRIORITIES_INFO: Query allowed group prio= rities information. */ DRM_PANTHOR_DEV_QUERY_GROUP_PRIORITIES_INFO, + + /** @DRM_PANTHOR_DEV_QUERY_MMU_INFO: Query MMU information. */ + DRM_PANTHOR_DEV_QUERY_MMU_INFO, }; =20 /** @@ -487,6 +490,16 @@ struct drm_panthor_timestamp_info { __u64 cpu_timestamp_nsec; }; =20 +/** + * struct drm_panthor_mmu_info - MMU information + * + * Structure grouping all queryable information relating to the MMU. + */ +struct drm_panthor_mmu_info { + /** @page_size_bitmap: Allowed page sizes */ + __u64 page_size_bitmap; +}; + /** * struct drm_panthor_group_priorities_info - Group priorities information * --=20 2.53.0 From nobody Sun May 24 19:33:56 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB02B36728D for ; Fri, 22 May 2026 18:52:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779475962; cv=pass; b=cLQa67xNmhxwVsdr67pfLBxa/LkFEgl7rV1zCPn60AsUBuEoTUyKpThxOfhrZcF1Ir8TRKE/T6+P1pdWH8BHlbqUX0km8/WFxW5G6QBj2lzowirZs0jBt9TlAyL8g46q1IhEfQ6aJUOL+N939F4DzEXP/ym18HD6HZbQy9HhjsA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779475962; c=relaxed/simple; bh=QeZLN0mm/T/FbI5ot6iepaxPYErQ2rwKWo5cvppDm+k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SCpmUFpU8Q3nC2pmjNWaD5svdByu8zoygquyGoGZjStt7XuhLBkh6YpgugWcY74BnBg0LBmr8E2O3fxksJjEvMhiyPMZFlS0RR2eHXFRncYz4Z+BUsiokuaa6OQn6iIPerVkOOSX/iiNpqwoyWAejUYZMLdyO8s+5DTHpNyM3xE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=RpKuqMaw; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="RpKuqMaw" ARC-Seal: i=1; a=rsa-sha256; t=1779475949; cv=none; d=zohomail.com; s=zohoarc; b=LRBlpnakLmOa5di9j0ZhbhEsgPvRzxOXlNH09IlvIHpnVvKn22Ljq/BvlMQASiZnpYikax9IPGzG2DSgs8LuyI2KQkUPBmiD3NKTgvobX7apHj9fg1dnWCnMBlOsJcd7YUeNphcUGD0SJsnr82tx9xUL0IIRwsAbQAJ4Zbr+lcs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779475949; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=ddviA53NnZ87Ufq8fjGtKHnmVM7l/mODG70lLztTAKo=; b=aUXvNbVMGVZXQanotHwfctOrk4oLjK882PkzberLL/N9vxgsfYlLtQCNoCEtMcd1gA06jqleVUJauaq9b+vIh0KtxHSoKpjh6X6MiOeGSDwdQhmOEMRNBF8ZWb+FHiuA8oQnorP7HzktbnuGMHInCDspK0yIRsQla6Y7pUJjRsA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1779475949; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=ddviA53NnZ87Ufq8fjGtKHnmVM7l/mODG70lLztTAKo=; b=RpKuqMawJNjsGbELf6yMy5GxAo0kqsje6T+W8dMmSWF5RSQ3MOhat+pAGONx6CEs jdrF3aiFW6NfEgmnHIq4/QXF9dKb3g3wBWfOSDH2sjpkdO6H5EXjRDYXY6bWc9fPkXW FEZ4u5+9PsWVOIMp8dl0+Rt28bSZ0lsg06lZ2VnQ= Received: by mx.zohomail.com with SMTPS id 1779475948073719.7516449336806; Fri, 22 May 2026 11:52:28 -0700 (PDT) From: =?UTF-8?q?Adri=C3=A1n=20Larumbe?= To: linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Steven Price , Boris Brezillon , kernel@collabora.com, =?UTF-8?q?Adri=C3=A1n=20Larumbe?= , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Subject: [PATCH v13 2/6] drm/panthor: Pass vm_bind_op to vm_prepare_map_op_ctx Date: Fri, 22 May 2026 19:51:56 +0100 Message-ID: <20260522185206.2798288-3-adrian.larumbe@collabora.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260522185206.2798288-1-adrian.larumbe@collabora.com> References: <20260522185206.2798288-1-adrian.larumbe@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Instead of passing its constituent elements, pass the whole struct to simplify the function prototype. Reviewed-by: Steven Price Reviewed-by: Boris Brezillon Signed-off-by: Adri=C3=A1n Larumbe --- drivers/gpu/drm/panthor/panthor_mmu.c | 27 ++++++++++++++------------- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/pantho= r/panthor_mmu.c index 46fadb487679..f1afe4a3e296 100644 --- a/drivers/gpu/drm/panthor/panthor_mmu.c +++ b/drivers/gpu/drm/panthor/panthor_mmu.c @@ -1282,9 +1282,7 @@ static int panthor_vm_op_ctx_prealloc_pts(struct pant= hor_vm_op_ctx *op_ctx) static int panthor_vm_prepare_map_op_ctx(struct panthor_vm_op_ctx *op_ctx, struct panthor_vm *vm, struct panthor_gem_object *bo, - u64 offset, - u64 size, u64 va, - u32 flags) + const struct drm_panthor_vm_bind_op *op) { struct drm_gpuvm_bo *preallocated_vm_bo; struct sg_table *sgt =3D NULL; @@ -1293,12 +1291,12 @@ static int panthor_vm_prepare_map_op_ctx(struct pan= thor_vm_op_ctx *op_ctx, if (!bo) return -EINVAL; =20 - if ((flags & ~PANTHOR_VM_BIND_OP_MAP_FLAGS) || - (flags & DRM_PANTHOR_VM_BIND_OP_TYPE_MASK) !=3D DRM_PANTHOR_VM_BIND_O= P_TYPE_MAP) + if ((op->flags & ~PANTHOR_VM_BIND_OP_MAP_FLAGS) || + (op->flags & DRM_PANTHOR_VM_BIND_OP_TYPE_MASK) !=3D DRM_PANTHOR_VM_BI= ND_OP_TYPE_MAP) return -EINVAL; =20 /* Make sure the VA and size are in-bounds. */ - if (size > bo->base.size || offset > bo->base.size - size) + if (op->size > bo->base.size || op->bo_offset > bo->base.size - op->size) return -EINVAL; =20 /* If the BO has an exclusive VM attached, it can't be mapped to other VM= s. */ @@ -1306,7 +1304,7 @@ static int panthor_vm_prepare_map_op_ctx(struct panth= or_vm_op_ctx *op_ctx, bo->exclusive_vm_root_gem !=3D panthor_vm_root_gem(vm)) return -EINVAL; =20 - panthor_vm_init_op_ctx(op_ctx, size, va, flags); + panthor_vm_init_op_ctx(op_ctx, op->size, op->va, op->flags); =20 ret =3D panthor_vm_op_ctx_prealloc_vmas(op_ctx); if (ret) @@ -1335,7 +1333,7 @@ static int panthor_vm_prepare_map_op_ctx(struct panth= or_vm_op_ctx *op_ctx, } =20 op_ctx->map.vm_bo =3D drm_gpuvm_bo_obtain_prealloc(preallocated_vm_bo); - op_ctx->map.bo_offset =3D offset; + op_ctx->map.bo_offset =3D op->bo_offset; =20 ret =3D panthor_vm_op_ctx_prealloc_pts(op_ctx); if (ret) @@ -2862,10 +2860,7 @@ panthor_vm_bind_prepare_op_ctx(struct drm_file *file, gem =3D drm_gem_object_lookup(file, op->bo_handle); ret =3D panthor_vm_prepare_map_op_ctx(op_ctx, vm, gem ? to_panthor_bo(gem) : NULL, - op->bo_offset, - op->size, - op->va, - op->flags); + op); drm_gem_object_put(gem); return ret; =20 @@ -3061,10 +3056,16 @@ int panthor_vm_bind_exec_sync_op(struct drm_file *f= ile, int panthor_vm_map_bo_range(struct panthor_vm *vm, struct panthor_gem_obje= ct *bo, u64 offset, u64 size, u64 va, u32 flags) { + struct drm_panthor_vm_bind_op op =3D { + .bo_offset =3D offset, + .size =3D size, + .va =3D va, + .flags =3D flags, + }; struct panthor_vm_op_ctx op_ctx; int ret; =20 - ret =3D panthor_vm_prepare_map_op_ctx(&op_ctx, vm, bo, offset, size, va, = flags); + ret =3D panthor_vm_prepare_map_op_ctx(&op_ctx, vm, bo, &op); if (ret) return ret; =20 --=20 2.53.0 From nobody Sun May 24 19:33:56 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D900377ED2 for ; Fri, 22 May 2026 18:52:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779475968; cv=pass; b=kjB1zlMTbxJidhP7/NIdLYpeeToIkBVYEcWqyOimrpWCBnXGN2R8OoogNXOlvzdYApSgQyTMZg1C1IpR3tJQMvhCwsBHyp0WZprd479jro8ELWWe83UmSTPnvC+FwdNzSlYpX6LeZJ34l+p2LwiemqvLcC+gEpe7hASywC+wMV4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779475968; c=relaxed/simple; bh=aJEQEOv1AwHlqR9vhWPtvf47jiLzbFDbg66Z45jzSAw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TTW7wmvjq8LLq9JP4Qh/Y0zLE9T92Lr6yp3rovKIM/OJxyQtV6octy5T9g9e9HAjh2sQ8YvKbylPiBT3jOPEcODF2GqymGk3LyTwlqrqFUsYguwR/jpj1f21fWyptlfV4++YZDW4w4WW6bH7TXud3Ar73rl1O7HgPBs0QFf8+9w= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=E4owSaL2; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="E4owSaL2" ARC-Seal: i=1; a=rsa-sha256; t=1779475953; cv=none; d=zohomail.com; s=zohoarc; b=mCyD2Y2mfCMi1akCT2aZP8+tCsT5vpLzJsfHccKBxrPoh9oH+J0KiH67S4cWDNToF9TWX04cheYjNANd9TAY2uif0Y8iTkN9ktg8FFwV9ooNyczjWXFesaHN+131ZzbLnT+eIm4hqKOQ3d4rCdlGoS3H8rHgohXgv9b0n2NmlMI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779475953; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=do/tIM3Ojb1Vv1appOYmHiLTKOw9/ngQpz7qtd/LP/Q=; b=Ki/iIH3rE0mT9Su2zpWZLjz+hN/bEcjNnyKgIsJ9rzPYHrvNR2OJXbW/uhhxCfeGqpTx9AvVm49w4N8eulqXhSleXaQRdx928gJoadWptScMYzgdBFGZgu30nhkomQzF6Q/TPQlkOsg52LIYDtGfs7dJLnaik56CB8wqWLwIdmc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1779475953; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=do/tIM3Ojb1Vv1appOYmHiLTKOw9/ngQpz7qtd/LP/Q=; b=E4owSaL2GY2gcwE8jRGeu7NeNioEL+rbhGH0Goudho9yyhNsb05p3IYjIX7G0ldL JNkasv0oTN647LdZX70EyZzbOnvrxBToI2qyPzlyuzUWZU7ir9jaHsJXc2zF8CrkMOd 4em7DQyXRDTdwAAM8THddaE3yTes8mcyNWkf94jw= Received: by mx.zohomail.com with SMTPS id 1779475951927658.5553860696097; Fri, 22 May 2026 11:52:31 -0700 (PDT) From: =?UTF-8?q?Adri=C3=A1n=20Larumbe?= To: linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Steven Price , Boris Brezillon , kernel@collabora.com, =?UTF-8?q?Adri=C3=A1n=20Larumbe?= , Liviu Dudau , Daniel Almeida , Alice Ryhl , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Subject: [PATCH v13 3/6] drm/panthor: Delete spurious whitespace from uAPI header Date: Fri, 22 May 2026 19:51:57 +0100 Message-ID: <20260522185206.2798288-4-adrian.larumbe@collabora.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260522185206.2798288-1-adrian.larumbe@collabora.com> References: <20260522185206.2798288-1-adrian.larumbe@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable There's no extra blank line after the last member of any other uAPI structures, so delete it. Reviewed-by: Steven Price Reviewed-by: Boris Brezillon Signed-off-by: Adri=C3=A1n Larumbe --- include/uapi/drm/panthor_drm.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/uapi/drm/panthor_drm.h b/include/uapi/drm/panthor_drm.h index b462752c793d..14a93a4ef6ff 100644 --- a/include/uapi/drm/panthor_drm.h +++ b/include/uapi/drm/panthor_drm.h @@ -677,7 +677,6 @@ struct drm_panthor_vm_bind_op { * This array shall not be empty for sync-only operations. */ struct drm_panthor_obj_array syncs; - }; =20 /** --=20 2.53.0 From nobody Sun May 24 19:33:56 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB6C727144B for ; Fri, 22 May 2026 18:52:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779475969; cv=pass; b=Y+Qm7DEg3sSj+J0DNsV9jwILItF1REnYxV3KV4nAb4bMsmaa4EYgQl+nmVvZdTYy08fJLnpxqVPSH6rRZBeSG1OI4ND5uoikFqN+dZdECyzh4OWzn4PJ11MSFgJg5L56Nq17muxLTX9zTsMuMoHidnicYqm7WVLV/bxMbspUFxI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779475969; c=relaxed/simple; bh=0Ou5o52IdoRvgjfbwyYkAujGyjJChhavGmjlSjig9Uk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=hCObWASm7CTnGqi2Yrnj1pEg503APgvK/yPeUuhg5kFCJxJkz1RJDlBLiABLqMaNq8sjQyfyDZ/QTfNwqMdjpdyYIXmngRlGMlM4FUqHkEon6o0t6JqIvxkUINlImvIBZ/kc4kDpYiuGxysIPMFN7mZ6c4shHs9UJUgoV4VoxqQ= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=Z5/jNRGH; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="Z5/jNRGH" ARC-Seal: i=1; a=rsa-sha256; t=1779475955; cv=none; d=zohomail.com; s=zohoarc; b=jSDBQD6w6BbTV7Jmj9EjEgvqYRGiHOK/hng/6DPYgCPd5nKY+GMn4N2KYwoIsPbHnp4NNZ2moaJPA+bHG+q7iF+ql3CgMXSJwEXGahhkMnvsNmh9s4Avn6wJYtL/9ojeFLJiSVf0WZUf8nF5NGv2X9aj0k//SIgOUsCJvIMnSZA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779475955; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=nWqrbHP+2Nsd9KkgwB6fZ0/LTOiEdw/wgbwod8voBuY=; b=i32Ja6taqXbYHH1mxRDyLym02w0tIB6i1fTFf/gdzdNRfjnmUAHTvhMMBQLhsnp7wnFZORWqJF3Y25fmIG6KBqhZgZBj87oXZHXJ1y1ng/3hr5nSlVK9RHxEp6cq6vRRJyJVbmsveHuYNHCmrNyYzw67jpWC9V4EpgT2UfyA6u0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1779475955; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=nWqrbHP+2Nsd9KkgwB6fZ0/LTOiEdw/wgbwod8voBuY=; b=Z5/jNRGH0l22jdWybvB1OJhkXICaS7CqUnt9m1W8r2oHGCdVxBbiUAA8u8rzFcyk Iu0W7mxJQ7YYD2VQ/W1JRU4IaEerc39mDAaRDW7WjfT8hNlCKHENB0y8Nu2bgyvuVv/ edZvtBOdIvltrWNFNQToKQqJG4QB9euPNg9jxfq4= Received: by mx.zohomail.com with SMTPS id 1779475954811754.7657344254476; Fri, 22 May 2026 11:52:34 -0700 (PDT) From: =?UTF-8?q?Adri=C3=A1n=20Larumbe?= To: linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Steven Price , Boris Brezillon , kernel@collabora.com, =?UTF-8?q?Adri=C3=A1n=20Larumbe?= , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Subject: [PATCH v13 4/6] drm/panthor: Remove unused operation context field Date: Fri, 22 May 2026 19:51:58 +0100 Message-ID: <20260522185206.2798288-5-adrian.larumbe@collabora.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260522185206.2798288-1-adrian.larumbe@collabora.com> References: <20260522185206.2798288-1-adrian.larumbe@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable A Panthor BO's sgtable is now retrieved from its dmap field. Reviewed-by: Steven Price Reviewed-by: Boris Brezillon Signed-off-by: Adri=C3=A1n Larumbe --- drivers/gpu/drm/panthor/panthor_mmu.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/pantho= r/panthor_mmu.c index f1afe4a3e296..ca78267d43e9 100644 --- a/drivers/gpu/drm/panthor/panthor_mmu.c +++ b/drivers/gpu/drm/panthor/panthor_mmu.c @@ -199,14 +199,6 @@ struct panthor_vm_op_ctx { /** @map.bo_offset: Offset in the buffer object. */ u64 bo_offset; =20 - /** - * @map.sgt: sg-table pointing to pages backing the GEM object. - * - * This is gathered at job creation time, such that we don't have - * to allocate in ::run_job(). - */ - struct sg_table *sgt; - /** @map.bo: the BO being mapped. */ struct panthor_gem_object *bo; } map; --=20 2.53.0 From nobody Sun May 24 19:33:56 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1DC0F36728D for ; Fri, 22 May 2026 18:52:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779475978; cv=pass; b=cVpMxwqwo4NSiZPFPXJ14zRilxSnDB/TIIFqeP4+LHVV3fq1hUVS1DekxkU4C0wUKLXF6alQIAJOJ+8mPelVJkniof7OP5TBOo423tgaY4HNfjkQnWkz0xhobGIe2tnTR9bRPrZwiGYYQzNOcea+WhXNfValzgY68EKhyDfFuEQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779475978; c=relaxed/simple; bh=WSAFt5TDzkVMa9iZF0gfnw6wSco2XIkO1xpQJnI9Lho=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=oUewYv2OAMSYiHA5PjgcnZ3ClUEdLel4SI7JLA2+f2PVYNdzujdOZJ/+Zf89lv0TB4dTUg3GP5D2kQRE9wlzulPnyCXpNEhhZEBFLSMja4vRYMZSxaHwSGc0gQWfeOilKiXPJQ46ZUMvAc5B4k3S01C5vWhR+L0GyM7rJE0o1F8= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=hiOnX2C9; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="hiOnX2C9" ARC-Seal: i=1; a=rsa-sha256; t=1779475959; cv=none; d=zohomail.com; s=zohoarc; b=DFk+vmjwXN2pD/0EkPxWvgJXNRikthMlxmWOgrbU3rY52FpQo5XKGmD1qeNh8SdFV5K0Ki0kkMdZ7pYcCaRqxn+T0S3T5BgLLy2xM+675lbS1LuggvEsbrkE3wrb8vtMrbm+S5Av6dckUHKaaavv8aRUVjZNocbXyRv93hmKvHM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779475959; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=dKKe8YYb+7dYWMwofFqaVAtDQxKnZlJjGKXRXNM2tUQ=; b=gnUvG9R04owPMLZyZIOI3zrtTKqaIPOcEz5jObwCWeXSGe6iRzIa6VzaIveeDdVlis4ndlE4T4gihJ/n+UAPXgkG6dePwgl04Xkbh8dnbI+YjkHoeZRuQUTNot+CvNqayN3utR7KlcUALeka9gWyw7NQETdXOJMaRtAV1vYprxE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1779475959; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=dKKe8YYb+7dYWMwofFqaVAtDQxKnZlJjGKXRXNM2tUQ=; b=hiOnX2C9ije5tpK4OJhKiepKk5LEBGMZig/9AL4Z+1V2sjk6AosbEzzL1ldknhUi J5UhnngJbFKQjTZ35/RmpczWzxGJpXzmn9qyJpLclHyXQgTVXkxotr2x87Gk2LJ4K6k gIyVbi81glZJwRbgzoBBn825FK3xt947uP3wyCyI= Received: by mx.zohomail.com with SMTPS id 1779475958626697.7730073846611; Fri, 22 May 2026 11:52:38 -0700 (PDT) From: =?UTF-8?q?Adri=C3=A1n=20Larumbe?= To: linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Steven Price , Boris Brezillon , kernel@collabora.com, =?UTF-8?q?Adri=C3=A1n=20Larumbe?= , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Daniel Almeida , Alice Ryhl Subject: [PATCH v13 5/6] drm/panthor: Support sparse mappings Date: Fri, 22 May 2026 19:51:59 +0100 Message-ID: <20260522185206.2798288-6-adrian.larumbe@collabora.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260522185206.2798288-1-adrian.larumbe@collabora.com> References: <20260522185206.2798288-1-adrian.larumbe@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Allow UM to bind sparsely populated memory regions by cyclically mapping virtual ranges over a kernel-allocated dummy BO. This alternative is preferable to the old method of handling sparseness in the UMD, because it relied on the creation of a buffer object to the same end, despite the fact Vulkan sparse resources don't need to be backed by a driver BO. The choice of backing sparsely-bound regions with a Panthor BO was made so as to profit from the existing shrinker reclaim code. That way no special treatment must be given to the dummy sparse BOs when reclaiming memory, as would be the case if we had chosen a raw kernel page implementation. A new dummy BO is allocated per open file context, because even though the Vulkan spec mandates that writes into sparsely bound regions must be discarded, our implementation is still a workaround over the fact Mali CSF GPUs cannot support this behaviour on the hardware level, so writes still make it into the backing BO. If we had a global one, then it could be a venue for information leaks between file contexts, which should never happen in DRM. As a side note, care was put to adjust dummy BO offsets for sparse mappings so that all addresses in the new VA are mapped aligned against it. Signed-off-by: Adri=C3=A1n Larumbe --- drivers/gpu/drm/panthor/panthor_gem.c | 18 +++ drivers/gpu/drm/panthor/panthor_gem.h | 2 + drivers/gpu/drm/panthor/panthor_mmu.c | 195 ++++++++++++++++++++++---- include/uapi/drm/panthor_drm.h | 12 ++ 4 files changed, 201 insertions(+), 26 deletions(-) diff --git a/drivers/gpu/drm/panthor/panthor_gem.c b/drivers/gpu/drm/pantho= r/panthor_gem.c index 13295d7a593d..c798ac2963e1 100644 --- a/drivers/gpu/drm/panthor/panthor_gem.c +++ b/drivers/gpu/drm/panthor/panthor_gem.c @@ -1345,6 +1345,24 @@ panthor_kernel_bo_create(struct panthor_device *ptde= v, struct panthor_vm *vm, return ERR_PTR(ret); } =20 +/** + * panthor_dummy_bo_create() - Create a Panthor BO meant to back sparse bi= ndings. + * @ptdev: Device. + * + * Return: A valid pointer in case of success, an ERR_PTR() otherwise. + */ +struct panthor_gem_object * +panthor_dummy_bo_create(struct panthor_device *ptdev) +{ + /* Since even when the DRM device's mount point has enabled THP we have n= o guarantee + * that drm_gem_get_pages() will return a single 2MiB PMD, and also we ca= nnot be sure + * that the 2MiB won't be reclaimed and re-allocated later on as 4KiB chu= nks, it doesn't + * make sense to pre-populate this object's page array, nor to fall back = on a BO size + * of 4KiB. Sticking to a dummy object size of 2MiB lets us keep things s= imple for now. + */ + return panthor_gem_create(&ptdev->base, SZ_2M, DRM_PANTHOR_BO_NO_MMAP, NU= LL, 0); +} + static bool can_swap(void) { return get_nr_swap_pages() > 0; diff --git a/drivers/gpu/drm/panthor/panthor_gem.h b/drivers/gpu/drm/pantho= r/panthor_gem.h index ae0491d0b121..8639c2fa08e6 100644 --- a/drivers/gpu/drm/panthor/panthor_gem.h +++ b/drivers/gpu/drm/panthor/panthor_gem.h @@ -315,6 +315,8 @@ panthor_kernel_bo_create(struct panthor_device *ptdev, = struct panthor_vm *vm, =20 void panthor_kernel_bo_destroy(struct panthor_kernel_bo *bo); =20 +struct panthor_gem_object *panthor_dummy_bo_create(struct panthor_device *= ptdev); + #ifdef CONFIG_DEBUG_FS void panthor_gem_debugfs_init(struct drm_minor *minor); #endif diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/pantho= r/panthor_mmu.c index ca78267d43e9..18b156172cc9 100644 --- a/drivers/gpu/drm/panthor/panthor_mmu.c +++ b/drivers/gpu/drm/panthor/panthor_mmu.c @@ -116,6 +116,17 @@ struct panthor_mmu { struct panthor_vm_pool { /** @xa: Array used for VM handle tracking. */ struct xarray xa; + + /** + * @dummy: Dummy object used for sparse mappings + * + * Sparse bindings map virtual address ranges onto a dummy + * BO in a modulo fashion. Even though sparse writes are meant + * to be discarded and reads undefined, writes are still reflected + * in the dummy buffer. That means we must keep a dummy object per + * file context, to avoid data leaks between them. + */ + struct panthor_gem_object *dummy; }; =20 /** @@ -395,6 +406,15 @@ struct panthor_vm { */ struct list_head lru_node; } reclaim; + + /** + * @dummy: Dummy object used for sparse mappings. + * + * VM's must keep a reference to the file context-wide dummy BO because + * they can outlive the file context, which includes the VM pool holding + * the original dummy BO reference. + */ + struct panthor_gem_object *dummy; }; =20 /** @@ -1027,6 +1047,30 @@ panthor_vm_map_pages(struct panthor_vm *vm, u64 iova= , int prot, return 0; } =20 +static int +panthor_vm_map_sparse(struct panthor_vm *vm, u64 iova, int prot, + struct sg_table *sgt, u64 size) +{ + u64 mapped =3D 0; + int ret; + + while (mapped < size) { + u64 addr =3D iova + mapped; + u32 chunk_size =3D min(size - mapped, SZ_2M - (addr & (SZ_2M - 1))); + + ret =3D panthor_vm_map_pages(vm, addr, prot, sgt, + addr % SZ_2M, chunk_size); + if (ret) { + panthor_vm_unmap_pages(vm, iova, mapped); + return ret; + } + + mapped +=3D chunk_size; + } + + return 0; +} + static int flags_to_prot(u32 flags) { int prot =3D 0; @@ -1269,6 +1313,7 @@ static int panthor_vm_op_ctx_prealloc_pts(struct pant= hor_vm_op_ctx *op_ctx) (DRM_PANTHOR_VM_BIND_OP_MAP_READONLY | \ DRM_PANTHOR_VM_BIND_OP_MAP_NOEXEC | \ DRM_PANTHOR_VM_BIND_OP_MAP_UNCACHED | \ + DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE | \ DRM_PANTHOR_VM_BIND_OP_TYPE_MASK) =20 static int panthor_vm_prepare_map_op_ctx(struct panthor_vm_op_ctx *op_ctx, @@ -1276,6 +1321,7 @@ static int panthor_vm_prepare_map_op_ctx(struct panth= or_vm_op_ctx *op_ctx, struct panthor_gem_object *bo, const struct drm_panthor_vm_bind_op *op) { + bool is_sparse =3D op->flags & DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE; struct drm_gpuvm_bo *preallocated_vm_bo; struct sg_table *sgt =3D NULL; int ret; @@ -1287,8 +1333,21 @@ static int panthor_vm_prepare_map_op_ctx(struct pant= hor_vm_op_ctx *op_ctx, (op->flags & DRM_PANTHOR_VM_BIND_OP_TYPE_MASK) !=3D DRM_PANTHOR_VM_BI= ND_OP_TYPE_MAP) return -EINVAL; =20 - /* Make sure the VA and size are in-bounds. */ - if (op->size > bo->base.size || op->bo_offset > bo->base.size - op->size) + /* uAPI mandates sparsely bound regions must not be executable. */ + if (is_sparse && !(op->flags & DRM_PANTHOR_VM_BIND_OP_MAP_NOEXEC)) + return -EINVAL; + + /* For non-sparse, make sure the VA and size are in-bounds. + * For sparse, this is not applicable, because the dummy BO is + * repeatedly mapped over a potentially wider VA range. + */ + if (!is_sparse && (op->size > bo->base.size || op->bo_offset > bo->base.s= ize - op->size)) + return -EINVAL; + + /* For sparse, we don't expect any user BO, the BO we get passed + * is the dummy BO attached to the VM pool. + */ + if (is_sparse && (op->bo_handle || op->bo_offset)) return -EINVAL; =20 /* If the BO has an exclusive VM attached, it can't be mapped to other VM= s. */ @@ -1437,7 +1496,9 @@ panthor_vm_get_bo_for_va(struct panthor_vm *vm, u64 v= a, u64 *bo_offset) if (vma && vma->base.gem.obj) { drm_gem_object_get(vma->base.gem.obj); bo =3D to_panthor_bo(vma->base.gem.obj); - *bo_offset =3D vma->base.gem.offset + (va - vma->base.va.addr); + *bo_offset =3D !(vma->flags & DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE) ? + vma->base.gem.offset + (va - vma->base.va.addr) : + va & (SZ_2M - 1); } mutex_unlock(&vm->op_lock); =20 @@ -1542,6 +1603,9 @@ int panthor_vm_pool_create_vm(struct panthor_device *= ptdev, if (IS_ERR(vm)) return PTR_ERR(vm); =20 + drm_gem_object_get(&pool->dummy->base); + vm->dummy =3D pool->dummy; + ret =3D xa_alloc(&pool->xa, &id, vm, XA_LIMIT(1, PANTHOR_MAX_VMS_PER_FILE), GFP_KERNEL); =20 @@ -1641,6 +1705,8 @@ void panthor_vm_pool_destroy(struct panthor_file *pfi= le) xa_for_each(&pfile->vms->xa, i, vm) panthor_vm_destroy(vm); =20 + if (pfile->vms->dummy) + drm_gem_object_put(&pfile->vms->dummy->base); xa_destroy(&pfile->vms->xa); kfree(pfile->vms); } @@ -1653,12 +1719,28 @@ void panthor_vm_pool_destroy(struct panthor_file *p= file) */ int panthor_vm_pool_create(struct panthor_file *pfile) { + struct panthor_gem_object *dummy; + int ret; + pfile->vms =3D kzalloc_obj(*pfile->vms); if (!pfile->vms) return -ENOMEM; =20 xa_init_flags(&pfile->vms->xa, XA_FLAGS_ALLOC1); + + dummy =3D panthor_dummy_bo_create(pfile->ptdev); + if (IS_ERR(dummy)) { + ret =3D PTR_ERR(dummy); + goto err_destroy_vm_pool; + } + + pfile->vms->dummy =3D dummy; + return 0; + +err_destroy_vm_pool: + panthor_vm_pool_destroy(pfile); + return ret; } =20 /* dummy TLB ops, the real TLB flush happens in panthor_vm_flush_range() */ @@ -1995,6 +2077,9 @@ static void panthor_vm_free(struct drm_gpuvm *gpuvm) =20 free_io_pgtable_ops(vm->pgtbl_ops); =20 + if (vm->dummy) + drm_gem_object_put(&vm->dummy->base); + drm_mm_takedown(&vm->mm); kfree(vm); } @@ -2154,7 +2239,30 @@ static void panthor_vma_init(struct panthor_vma *vma= , u32 flags) #define PANTHOR_VM_MAP_FLAGS \ (DRM_PANTHOR_VM_BIND_OP_MAP_READONLY | \ DRM_PANTHOR_VM_BIND_OP_MAP_NOEXEC | \ - DRM_PANTHOR_VM_BIND_OP_MAP_UNCACHED) + DRM_PANTHOR_VM_BIND_OP_MAP_UNCACHED | \ + DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE) + +static void +panthor_fix_sparse_map_offset(struct drm_gpuva_op_map *op, u32 flags) +{ + if (op && (flags & DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE)) + op->gem.offset =3D op->va.addr & (SZ_2M - 1); +} + +static int +panthor_vm_exec_map_op(struct panthor_vm *vm, u32 flags, + const struct drm_gpuva_op_map *op) +{ + struct panthor_gem_object *bo =3D to_panthor_bo(op->gem.obj); + int prot =3D flags_to_prot(flags); + + if (flags & DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE) + return panthor_vm_map_sparse(vm, op->va.addr, prot, + bo->dmap.sgt, op->va.range); + + return panthor_vm_map_pages(vm, op->va.addr, prot, bo->dmap.sgt, + op->gem.offset, op->va.range); +} =20 static int panthor_gpuva_sm_step_map(struct drm_gpuva_op *op, void *priv) { @@ -2167,10 +2275,9 @@ static int panthor_gpuva_sm_step_map(struct drm_gpuv= a_op *op, void *priv) return -EINVAL; =20 panthor_vma_init(vma, op_ctx->flags & PANTHOR_VM_MAP_FLAGS); + panthor_fix_sparse_map_offset(&op->map, vma->flags); =20 - ret =3D panthor_vm_map_pages(vm, op->map.va.addr, flags_to_prot(vma->flag= s), - op_ctx->map.bo->dmap.sgt, op->map.gem.offset, - op->map.va.range); + ret =3D panthor_vm_exec_map_op(vm, vma->flags, &op->map); if (ret) { panthor_vm_op_ctx_return_vma(op_ctx, vma); return ret; @@ -2202,6 +2309,8 @@ static void unmap_hugepage_align(const struct drm_gpuva_op_remap *op, u64 *unmap_start, u64 *unmap_range) { + struct panthor_vma *unmap_vma =3D container_of(op->unmap->va, struct pant= hor_vma, base); + bool is_sparse =3D unmap_vma->flags & DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE; u64 aligned_unmap_start, aligned_unmap_end, unmap_end; =20 unmap_end =3D *unmap_start + *unmap_range; @@ -2209,11 +2318,15 @@ unmap_hugepage_align(const struct drm_gpuva_op_rema= p *op, aligned_unmap_end =3D ALIGN(unmap_end, SZ_2M); =20 /* If we're dealing with a huge page, make sure the unmap region is - * aligned on the start of the page. + * aligned on the start of the page. If the unmapped VMA stands for + * a sparse mapping, always assume the backing storage is a THP, since + * the overhead of unmapping 2MiB worth of 4KiB pages and remapping + * some of them is offset by the logic of working out whether it's + * the opposite case right below. This also holds true for op->next. */ if (op->prev && aligned_unmap_start < *unmap_start && op->prev->va.addr <=3D aligned_unmap_start && - iova_mapped_as_huge_page(op->prev, *unmap_start)) { + (is_sparse || iova_mapped_as_huge_page(op->prev, *unmap_start))) { *unmap_range +=3D *unmap_start - aligned_unmap_start; *unmap_start =3D aligned_unmap_start; } @@ -2223,7 +2336,7 @@ unmap_hugepage_align(const struct drm_gpuva_op_remap = *op, */ if (op->next && aligned_unmap_end > unmap_end && op->next->va.addr + op->next->va.range >=3D aligned_unmap_end && - iova_mapped_as_huge_page(op->next, unmap_end - 1)) { + (is_sparse || iova_mapped_as_huge_page(op->next, unmap_end - 1))) { *unmap_range +=3D aligned_unmap_end - unmap_end; } } @@ -2240,6 +2353,11 @@ static int panthor_gpuva_sm_step_remap(struct drm_gp= uva_op *op, =20 drm_gpuva_op_remap_to_unmap_range(&op->remap, &unmap_start, &unmap_range); =20 + /* op->remap.prev's BO offset is always the same as the unmap va's, but + * that of op->remap.next must be adjusted so as to remain < SZ_2M + */ + panthor_fix_sparse_map_offset(op->remap.next, unmap_vma->flags); + /* * ARM IOMMU page table management code disallows partial unmaps of huge = pages, * so when a partial unmap is requested, we must first unmap the entire h= uge @@ -2259,14 +2377,19 @@ static int panthor_gpuva_sm_step_remap(struct drm_g= puva_op *op, } =20 if (op->remap.prev) { - struct panthor_gem_object *bo =3D to_panthor_bo(op->remap.prev->gem.obj); u64 offset =3D op->remap.prev->gem.offset + unmap_start - op->remap.prev= ->va.addr; u64 size =3D op->remap.prev->va.addr + op->remap.prev->va.range - unmap_= start; =20 - if (!unmap_vma->evicted) { - ret =3D panthor_vm_map_pages(vm, unmap_start, - flags_to_prot(unmap_vma->flags), - bo->dmap.sgt, offset, size); + if (!unmap_vma->evicted && size > 0) { + struct drm_gpuva_op_map map_op =3D { + .va.addr =3D unmap_start, + .va.range =3D size, + .gem.obj =3D op->remap.prev->gem.obj, + .gem.offset =3D offset, + }; + panthor_fix_sparse_map_offset(&map_op, unmap_vma->flags); + + ret =3D panthor_vm_exec_map_op(vm, unmap_vma->flags, &map_op); if (ret) return ret; } @@ -2277,14 +2400,19 @@ static int panthor_gpuva_sm_step_remap(struct drm_g= puva_op *op, } =20 if (op->remap.next) { - struct panthor_gem_object *bo =3D to_panthor_bo(op->remap.next->gem.obj); u64 addr =3D op->remap.next->va.addr; u64 size =3D unmap_start + unmap_range - op->remap.next->va.addr; =20 - if (!unmap_vma->evicted) { - ret =3D panthor_vm_map_pages(vm, addr, flags_to_prot(unmap_vma->flags), - bo->dmap.sgt, op->remap.next->gem.offset, - size); + if (!unmap_vma->evicted && size > 0) { + struct drm_gpuva_op_map map_op =3D { + .va.addr =3D addr, + .va.range =3D size, + .gem.obj =3D op->remap.next->gem.obj, + .gem.offset =3D op->remap.next->gem.offset, + }; + panthor_fix_sparse_map_offset(&map_op, unmap_vma->flags); + + ret =3D panthor_vm_exec_map_op(vm, unmap_vma->flags, &map_op); if (ret) return ret; } @@ -2481,11 +2609,17 @@ static int remap_evicted_vma(struct drm_gpuvm_bo *v= m_bo, ret =3D panthor_vm_lock_region(vm, evicted_vma->base.va.addr, evicted_vma->base.va.range); if (!ret) { - ret =3D panthor_vm_map_pages(vm, evicted_vma->base.va.addr, - flags_to_prot(evicted_vma->flags), - bo->dmap.sgt, - evicted_vma->base.gem.offset, - evicted_vma->base.va.range); + struct drm_gpuva_op_map map_op =3D { + .va.addr =3D evicted_vma->base.va.addr, + .va.range =3D evicted_vma->base.va.range, + .gem.obj =3D &bo->base, + .gem.offset =3D evicted_vma->base.gem.offset, + }; + if (evicted_vma->flags & DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE) + drm_WARN_ON_ONCE(&vm->ptdev->base, map_op.gem.offset !=3D + (map_op.va.addr & (SZ_2M - 1))); + + ret =3D panthor_vm_exec_map_op(vm, evicted_vma->flags, &map_op); if (!ret) evicted_vma->evicted =3D false; =20 @@ -2849,7 +2983,13 @@ panthor_vm_bind_prepare_op_ctx(struct drm_file *file, =20 switch (op->flags & DRM_PANTHOR_VM_BIND_OP_TYPE_MASK) { case DRM_PANTHOR_VM_BIND_OP_TYPE_MAP: - gem =3D drm_gem_object_lookup(file, op->bo_handle); + if (!(op->flags & DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE)) { + gem =3D drm_gem_object_lookup(file, op->bo_handle); + } else { + gem =3D &vm->dummy->base; + drm_gem_object_get(&vm->dummy->base); + } + ret =3D panthor_vm_prepare_map_op_ctx(op_ctx, vm, gem ? to_panthor_bo(gem) : NULL, op); @@ -3057,6 +3197,9 @@ int panthor_vm_map_bo_range(struct panthor_vm *vm, st= ruct panthor_gem_object *bo struct panthor_vm_op_ctx op_ctx; int ret; =20 + if (drm_WARN_ON(&vm->ptdev->base, flags & DRM_PANTHOR_VM_BIND_OP_MAP_SPAR= SE)) + return -EINVAL; + ret =3D panthor_vm_prepare_map_op_ctx(&op_ctx, vm, bo, &op); if (ret) return ret; diff --git a/include/uapi/drm/panthor_drm.h b/include/uapi/drm/panthor_drm.h index 14a93a4ef6ff..a2ff0f4ec691 100644 --- a/include/uapi/drm/panthor_drm.h +++ b/include/uapi/drm/panthor_drm.h @@ -614,6 +614,18 @@ enum drm_panthor_vm_bind_op_flags { */ DRM_PANTHOR_VM_BIND_OP_MAP_UNCACHED =3D 1 << 2, =20 + /** + * @DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE: Sparsely map a virtual memory range + * + * Only valid with DRM_PANTHOR_VM_BIND_OP_TYPE_MAP. + * + * When this flag is set, the whole vm_bind range is mapped over a dummy = object in a cyclic + * fashion, and all GPU reads from addresses in the range return undefine= d values. This flag + * being set means drm_panthor_vm_bind_op::bo_offset and drm_panthor_vm_b= ind_op::bo_handle + * must both be set to 0. DRM_PANTHOR_VM_BIND_OP_MAP_NOEXEC must also be = set. + */ + DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE =3D 1 << 3, + /** * @DRM_PANTHOR_VM_BIND_OP_TYPE_MASK: Mask used to determine the type of = operation. */ --=20 2.53.0 From nobody Sun May 24 19:33:56 2026 Received: from sender4-pp-f112.zoho.com (sender4-pp-f112.zoho.com [136.143.188.112]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F2AC3377EA4 for ; Fri, 22 May 2026 18:52:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.112 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779475977; cv=pass; b=XzdADwG0+aRzap0+vz/CUh4uW2YPfhnIbwYBFjZy+Ri2yZDZfkGz4fPFVjlwgYFXY3BJ2x40b44PNWyZtoeo20vj1+5rYtzlfJk/N+PQYqHanx0Q3ajlCSa5WWucIlW9Ag4U+lptdimojkWiqLrMwqrDh8JA+SQnVZYU/3hR/Rk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779475977; c=relaxed/simple; bh=932aPExA/nHpueHHZGDxS84uj0ZeuFMM5Ag7cQW9eQ4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=eUlAV9Wk9IzrtkfAHF9sPQk5bHRmWntobz2PHF8QMOSA03pQdOcBuMBn28pWzAHevzcRe85Dvx8aOsdLo8HwY02eNv5fDWEZVrfVuVdUMNrf1Oj0KonOlQ5Q2u551NIxOkBKuWxvLWzdWr18xsmOrCW1uzlUjQs39drO0YQAKf4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=RgSbVEe9; arc=pass smtp.client-ip=136.143.188.112 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="RgSbVEe9" ARC-Seal: i=1; a=rsa-sha256; t=1779475963; cv=none; d=zohomail.com; s=zohoarc; b=Op8FBxzuwGhNJm2/9mFWqVDRb8xYa6YcKTwhgwbIWMi0kO3UbNUvEYdv18UxLWRZbx9AYhjnBm+7OUmVOlc7qeCup+zq4Ncz4ZEytMNkro4edagInMJpQJxvRZYU3Maj1V/Up0bgQEgrA+6FQTmdN/VYpWlK/Yq0L+wCkXSzZeE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1779475963; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=uXh2mb3EqCBjA3lTtrQ2lSKuGm0LC9cSnJSD2N7NX0Y=; b=ht+HXK8VrToxdoWkAc+GuT9mWhfDpdh/eVY36et6VFhS9q0AgYsCffNDeIDJ7LdewtuaIRMXv2RANIux2n8J+In7QUGkfF62U8cQgnLmrDSrfcG21dmo0GJGPqSL9WZ5fEcfzDk72HjyKmRdSaVuEYqo7S9SfJIrsy8zgfdy89Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1779475963; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:To:To:Cc:Cc:Subject:Subject:Date:Date:Message-ID:In-Reply-To:References:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=uXh2mb3EqCBjA3lTtrQ2lSKuGm0LC9cSnJSD2N7NX0Y=; b=RgSbVEe9ZbECuL59OsTem43NFtsLbyXkj7MPAOSzoewR5LOCACOvCASxpruf/EZC qfYlsHR11KtVEGAudbvRI0VaUFpFRBEXww0OJBJm+FCDFEOiipBFK9KpzmxFE9vp6h2 qRxE7eeX64DskpCtlF9RLAy4a+2ZHf14HGfEMgrM= Received: by mx.zohomail.com with SMTPS id 1779475961895572.0983361381426; Fri, 22 May 2026 11:52:41 -0700 (PDT) From: =?UTF-8?q?Adri=C3=A1n=20Larumbe?= To: linux-kernel@vger.kernel.org Cc: dri-devel@lists.freedesktop.org, Steven Price , Boris Brezillon , kernel@collabora.com, =?UTF-8?q?Adri=C3=A1n=20Larumbe?= , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Subject: [PATCH v13 6/6] drm/panthor: Bump the driver version to 1.9 Date: Fri, 22 May 2026 19:52:00 +0100 Message-ID: <20260522185206.2798288-7-adrian.larumbe@collabora.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260522185206.2798288-1-adrian.larumbe@collabora.com> References: <20260522185206.2798288-1-adrian.larumbe@collabora.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Bump the driver version to reflect the new DRM_PANTHOR_DEV_QUERY_MMU_INFO query type and the DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE flag. Reviewed-by: Boris Brezillon Reviewed-by: Steven Price Signed-off-by: Adri=C3=A1n Larumbe --- drivers/gpu/drm/panthor/panthor_drv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panthor/panthor_drv.c b/drivers/gpu/drm/pantho= r/panthor_drv.c index bfb49fe2a306..4b6dbd600d61 100644 --- a/drivers/gpu/drm/panthor/panthor_drv.c +++ b/drivers/gpu/drm/panthor/panthor_drv.c @@ -1787,6 +1787,8 @@ static void panthor_debugfs_init(struct drm_minor *mi= nor) * - adds DRM_IOCTL_PANTHOR_BO_QUERY_INFO ioctl * - adds drm_panthor_gpu_info::selected_coherency * - 1.8 - extends DEV_QUERY_TIMESTAMP_INFO with flags + * - 1.9 - adds DRM_PANTHOR_DEV_QUERY_MMU_INFO query + * - adds DRM_PANTHOR_VM_BIND_OP_MAP_SPARSE flag */ static const struct drm_driver panthor_drm_driver =3D { .driver_features =3D DRIVER_RENDER | DRIVER_GEM | DRIVER_SYNCOBJ | @@ -1800,7 +1802,7 @@ static const struct drm_driver panthor_drm_driver =3D= { .name =3D "panthor", .desc =3D "Panthor DRM driver", .major =3D 1, - .minor =3D 8, + .minor =3D 9, =20 .gem_prime_import_sg_table =3D panthor_gem_prime_import_sg_table, .gem_prime_import =3D panthor_gem_prime_import, --=20 2.53.0