vfio/pci: Fix sparse warning in vfio_pci_core_get_iomap()

[PATCH] vfio/pci: Fix sparse warning in vfio_pci_core_get_iomap()

Posted by Matt Evans 2 days, 5 hours ago

Use IOMEM_ERR_PTR() when returning a void __iomem * rather than
ERR_PTR().  This fixes a sparse warning, "different address spaces".

Fixes: 859dc0f6253b ("vfio/pci: Replace vfio_pci_core_setup_barmap() with vfio_pci_core_get_iomap()")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202605211601.U1OvmuqY-lkp@intel.com/
Signed-off-by: Matt Evans <mattev@meta.com>
---
 include/linux/vfio_pci_core.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/vfio_pci_core.h b/include/linux/vfio_pci_core.h
index 7accd0eac457..4fa129fc5c64 100644
--- a/include/linux/vfio_pci_core.h
+++ b/include/linux/vfio_pci_core.h
@@ -244,10 +244,10 @@ static inline void __iomem __must_check *
 vfio_pci_core_get_iomap(struct vfio_pci_core_device *vdev, unsigned int bar)
 {
 	if (WARN_ON_ONCE(bar >= PCI_STD_NUM_BARS))
-		return ERR_PTR(-EINVAL);
+		return IOMEM_ERR_PTR(-EINVAL);
 
 	if (WARN_ON_ONCE(!vdev->barmap[bar]))
-		return ERR_PTR(-ENODEV);
+		return IOMEM_ERR_PTR(-ENODEV);
 
 	return vdev->barmap[bar];
 }
-- 
2.47.3

Re: [PATCH] vfio/pci: Fix sparse warning in vfio_pci_core_get_iomap()

Posted by Alex Williamson 1 day, 19 hours ago

On Fri, 22 May 2026 05:42:11 -0700
Matt Evans <mattev@meta.com> wrote:

> Use IOMEM_ERR_PTR() when returning a void __iomem * rather than
> ERR_PTR().  This fixes a sparse warning, "different address spaces".
> 
> Fixes: 859dc0f6253b ("vfio/pci: Replace vfio_pci_core_setup_barmap() with vfio_pci_core_get_iomap()")
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202605211601.U1OvmuqY-lkp@intel.com/
> Signed-off-by: Matt Evans <mattev@meta.com>
> ---
>  include/linux/vfio_pci_core.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/vfio_pci_core.h b/include/linux/vfio_pci_core.h
> index 7accd0eac457..4fa129fc5c64 100644
> --- a/include/linux/vfio_pci_core.h
> +++ b/include/linux/vfio_pci_core.h
> @@ -244,10 +244,10 @@ static inline void __iomem __must_check *
>  vfio_pci_core_get_iomap(struct vfio_pci_core_device *vdev, unsigned int bar)
>  {
>  	if (WARN_ON_ONCE(bar >= PCI_STD_NUM_BARS))
> -		return ERR_PTR(-EINVAL);
> +		return IOMEM_ERR_PTR(-EINVAL);
>  
>  	if (WARN_ON_ONCE(!vdev->barmap[bar]))
> -		return ERR_PTR(-ENODEV);
> +		return IOMEM_ERR_PTR(-ENODEV);
>  
>  	return vdev->barmap[bar];
>  }

Applied to vfio next branch for v7.2.  Thanks,

Alex