From nobody Sun May 24 18:41:32 2026 Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 94B9C3793A5 for ; Fri, 22 May 2026 12:20:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779452445; cv=none; b=VhVIPWCp6oZPxBrbjgkzCToKRkMVTGL12CGM9Uz7k6yEi/iNSJ09uN7hNyOZYi+48t4L2emLyQvkeJgIPLChoVu4v9t2DVDmGznajk0C/xdoH3SWiuRytLhFFKWryMYNKHqEKBvCSpO8sR3o6k6xSlKo2NmXUUHJszzGebvRM2Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779452445; c=relaxed/simple; bh=bhfJYktqcLA186BQdpKCnz/FDnquz083vYJ7/H9ksvk=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=gRT6bukTDGWOepKGnWSr8ehcWbZK8biZrUHTpJl09+I2qtsfaYIvCPoR0XXlf5wgqz4NEQtJn0oA8cbipgkx3jSDXnHkhKF2DhzzYeb6sKN15FOQVYAh7jdSvimG3QptaTwVuuuP9EElIWPHvcun/k8crBM7uuGs8Ib6i21Fb3w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nmY0gZbX; arc=none smtp.client-ip=209.85.219.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nmY0gZbX" Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-8b59772d441so89285636d6.0 for ; Fri, 22 May 2026 05:20:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779452442; x=1780057242; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=DMmEkAgbAbL0bknXE6VKXd/SNfsxV03AylxbVaw6hzs=; b=nmY0gZbXwgS54EoPEXgYVuBKpYHH6io3n5ehwg78xbZhHaK38dOB+Telxxx45Jp61X GGZcKzR414JW1sZAQg8+hXmbyeXSFSwHy4XMXwH/mgHvOYuNWc1enuyP/voeR4nRiLOu uGbNfZA7uLya1U3P55tAVoACav6qc9YSgtX655yA1BAx882fBQ7XSrvjveGChsPOIrO/ d29pPkwrNOUhDdRp8iGHn7CXgRyZnNDi/Ob+K2YrMYjmIWL9+zhdQAUxmk5CJaU2G3DI FlValHSurbv0C71Z7jtpwRK+c1/3wlRfiBQ8JZULCT+nvX6OTidV6RzWtdNRI7mCRYzG +ZdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779452442; x=1780057242; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DMmEkAgbAbL0bknXE6VKXd/SNfsxV03AylxbVaw6hzs=; b=nofYcwx1J+BmnvhLGJpg7o0OEIt02vJ/gU00Zd6hyJYltCf6nDo7hVWLk81Z5LftWR /AWcjrmZMoFQSfjFOOBvZqOc4Tha58AzH5epDig9/98uPJXCKHKYFDr8cvM/HGTt2Vib cnHKis3N4q1rcN1G4+ChNBbTzAAtBA9XCQdIsByk7aqQbV2Cy3PmWOKS03UvhVOTcUj9 QEtGC+0e8BrAm8c8LQuBqm1sXHifZjuChTS/XVzL79pInO6/xOuQ8IFdI6J6oovjRTAx t3J6pKacTIVzmvIIScdFvpzhBYghetiYwsbjI8DL24wb+WhQYknfodzs8WlF0EE7Gsqz hFYA== X-Forwarded-Encrypted: i=1; AFNElJ/A5cOlciRHWsM9+3LycdPPafC6ySTGWRrOCMLF5GsWoiyU2CFY21Gt//qLyYswdJFM+jLsJN752dK/RWw=@vger.kernel.org X-Gm-Message-State: AOJu0Yw03Bxaa6nRuwyeg6xv7BRkzhQmNGxMfAyUrrqDqc06h5Ntw2K9 kAjdUgctSax/5F3yVKMnGbpjTDcWsvKDD5vaM5b0shArvERNd3Xs14qB X-Gm-Gg: Acq92OG0LY39hqs+6OyueMumihPqL7OUyNfJz6mvGpUmhmstAt/3onE/c23YILeSxqJ m4ZxjAF7vxP5THlVrZR5SUXGwzOv0JtMRUZOfzXKmvFPCeTjIDChKyPeIGl+4U464MXD7Tjnc02 XNCgVb2FsE71Qwh5Mx/vYJ/1kiFbgm2L52unhDuvPBIjPdPHoVYuaO0+N/2Bn5d0jxngbKvZq9X 6HGxuNmqYb5clZ6XGFTrmhAuIGJP6/C9O/W7xHtLr6abVTljw40VZK2VDgz6XrAQVLjNYcNMHdF NXR+OLQoAFTiA0iTQiSx8Q3hQNfh3HBllA4sNr9l9tHczcAe1QDDsqrIdDfWbuZw434Q5S5V6Lp tQnttuFJk64/7r7KlBfAlL70QK/fL4zUaU1hHuACn6tehwtfmTCntuZJuLyNAEfWn+5Pg009nRN AciMWIdS/oiZPzlFQCC6F6HWIFQyfVREorBCKPTO4oVfCBq8SEs0JYT+Qnh2rAeLf1+GoIiGWH7 AVGdyGJDAZqFEkQW6R4 X-Received: by 2002:ad4:5d4c:0:b0:8a4:8b2c:428f with SMTP id 6a1803df08f44-8cc7b53d77amr58734616d6.2.1779452441618; Fri, 22 May 2026 05:20:41 -0700 (PDT) Received: from server0 (c-68-48-65-54.hsd1.mi.comcast.net. [68.48.65.54]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8cc80dcec8esm16656626d6.7.2026.05.22.05.20.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2026 05:20:41 -0700 (PDT) From: Michael Bommarito To: David Howells , Lukas Wunner , Ignat Korchagin , Herbert Xu , "David S. Miller" Cc: Kees Cook , Vivek Goyal , Weiming Shi , Xiang Mei , keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] crypto: asymmetric_keys: validate PE section bounds before hashing Date: Fri, 22 May 2026 08:20:25 -0400 Message-ID: <20260522122025.250646-1-michael.bommarito@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" pefile_digest_pe_contents() hashes each PE section using PointerToRawData and SizeOfRawData from the section table. These fields are parsed from the input image, but the per-section hashing path does not check that the resulting range lies inside the supplied PE buffer before passing it to crypto_shash_update(). A malformed image passed to kexec_file_load() can therefore make signature verification read past the end of the PE buffer. Return -ELIBBAD for out-of-range section data and guard hashed_bytes against unsigned wrap before it is used by the trailing-data calculation. Link: https://lore.kernel.org/keyrings/20260430173632.277436-3-bestswngs@gm= ail.com/ Fixes: af316fc442ef ("pefile: Digest the PE binary and compare to the PKCS#= 7 data") Assisted-by: Codex:gpt-5-5-xhigh Signed-off-by: Michael Bommarito --- crypto/asymmetric_keys/verify_pefile.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/crypto/asymmetric_keys/verify_pefile.c b/crypto/asymmetric_key= s/verify_pefile.c index 1f3b227ba7f22..1405b76322cbd 100644 --- a/crypto/asymmetric_keys/verify_pefile.c +++ b/crypto/asymmetric_keys/verify_pefile.c @@ -292,6 +292,15 @@ static int pefile_digest_pe_contents(const void *pebuf= , unsigned int pelen, i =3D canon[loop]; if (ctx->secs[i].raw_data_size =3D=3D 0) continue; + if (ctx->secs[i].data_addr > pelen || + ctx->secs[i].raw_data_size > pelen - ctx->secs[i].data_addr) { + kfree(canon); + return -ELIBBAD; + } + if (ctx->secs[i].raw_data_size > UINT_MAX - hashed_bytes) { + kfree(canon); + return -ELIBBAD; + } ret =3D crypto_shash_update(desc, pebuf + ctx->secs[i].data_addr, ctx->secs[i].raw_data_size); --=20 2.53.0