From nobody Sun May 24 19:32:58 2026 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16B463BB132 for ; Fri, 22 May 2026 09:54:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779443667; cv=none; b=IoEbSjM9EzL4ESbnxk+AHB2+Nxw8Ny1CB1rHP78tJdgsJRUJYL7Xm8AtO5sq54O0RN1LGAp2y9thMN14ML54JigMbp9cq9k78ARWSgy86O5ntj07540BmZXiUOUlafhO5ucoaCdbwD2N3TLLySRoTmjERWaWCkNp7zJdG3JY9Lw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779443667; c=relaxed/simple; bh=hk+pW36En4Wy1AZ68b3gwc2MovHJXPl64J4AmrYmsEc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qGGCo2fzczuwsSaDxhCWjruHiP8O10ph4XSxVrkwZMdwTqr/0x9vMYe47c1gd3JAG2pHnJwLrLPZlBRcX2nodzPspZrN8+tVKjRu49CUvj0FM5BgFrmJ54GyhEoPTxtfkUaQ0WkJjE97/iqk2mVTHxBIKwctRMCBbjlJ1Kzma+M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CtbouQeF; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CtbouQeF" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-8379e010b01so3137385b3a.1 for ; Fri, 22 May 2026 02:54:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779443665; x=1780048465; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nfxD9+jDbayH+o4mAO389jhPYWsWPPQA6d87WX8ntHs=; b=CtbouQeFYWABE9x3h/+qraJS1bSiZ259zBr6nybAxfBnnKN3qSTNc+WUyEilcPNWzG DjiNnFSXukKrVlil4n9sRhu1uKA/RodqijbDttBaGUUocXtpF5//n8Ctx5op6ZqSiU0d IoH4rolx2NOAYvkQh0SxVx37m/6hIhtv+c51xEsjYMolte9RsZEwbDJnrZRl2yapE5WX n0C/KCSKOtJI1G/4zNV8xlnQ6DaXOicJARgyB80sLAmi0SwnnIL6pCReAGFWFw0G7LJP j2FHIPGcY1ZKSKLeJKw3JNq1IMRgzOJix7mxpKC4095lcTKUhSIv9EaFhr02nLx2VyDb NG1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779443665; x=1780048465; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=nfxD9+jDbayH+o4mAO389jhPYWsWPPQA6d87WX8ntHs=; b=j7tOnDtXLfo8xyRzhYv/fElflgpGbRhrRl4Bt8q/Ktv17wIscbl/GmU4mh759Vsxyo cdnIEl2TO8MSrHQBU73B52DhHXgCd1MA681+b4IUI+tGVGpdHOjB7QpfZQheqAZlIozs Q7K7ROZhH2fQfheN3DiEdK9IRktiK5Er8VClpkTJlVnFMviBMckYC2JphOHLdy8SwemQ FhseJ/kFOAkjY1Ua+lhwmJZrZB99dBDNcuYqKy+lCrsubLh6+dOgozsTkXRTCrqm8a6/ dHOOnRJDEcdaJPaFSCQhOeVujEeEt/Qtq7IzJMdAa++oVE7+WWRnAv4SI9TpX0qYpes+ h2AQ== X-Forwarded-Encrypted: i=1; AFNElJ+t57OY65RaLlpoxM7SjBXIhJTYgVYNVXvouZS4ItLJKMra7VHrnl/QH5d0N0CiPgg7UHk5cQjjSLuNnIQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yzlvvosy4xw7DgB/eeMIdpdvTgitoaxn7GGTPlytZu0goFVxKow jrcy0vTAfUDNSe7zWJ1Wn5k2KH68HXj1CZXe8x2PRtlrr4+7ayFZalC4 X-Gm-Gg: Acq92OEbGDe0mfUmE9nkQmuO5c5YJamcVHuBJTp2mrwKumeYE+xicLPwSQXY9U0eU5n uHfznuXvZIbeq+B4LcsaPJ3S5ivwZ90keEQUIX3Ue+R4Aww+Q7WZohw/DNQW5hUuMlS24qot/ue AWGlyTRWn9fldaIVuBGCMe5ALwMVUPa/A6iCH2g22EhDwlXtOYXkHGSdtOvLbmS4Rw82GstOyiH B7XFSfS3BzekfSGhRgR2qoRUvOs5005OKPoea/MXhWKDIvpziwZeYkF5II7S7FXvmJXFjrtl2th oyUIvM7bi0hdGMVa/CkCukyPoqEXZlIWliqgOJcF2CcO0zV7G8en8hsSXfUR9A9W8vgVGJhxh3a 8WpOcuzUaEL8Tuxr6hvJoT++V0i1mfMY7NGQyQdZfBnhWHY+BdCApUmHgse6y7a1/1DoXdH68WR N/Hs6NCoWUR7/hDS+eI6aLElPknHrMwqDgD6WeWtI4YGHkd9oqNX3OsOYAIQ== X-Received: by 2002:a05:6a00:4b45:b0:827:3b1b:43e6 with SMTP id d2e1a72fcca58-8415f5ea4bbmr3190006b3a.21.1779443665338; Fri, 22 May 2026 02:54:25 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84164aed7c9sm1757366b3a.13.2026.05.22.02.54.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2026 02:54:24 -0700 (PDT) From: phucduc.bui@gmail.com To: broonie@kernel.org Cc: codekipper@gmail.com, jernej.skrabec@gmail.com, lgirdwood@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-sunxi@lists.linux.dev, nichen@iscas.ac.cn, perex@perex.cz, samuel@sholland.org, tiwai@suse.com, wens@kernel.org, bui duc phuc Subject: [PATCH v2 1/3] ASoC: sunxi: sun4i-spdif: Use guard() for spin locks Date: Fri, 22 May 2026 16:53:59 +0700 Message-ID: <20260522095401.72915-2-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260522095401.72915-1-phucduc.bui@gmail.com> References: <20260522095401.72915-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Clean up the code using guard() for spin locks. Merely code refactoring, and no behavior change. Signed-off-by: bui duc phuc --- Change in v2:=20 - Switched from using guard() to scoped_guard() sound/soc/sunxi/sun4i-spdif.c | 62 ++++++++++++++++------------------- 1 file changed, 28 insertions(+), 34 deletions(-) diff --git a/sound/soc/sunxi/sun4i-spdif.c b/sound/soc/sunxi/sun4i-spdif.c index c2ec19437cd7..89eccc83a130 100644 --- a/sound/soc/sunxi/sun4i-spdif.c +++ b/sound/soc/sunxi/sun4i-spdif.c @@ -427,24 +427,21 @@ static int sun4i_spdif_get_status(struct snd_kcontrol= *kcontrol, struct snd_soc_dai *cpu_dai =3D snd_kcontrol_chip(kcontrol); struct sun4i_spdif_dev *host =3D snd_soc_dai_get_drvdata(cpu_dai); u8 *status =3D ucontrol->value.iec958.status; - unsigned long flags; unsigned int reg; =20 - spin_lock_irqsave(&host->lock, flags); + scoped_guard(spinlock_irqsave, &host->lock) { + regmap_read(host->regmap, SUN4I_SPDIF_TXCHSTA0, ®); =20 - regmap_read(host->regmap, SUN4I_SPDIF_TXCHSTA0, ®); + status[0] =3D reg & 0xff; + status[1] =3D (reg >> 8) & 0xff; + status[2] =3D (reg >> 16) & 0xff; + status[3] =3D (reg >> 24) & 0xff; =20 - status[0] =3D reg & 0xff; - status[1] =3D (reg >> 8) & 0xff; - status[2] =3D (reg >> 16) & 0xff; - status[3] =3D (reg >> 24) & 0xff; + regmap_read(host->regmap, SUN4I_SPDIF_TXCHSTA1, ®); =20 - regmap_read(host->regmap, SUN4I_SPDIF_TXCHSTA1, ®); - - status[4] =3D reg & 0xff; - status[5] =3D (reg >> 8) & 0x3; - - spin_unlock_irqrestore(&host->lock, flags); + status[4] =3D reg & 0xff; + status[5] =3D (reg >> 8) & 0x3; + } =20 return 0; } @@ -455,35 +452,32 @@ static int sun4i_spdif_set_status(struct snd_kcontrol= *kcontrol, struct snd_soc_dai *cpu_dai =3D snd_kcontrol_chip(kcontrol); struct sun4i_spdif_dev *host =3D snd_soc_dai_get_drvdata(cpu_dai); u8 *status =3D ucontrol->value.iec958.status; - unsigned long flags; unsigned int reg; bool chg0, chg1; =20 - spin_lock_irqsave(&host->lock, flags); - - reg =3D (u32)status[3] << 24; - reg |=3D (u32)status[2] << 16; - reg |=3D (u32)status[1] << 8; - reg |=3D (u32)status[0]; + scoped_guard(spinlock_irqsave, &host->lock) { + reg =3D (u32)status[3] << 24; + reg |=3D (u32)status[2] << 16; + reg |=3D (u32)status[1] << 8; + reg |=3D (u32)status[0]; =20 - regmap_update_bits_check(host->regmap, SUN4I_SPDIF_TXCHSTA0, - GENMASK(31,0), reg, &chg0); + regmap_update_bits_check(host->regmap, SUN4I_SPDIF_TXCHSTA0, + GENMASK(31, 0), reg, &chg0); =20 - reg =3D (u32)status[5] << 8; - reg |=3D (u32)status[4]; + reg =3D (u32)status[5] << 8; + reg |=3D (u32)status[4]; =20 - regmap_update_bits_check(host->regmap, SUN4I_SPDIF_TXCHSTA1, - GENMASK(9,0), reg, &chg1); + regmap_update_bits_check(host->regmap, SUN4I_SPDIF_TXCHSTA1, + GENMASK(9, 0), reg, &chg1); =20 - reg =3D SUN4I_SPDIF_TXCFG_CHSTMODE; - if (status[0] & IEC958_AES0_NONAUDIO) - reg |=3D SUN4I_SPDIF_TXCFG_NONAUDIO; + reg =3D SUN4I_SPDIF_TXCFG_CHSTMODE; + if (status[0] & IEC958_AES0_NONAUDIO) + reg |=3D SUN4I_SPDIF_TXCFG_NONAUDIO; =20 - regmap_update_bits(host->regmap, SUN4I_SPDIF_TXCFG, - SUN4I_SPDIF_TXCFG_CHSTMODE | - SUN4I_SPDIF_TXCFG_NONAUDIO, reg); - - spin_unlock_irqrestore(&host->lock, flags); + regmap_update_bits(host->regmap, SUN4I_SPDIF_TXCFG, + SUN4I_SPDIF_TXCFG_CHSTMODE | + SUN4I_SPDIF_TXCFG_NONAUDIO, reg); + } =20 return chg0 || chg1; } --=20 2.43.0 From nobody Sun May 24 19:32:58 2026 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3DDB3C4B76 for ; Fri, 22 May 2026 09:54:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.182 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779443672; cv=none; b=PBneUszP2b2PuZyccmi1ZF6seEXd7JruwCEaXfP7awiGmMQmxAg1cGpoTsiIJxpzwg6eSY2OXv+O0MVot5L/aONjh566KXubWiCjPeO2LWn7C5KOo0gNy9JP4nHNMvbKssloXVzFLaYtogqa5/i2q7pFAd7SG3AHVIqC0p94VYU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779443672; c=relaxed/simple; bh=FES/LPsuYUEIfYpCxaSWRQknC3l1jlyEQS86EeloiaE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lL/aXpZxUYiNWlVVpvXb6oXhVGh8mmqB/ipx5mxtPrMi8t8izGAVhpWXcqC5y5gmKnD3FmBZOPQr5RVniYHiBwKrCWNR7TC8pAYwgPi6/TdN/lzUxzXu3gCKJYHrDULzkPSQ35q9pJLXxRwgDyXdna35ZzJXCUxR5tJ2Khl37Ew= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=lDp7sEin; arc=none smtp.client-ip=209.85.210.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lDp7sEin" Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-837b39eb078so4832645b3a.2 for ; Fri, 22 May 2026 02:54:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779443670; x=1780048470; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WsLsnv7a/QcqqVOvsqB3nlisoqKckWLxKBBgfnHU3Rw=; b=lDp7sEin6PGJOiHzQsZKoYxIPYRYP9LcWhbD/AAt/EnRGaprlmSTA+FVwvDPD1Fd3n uBSkTn+eO7V3OOnuZ/bXkY2McSjFXkpK4M0499xW/Vktsn0x4pLAvogF30jDkWDxqPNo BW6BrxVLCSPVbO/brLdfgKgQd5ZRgHjjY2oF3ciofobZQaSTozsI5v5JrQexlI5xZU8G WIJJqtr0VU3PH+xmKhanzZrRqvabY0Bbv48RhPM21RnAzeP91fZ6uB0JShYRj/+jJ27h L3NGq0Qy9I8FVUzAqiGDNRKe9yHMg3OhggActWI7lDRhcXhlHTRpx2gz/QLL6IBD4lZE EGjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779443670; x=1780048470; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WsLsnv7a/QcqqVOvsqB3nlisoqKckWLxKBBgfnHU3Rw=; b=S5fFVzntVzDk6yaWL6DB1YAqN4x6C56Y2B1wQAIvSy7sa4Bs66/D0vUQEVcRul9hZB 8/sf9HscPCRX7nWJ4GGW7zCAXh58pAeilFadIiVeei3RVrb2ZdAj8tzjJaH6bDEfFUMa sBKVENSiG8BcBs7AZo4WtXcb0a67ydomeGyjzpAuo5BqNHDCLcheQHqkQUPuOMWF8CV8 IefzJx6yB054U5+3zrqaaWJ1tBSCCKNg1B/0J3RY7rTaCA6acb9ttu6IRFeveo4iaDZz pZdUB3xuaikjB0LFGfTnAipWy176BWxre9nnC5gWguue50ZuqJ0mjV/iuU//y5RQBjSn Ql7Q== X-Forwarded-Encrypted: i=1; AFNElJ/PDAPdgTi+5Ge/LOPMb+JrJk5t7o+R0fblIiNcbWcBCvxzOGmgLv081Pwk1KqNjFSMXDcvj/Sw0Rc0i8w=@vger.kernel.org X-Gm-Message-State: AOJu0YzcE0vxqXhXd8PyFexCjNyfDZuRMDRl1JMwlEcuwXKw+6Q5pFTd YDui31hpxdhIdGvj6Fs04B3YbjlwHP3uy004524EPAEYyY7sbSbhsW60 X-Gm-Gg: Acq92OGCun0ZNgvi79umIQB5ZzwO+E5CwaUihonG2ImoZN++cSQwEaFaf0KdfkcyUxk VMENGoKL0ugTkM5H8mnH18tHsPIKoSDn2PByfJdyUHeaRmUcjzk6biRkFYV70cKImBgBzNZp/Wt LRiepM5njLsINhhWshAoTyGAm0SW8bMYFsM6ec1881AVbP2X6KfuKCYY7CNkZPxmtpX27QBoYxQ IhR3quEP1AyExi6mIQMd7jQupCQUKViTHR2xu4gjOBOLSwEWqeblSTz5scwa5cqnKJTrGRf3bdg 7X7mFR2d2n0xVgttlP3s1Mcl9fPh2WdzFtWLcCUDM+tIAGKqJa0oyV8EeXbFu9a7a7akPzXMJmu siS2jxQoYz6iOAM/0uniKrOMvbyDykuSNP3m1Rm88IwPZr0DRm6c0ecZ94qB17WI7kATD6Bjuy9 wlJLw/MksBVVznXKKVYI+Df9BEzoxOeC4v9pg2OLJVzFvCsRDulxqmOe29m4VCNVQA1Qvo X-Received: by 2002:a05:6a00:2447:b0:835:4776:7d7b with SMTP id d2e1a72fcca58-8415f65c44bmr3236104b3a.42.1779443669845; Fri, 22 May 2026 02:54:29 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84164aed7c9sm1757366b3a.13.2026.05.22.02.54.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2026 02:54:29 -0700 (PDT) From: phucduc.bui@gmail.com To: broonie@kernel.org Cc: codekipper@gmail.com, jernej.skrabec@gmail.com, lgirdwood@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-sunxi@lists.linux.dev, nichen@iscas.ac.cn, perex@perex.cz, samuel@sholland.org, tiwai@suse.com, wens@kernel.org, bui duc phuc Subject: [PATCH v2 2/3] ASoC: sunxi: sun4i-spdif: Resume device before kcontrol register access Date: Fri, 22 May 2026 16:54:00 +0700 Message-ID: <20260522095401.72915-3-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260522095401.72915-1-phucduc.bui@gmail.com> References: <20260522095401.72915-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Accessing registers while the device is runtime-suspended may lead to invalid hardware accesses on systems where the APB bus clock is gated during runtime suspend. Ensure the device is resumed before accessing registers. Signed-off-by: bui duc phuc --- sound/soc/sunxi/sun4i-spdif.c | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/sound/soc/sunxi/sun4i-spdif.c b/sound/soc/sunxi/sun4i-spdif.c index 89eccc83a130..f54eb14c9ed8 100644 --- a/sound/soc/sunxi/sun4i-spdif.c +++ b/sound/soc/sunxi/sun4i-spdif.c @@ -428,6 +428,11 @@ static int sun4i_spdif_get_status(struct snd_kcontrol = *kcontrol, struct sun4i_spdif_dev *host =3D snd_soc_dai_get_drvdata(cpu_dai); u8 *status =3D ucontrol->value.iec958.status; unsigned int reg; + int ret; + + ret =3D pm_runtime_resume_and_get(cpu_dai->dev); + if (ret) + return ret; =20 scoped_guard(spinlock_irqsave, &host->lock) { regmap_read(host->regmap, SUN4I_SPDIF_TXCHSTA0, ®); @@ -443,6 +448,8 @@ static int sun4i_spdif_get_status(struct snd_kcontrol *= kcontrol, status[5] =3D (reg >> 8) & 0x3; } =20 + pm_runtime_put(cpu_dai->dev); + return 0; } =20 @@ -453,8 +460,13 @@ static int sun4i_spdif_set_status(struct snd_kcontrol = *kcontrol, struct sun4i_spdif_dev *host =3D snd_soc_dai_get_drvdata(cpu_dai); u8 *status =3D ucontrol->value.iec958.status; unsigned int reg; + int ret; bool chg0, chg1; =20 + ret =3D pm_runtime_resume_and_get(cpu_dai->dev); + if (ret) + return ret; + scoped_guard(spinlock_irqsave, &host->lock) { reg =3D (u32)status[3] << 24; reg |=3D (u32)status[2] << 16; @@ -479,6 +491,8 @@ static int sun4i_spdif_set_status(struct snd_kcontrol *= kcontrol, SUN4I_SPDIF_TXCFG_NONAUDIO, reg); } =20 + pm_runtime_put(cpu_dai->dev); + return chg0 || chg1; } =20 --=20 2.43.0 From nobody Sun May 24 19:32:58 2026 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E8293C3C01 for ; Fri, 22 May 2026 09:54:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779443676; cv=none; b=aIbbev4k8ZVCjB0QpfifLBmNiiuwYM/eReHQNI5stvZSKYmXoBhn+zPPfxSTaaMmmMXb4iLpjgetgG6ck8mLy4mwcyOlbUHOGUVtYGDxa6eRSiElyd1yxzc9vr4tE1u4qHvVGbA17vsKGT1UhUsP3SaJ5m/BjSVl8x1lLXPm2FU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779443676; c=relaxed/simple; bh=qbDGhHNnk9OCLZQ1PGxrrKjrGTP1fFlGw+ruMcn44HU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MbI1szECP9CYUq06MQqmoPJYrzzcgxHA+ho3jZDsF08QeguH6Ovb7BtWthlalo0fK8JijZFPMD2HYofIMo5vEaqLDYuALlS2/mOUj7+6VTmXtHFKEpuCKn+fSfiA9aVjsqFcvPtQEsZC3X7dNBKwj9owf2Cl6Q+oA84941R7OAo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PZZlWvhq; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PZZlWvhq" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-835b78c3797so3129715b3a.2 for ; Fri, 22 May 2026 02:54:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779443674; x=1780048474; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OZzUxIkdaJ6gBxa9mowChRFjkNJFrAHd972GUGZ8zKk=; b=PZZlWvhqvul1AjFa8ARbD4hZ0tLpuIqOYzY4ugtubN2oEEwTj0IbktdNO3uGSZDvkA 1WkF2IVImCiW7CRKvR4KJnZxaYlIDEeCjM89E5Vf36Npu0UWi8268NK6KobJP2FCQ3oo wGA5LEk1HsJRPuuycAiamTpXXABT7uZO2prKgXbd+VYmlVFTxkyNathLRaA9X4wtcHpc ZerW/NSXnrUIRvf/Ba8BP28RfBXTJuJK++OyR67Ac8vfcYrJXn+FIKFLzA/oXuoCA8wG 00Z0hy5kPuCXT8MYxpX6eQQLJsJrhqfePgOK06m/H47mjSLdNTRyT9PN0tnx3uTXZ3fG ZcYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779443674; x=1780048474; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=OZzUxIkdaJ6gBxa9mowChRFjkNJFrAHd972GUGZ8zKk=; b=ZBsXnZvJhVy0UdZWeJ8RpedkNTRxgFNXlg2rae/164Yh2JH0TPCmDRem8joYhAaCwL QQKLp/EQmy7PdUTryo88fuCR/WgkYlGHab+6EQv7IYqzxKxJGF5hq5qUMT1oB1O7Fje8 7nDiXUc3G8aAKPKQAtNPHEV0jVtKE1uxOANFh2whpgGF21zCYyU+aArkh9GANWfAKzzf DtEugJ3zXYhsqHcSVTj4rUhDmjfbcB1SnbedajOhYrK32W2pIMei4srRRnBFVlsJMm7J jpW9n/gtSWVWxktsuTH02fm/rlm495B72Us0C3MYMXd57GM8xa6i+XG4tloT51yJSGz7 OeTA== X-Forwarded-Encrypted: i=1; AFNElJ/xz9WOJlGGAeBemPsTqqWXgY65y+1VSp4qvCM8X2slY7Npo3zntC7PORM+TlwnrYNVwP6E4e3ilz3SqwA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1cbbffQ+vF580wnlHbeJ+2vEOk8TpxZVWX/sOgW13P+VI5hBN nc2cn7wIe4nVO2NSFxTGMZLMoC+0vKvNUPg+7o+eytV8rfVXc/R9kknk X-Gm-Gg: Acq92OFDnNRP4VYxocdnF2jHNLeYBMiRhT2dMtYL4MeuYbp5PwANgTJQgZDidYwC1A8 Vjr6tckLmurJsEj5NG1tyqAf1XN9Y7ED7iUF3je4MPOux6S6bQ64gpM9pLb08ge27rekeIv7NJE WaQH9HJjnm4ZYPTHpORUFe+ujmOQq330EERABsEIxDolaQRVynpnhR5fd6uxPAA5pIkmaa+jVr2 QxX9sGarTFZ3loov8w/4vNQ0Bu0n3z3hcLxwkWk9wEpaMV/MZPYN7ehpbBycCs0KlRovXzG+IPs TFsh16fCaAXeb5e6fdW5ML68liKJtB139ipnWBBq/6qpw+xl2jv2jL1Shv8rmV93jKFmBeyr7nJ FTj5MraXiG4uxBiC95X58Sr88U9UFhXbc6Rm2Da7uy4LaHRvztdBERrbKdX0Tzjbui0zBU3kDIn RIQz8sUSRtTndjYUoC3y5TRdIJCY9wLo+C+iaJFnM+BLL3NELAHiOWZkFSJA== X-Received: by 2002:a05:6a00:17a4:b0:82f:5726:be23 with SMTP id d2e1a72fcca58-8415f3f68ccmr3185755b3a.49.1779443674325; Fri, 22 May 2026 02:54:34 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84164aed7c9sm1757366b3a.13.2026.05.22.02.54.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2026 02:54:33 -0700 (PDT) From: phucduc.bui@gmail.com To: broonie@kernel.org Cc: codekipper@gmail.com, jernej.skrabec@gmail.com, lgirdwood@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, linux-sunxi@lists.linux.dev, nichen@iscas.ac.cn, perex@perex.cz, samuel@sholland.org, tiwai@suse.com, wens@kernel.org, bui duc phuc Subject: [PATCH v2 3/3] ASoC: sunxi: sun4i-spdif: Reorder clock enable sequence Date: Fri, 22 May 2026 16:54:01 +0700 Message-ID: <20260522095401.72915-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260522095401.72915-1-phucduc.bui@gmail.com> References: <20260522095401.72915-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: bui duc phuc Enable the APB bus clock before the SPDIF module clock during runtime resume, as register accesses depend on the bus clock being enabled first. Signed-off-by: bui duc phuc --- sound/soc/sunxi/sun4i-spdif.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/soc/sunxi/sun4i-spdif.c b/sound/soc/sunxi/sun4i-spdif.c index f54eb14c9ed8..102db1a2afbb 100644 --- a/sound/soc/sunxi/sun4i-spdif.c +++ b/sound/soc/sunxi/sun4i-spdif.c @@ -643,15 +643,15 @@ static int sun4i_spdif_runtime_suspend(struct device = *dev) =20 static int sun4i_spdif_runtime_resume(struct device *dev) { - struct sun4i_spdif_dev *host =3D dev_get_drvdata(dev); + struct sun4i_spdif_dev *host =3D dev_get_drvdata(dev); int ret; =20 - ret =3D clk_prepare_enable(host->spdif_clk); + ret =3D clk_prepare_enable(host->apb_clk); if (ret) return ret; - ret =3D clk_prepare_enable(host->apb_clk); + ret =3D clk_prepare_enable(host->spdif_clk); if (ret) - clk_disable_unprepare(host->spdif_clk); + clk_disable_unprepare(host->apb_clk); =20 return ret; } --=20 2.43.0