From nobody Sun May 24 19:33:40 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E484D3655D5 for ; Fri, 22 May 2026 07:35:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779435341; cv=none; b=J6N3Dumj4r0yl3lp4TMBY7+RmZJ5MknW96+vR3j4vlNGrS8hZVqYZ1RHWUBlWCOLAk0AWDhH3PmgSSBHWWBrSCoQf9PwRX0T0Sv8b2lCK1/naAlxnWtnXMDdRTHH7pJJBar6KEwD/S3Lyaw6hZpP3d/J1mwougpDVzgdrjcVmk4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779435341; c=relaxed/simple; bh=34A3NYQ2nCAvmhCIXKxDkNjNqS+iKEl9ON6EMSLZu4E=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=VGZ/qqbXH08Y9UDkvAM3trWLxvFBYaCCGK3pGoeOG6Egpm5q0nrMw0S4FtquxLmgBYKi27o2ZoBS+PYnzfDVT55Y00Onh169i9dUnvRny7K+LLa7tLWwM2reJrDMV5+3MHEf3L/G4aSVDzA8/hmet2bUVDV7lF6/BxQ4CuOLjXU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=I61iOry/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=MHkbC2CI; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="I61iOry/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="MHkbC2CI" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64M5Q9TZ312836 for ; Fri, 22 May 2026 07:35:39 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=XrO5HrprjNU8qYtCKE6JyzhJV/eGBCYR9oZ lGB26sVU=; b=I61iOry/om8cPUmjIwICmqgXmM6ukhM575yzzZ2LFRS9HKSVVlz Pj/4y3jVwdMkJad13VeoZvv1InEPUUCk9yC/WKMfg4ldxafziHkaq1+u1AKQEpL6 JLiBeFDEhgF9/z2vuHSA4mxgoOKwmLu25gv/M/u6s4xuvF1jgWgHC4GkEMnScXfz BwKGpez8J+C2w4enV6rvD1lPdVOC16luBn+w+kIwkOq1eRN7QYLeruzdPXQ3Voiv i7+47+e6GW3sqQhiBFYYwrhUnGse6IZRn6LJOSDyAzJ2pK+FVE7Cuvb5nWfpndxd e8gL/immyvyDipO9npXsg7w+t8ul0qQoLIQ== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ea8832fbh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 22 May 2026 07:35:38 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-516458449d4so106732411cf.1 for ; Fri, 22 May 2026 00:35:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779435338; x=1780040138; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=XrO5HrprjNU8qYtCKE6JyzhJV/eGBCYR9oZlGB26sVU=; b=MHkbC2CIAFy0rpViPpmo02jPEva3C0TvZtlz8qmIyeRAcrnV69X6Mgj9Wsx4byO9BW 0cgdwJokFEab0bio/DPsBkaWyX0YO4RAXYe/gE0nisLhLDhQXS03nQnzJ0kf+tYLgWUm nKy+IpQvN4Mf4zIWBMvRYdL1qCcrQsdiP947XY3Ld52xut6DhHIoC8njpkY8jFaVb6VH M6hvSL+/sVZ4uuFrS0OTNeMSyOWFIWEW0ns0tdi6iFsZKBpzUd3T/Gw3Mnen8Ov5Byt5 +nND32ZTeIOEpH6uS7yi8gJb3wlXBHwO1+F7yH8D9MfL0z6MA+J1AbSWhx9zqrSfwtTC kLCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779435338; x=1780040138; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=XrO5HrprjNU8qYtCKE6JyzhJV/eGBCYR9oZlGB26sVU=; b=slDpoo/mQC1NBvc141/XVWKJC9smr/xNj4sUYX0XtFE9Iy51nVvazth9tIxJiDUkFC I9XJrn/S8zGsLbErrulM56HcDAu2g51jiKDMmcwaAF0L1JmlM5l3dDe6hdZ0g2JNAo7S JXGh3niTKGqao+FSArcYJni6eKlZvzdwXwXKkbKC5gNmU7G4GQzhNvjayLA+KzyAnuS3 I6IufiYU/zOibXnNWT2Kw+25fHsbSWQIYxsIodxmO913kV2JNNoC8gj69tWMfBW8tDsM znePDTvIqwV/W/aaAoPAteekY4YF8nbj8zHqQS8ansp1788xhQd7xCXQpH9hvIuGw4CR SWnw== X-Gm-Message-State: AOJu0YyfiEjqhs1MXcr/g8Jioi95PLIoL6mrzj6cjiibTt15E3u/Y/tQ 4Qq7NOH/Bp6/76oxlYp1GmDrcwQJ5Lr8vMvGnQQZRnHU7w4g+tMEw07t5rdlBSxG5yVu04JLgek glEGYpTCFx/AHRmCb5r1jfnuJgx1EXnGsMT0vNTTZHSFbAcPIxmUSXgOjxOb77/udZqI= X-Gm-Gg: Acq92OEl1neDSriOGQ6fqOuBHSUxbfnr1tJ8vXGrpwCMmdiRaMPxFZjFbzdAcMwgMyW 6s/quiVTEaD/+L1pD28/osTObmwvQdMZsQMNmLmGJym2MjnMOty5JEfzzb4v7KIw2+eiLo8aW9K QxMI1yj1OZxGO1EvzDS321XXphgnvWt/MFDFbUHCMZU1sFBKiLNJ5I7oZR+eRWdOHn41D8NLFKV 4TMSfdUmailq7aiH4fCeayb/oTK2aAhgNmV0GL3lCBi+O7zUaZzKgI+YgxatCcuHe5KZqL8Q0qq 2RzTdw1xR5TZZ+ORV3dXtGhr3z7zsvhizEGOO2pnkiOVia6TtctREbj8bFiORpw00DZJwWxG79C Yz8pkSZi4axvKPDgOU8TkrUWpfyTkj4DkO3KfyR+3QiJyTSX6 X-Received: by 2002:ac8:5cd5:0:b0:509:2b02:c1bd with SMTP id d75a77b69052e-516d442805fmr40940531cf.12.1779435338159; Fri, 22 May 2026 00:35:38 -0700 (PDT) X-Received: by 2002:ac8:5cd5:0:b0:509:2b02:c1bd with SMTP id d75a77b69052e-516d442805fmr40940311cf.12.1779435337812; Fri, 22 May 2026 00:35:37 -0700 (PDT) Received: from brgl-qcom.home ([2a01:cb1d:dc:7e00:2fa:6280:a48f:fb37]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49042aeafa8sm9768775e9.27.2026.05.22.00.35.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2026 00:35:36 -0700 (PDT) From: Bartosz Golaszewski To: Linus Walleij , Bartosz Golaszewski Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski , David Lechner Subject: [PATCH] gpio: adnp: fix flow control regression caused by scoped_guard() Date: Fri, 22 May 2026 09:35:27 +0200 Message-ID: <20260522073527.9812-1-bartosz.golaszewski@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIyMDA3MyBTYWx0ZWRfX7/tk+QUdcFPH VohhUr20T9d6rBQPzMiPrp8FN0HICe5VKUzX3hK1YqREfJyY+ILqPPq8XleZfCx+fvL/3xY6lzB PFmKDXJtQ1jqN129WbVide2ZOoYe+jT1KZseUhj3ApFlSFmSSCFX3TDh6vyqFVuZuTQvXIbssW/ gIKf5SP5bREU9q/XGw/JTb9/sfahxDoZpzTITdcvuyCA/YXZvF3TrfpCuxCXxZHvZvIiFRScEOR mUcKieC5U1STqAo1CeBya+6GTjwyGG+bZrvr/jh8FSFTO8Ym7ANagYFVSKmv+wSeRUrNDmnzSt4 vD2L4uijUZYlgqTWKHv7jz8whfiBzoGR4bk7Y2OS+vOrkrf7Wcc99Bn9a+Vy15MWB2G116p74kT Ep06ifWzD1MLCVfseD1lJtwRKwQEfhtuZ1y4espysRsFWiabc+opJajWLg36CdG6eEsTIB/End5 iAeb/IPxySIBwCVehQg== X-Proofpoint-GUID: u5SZ4CpvtUdyCWQ5sIYvkPGURLYo4eTZ X-Proofpoint-ORIG-GUID: u5SZ4CpvtUdyCWQ5sIYvkPGURLYo4eTZ X-Authority-Analysis: v=2.4 cv=LsSiDHdc c=1 sm=1 tr=0 ts=6a10074a cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=VwQbUJbxAAAA:8 a=IpJZQVW2AAAA:8 a=EUspDBNiAAAA:8 a=VaRsTcMx-6-8SV5EPosA:9 a=uxP6HrT_eTzRwkO_Te1X:22 a=IawgGOuG5U0WyFbmm1f5:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-22_01,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 suspectscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605220073 Content-Type: text/plain; charset="utf-8" scoped_guard() is implemented as a for loop. Using it to protect code using the continue statement changes the flow as we now only break out of the hidden loop inside scoped_guard(), not the original for loop. Use a regular code block instead. Fixes: c7fe19ed3973 ("gpio: adnp: use lock guards for the I2C lock") Reported-by: David Lechner Closes: https://lore.kernel.org/all/cde2abb2-4cc8-4fc9-b34a-0c5d2b95779f@ba= ylibre.com/ Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-adnp.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-adnp.c b/drivers/gpio/gpio-adnp.c index 27a80d1143a1..350feea2afa3 100644 --- a/drivers/gpio/gpio-adnp.c +++ b/drivers/gpio/gpio-adnp.c @@ -237,7 +237,9 @@ static irqreturn_t adnp_irq(int irq, void *data) unsigned long pending; int err; =20 - scoped_guard(mutex, &adnp->i2c_lock) { + { + guard(mutex)(&adnp->i2c_lock); + err =3D adnp_read(adnp, GPIO_PLR(adnp) + i, &level); if (err < 0) continue; --=20 2.47.3