From nobody Sun May 24 18:42:30 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D620A36A352 for ; Fri, 22 May 2026 12:08:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779451703; cv=none; b=RJVGE4uqrZcz+Efb94Y7I4nAK61GCEmJ3Fv6UghAxe6p2sx2gVl1USFNzdi93Cho0tFg6drPX9ncr7BoR8MwzrCrl/+9+y4hcdcygJ+NH5dMSXr2/2Qe6NeE4anO5z9eLaavTCVSEJPLPtRyWHCnencggRrJ6EqPMMhlgnspaeE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779451703; c=relaxed/simple; bh=/sVcLq/SnB7dgVSyU5tIaVlIonGAraV4aUcqKdWR0Sw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=l63eF2HSsIQ/xsVXzjwW8iDEEFnLL8wfaTzw0Zwr0Fs8c3ve/kMyTCKeJMMgKnGetwWRZ5ReRN0jikgjkROPhXK5KHOmSOKKmcUc8ncDZcILGRRgzhfsyaQrsKakbnEN35uJ1oq09B2tyWIpYwmDt7VYQql/04X34cnQCkxvG7A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Ns6eEsYz; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=E/XFA/gA; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Ns6eEsYz"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="E/XFA/gA" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64MAUH3l312910 for ; Fri, 22 May 2026 12:08:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to; s=qcppdkim1; bh=l/EbcWlaCT4k9N1N4GMX/Z 2U8nuDy2ujSl/x25p/kuc=; b=Ns6eEsYzVQ4Ww85UapDiKBk7AkfjNUw1ky5KdB tm39HeL8e5JgioV571BIcubNsAJk9rF+AhbCOExQWdXHvhzExw1rHUa12adQGnli rwNbjXHH5yFBdYxcvBhzuVByFh5WuMyCA2A7wI9wMK1u90hPexSeZpNu1vmBg+4Q OFKc8TYUCpTV8IXqz9ZzM5xpFxv2Ja50Hsd4iI9iRYINZXlCMYDYbAetL8o/0dne 6e1XUgZ+zfK0Koixcau5lu71yvi/lja1MFu/LSdGuvXaNWsWHD4OyJPCoiIMD6J6 BmGa8zF+qgr5BnTAGnTpXiuFqlSKwvotspBKBYIfoyZ8X6qg== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4ea8833pww-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 22 May 2026 12:08:20 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-8353fbc7ad5so3676621b3a.3 for ; Fri, 22 May 2026 05:08:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779451700; x=1780056500; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=l/EbcWlaCT4k9N1N4GMX/Z2U8nuDy2ujSl/x25p/kuc=; b=E/XFA/gAC8glGy3jARMOKxpbO4rzsG9yhliKgyPFLBUiklCbNweWRHWd2ZyPROVTlr 5QI7I8VBjpR8YmPWOq5favPBun89bXIi4gGydKCzij8Sx1zCb5kRM4B2Rg9BxXwVZR4y iht/KhEIwMwhE8sjJ89Wr5Z2yqv3W+X7wZeCILI/vve5taA1TPd1UsDPVC5nPY++0EtX Wkt7OTygms53YON3LSh/9lQBY0nhU7F7JVokKeEraF7jvU5oimCjDaygGS4wHSbxysNP hDhuNpB8ntkUG7rpMToma81a/kuqrx6EArjvEK4t+zEgl1yEoDl+90GmDGqdTab1140Q E7qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779451700; x=1780056500; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=l/EbcWlaCT4k9N1N4GMX/Z2U8nuDy2ujSl/x25p/kuc=; b=Bg/xEzbCO5f8adMAYcFMogkdOuglMVpxOPcFT0dvBhxKHy96MF5P7Gja2pSZDZhaSZ zZW7pRnCxPWD4C7TE0I1lD6ES/kok2wQSS3l860f2gqsnXHgwpxyTqfDpS7cs+EZFt4p BgJMWMyyqSIIl6yaoCOCLoOZkI8yGtNwxIiYEgSbtpNKS3bHO6w6bUCgFsowi4Z8kq3t xoVzst4QLOY0tio+7B6LC+m06NRBM0HXVbjiF0iDW/Oct+gwoRYeg1pVKRM7JlaPX7ds yFRiehKFMVqZGQyuAKTjclKIiiULSWjXEi6MZGDbir1yOL2XInmjlrYPKtuQzzCsDEhs 5Zwg== X-Forwarded-Encrypted: i=1; AFNElJ9aXQhAYcJiH7dW5EOXCDpbM5fyW1ip1scy8aUqNghF6EsY84BrVVpseAI7Ibe6VwtFWK7ypg0Kt7UOZoE=@vger.kernel.org X-Gm-Message-State: AOJu0YyQN/OARocLQGPHEN8rPkFp7gP3nf+agsX4rDp6Joo3FRghfIG7 KZW8syOiplk5jxwZ3uwtpnPgdgi3d6qNQVZWKJUPjplHrT/N3/V44OVRQFRY9Ix7+sIwIDzjVRr qdaGTlhfKlc0E1Lhfn/n+k8mjB6uT6haO3/9k+nup+G7ImFu8+FN+gWcjlZsYbB9G7IM= X-Gm-Gg: Acq92OEIyq79lIK0QH4WnbKdjud5Y5+Q0UsDBF71Tm+SsiVKuKdtdl6kXj6vsbQAuWi L+gXriROP0vCkWfQlgHIyvLsjhI0DRN4zU5Gdo6lFlK3l+gDt59ywuLht6rMCScaOrwrjfdVm3G 3xPgIvDTk4iLXTLMePdxWhLuTpLi7hiGCXFD+p7ptnavOfgDdDWtpjKyAmaPRGLVRPEGWP8zK0b NB8RgXd7h6fr5mJmD6mayFOw8B+0sb3OdTUBFR8HeF6dWic71iSeE0ohTqS7E0n8QyAHcBQsFyh yj/zleUdyHZ8EeD4n0xp/FOVM6pfIBH/hTVCgzHLw/5QoEK72qPa1o7FXeDmvErs5XAt9uyIhTq TBNoz4eiQfkg5jVp1m9zTu1xVtPpcM3NlQxtj8QFgJId/RMSBeZWTKcFnlK7aJWn3k80N1Wvgs6 K0tV7q6vnT/ymlFQ== X-Received: by 2002:a05:6a00:8c04:b0:835:cc47:6fe3 with SMTP id d2e1a72fcca58-8415f3b0825mr3980560b3a.45.1779451699708; Fri, 22 May 2026 05:08:19 -0700 (PDT) X-Received: by 2002:a05:6a00:8c04:b0:835:cc47:6fe3 with SMTP id d2e1a72fcca58-8415f3b0825mr3980523b3a.45.1779451699170; Fri, 22 May 2026 05:08:19 -0700 (PDT) Received: from jinlmao-gv.qualcomm.com (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84164ffee25sm1812820b3a.58.2026.05.22.05.08.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2026 05:08:18 -0700 (PDT) From: Yingchao Deng Date: Fri, 22 May 2026 20:08:06 +0800 Subject: [PATCH] stm: p_sys-t: Fix su_mutex held across wrong region in interval stores Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260522-stm-v1-1-cbdbab9f9ee7@qti.qualcomm.com> X-B4-Tracking: v=1; b=H4sIACVHEGoC/6tWKk4tykwtVrJSqFYqSi3LLM7MzwNyDHUUlJIzE vPSU3UzU4B8JSMDIzMDUyND3eKSXN2kFFNL8xRzk9RUsxQloMqCotS0zAqwKdGxtbUAo6b7W1U AAAA= To: Alexander Shishkin , Maxime Coquelin , Alexandre Torgue , Greg Kroah-Hartman Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, quic_yingdeng@quicinc.com, jie.gan@oss.qualcomm.com, jinlong.mao@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, Yingchao Deng X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1779451696; l=2360; i=yingdeng@qti.qualcomm.com; s=20260521; h=from:subject:message-id; bh=/sVcLq/SnB7dgVSyU5tIaVlIonGAraV4aUcqKdWR0Sw=; b=iq04wTDJ+dwmeDvU5JNknfPq72An2aZOs3OXggQ9Mr6YMyqOSbKSWtqbAHtKFIPDscitKO2s8 KlEPFIxmw8oBDj3yBZx6SrxqAouGX4Njs5Zaz4PvxlM/67ADCSShj7a X-Developer-Key: i=yingdeng@qti.qualcomm.com; a=ed25519; pk=YbHeeX0Qzqo7voZLva784lFhVChB9yF3a4sceW95ljA= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIyMDEyMSBTYWx0ZWRfX7WQ68YSRUqwU BQBDfNi35sZ82W5uM7Z1IRN6Lt717hY7l/Thlghw3AHdq1rQm55i1g1NuevlvsFrsyUPurlD2TR C067NlS98c91VUQDIvP1eb2NUNNcLmXspghEJtUOfCml5A5FirVX2GunbsetZlOOYzqFBSINsiv j+BMzpgek+C2mtzSamKFyvVkCIhYn2IOxfYufZwFRVi1FgEm2BSXJstzDAK2KTd20K2rjy8/26t QP//B216KyZJDKNgNXK8iZ0XLxSo/GaDkMSOgKC6Q+XgzWMrZnj29TucGFxw3V3jbiZ0XW2zlvf gjlSwsFT39283Qx8ORKAnklyFpoBoJBmKsE0nL7nR/UzZe/GxXM63zOmjBl1fKHVhCt1/wAJx3S OhONbWOJUd9dX+xiSQ9wvnvQmeJxz7jdbheBJ5ZRiyNl//e1BAzy7IgGSE4lkt3qpcIbApa6VKn z+6GfX2UNrdjBIxBGkw== X-Proofpoint-GUID: hIOWyBmbDHWzlWSdwcJ6d_dYcLe_xEsW X-Proofpoint-ORIG-GUID: hIOWyBmbDHWzlWSdwcJ6d_dYcLe_xEsW X-Authority-Analysis: v=2.4 cv=LsSiDHdc c=1 sm=1 tr=0 ts=6a104734 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=3pKDUSyV39LOQavuatcA:9 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-22_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 suspectscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 clxscore=1015 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605220121 subsys->su_mutex is used here to serialize attribute stores against pdrv->output_open(), which copies the policy node under that mutex: stp_policy_node_lookup() /* acquires su_mutex, returns holding it */ stm_output_assign() pdrv->output_open() /* memcpy(&op->node, pn, ...) */ stp_policy_node_put() /* releases su_mutex */ The comment in stm_assign_first_policy() (core.c) makes the intent explicit: "This allows the pdrv->output_open() in stm_output_assign() to serialize against the attribute accessors." sys_t_policy_ts_interval_store() and sys_t_policy_clocksync_interval_store() however acquired su_mutex only around the kstrtouint() parse step, a pure local-variable operation with no shared state. The actual writes to pn->ts_interval and pn->clocksync_interval were left outside the critical section, defeating the serialization entirely. Move the mutex_lock/unlock to bracket the pn field assignment instead. Fixes: d69d5e83110f ("stm class: Add MIPI SyS-T protocol support") Fixes: 39f10239df75 ("stm class: p_sys-t: Add support for CLOCKSYNC packets= ") Signed-off-by: Yingchao Deng --- drivers/hwtracing/stm/p_sys-t.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/hwtracing/stm/p_sys-t.c b/drivers/hwtracing/stm/p_sys-= t.c index bcbbc4d92325..077b62ca3f46 100644 --- a/drivers/hwtracing/stm/p_sys-t.c +++ b/drivers/hwtracing/stm/p_sys-t.c @@ -210,12 +210,11 @@ sys_t_policy_ts_interval_store(struct config_item *it= em, const char *page, unsigned int ms; int ret; =20 - mutex_lock(mutexp); ret =3D kstrtouint(page, 10, &ms); - mutex_unlock(mutexp); - if (!ret) { + mutex_lock(mutexp); pn->ts_interval =3D msecs_to_jiffies(ms); + mutex_unlock(mutexp); return count; } =20 @@ -241,12 +240,12 @@ sys_t_policy_clocksync_interval_store(struct config_i= tem *item, unsigned int ms; int ret; =20 - mutex_lock(mutexp); ret =3D kstrtouint(page, 10, &ms); - mutex_unlock(mutexp); =20 if (!ret) { + mutex_lock(mutexp); pn->clocksync_interval =3D msecs_to_jiffies(ms); + mutex_unlock(mutexp); return count; } =20 --- base-commit: 80dd246accce631c328ea43294e53b2b2dd2aa32 change-id: 20260521-stm-bd597d74ee6d Best regards, --=20 Yingchao Deng