From nobody Sun May 24 19:33:39 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1250F384CED for ; Fri, 22 May 2026 06:39:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779431967; cv=none; b=H5Tg17wif+dq+JpVOa5UjyGG1z1UCtwMzqkI00PBvjXtSJb3ZpQoAGAQoDS9syOWuU7EKeguyx69sHuyDsMCuuYBQxi0pxeM0PgugASSpHstQ8YY+Ud4jzbXr3gulg9Dbd4DIwpJ+x3aQR/Ay9SBae40G1QbXC5HGg+ALftR2w4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779431967; c=relaxed/simple; bh=rvFFneORD0Dbgh2QGrsz1FyVUySZSlf6xvEpguD3GD4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QDX2kvs9J8RlaMXLrlZbgcsnU7lmT2ClBL687aZ1zn/4ipo7PN/eUz1MNKdL3NyVpePvS3r4cC4Co4yowZvqDcdWWxImVQHgSCEZ4t/+2vHIzt7XfXYw710Ldkn3MBMsY/FvB9VfcoTo0Qo6K6HbpL4zy0fhPFYE3JAqcM9rkos= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WYUducgv; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=XN5GOiR9; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WYUducgv"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="XN5GOiR9" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64M41lmr3005110 for ; Fri, 22 May 2026 06:39:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= S7lZAB3LZQPlM8w6vhzswPmoYQZmKcDj4rpm1SKgcRw=; b=WYUducgvS09R13PQ ufAd6Ym8IkWmN7x5rtutByRonHvT/u03XVKN8kIdXW3t2sthJoEQyd+36PBxdy2H 0bouMYmiUE5ab93JBF1YPWuUCTitWEh5lhbfRxdJxQUjLI5X1aG47G8ijsYLzF44 q0MhtOfQvgKjRIlvVATly+Sy2aVYd+lOfQzbXjBtLYg7JjmYkWu48nxmbfDv/iHV W7THG6O/quYfQ+YxVmpFd7F8HRr9Mlfm+954hCoNwqEEChk/UYRfmXF2Ya2IRBag msqXw4VzzaH+Wx5sKTAKeJcmA+ZzLVo4/QnRj3KSfULmCoynlfL+tQPrpRda9ztA x1RCQA== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eafrt8f82-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 22 May 2026 06:39:25 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-366122e01fcso6943745a91.2 for ; Thu, 21 May 2026 23:39:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779431965; x=1780036765; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=S7lZAB3LZQPlM8w6vhzswPmoYQZmKcDj4rpm1SKgcRw=; b=XN5GOiR9ruA+CowWqk4JSfF8R5HG4wOUSF21925KpfSGU6ub1ZlqcM1kedqYLWseeK CFWuVDaJMVQy8k9FKSGTn2+iG8I8jpm5s19WDpGGLNQmSyLRIA8fkPIzEVkjiJGq+ayO QTfh6V6NLDjJQyPFtrXgA8TJabUlMnXtjFrXG8+lVlCUCZ2cJmDUH+WUj21eBeY1xEW/ jBHirJt/71D23R8Efdb17o1xmtasaaQKRjZNgKjgyVyrFH8js3fo3nfSDVBkmtFyoWyK LGSSkLfHpAkxpVUR9NfuQE+7wxAtZ+Re0nbwpL2PRcMluSDymsNJWHsCUNh7ynvA6TKw vVYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779431965; x=1780036765; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=S7lZAB3LZQPlM8w6vhzswPmoYQZmKcDj4rpm1SKgcRw=; b=T1alFg4bYJIgM0LlW/fYE4i73bIyfiGFyOzvVMmAz69I6/qKWIvuCiLdYR2p0oe9mP BR3SD1k2TEKOndAVHthVmyU5oPZzPICKoHbiqqeIONFl3AE4zk7xxnaSwhz1pJ0UP/+9 0H6NbC+IiT9GPvtD5KpD3qor7wVy8hgsrZmwMN6wwVBcz5J87GeZZqELPt9Q0NG20pDf uhamgWVMWZsaHIxQbDEOooB2AJhMfRwhWbjHavkrbhCnSRLqO45QG+EeyUiMM1v2bLVF lcv0iODbjJy1z3cICT3E0vq2FJ+HiibTacis5BwYDBU7RAiTulvRE3tJbhuVPDVtkPtv VQng== X-Forwarded-Encrypted: i=1; AFNElJ/y5XvnUdVZ5gUM9VOHysHEcoYJG8dTqpTfE5d4GHymlVMtkuTk7GQPvz01fLxNsEyixAWrick3Qt2qoig=@vger.kernel.org X-Gm-Message-State: AOJu0Yy1tTNaIP/9/JqBbeobQrPTwTOHM76kfSR+xRRVZwg5GKdBjZ97 yPUtgBnMtqGljF4cpZfiN+IO4KfvU5SWBzMSOrSdpbd3KiHtBQsV5/tPHPsMYY+xBbDtogXmxKf CzWdaEf+dl5vcrSlfUC5V6Z4vwTv2iOjMvrgKyTGQLw5oiXmqwB0wdhZiJMXgkI9IUkw= X-Gm-Gg: Acq92OEOLICZ/V+4mLwolTMj+JCVY7S/PbG7lQSDfBU1HegLW8+Y5p3XA7Jlr76+CFT FiuojxkjHnO3m73CUOqK4FyTmn31k04uh32jGDxWwWMD/QRhw0xt7YQLJ6DeiCkMT0soSZe91PD I4xN0SzYeEhP1BFrhAMEIK32EC9RV99MLX3FWEwuDnYSRcC+1Dsv35C1EmpEaJvegnPySn5qGPU b0dRd4LhIsnTESLWUygDNqrGvfRGUXx2iJEbM8Cf3eDK8JQIsOFP8nJO6vSaX8slypPigQi2WAg e+FsXCpa8QHguQRa4sAUhhesrV+Emw7TNudEEmPuXv7BLBcySR78wUakE4r1pApXQrjRC3G0dx7 Z0aCFxULoWoGx3z9jMBY4+8vou1/+IwvhUgZWvqQMWK8QVTpoUisk1R3B+c49YhvmsefRcpwuvp L567qpnwpyJ0R3Uf6DShW402QqWHqjZgKXSyMSjlEjLccCV1eLUas= X-Received: by 2002:a17:90b:3f85:b0:369:73a:3266 with SMTP id 98e67ed59e1d1-36a67765ae5mr2314782a91.10.1779431964562; Thu, 21 May 2026 23:39:24 -0700 (PDT) X-Received: by 2002:a17:90b:3f85:b0:369:73a:3266 with SMTP id 98e67ed59e1d1-36a67765ae5mr2314750a91.10.1779431964053; Thu, 21 May 2026 23:39:24 -0700 (PDT) Received: from hu-yrangana-blr.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36a72c4cf56sm888822a91.12.2026.05.21.23.39.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 23:39:23 -0700 (PDT) From: Yuvaraj Ranganathan Date: Fri, 22 May 2026 12:08:59 +0530 Subject: [PATCH v2 1/2] firmware: qcom: scm: add trace events for the SMC call interface Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260522-scm-tracepoints-v2-1-e27cdbe0c585@oss.qualcomm.com> References: <20260522-scm-tracepoints-v2-0-e27cdbe0c585@oss.qualcomm.com> In-Reply-To: <20260522-scm-tracepoints-v2-0-e27cdbe0c585@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio Cc: kernel@oss.qualcomm.com, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Yuvaraj Ranganathan , Konrad Dybcio X-Mailer: b4 0.16-dev-d5d98 X-Developer-Signature: v=1; a=ed25519-sha256; t=1779431958; l=5541; i=yuvaraj.ranganathan@oss.qualcomm.com; s=20260506; h=from:subject:message-id; bh=rvFFneORD0Dbgh2QGrsz1FyVUySZSlf6xvEpguD3GD4=; b=iePkhOojhdQmuelXiAzmxaG4/Ye6BEtUfQIcjJ9U8hxA3sgRyKSkr0VTRx8NvM7TQlPWqK4Pw dEZa0cg/Zx9A3mwpeEkx8wdhr3hriSk5369HudBdz6mb5ZZI1OF0Ryq X-Developer-Key: i=yuvaraj.ranganathan@oss.qualcomm.com; a=ed25519; pk=ln7RObom4c2W8MEnQqwZbOi6X198/6toN51al5+6rKI= X-Authority-Analysis: v=2.4 cv=JN0LdcKb c=1 sm=1 tr=0 ts=6a0ffa1d cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=9OSSLOKjDFKvovXBaDAA:9 a=QEXdDO2ut3YA:10 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIyMDA2NCBTYWx0ZWRfX7errYV0jm4Gb jsN5hk8YJCW6YxHpU3Q2j+ab6f4WkkNJItoGSc2gVq2NJZjl3ms5dr7WaFHHvABimYF4TuIZts3 YQjLpTbnoKWZ0bo7Pd9P+wHtvwPhSIwmCTxWKbr/L4bLnVmnki8ecfFc3F679Y0bNVumnBhAMKZ rnsKSwdq2DKbyDtPjoGkOLUD8E8ntOeRLlaAMD9qkCELLA0V7GC2xmnaNIkcptaDSmnDBySdpLC cwrInRGqRJVrtfBt19InJDVSYVv+cMuHKeQXsvcx+sn+0rynLW9aU0Pgg2ZZx45ye5RNHz9pJEd R7/shiw66LmcpIbhqj5zvMWNgDYIwTQhITUpBsgPiL5HpkNpo3tg68dqeyI2NoNDG+e4uIp8GuN 1Wp8q+/tA3KKcraArFUlc9hBmmQxXcAdvwgWDK84IVnZ31Pi67KI69n6q1mS1rEORoag1I8bSci bKkSPKWhwSPHPzVJnkg== X-Proofpoint-GUID: -lNZhxAF0hV6A9Q14bwVY0sHT_djCEh- X-Proofpoint-ORIG-GUID: -lNZhxAF0hV6A9Q14bwVY0sHT_djCEh- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-22_01,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 impostorscore=0 phishscore=0 bulkscore=0 clxscore=1015 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605220064 The SCM SMC call path is opaque at runtime. Stalls caused by firmware congestion, QCOM_SCM_WAITQ_SLEEP/RESUME cycles, and EBUSY retry loops are invisible without recompiling the kernel with temporary printk statements or attaching a hardware debugger. Add five TRACE_EVENTs covering the complete lifecycle of an SCM call: scm_smc_request Emit before each arm_smccc_smc_quirk() invocation. Records the SMC function ID, decoded service and command identifiers, argument count, and up to six register arguments in hex and decimal. Because the caller loops on QCOM_SCM_INTERRUPTED, this event fires once per physical SMC instruction including inte scm_smc_done Emit after the outer __scm_smc_do() returns, pairing each request with its final outcome. Records the SMC function ID, the kernel error code returned to the caller, and the four firmware result registers a0-a3. scm_waitq_sleep Emit when the firmware returns QCOM_SCM_WAITQ_SLEEP. Records the wait-queue context and the SMC call context handles required to issue the matching WAITQ_RESUME. scm_waitq_resume Emit just before constructing and sending the WAITQ_RESUME follow-up call. Records the SMC call context handle being resumed. scm_waitq_get_wq_ctx Emit after a successful WAITQ_GET_WQ_CTX fast-call. Records the returned wait-queue context, flags, and more_pending indicator. These events let ftrace and perf reconstruct the full sequence of firmware interactions, measure per-call and end-to-end latency, and attribute waitqueue stalls to specific service/command pairs without modifying driver source. Reviewed-by: Konrad Dybcio Signed-off-by: Yuvaraj Ranganathan --- drivers/firmware/qcom/qcom_scm_trace.h | 143 +++++++++++++++++++++++++++++= ++++ 1 file changed, 143 insertions(+) diff --git a/drivers/firmware/qcom/qcom_scm_trace.h b/drivers/firmware/qcom= /qcom_scm_trace.h new file mode 100644 index 000000000000..6c911124fc56 --- /dev/null +++ b/drivers/firmware/qcom/qcom_scm_trace.h @@ -0,0 +1,143 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. + */ + +#undef TRACE_SYSTEM +#define TRACE_SYSTEM qcom_scm + +#if !defined(_TRACE_SCM_SMC_INTERFACE_H) || defined(TRACE_HEADER_MULTI_REA= D) + +#define _TRACE_SCM_SMC_INTERFACE_H + +#include + +TRACE_EVENT(scm_smc_request, + + TP_PROTO(unsigned long a0, const struct arm_smccc_args *smc), + + TP_ARGS(a0, smc), + + TP_STRUCT__entry( + __field(u64, smc_id) + __field(u8, svc_id) + __field(u8, cmd_id) + __field(u8, args_cnt) + __dynamic_array(unsigned long, args, + min_t(u8, (smc->args[1] & 0xF), (u8)6)) + ), + + TP_fast_assign( + __entry->smc_id =3D a0; + __entry->svc_id =3D (smc->args[0] >> 8) & 0xFF; + __entry->cmd_id =3D smc->args[0] & 0xFF; + u8 n =3D min_t(u8, (smc->args[1] & 0xF), (u8)6); + + __entry->args_cnt =3D n; + + unsigned long *dst =3D __get_dynamic_array(args); + + for (int i =3D 0; i < n; i++) + dst[i] =3D smc->args[2 + i]; + ), + + TP_printk("smc_id:0x%08llx svc_id:0x%02x cmd_id:0x%02x args_cnt:%u args:%= s", + __entry->smc_id, __entry->svc_id, __entry->cmd_id, __entry->args_cnt, + __print_dynamic_array(args, sizeof(unsigned long))) +); + +TRACE_EVENT(scm_waitq_sleep, + + TP_PROTO(u32 wq_ctx, u32 smc_ctx), + + TP_ARGS(wq_ctx, smc_ctx), + + TP_STRUCT__entry( + __field(u32, wq_ctx) + __field(u32, smc_call_ctx) + ), + + TP_fast_assign( + __entry->wq_ctx =3D wq_ctx; + __entry->smc_call_ctx =3D smc_ctx; + ), + + TP_printk("wq_ctx:%u, smc_call_ctx:%u", __entry->wq_ctx, __entry->smc_cal= l_ctx) +); + +TRACE_EVENT(scm_waitq_resume, + + TP_PROTO(u32 smc_ctx), + + TP_ARGS(smc_ctx), + + TP_STRUCT__entry( + __field(u32, smc_call_ctx) + ), + + TP_fast_assign( + __entry->smc_call_ctx =3D smc_ctx; + ), + + TP_printk("smc_call_ctx:%u", __entry->smc_call_ctx) +); + +TRACE_EVENT(scm_waitq_get_wq_ctx, + + TP_PROTO(u32 wq_ctx, u32 flags, u32 pending), + + TP_ARGS(wq_ctx, flags, pending), + + TP_STRUCT__entry( + __field(u32, wq_ctx) + __field(u32, flags) + __field(u32, more_pending) + ), + + TP_fast_assign( + __entry->wq_ctx =3D wq_ctx; + __entry->flags =3D flags; + __entry->more_pending =3D pending; + ), + + TP_printk("wq_ctx:%u, flags:%u, more_pending:%u", + __entry->wq_ctx, __entry->flags, __entry->more_pending) +); + +TRACE_EVENT(scm_smc_done, + + TP_PROTO(int ret, u64 smc_id, struct arm_smccc_res *smc_res), + + TP_ARGS(ret, smc_id, smc_res), + + TP_STRUCT__entry( + __field(int, ret) + __field(u64, smc_id) + __field(unsigned long, res) + __field(unsigned long, res0) + __field(unsigned long, res1) + __field(unsigned long, res2) + ), + + TP_fast_assign( + __entry->ret =3D ret; + __entry->smc_id =3D smc_id; + __entry->res =3D smc_res->a0; + __entry->res0 =3D smc_res->a1; + __entry->res1 =3D smc_res->a2; + __entry->res2 =3D smc_res->a3; + ), + + TP_printk("smc_id:0x%08llx, ret:%d res_to_callee:0x%lx res0:0x%lx res1:0x= %lx res2:0x%lx", + __entry->smc_id, __entry->ret, __entry->res, + __entry->res0, __entry->res1, __entry->res2) +); + +#endif /* _TRACE_SCM_SMC_INTERFACE_H */ + +#undef TRACE_INCLUDE_PATH +#define TRACE_INCLUDE_PATH . +#define TRACE_INCLUDE_FILE qcom_scm_trace + +#include + --=20 2.34.1 From nobody Sun May 24 19:33:39 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC8B73783AE for ; Fri, 22 May 2026 06:39:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779431970; cv=none; b=sM0I4xsbxbpXBkn0NHyKIvtaNGQTjtKc2W33uvjAkzXYiJbh5i68d4Z9dyf6EN9UmRqBk3qzBQ/ZgFf+qTVn7KyEv8T6gN64+nbt5eVeFoT9yHTm/nL8D+VJvu6Q3l53P01O1Ea+G0it7WjqvxKwEqQKsdqtXe8bmz6xQ5tLc4M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779431970; c=relaxed/simple; bh=vPPMrwSbretNAwmHkQk5Ze+IfHo/ksOHlGl4SvYHmK8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=fH8ZyneG4CRuYBY6J4xCYtorCNTvjVBGcGcwUO7Fb4ekl4EIQqHnwKBNm9ax8azHucd0L7QVhZRMXUP3Bd5QZT9cNgNRjupND0eZr9sXhzP/vRjkWiLUkYtzR2xz9G+L6/f08ZP1icatGeIHHpGT2SczVcPOtsGM/BLxj3X8xiw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=PBo1gV3j; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=csXohnQF; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="PBo1gV3j"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="csXohnQF" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64M41l4O3005097 for ; Fri, 22 May 2026 06:39:28 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6k8zFeejpgENGIEpm3ejapchplAB5iHo5fBZStZd09U=; b=PBo1gV3jZW2KmiE3 4w7Le3ttaxSP19Y559/83uUzYKilB5LuwQpJhQCunj9AgLeXevf9gutyIPq/zmBq O0mwe683VbR1Pfna7T8PbTnfgQd5/TqHYm95cIRMdg0eE5XLUvrFe2QYvMCrOXY2 vPXYpYrlJ4oLHOB5R4pdDtViizXCcGolhwWdU49oogFohflUT0RFNSD6vkU5AM23 w71lrN0JVcdMZG+IdcBi8+e8ds4U8BCp432jCNOLlQV+YwReKokgHCo+181gUone j2awD7dvyerB8gnemK0LppVc+xHW9lsqHtSry3qTKoAew3amVciA2fi1ndWPnVRW n8+eJw== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eafrt8f87-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 22 May 2026 06:39:28 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-3684cb22502so6614063a91.2 for ; Thu, 21 May 2026 23:39:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779431967; x=1780036767; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=6k8zFeejpgENGIEpm3ejapchplAB5iHo5fBZStZd09U=; b=csXohnQF39WJDpj4IbmUaYgpz73oeub2hozYAgvbYVWVMZSXvJpJw9mqfCSKEIWXao ur83uwLqwuEWF8GbDad0wth466TBttfMZJDDNW5IUB8DZnqOjaMqLv3BxIzdslJUpoDw QIps9qo+34bmpdPvSDojYazWSOQXHIK680tf3jEo1lMdCRnTsYLurWAYgx3dqLwQglc/ CnTLuQbg4+Wy/71L1cpSPebDc0LIIObYnWAxGWnj9tHVb9y27hN2xhwBRFgkKJgtUg+Q /jkq3+tCRKaDDQ7RxQOdA3KGMUx+T9cRsRdcZUvR/Cr+ZDBy46Ssqnd5jk0cNnCbYOBY wZzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779431967; x=1780036767; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=6k8zFeejpgENGIEpm3ejapchplAB5iHo5fBZStZd09U=; b=fcgtkl9+vyxHQgLRsHOPdWqVmTrbKG4qrGWi2QaZ8CDPTM3wC5huF+uc3NGQwFyX3K l1i5xDlMrX/hiT+OT8aF1agAT0pS9tkkqfmuWjbR1NlgkPnp1LIdFkKf/xKVButpVzpe r1PoACCkde68tAxli6qKW5K9m9ynWViVf29EKQEs46r4YfecanH84Hu+kcWZ01wMPsVs NDySdK40L88xFTxfd3TrGefeBPsIiwloZuAtWpjuYoq0FvEGyVo7ZP8HWhhdQcU66Op3 uztOo0D06GzbdZeUv78yevLtDnH9Hp/5UhSMgL4rHneApwMKGg0G4BKT11VYa573yzZ/ PmMw== X-Forwarded-Encrypted: i=1; AFNElJ/B/Tao+gt957kw6j23AqDVrcAkWi10Fx2GBs3skVrK9gEGvXDui95iReTA7BQtOsEHfgUeMcbHHMTA7NA=@vger.kernel.org X-Gm-Message-State: AOJu0YwiYiNrPyly2BGWi4+EaCnGa1OsjYiBxfI1lX3CP+wDrsZRHAAI gFPg4blYUIIxDhYRukFuuTJA1IyM2YxXTMJ+b3ymQJK5nctsRFCg/6nqec9Gkz/wZuiEbE9Ae1w /ZmQaIto2xF+1fAJ4WtRO95zKiOjhkRNnhPWsrQpdy/4UkeE9zJJlzrhEFfTM5C824wc= X-Gm-Gg: Acq92OHfaEYX7iAS+OF5z8v//sZONCxu5lcKo7jfXXLLQN8dPoDcHP5dgeRaBoARLIg Ojaak8SxtAAxtHt4qEOrSvBLCWTP8zEcGOFcrNK2kP4ra59f4JJF2sOafSqjLkYKqdFlbeJVbfC suZKhoC9hqN3YClAqmUGJOobbynXZrZB80sGBMn/LOiQaNN/LUb+5D3VXAwsHBM+CyS2KUWmg0h F3Dwhl4U4xP+ZrbiZZDBKCBSNdqcmJpGwTZnvE/DEIN3H562HsreZYVXMlYLy9Va9N6N4GSp0TB Ogs4ioODq5e4CqCMCLIc8btyeYxVNKkX0GRS5P5bXxtsRTY603RdrtexWjWSx8R8bnynATo9C0Y n3gQj6KL93DEuaQz8UCA0KtekfM/GdQMYxAq4mtit4OnYzA2/w1t8f3ejLNeC8N716Cc9f1VNfi niL9xkCQdZqVStbeOMzsn2djbq+HT+AVnvueowsdLMPeiMWndETtk= X-Received: by 2002:a17:90b:5823:b0:366:aba:4c86 with SMTP id 98e67ed59e1d1-36a676931aamr2428165a91.27.1779431967494; Thu, 21 May 2026 23:39:27 -0700 (PDT) X-Received: by 2002:a17:90b:5823:b0:366:aba:4c86 with SMTP id 98e67ed59e1d1-36a676931aamr2428140a91.27.1779431967001; Thu, 21 May 2026 23:39:27 -0700 (PDT) Received: from hu-yrangana-blr.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36a72c4cf56sm888822a91.12.2026.05.21.23.39.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 23:39:26 -0700 (PDT) From: Yuvaraj Ranganathan Date: Fri, 22 May 2026 12:09:00 +0530 Subject: [PATCH v2 2/2] firmware: qcom: scm: instrument SMC call path with tracepoints Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260522-scm-tracepoints-v2-2-e27cdbe0c585@oss.qualcomm.com> References: <20260522-scm-tracepoints-v2-0-e27cdbe0c585@oss.qualcomm.com> In-Reply-To: <20260522-scm-tracepoints-v2-0-e27cdbe0c585@oss.qualcomm.com> To: Bjorn Andersson , Konrad Dybcio Cc: kernel@oss.qualcomm.com, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Yuvaraj Ranganathan , Konrad Dybcio X-Mailer: b4 0.16-dev-d5d98 X-Developer-Signature: v=1; a=ed25519-sha256; t=1779431958; l=2631; i=yuvaraj.ranganathan@oss.qualcomm.com; s=20260506; h=from:subject:message-id; bh=vPPMrwSbretNAwmHkQk5Ze+IfHo/ksOHlGl4SvYHmK8=; b=R5UMEPITv03nsw2tgtSkEHEmRgrc/fIj4oshFHBNnKqsj9vNL7zeFFpd8sPJpBMpHHE9C8uUf XtGAI07dRl2AcMF26HuHp238BsTTYLP5Z4zMNjKKPDdm37ZtpUZrLMx X-Developer-Key: i=yuvaraj.ranganathan@oss.qualcomm.com; a=ed25519; pk=ln7RObom4c2W8MEnQqwZbOi6X198/6toN51al5+6rKI= X-Authority-Analysis: v=2.4 cv=JN0LdcKb c=1 sm=1 tr=0 ts=6a0ffa20 cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=R2Gh0RvCMMMYrCYy2VcA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIyMDA2NCBTYWx0ZWRfX64aUM1oYZS4/ BFD0eRUIPYef5NE0ID0wskD369CAqmOYBn0Ru2nXY+UYmZrIESSCD3kHh65kEmwTrUARVx3F2Df vOpwjE0LgK0zxSLBQsYON/tXno0+BBiYbVCo5FIaIgj5bmmbceLqoZ7B1TegxWGMhRY4Co4hc9t XaUZCg8mNagDEQyJX8GYh5ibhGALXdO+yAx2p9OqQP4AnrZkYIGRkqZ5qNxOhzT4kRBie46HscS jqZ5JLS4qCTGqnkcN1DDejOcSMEby9pkin1PcxVWcrLdlMIdjPX1fiWwvdvLCamNHoSxdBgJZd2 ZF7T77zEY3+M3MyYZwDuS0KgS+V6UjZ3posfUwVD+LiJlOjSCd3pN9cnnD+thYubkgzcXvQGoWI AxY/hLv78WjnzUp5XNsiHvcPfNaFgGq8aCJKy5ActIfOpOgIKos9GeYI539qnPKmSQtn+w/catQ P4YkinKP9vOLZJKgiow== X-Proofpoint-GUID: mOQiF5QHl8JxCdGjIH5poENRo2tsW_2s X-Proofpoint-ORIG-GUID: mOQiF5QHl8JxCdGjIH5poENRo2tsW_2s X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-22_01,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 lowpriorityscore=0 suspectscore=0 malwarescore=0 impostorscore=0 phishscore=0 bulkscore=0 clxscore=1015 spamscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605220064 Wire the five tracepoints defined in qcom_scm_trace.h into the SMC execution path by including the header with CREATE_TRACE_POINTS. Reviewed-by: Konrad Dybcio Signed-off-by: Yuvaraj Ranganathan --- drivers/firmware/qcom/Makefile | 1 + drivers/firmware/qcom/qcom_scm-smc.c | 10 ++++++++++ 2 files changed, 11 insertions(+) diff --git a/drivers/firmware/qcom/Makefile b/drivers/firmware/qcom/Makefile index 0be40a1abc13..b679d3fc2c26 100644 --- a/drivers/firmware/qcom/Makefile +++ b/drivers/firmware/qcom/Makefile @@ -5,6 +5,7 @@ =20 obj-$(CONFIG_QCOM_SCM) +=3D qcom-scm.o qcom-scm-objs +=3D qcom_scm.o qcom_scm-smc.o qcom_scm-legacy.o +CFLAGS_qcom_scm-smc.o :=3D -I$(src) obj-$(CONFIG_QCOM_TZMEM) +=3D qcom_tzmem.o obj-$(CONFIG_QCOM_QSEECOM) +=3D qcom_qseecom.o obj-$(CONFIG_QCOM_QSEECOM_UEFISECAPP) +=3D qcom_qseecom_uefisecapp.o diff --git a/drivers/firmware/qcom/qcom_scm-smc.c b/drivers/firmware/qcom/q= com_scm-smc.c index 574930729ddd..01999c22659c 100644 --- a/drivers/firmware/qcom/qcom_scm-smc.c +++ b/drivers/firmware/qcom/qcom_scm-smc.c @@ -24,6 +24,9 @@ struct arm_smccc_args { unsigned long args[8]; }; =20 +#define CREATE_TRACE_POINTS +#include "qcom_scm_trace.h" + static DEFINE_MUTEX(qcom_scm_lock); =20 #define QCOM_SCM_EBUSY_WAIT_MS 30 @@ -44,6 +47,7 @@ static void __scm_smc_do_quirk(const struct arm_smccc_arg= s *smc, quirk.state.a6 =3D 0; =20 do { + trace_scm_smc_request(a0, smc); arm_smccc_smc_quirk(a0, smc->args[1], smc->args[2], smc->args[3], smc->args[4], smc->args[5], quirk.state.a6, smc->args[7], res, &quirk); @@ -83,6 +87,7 @@ int scm_get_wq_ctx(u32 *wq_ctx, u32 *flags, u32 *more_pen= ding) if (ret) return ret; =20 + trace_scm_waitq_get_wq_ctx(get_wq_res.a1, get_wq_res.a2, get_wq_res.a3); *wq_ctx =3D get_wq_res.a1; *flags =3D get_wq_res.a2; *more_pending =3D get_wq_res.a3; @@ -105,10 +110,12 @@ static int __scm_smc_do_quirk_handle_waitq(struct dev= ice *dev, struct arm_smccc_ wq_ctx =3D res->a1; smc_call_ctx =3D res->a2; =20 + trace_scm_waitq_sleep(wq_ctx, smc_call_ctx); ret =3D qcom_scm_wait_for_wq_completion(wq_ctx); if (ret) return ret; =20 + trace_scm_waitq_resume(smc_call_ctx); fill_wq_resume_args(&resume, smc_call_ctx); smc =3D &resume; } @@ -201,6 +208,9 @@ int __scm_smc_call(struct device *dev, const struct qco= m_scm_desc *desc, } =20 ret =3D __scm_smc_do(dev, &smc, &smc_res, atomic); + + trace_scm_smc_done(ret, smc.args[0], &smc_res); + if (ret) return ret; =20 --=20 2.34.1