From nobody Sun May 24 18:42:55 2026 Received: from mail-dy1-f173.google.com (mail-dy1-f173.google.com [74.125.82.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF1231E834B for ; Fri, 22 May 2026 12:49:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779454185; cv=none; b=MoUIfW5ALrwLRjy124reAMMr5KSCwyLzI6JYw/RPuGO/Ja/M7t/Lbs+yMpiAJD+3REOJ19gJXRQSRsTKKuQCUjeRx90p7dR4rQL23Hbn26LKWtB4mLTTQR2Jlwj05Cofm8aaK1WfyY74ZbLgJpPK8oTJj2emjFUjejCXLAvtXf4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779454185; c=relaxed/simple; bh=txvR/MSiTpf9NorbW6/gmSUwVrOklO38SeSFp2Hr+uM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=OvCo+/ph3LFRNPkE3G2UaxN+6Fg5ANKB6rVGcOUF3+WVyUlgXsBJ+f1utTavJ4PscVqE2Ka+CoH356K+iSeydz7gLJbsP1pcYJIJUvPPLGoHR7TWYiW/PjQLwUqEfk8CV4dRd3L4Vc2Tc5E8xc7mNLJRehjOGrvDG6Oc9KOu4+M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d4Eep36w; arc=none smtp.client-ip=74.125.82.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d4Eep36w" Received: by mail-dy1-f173.google.com with SMTP id 5a478bee46e88-304545f5206so510997eec.0 for ; Fri, 22 May 2026 05:49:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779454183; x=1780058983; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=rZlYIto97MmzQySh5rb4+w1RJlukSriFG/8QM8SYO3c=; b=d4Eep36wljA4e/X+bfnIG4Gfe7BeAl2c7kvNy4Bho+WsMaHOCq7B9iyCI6nFtimtjY +RsBy7GMru5kbKIQkhsAfZWhiyunw/1bFpNPurwOr57bFfry8DJfaNCwyz27yhrHy3ow AF/uCSQBD4jr5ujYnPDuNoZS7B38wVhVjyJZArVs2D4EaXUY4Q9KOct8GPTdM+7QB0Zj q4QKmdZIJA0a5UCCWELY/82GBH95BOtuyg7iQ2BT5uje8PvSerXW6Ek5irOS9GG2vwFF geG+ANahmyvaKYRVmtMug763xvcETxYesQxBIS/HhfZkgbaeayV1XmIx2o9U9wrNdMbz ZiNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779454183; x=1780058983; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rZlYIto97MmzQySh5rb4+w1RJlukSriFG/8QM8SYO3c=; b=gzg8+huixLvlyU71w+YoCpxnkxdeWdkxNEba34gfnyjo7P8OmZ8RfI0FtBBAJN0e0q vHN5an4upy4nn8QnzvbSoAVrWX+LNFwHz0NEdE8yGvwLt1QjrJ2jp7PIIBIDowMYqor9 2lsYcpMT22mkAMWu2P9lN18BIG3y2fcnMfcNi66nQN7b9tdAoWp74geUyyx0M32Zze0S 8lX2sgSbaz3n/JALijtzRZmg+DwK/ToNMWWRc5CXbckUKEX6RpLETXO+EucSub1jfoIw Hz1p/e+C1CSPnukCvaSvU5L+c03g7UH/myJlzG6kjQHE02bqxXeLHiElMHHD3Rr0VWe6 6H0g== X-Forwarded-Encrypted: i=1; AFNElJ8jwkqWxo0JpFPexmIgR/5/FoYuoN4WfjKZ0Dd0muPevIc7fKuZNaUB0EkwAwCSjmV30KuPqV51QmSOBvo=@vger.kernel.org X-Gm-Message-State: AOJu0Yx6t1ZDEboc1e35lcCGOM4pbpDSmaZagjVVnzrxhJ3hLaHk2dr5 E5QohcniL1Dide6kghjOFL6jOlknb/3YiDiH2jFTphuEYwuDdV+jgc5/1reCS2Y1 X-Gm-Gg: Acq92OHVzBI3H8WlpCLMRaZc55obIpJ09vA2EqRPkRTlo0PLKhmIaehCtjx6O0hyv8j iI8CjPB/DZnBUUKD6+3t1Qu6l6pDzRnf+18aI6nbLVhnshSE1qBTXAEFO6fihI0rAdHRWzU/TEq W3/1MAJot4oW1yJSl5vPcTLHn8Q7cymAYTB3ORzDbt2bz5N1YafbrW/evD6A4PUL/ZxaTyoowDf YWJkXmQzhof1UGtzpnubqPbyRLTy+CYvIPmDgCwew2oE1C4KHAblVE8UmpFRizrINi9VehObfyn XvnnK5sxVt1JnQ7oif7vOWZOuUG++daF98NkUrAW9mTiycgszzkG+UcyCbyRWQuFjaqMdU9GMHs CFt7IMNuOLAdIMbJwt0Ai/TmP1lUIo6/0SseTVf00VKtswhVQrGO7cXqbzo/AN0jfN8Stmd/fx4 +i59vKNRCZydJO608kcCM9+r7qh5ahpqoaedl4sw+7t8euOI2OZwFCJlvQiBvikl245rt+yf3lQ Q== X-Received: by 2002:a05:7301:fa0a:b0:2ea:c085:44b1 with SMTP id 5a478bee46e88-304491037b5mr1762157eec.19.1779454182961; Fri, 22 May 2026 05:49:42 -0700 (PDT) Received: from [192.168.1.18] (177-4-162-74.user3p.v-tal.net.br. [177.4.162.74]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-30452230f1bsm903987eec.14.2026.05.22.05.49.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2026 05:49:41 -0700 (PDT) From: =?utf-8?q?C=C3=A1ssio_Gabriel?= Date: Fri, 22 May 2026 09:49:30 -0300 Subject: [PATCH v4] ALSA: hda: cs35l56: Fix system name string leaks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260522-alsa-cs35l56-system-name-leak-v4-1-a6154dd09cd9@gmail.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/5XQTW7CMBAF4Ksgr5nKHtsJZsU9qi4cewKG/KBMa hWh3L0J7QLYIJZPevreaK6CaUjEYru6ioFy4tR3czDrlQgH3+0JUpyzQImFtFKBb9hDYG0bWwB feKQWOt8SNORPUNaxLB35oJ0Ss3EeqE4/N//z6y/zd3WkMC7o0jgkHvvhcjsgq6X3v4XyxVZWI CEqXVljUCu32e1bn5qP0Ldi2cr4loazVsgai6Csk6ifNX2vvfpD1qDAxWgIY6hM+aBN0/QLXwO GDXgBAAA= X-Change-ID: 20260501-alsa-cs35l56-system-name-leak-7fd779eac391 To: David Rhodes , Richard Fitzgerald , Takashi Iwai , Jaroslav Kysela , Simon Trimmer , Mark Brown Cc: linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, =?utf-8?q?C=C3=A1ssio_Gabriel?= X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=4116; i=cassiogabrielcontato@gmail.com; h=from:subject:message-id; bh=txvR/MSiTpf9NorbW6/gmSUwVrOklO38SeSFp2Hr+uM=; b=owGbwMvMwCV2IdZeKur/u2bG02pJDFkCAfc2dsTuXXZ8tlvc3fezpV8E/jvln6nzvqE5boL9p x1P/t980FHKwiDGxSArpsiyOmmR5Z6uB1fr41Z4wMxhZQIZwsDFKQATmazG8IfriXJhwJm9b7ji P0Wxa89gOBcfu2/N1Fn7OWabz78aw5rKyPBJ9vDmiZf/fNd5mtU94+nJaMkzGloybiZmW5WnS+x fNo8HAA== X-Developer-Key: i=cassiogabrielcontato@gmail.com; a=openpgp; fpr=AB62A239BC8AE0D57F5EA848D05D3F1A5AFFEE83 cs35l56_hda_read_acpi() gets an allocated ACPI _SUB string from acpi_get_subsystem_id(). On success, that string is used to create the firmware system name. Several error paths after the _SUB lookup can return without releasing the allocated string. This includes speaker ID lookup errors other than -ENOENT, and errors after a firmware system name has been allocated. Use scoped cleanup for the temporary _SUB string and make cs35l56->system_name device-managed. This releases the temporary _SUB string on every error path and lets devres release the firmware system name on probe failure and device removal. Fixes: 6f03b446cbae ("ALSA: hda: cs35l56: Add support for speaker id") Fixes: 40b1c2f9b299 ("ALSA: hda/cs35l56: Workaround bad dev-index on Lenovo= Yoga Book 9i GenX") Signed-off-by: C=C3=A1ssio Gabriel Reviewed-by: Richard Fitzgerald --- Changes in v4: - Drop unrelated line-wrap change in reset GPIO error path. - Link to v3: https://patch.msgid.link/20260521-alsa-cs35l56-system-name-le= ak-v3-1-9dd4e2dcb473@gmail.com Changes in v3: - Make cs35l56->system_name devm-managed. - Keep __free(kfree) only for the temporary ACPI _SUB string. - Remove the local cleanup-managed system_name variable. - Drop the probe-error cleanup patch; devres now owns system_name. - Remove the manual remove-time kfree for system_name. - Link to v2: https://patch.msgid.link/20260520-alsa-cs35l56-system-name-le= ak-v2-0-60f26c159023@gmail.com Changes in v2: - Use __free(kfree) for the temporary ACPI _SUB string. - Keep the derived system name local until read_acpi() succeeds. - Transfer ownership with no_free_ptr() only on successful paths. - Link to v1: https://patch.msgid.link/20260520-alsa-cs35l56-system-name-le= ak-v1-0-d13b54423198@gmail.com --- sound/hda/codecs/side-codecs/cs35l56_hda.c | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/sound/hda/codecs/side-codecs/cs35l56_hda.c b/sound/hda/codecs/= side-codecs/cs35l56_hda.c index cdbc576569ef..a0ea08eb96a9 100644 --- a/sound/hda/codecs/side-codecs/cs35l56_hda.c +++ b/sound/hda/codecs/side-codecs/cs35l56_hda.c @@ -1025,7 +1025,7 @@ static int cs35l56_hda_read_acpi(struct cs35l56_hda *= cs35l56, int hid, int id) u32 values[HDA_MAX_COMPONENTS]; char hid_string[8]; struct acpi_device *adev; - const char *property, *sub; + const char *property; int i, ret; =20 /* @@ -1047,7 +1047,8 @@ static int cs35l56_hda_read_acpi(struct cs35l56_hda *= cs35l56, int hid, int id) /* Initialize things that could be overwritten by a fixup */ cs35l56->index =3D -1; =20 - sub =3D acpi_get_subsystem_id(ACPI_HANDLE(cs35l56->base.dev)); + const char *sub __free(kfree) =3D acpi_get_subsystem_id(ACPI_HANDLE(cs35l= 56->base.dev)); + ret =3D cs35l56_hda_apply_platform_fixups(cs35l56, sub, &id); if (ret) return ret; @@ -1095,15 +1096,16 @@ static int cs35l56_hda_read_acpi(struct cs35l56_hda= *cs35l56, int hid, int id) ret =3D cirrus_scodec_get_speaker_id(cs35l56->base.dev, cs35l56->index, cs35l56->num_amps, -1); if (ret =3D=3D -ENOENT) { - cs35l56->system_name =3D sub; + cs35l56->system_name =3D devm_kstrdup(cs35l56->base.dev, sub, GFP_KERNE= L); } else if (ret >=3D 0) { - cs35l56->system_name =3D kasprintf(GFP_KERNEL, "%s-spkid%d", sub, ret); - kfree(sub); - if (!cs35l56->system_name) - return -ENOMEM; + cs35l56->system_name =3D devm_kasprintf(cs35l56->base.dev, GFP_KERNEL, + "%s-spkid%d", sub, ret); } else { return ret; } + + if (!cs35l56->system_name) + return -ENOMEM; } =20 cs35l56->base.reset_gpio =3D devm_gpiod_get_index_optional(cs35l56->base.= dev, @@ -1254,7 +1256,6 @@ void cs35l56_hda_remove(struct device *dev) =20 cs_dsp_remove(&cs35l56->cs_dsp); =20 - kfree(cs35l56->system_name); pm_runtime_put_noidle(cs35l56->base.dev); =20 gpiod_set_value_cansleep(cs35l56->base.reset_gpio, 0); --- base-commit: ef807cc07dec16edc7863d437e9250e20cb73741 change-id: 20260501-alsa-cs35l56-system-name-leak-7fd779eac391 Best regards, -- =20 C=C3=A1ssio Gabriel