From nobody Sun May 24 19:35:41 2026 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11010019.outbound.protection.outlook.com [52.101.69.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9FDFD3FC5D4; Thu, 21 May 2026 20:29:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.19 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779395385; cv=fail; b=dfGmwCSObJE2bpGhY2qmIx/IHI061fQYP/aRRbn6+sb+FUPJ2aK1L1qUmYD6jTHQPldoI/stA4dNtMMkTXwF4q1R39jmCJLtSHJhro8VpFSzhw6xjpwgYR4Q86wGiWDa22wqRY3Olq7Wkohh84kpAjr9zOl6T1GFuKsu8wlgy1c= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779395385; c=relaxed/simple; bh=Hq/sOUFo6NfRXo1CJAUy1PPGFamAJHIpVq0bhhcvMPE=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=DwWyxRp6M99/+/2C9jyo3vr2lM0asHitZVm7+Kf08M8pyOtE1EReo3ctAJCXOsbfbcYDYAGDoPhBblKJCrIwh4XiqDuDTYeZ5yQdSq20hEPEJ/kpiVrVzxG2Q/p4o2Wg18Fp1P54YQByqM0JkyGGUEAfw9AjwHp3JB7FTVeLE5Q= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ericsson.com; spf=pass smtp.mailfrom=ericsson.com; dkim=pass (2048-bit key) header.d=ericsson.com header.i=@ericsson.com header.b=c0H/shPn; arc=fail smtp.client-ip=52.101.69.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ericsson.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ericsson.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ericsson.com header.i=@ericsson.com header.b="c0H/shPn" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CutLM39WZQ1UJash2O3EoFqF6aqFh9G79vhTzrxU3ThglCvgo4ExWl3wA1H0F/RFfT+00cYySq5iI77IydTTmIfGtQceZSjgfgf9rugNb3xCA8HOaeLKoRz9Ki32H0CekXWgtS7AiIFl//8fKgZlqa0Id324lHfVEK6Sr0XXgf0R3c0hRaXrRrwZ7hIH6kGyU+GtTs4mxudLvBxgrLjfXtFFHby6NzzvCGXQACp9oGiA4vG7u58N1RRc4y9YMboB45tHbcwH6XlscYSgA2GZfA+Tl81erhd+N8aHV3imBisKyu3IucNRnnc+4Ip1reMwpzcjsUqxfYg9O99qmTWZSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nXIZlVo4hiOJRVR5Lrn7RVvgrMnrBi6KHIQnuvF/Ro8=; b=VlPHzUpICUjyUJAZVRm/zhLKK3F7v1xza06nSI3hXMzIPOYVulZZ2JrHKzp8+iS+NlO/lLuwxhG/d66eQ1wsdAk3vM5AKe+d9jrv7kIpQ7Z3uoH+gynXoRkHDmGRLhHRyOb6+mAvhbjgVzUKSd/KzsOaoPDC+rozUFnXXF1M6lEOP9bE3Mlw2T3K1KXNPLscwNNNAGEY08eFiGpLsVl12babg/ub0WcH50o41pMR/igaJKBwc5sejLmNUwdqvC+zET70ZUjF4rwpizgluUww8RnUyf6LLqLN298Sd5oMr0D90Bi64K1pUBSMb+uJWOI3tKw/sQy0Lj0MsDGUY2fBHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.176.1.74) smtp.rcpttodomain=davemloft.net smtp.mailfrom=ericsson.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nXIZlVo4hiOJRVR5Lrn7RVvgrMnrBi6KHIQnuvF/Ro8=; b=c0H/shPnpLcGuhp9i+l7DInmKVYDhNzxsl8O4n5XdtI+qWaMQ4AbYTDUynnMMDIQH0CO2kQqQoSC/9/flGNg8ag7zgHmjkXNmEWPooRd8/QgSB5v0SmUywTT221CFKjKDwUUy1/RBq1vjppDEsjobfcpWAIVdvmqCSlBBbXlmIRXhBDofF+beQFZkq8WGxPWvTFNkhh0pPT7FBGUiuUk0Hf1sLi7FnDRTGfyHExjprK4Z+aUSFAKtrhqktfTUV7LIKIjel0sfcbkq7yQt++gFGYguZkhlUscjgMLfNdB2QhMVIwQYoPQHz9mNeGymtv2BBavHsoAagSlb7ywPlEuHw== Received: from DU2PR04CA0052.eurprd04.prod.outlook.com (2603:10a6:10:234::27) by DBAPR07MB6872.eurprd07.prod.outlook.com (2603:10a6:10:17c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.48.17; Thu, 21 May 2026 20:29:40 +0000 Received: from DU6PEPF0000B622.eurprd02.prod.outlook.com (2603:10a6:10:234:cafe::8d) by DU2PR04CA0052.outlook.office365.com (2603:10a6:10:234::27) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.48.17 via Frontend Transport; Thu, 21 May 2026 20:29:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.176.1.74) smtp.mailfrom=ericsson.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ericsson.com; Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates 192.176.1.74 as permitted sender) receiver=protection.outlook.com; client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C Received: from oa.msg.ericsson.com (192.176.1.74) by DU6PEPF0000B622.mail.protection.outlook.com (10.167.8.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.71.7 via Frontend Transport; Thu, 21 May 2026 20:29:39 +0000 Received: from seroius18813.sero.gic.ericsson.se (153.88.142.248) by smtp-central.internal.ericsson.com (100.87.178.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Thu, 21 May 2026 22:29:38 +0200 Received: from seroius06448.sero.gic.ericsson.se (seroius06448.sero.gic.ericsson.se [10.117.92.228]) by seroius18813.sero.gic.ericsson.se (Postfix) with ESMTP id 2B3399569E; Thu, 21 May 2026 22:29:38 +0200 (CEST) Received: by seroius06448.sero.gic.ericsson.se (Postfix, from userid 7434092) id 17CCA1005D6A; Thu, 21 May 2026 22:29:38 +0200 (CEST) From: Fidan Aliyeva To: , , , , , , CC: , , , Thomas Eckerman Subject: [PATCH net-next v2 1/4] mv88e6xxx: Add mv88e6352_reset for 6352 family Date: Thu, 21 May 2026 22:29:21 +0200 Message-ID: <20260521202924.727929-2-fidan.aliyeva.ext@ericsson.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20260521202924.727929-1-fidan.aliyeva.ext@ericsson.com> References: <20260521202924.727929-1-fidan.aliyeva.ext@ericsson.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU6PEPF0000B622:EE_|DBAPR07MB6872:EE_ X-MS-Office365-Filtering-Correlation-Id: e62944a9-0ed7-4c91-f4aa-08deb777aece X-SMTP-Server: smtp-central.internal.ericsson.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|36860700016|82310400026|11063799006|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info: zirp6YabSXZ0aK1ubQVegMtbM7iSH1U8pocYwEX2u5SrFPifZG2rKZD5e6u5hdpE6aY9FxuXhuHXDl6H6eXpEgcdnidvPdJFDWYhm0KshWgBQYYDUIVwRMqb1oF5jrdH/3Y+W/cjxYwKLot1l6QUiKUd53KqEMJHhutOtrTwn+Qatz2lCDqC2ehmwYBwLoAc5Uq9d9Qjhy/SKYHfQQZI4cFu7yTqXqek4AWMasVpqW7f0soOQfHeq8DXWWj+/e35HZyRHMyqHDCo4xDDYdCguSgH/ygUh9Qzd7k9rkd4IKibG4tjYh0ChA1rofbJN3fOASwBbAzQdA2EulFWwvsj3/i19R1g3wOxK7xYhhOzkDXl9CPZWWan9nZqF5OBLJhThahtetwNxnWqv2bEMF7Yjd1azUP5EPwOlSA71C6GiT8lUbvFmpc1phPBfwMplSdwTWHWzR1EwoHN579a1o0ggoovAn29IIkI8loEaf4e6EOTYkE1tiyzJHzf6Px1Me/qYkbV5La6xAX9lyZBycTTZ1OF7IUXbUEmt9Vrm2+cT/qs4TpWMpTGEZnqYkM9ERq49sTlGXFHcPemxKNcRhTppOw0L++EhsWA8UIwhnZRrgqK9hPwpSMhWMnAhk2j8iYKjkHiVnAnXrj2tL4yWDaPc7x6YFygtsYHis1XI+EmIqz6SLFOXnmwFVwXCrFJanvoTojL3H+Jzs+gLMzAkFcKolm2IgQjTb5TNjwin7w9Jkk= X-Forefront-Antispam-Report: CIP:192.176.1.74;CTRY:SE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:oa.msg.ericsson.com;PTR:office365.se.ericsson.net;CAT:NONE;SFS:(13230040)(376014)(1800799024)(36860700016)(82310400026)(11063799006)(56012099003)(18002099003)(22082099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: Ahuq7rPom+TjACtjqvTj6sbOpOTa29gGRTI9OqYS81L4yUO0JEsob4RSqRZYarMg47hwiDq3YJG3rluNNAmtGOYU4/gM1tKdMfwqyL83J50YGoQYcXqsjn07NU7dlQrz6phznEDqQOawNwcEgMBnazP/9oiJTIZZ7ZdkHJiAkW9LiTDHAgMCex3bW++8sTlrRgKbyWu5zo75xQrecugF/xa8KI9V0sfhLzahidd1UHyhzKvPBPuxhtr7es+iY1JgQEU+sgubyptrGsKaGvdW0wnMXapboDF0mBCrzt5PdhMfLouAM/v0GFsiqC6JF6/7EaUesuig+jhyZo97pgnH1yxZCuxgLV5GCIjtYxmk9HOfTYx7HOtmwmRfZRnd5ep9n25x2mLfUwpsZoUXweylh7aeSkdSq2ry6VLTEZE6MSvIP/WUETKCidDa0jJcMBE7 X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2026 20:29:39.4193 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e62944a9-0ed7-4c91-f4aa-08deb777aece X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f;Ip=[192.176.1.74];Helo=[oa.msg.ericsson.com] X-MS-Exchange-CrossTenant-AuthSource: DU6PEPF0000B622.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR07MB6872 Content-Type: text/plain; charset="utf-8" 1. Add mv88e6352_reset which calls the previous ops->reset function - mv88e6352_g1_reset. 2. Make all 6352 family use this new function as ops->reset Co-developed-by: Thomas Eckerman Signed-off-by: Thomas Eckerman Signed-off-by: Fidan Aliyeva --- drivers/net/dsa/mv88e6xxx/chip.c | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/c= hip.c index 8ca5fd40df92..6102b7fd8d44 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -3736,6 +3736,15 @@ static int mv88e6390_setup_errata(struct mv88e6xxx_c= hip *chip) return mv88e6xxx_software_reset(chip); } +static int mv88e6352_reset(struct mv88e6xxx_chip *chip) +{ + int err; + + err =3D mv88e6352_g1_reset(chip); + + return err; +} + /* prod_id for switch families which do not have a PHY model number */ static const u16 family_prod_id_table[] =3D { [MV88E6XXX_FAMILY_6341] =3D MV88E6XXX_PORT_SWITCH_ID_PROD_6341, @@ -4654,7 +4663,7 @@ static const struct mv88e6xxx_ops mv88e6172_ops =3D { .pot_clear =3D mv88e6xxx_g2_pot_clear, .hardware_reset_pre =3D mv88e6xxx_g2_eeprom_wait, .hardware_reset_post =3D mv88e6xxx_g2_eeprom_wait, - .reset =3D mv88e6352_g1_reset, + .reset =3D mv88e6352_reset, .rmu_disable =3D mv88e6352_g1_rmu_disable, .atu_get_hash =3D mv88e6165_g1_atu_get_hash, .atu_set_hash =3D mv88e6165_g1_atu_set_hash, @@ -4757,7 +4766,7 @@ static const struct mv88e6xxx_ops mv88e6176_ops =3D { .pot_clear =3D mv88e6xxx_g2_pot_clear, .hardware_reset_pre =3D mv88e6xxx_g2_eeprom_wait, .hardware_reset_post =3D mv88e6xxx_g2_eeprom_wait, - .reset =3D mv88e6352_g1_reset, + .reset =3D mv88e6352_reset, .rmu_disable =3D mv88e6352_g1_rmu_disable, .atu_get_hash =3D mv88e6165_g1_atu_get_hash, .atu_set_hash =3D mv88e6165_g1_atu_set_hash, @@ -5032,7 +5041,7 @@ static const struct mv88e6xxx_ops mv88e6240_ops =3D { .pot_clear =3D mv88e6xxx_g2_pot_clear, .hardware_reset_pre =3D mv88e6xxx_g2_eeprom_wait, .hardware_reset_post =3D mv88e6xxx_g2_eeprom_wait, - .reset =3D mv88e6352_g1_reset, + .reset =3D mv88e6352_reset, .rmu_disable =3D mv88e6352_g1_rmu_disable, .atu_get_hash =3D mv88e6165_g1_atu_get_hash, .atu_set_hash =3D mv88e6165_g1_atu_set_hash, @@ -5463,7 +5472,7 @@ static const struct mv88e6xxx_ops mv88e6352_ops =3D { .pot_clear =3D mv88e6xxx_g2_pot_clear, .hardware_reset_pre =3D mv88e6xxx_g2_eeprom_wait, .hardware_reset_post =3D mv88e6xxx_g2_eeprom_wait, - .reset =3D mv88e6352_g1_reset, + .reset =3D mv88e6352_reset, .rmu_disable =3D mv88e6352_g1_rmu_disable, .atu_get_hash =3D mv88e6165_g1_atu_get_hash, .atu_set_hash =3D mv88e6165_g1_atu_set_hash, -- 2.36.0 From nobody Sun May 24 19:35:41 2026 Received: from AM0PR02CU008.outbound.protection.outlook.com (mail-westeuropeazon11013027.outbound.protection.outlook.com [52.101.72.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 910DA3FC5C1; Thu, 21 May 2026 20:29:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.72.27 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779395390; cv=fail; b=kaJVjEyQVhQxK9NbUuFWVHJHNaTyQbZwjWV2QnvMFxwuMdbmRkFXsK8wqawJT9aOc0BZcfzEo247McCBz5TzU9nbdMBDMdG/xth0RI+wtB3p3Z5l0V2HNkAUzgWqyH9o8h1DyfwSBWEGAYR05Vb/BFxiA6QY8N5ZBiviB0a67oc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779395390; c=relaxed/simple; bh=d2TwtUirWr4f3Gno1OlQJuciGtgjQYh5xyYP3KskoXw=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Q80HJUO+VDM4Wz9XbcX6/ITkYWm/JjrR7hyufYML5YC8dyVMJmD/wVpqlBf4XYH3r7h+DG9e9XxHXX22OzEVQ3xZkd0pySJ+nyVHDVoqUipOFMkPdrWlGvZ74cJ0sTMvux505mw+RQa42nlX/MwoDXRk2i7uHigPvc3/DUp/O0I= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ericsson.com; spf=pass smtp.mailfrom=ericsson.com; dkim=pass (2048-bit key) header.d=ericsson.com header.i=@ericsson.com header.b=TKYVbitJ; arc=fail smtp.client-ip=52.101.72.27 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ericsson.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ericsson.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ericsson.com header.i=@ericsson.com header.b="TKYVbitJ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AjHbj9C8AEFHDgufJVnVTEGX03CIxm4dVWiSvXcYiAqRuDoX4I3w0ZOAVBwUryz2KSormoNbs7B1YNLqcwLIxZ20pMnuah3YITViJCNioWqrwJxWhLac3XQ6NVajjjFwo05ie/WiuzD2lz9l3BXp7zZTEHvrVmWQnF39A+xCsJ1q7D9hXff6TxjwNpcYu6fJiXhEX8QhKOhcStDYWD47dePpXfQXFOVjUwe8AmA6QJLXM54DokPHdrYcm4GU3ZMo5Ch6jKX4hAu4sFIWHO9rBlw1TSpQTdJG1Lx6A5woWvyd/ybdcxWspUty+GQv5VwzTKZSL9eVZfLvZ8Sz8fu5pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6r/HmXPlWui9CHqWxJSkFPhxidm2DtR0Y7zoTStvjeg=; b=WrMSP4gTUSd7zYp3Viy3koKHGmmrEoFSohAkep1h0k2e/Q86jjfGXxUI7jPmGfNeMiEPtlsRZgo+00m59ghkry/62yQ348MTGh17SCrn2Va2tIfCPaRUoOeAOv75vsFVKXShKIRZAKuCb+c6RLpk5VQKwWBCqDSnQlN4cSnCMY5XzEziNU2RJtd5N0jzo24BqnZjFp8AGUNOm7v+wUW322KWX24Z4Xccj8/fwYF0x76Kv5dQHBl72XGrYKn8rejZI3KbwZ3VFFC2fqtRN7OYlCxhzezMQzxkW1h78SrBxxmCa+ucZD3koDXDACovh0gGmHBEs3jmRqcdNWVQxLpPvQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.176.1.74) smtp.rcpttodomain=davemloft.net smtp.mailfrom=ericsson.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6r/HmXPlWui9CHqWxJSkFPhxidm2DtR0Y7zoTStvjeg=; b=TKYVbitJfMeiQxGyLu7D+nhBfbTarrDueG6TpEIv3/2FVR9TuilN6sn+LHhn2rap2pBAqsuaM+Yq+HeZMNxpav49rdE87jXBzdue+ppge+60bdA8A7iqn/WiLVPXsn5+RncQ87MMIuYgrmUPwDuCETV0uqG9VFJsvt6yhAuvOEzmqWyEieGKNYQGIxl3Ceq38MSDmX6LTITFmEK+gH67WfwJNRutNkdh+yvcnZFHKTvq+UYaps1zN5N3Vv9L8o0VBo2QaVLA4yIKmL7vw4D/ocOqxWd9VDxmNsDzocibQtKPsRyfnoDaUx9RWZRkB2d4udAWKtTxqldaPsbAgTu6uA== Received: from DB9PR06CA0024.eurprd06.prod.outlook.com (2603:10a6:10:1db::29) by DUZPR07MB10126.eurprd07.prod.outlook.com (2603:10a6:10:4de::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.48.17; Thu, 21 May 2026 20:29:44 +0000 Received: from DU6PEPF0000B61C.eurprd02.prod.outlook.com (2603:10a6:10:1db:cafe::49) by DB9PR06CA0024.outlook.office365.com (2603:10a6:10:1db::29) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.48.17 via Frontend Transport; Thu, 21 May 2026 20:29:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.176.1.74) smtp.mailfrom=ericsson.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ericsson.com; Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates 192.176.1.74 as permitted sender) receiver=protection.outlook.com; client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C Received: from oa.msg.ericsson.com (192.176.1.74) by DU6PEPF0000B61C.mail.protection.outlook.com (10.167.8.135) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.71.7 via Frontend Transport; Thu, 21 May 2026 20:29:43 +0000 Received: from seroius18814.sero.gic.ericsson.se (153.88.142.248) by smtp-central.internal.ericsson.com (100.87.178.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Thu, 21 May 2026 22:29:42 +0200 Received: from seroius06448.sero.gic.ericsson.se (seroius06448.sero.gic.ericsson.se [10.117.92.228]) by seroius18814.sero.gic.ericsson.se (Postfix) with ESMTP id 3FE8D4020B7B; Thu, 21 May 2026 22:29:42 +0200 (CEST) Received: by seroius06448.sero.gic.ericsson.se (Postfix, from userid 7434092) id 2FE031005D6A; Thu, 21 May 2026 22:29:42 +0200 (CEST) From: Fidan Aliyeva To: , , , , , , CC: , , , Thomas Eckerman Subject: [PATCH net-next v2 2/4] mv88e6xxx: Cache scratch config3 of 6352 Date: Thu, 21 May 2026 22:29:22 +0200 Message-ID: <20260521202924.727929-3-fidan.aliyeva.ext@ericsson.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20260521202924.727929-1-fidan.aliyeva.ext@ericsson.com> References: <20260521202924.727929-1-fidan.aliyeva.ext@ericsson.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU6PEPF0000B61C:EE_|DUZPR07MB10126:EE_ X-MS-Office365-Filtering-Correlation-Id: cbd772f3-17b9-41a2-cd19-08deb777b11b X-SMTP-Server: smtp-central.internal.ericsson.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|376014|36860700016|56012099003|22082099003|18002099003|11063799006; X-Microsoft-Antispam-Message-Info: i2fOU9FE0sxuphWuiMYm4L6SeSqk7BZtHfOWYtQANtEiavMF0qqDiqyBa9gdvY1aHqgX5wg2fxi9IL+MUxgiSnH5YnIPlrcHX8Xqs5625AvS9wEwK41BQrgaxV4dUecltuKv6jwFScEtkvgAcHuTN1q4QFFaJhfouNVbGXHhTpnfC02zXA2NsCjJM0ymR7sJ/kx2VffUzQIZPierTvCllZtqL/4FyKVTduwVQZcwa+cRf7JwwF8bJQo/kh9YE9Ub9toFcTlO2S0JPHcO8HG/CWxT3Polg912784j6oozepSG1Jpt7S32Z5mjHK6rFClMUd0f8HgWFWU4ruIoNs6qGeYmlbErueAr1OoO99ZNitUlMRbCqTwahMiqJryYD/1Ew8AsbFUStNCZLxXhz+zXu8/09jYXUqZXOSJDaoeR5xxIfBzMm7bPy+PjeLlypIPj3f1ZhPDH0MzZEKkTy7AtzoHxWgMQ2o1lmtKUL7t4p2CiaWMyYJxEjnFhyp7MG60ewz1waVt2Db27QtcRFhMW1FPq6kFtUicFcUFXWNbZ6mRlPqWgsScYTXRCvGKrvzn8arI+PHTPLAKSdsdqM3h3XV5jg8Ar73Ts9StbdmSZ784DJV50rSmcuknDVceScqJ+6PQjZ+uTiKyqAcPdu3JPfsgJuaGzU0dJhx8oZ9DER8hC2R6yig2w3JyEwnCbpHwFeLekPd9tP8iLY0saER8jvX5N+zShBqfjFZ1s8h0cKpI= X-Forefront-Antispam-Report: CIP:192.176.1.74;CTRY:SE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:oa.msg.ericsson.com;PTR:office365.se.ericsson.net;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(376014)(36860700016)(56012099003)(22082099003)(18002099003)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: +6Vo8rf3tLLROc7DoTvNefWf1Ue9uQYjeS0yUHLR5hGi8R+EZvwnA7a8KzYezHMmQepKiORFANBw3me7jA4DldDKEoOGsCZrFhmfJo3/BvRIw3uFojgGGaPgo4sUDEM43JmJ7+1J5Vh/Arl7dNjz/A35DzGfVgx40bGj4R5wQrrlMgYmK53mDu8VLNSd8Rf743hKeZU5pu3eMBHCGfkmG97Q6HSDMOuZEgl7AFLpivQS0X8PNapPovHI1Eb3u5AsAG25YIDzLF7camSCD1dakqRJFRVNaxmQdJCvMCiXd5yBBlhVmFA2Hfk/6VauGF+cNrqPOLtpsAisSX3iKeFWNd3RdomRQnivT8P6LFmosjb56DIFgZjKWXQmzUl3SsxtlljlPaX3XVJN/xz2nV0zpVj4hyHaWjI+Pv4+M+sODC9sTV8iLUbZTkVx6k1XdaPX X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2026 20:29:43.2775 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cbd772f3-17b9-41a2-cd19-08deb777b11b X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f;Ip=[192.176.1.74];Helo=[oa.msg.ericsson.com] X-MS-Exchange-CrossTenant-AuthSource: DU6PEPF0000B61C.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DUZPR07MB10126 Content-Type: text/plain; charset="utf-8" Changes: 1. Add g2_scratch_config3 member to mv88e6xxx_chip. 2. Add mv88e6352_g2_cache_global_scratch_config3 which reads the CONFIG3 value from the scratch register and caches it. 3. Call this function in mv88e6352_reset. Co-developed-by: Thomas Eckerman Signed-off-by: Thomas Eckerman Signed-off-by: Fidan Aliyeva --- drivers/net/dsa/mv88e6xxx/chip.c | 7 +++++- drivers/net/dsa/mv88e6xxx/chip.h | 3 +++ drivers/net/dsa/mv88e6xxx/global2.h | 1 + drivers/net/dsa/mv88e6xxx/global2_scratch.c | 26 +++++++++++++++++++++ 4 files changed, 36 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/c= hip.c index 6102b7fd8d44..4ed6f880e02c 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -3736,13 +3736,18 @@ static int mv88e6390_setup_errata(struct mv88e6xxx_= chip *chip) return mv88e6xxx_software_reset(chip); } +/* For MV88E6XXX_FAMILY_6352, perform reset on G1 control. + * Also, read and cache G2 scratch register. + */ static int mv88e6352_reset(struct mv88e6xxx_chip *chip) { int err; err =3D mv88e6352_g1_reset(chip); + if (err) + return err; - return err; + return mv88e6352_g2_cache_global_scratch_config3(chip); } /* prod_id for switch families which do not have a PHY model number */ diff --git a/drivers/net/dsa/mv88e6xxx/chip.h b/drivers/net/dsa/mv88e6xxx/c= hip.h index 2b235ac2c5df..d911f60aca10 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.h +++ b/drivers/net/dsa/mv88e6xxx/chip.h @@ -454,6 +454,9 @@ struct mv88e6xxx_chip { /* TCAM entries */ struct mv88e6xxx_tcam tcam; + + /* Global2 scratch register config data3 */ + u8 g2_scratch_config3; }; #define TCAM_MATCH_SIZE 96 diff --git a/drivers/net/dsa/mv88e6xxx/global2.h b/drivers/net/dsa/mv88e6xx= x/global2.h index 82f9b410de0b..ff5adf7c9bc3 100644 --- a/drivers/net/dsa/mv88e6xxx/global2.h +++ b/drivers/net/dsa/mv88e6xxx/global2.h @@ -382,6 +382,7 @@ int mv88e6390_g2_scratch_gpio_set_smi(struct mv88e6xxx_= chip *chip, bool external); int mv88e6393x_g2_scratch_gpio_set_smi(struct mv88e6xxx_chip *chip, bool external); +int mv88e6352_g2_cache_global_scratch_config3(struct mv88e6xxx_chip *chip); int mv88e6352_g2_scratch_port_has_serdes(struct mv88e6xxx_chip *chip, int = port); int mv88e6xxx_g2_atu_stats_set(struct mv88e6xxx_chip *chip, u16 kind, u16 = bin); int mv88e6xxx_g2_atu_stats_get(struct mv88e6xxx_chip *chip, u16 *stats); diff --git a/drivers/net/dsa/mv88e6xxx/global2_scratch.c b/drivers/net/dsa/= mv88e6xxx/global2_scratch.c index 53a6d3ed63b3..f2f9e7dce1aa 100644 --- a/drivers/net/dsa/mv88e6xxx/global2_scratch.c +++ b/drivers/net/dsa/mv88e6xxx/global2_scratch.c @@ -321,6 +321,32 @@ int mv88e6393x_g2_scratch_gpio_set_smi(struct mv88e6xx= x_chip *chip, return mv88e6xxx_g2_scratch_write(chip, misc_cfg, val); } +/** + * mv88e6352_g2_cache_global_scratch_config3 - caches G2 CONFIG3 value + * @chip: chip private data + * + * Reads and stores config3 value of global2 scratch registers, which + * can be used to determine if the port is attached to a serdes. The + * value does not change once the switch is released from reset and + * represents the value of the pin strapping. + * + * Return: negative error number if the register read fails; otherwise, 0 + */ +int mv88e6352_g2_cache_global_scratch_config3(struct mv88e6xxx_chip *chip) +{ + u8 config3; + int err; + + err =3D mv88e6xxx_g2_scratch_read(chip, MV88E6352_G2_SCRATCH_CONFIG_DATA3, + &config3); + if (err) + return err; + + chip->g2_scratch_config3 =3D config3; + + return 0; +} + /** * mv88e6352_g2_scratch_port_has_serdes - indicate if a port can have a se= rdes * @chip: chip private data -- 2.36.0 From nobody Sun May 24 19:35:41 2026 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11013042.outbound.protection.outlook.com [40.107.162.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE48C3E172B; Thu, 21 May 2026 20:29:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.162.42 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779395391; cv=fail; b=M30MeeCrK5RRE+aberrFEh44mpyiGuaFczQ+rbrbcUvcBv1UIxXwIRdBXufgR3xF+VrXE5qc83DgFgrC7GRVji12OM9YfNoSbJqvQtmh5GSDE+F+x/l4ltzP+MUCvrvePeBRvPyNzd/woWoEUUPa4bOmuncIOgdBwayRxjTqmK0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779395391; c=relaxed/simple; bh=oUFyVCW+OjwRjF16ZkMy0ScmFKVu3UBQg8iolpxAKPA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=qeHjrVyiO41wY0bPQXJwjOJ3tLMFmME1k9s1r4cutj27Gs6vWvcUllsyZRUIySNr9Ue4iYFhxMZUO3rJXvKykwSY6KK3EID4Gn4f7zUe23WHywgIZ+1y20l4XoL+J2H2M/cR1g4r38VGUgKHxhxHndrlGpYz5kkZJBhWpGujpJ4= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ericsson.com; spf=pass smtp.mailfrom=ericsson.com; dkim=pass (2048-bit key) header.d=ericsson.com header.i=@ericsson.com header.b=bQAJuXKt; arc=fail smtp.client-ip=40.107.162.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ericsson.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ericsson.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ericsson.com header.i=@ericsson.com header.b="bQAJuXKt" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=QU7ASBreBjPnt8ZVhmZZwYYR8qKfHhxIVVMc/5wWF9dRlrObHfPauJpPQ1IJ1yjr1+Jc9YGd3Fr5vUPZJNrIHufIAajnTMdwsqntk7KQjWP7kRnDztndqNjRiQerpHqZzW5bO/DTjVZQkQPEhuz/a4r+YfFsJ+BZU8BKs/zxGUS+K89tM85oEIt8SqX7F1d4oHgtYS2AO+9mgn4vT/bJ7K+iSu+7Jn21doWG9R7fUXi1lbvAmcLWmLRr243pv3TJyc77UQ7nC+M1UidSi7NFqL9m36bZlr/+WB+pnRIbLyb6jzDB0YbyRm3Qw4hlqM2blpGkFpP9GLyn8SWKOFXcRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VH/jULfdgyeACxs/2hZLkX18zgNZg8gQUfU6Az8XTEA=; b=l15QSqccZsDiKRozIcJMBT+J+z61Fv5filDVEqIBqC83QcX9KghWbAks9Fdas5GdLeMhT0FdtrnMHekuejE5j3edtFaIu4TBnniFBcLttG7JpXvXUGGWb0Osc65TW7rZGQE8nBpzYW5KaCjt5D7aNRlIXrufd5Nl5dIKzYV6/B1UYwPOmS1gW0+1ca579tmOpq7HPxZTeBXqG5mtY/pKHdYd7nnAVIMdbvkz+57jUl/8fAmuqMr/nORnQUXwLtDpyKzDRb9K0YDnIB5m9fwSFo3i2FnHiw6Sg1TIdlENVg+pf2/HxOyLpULX9pQN7NtPC+63XB4UGtkeLe1wP9zUoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.176.1.74) smtp.rcpttodomain=davemloft.net smtp.mailfrom=ericsson.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VH/jULfdgyeACxs/2hZLkX18zgNZg8gQUfU6Az8XTEA=; b=bQAJuXKtQkXw1XbUbdEeg5FavxwWfXVdrjHIa4Mapg0FZQW/ww5SuOcgoGvx63tva53nND68YN2GgNpE33OpWSmruikZ/vp9aVwW1DXXPzj47m5gP1Zqs2MyT9RWFgtXkCgQU/W8TPVEmRqaO+Hvd913vlXklx6lMoVwWK77IHmApTb6AvSrVR36InqTWVf2x7N4mrmylEGuCDcamkZxRyiaMaWG3VJ4dUShpwRIInbxBPNatBD0HKP/zHkYW/fTlr1qJospp8/ny46vLTwVMeD+xlsqONcYcmvvrlP4W1GxcU48e7XJgy8ebcstR2a1lcyupDQovIutZ1yhiQbWsQ== Received: from AS4P250CA0014.EURP250.PROD.OUTLOOK.COM (2603:10a6:20b:5df::17) by AS8PR07MB7160.eurprd07.prod.outlook.com (2603:10a6:20b:25d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.48.17; Thu, 21 May 2026 20:29:46 +0000 Received: from AMS0EPF000001A9.eurprd05.prod.outlook.com (2603:10a6:20b:5df:cafe::3e) by AS4P250CA0014.outlook.office365.com (2603:10a6:20b:5df::17) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.48.17 via Frontend Transport; Thu, 21 May 2026 20:29:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.176.1.74) smtp.mailfrom=ericsson.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ericsson.com; Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates 192.176.1.74 as permitted sender) receiver=protection.outlook.com; client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C Received: from oa.msg.ericsson.com (192.176.1.74) by AMS0EPF000001A9.mail.protection.outlook.com (10.167.16.149) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.71.7 via Frontend Transport; Thu, 21 May 2026 20:29:44 +0000 Received: from seroius18814.sero.gic.ericsson.se (153.88.142.248) by smtp-central.internal.ericsson.com (100.87.178.62) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Thu, 21 May 2026 22:29:44 +0200 Received: from seroius06448.sero.gic.ericsson.se (seroius06448.sero.gic.ericsson.se [10.117.92.228]) by seroius18814.sero.gic.ericsson.se (Postfix) with ESMTP id E16FD4020B7B; Thu, 21 May 2026 22:29:43 +0200 (CEST) Received: by seroius06448.sero.gic.ericsson.se (Postfix, from userid 7434092) id D0FC51005D6A; Thu, 21 May 2026 22:29:43 +0200 (CEST) From: Fidan Aliyeva To: , , , , , , CC: , , , Thomas Eckerman Subject: [PATCH net-next v2 3/4] mv88e6xxx: Use cached config3 in 6352 has_serdes Date: Thu, 21 May 2026 22:29:23 +0200 Message-ID: <20260521202924.727929-4-fidan.aliyeva.ext@ericsson.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20260521202924.727929-1-fidan.aliyeva.ext@ericsson.com> References: <20260521202924.727929-1-fidan.aliyeva.ext@ericsson.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS0EPF000001A9:EE_|AS8PR07MB7160:EE_ X-MS-Office365-Filtering-Correlation-Id: 4e371019-aba4-4c57-6a04-08deb777b20d X-SMTP-Server: smtp-central.internal.ericsson.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|82310400026|376014|36860700016|11063799006|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: qZFE9TC+1qEIGewE7P50prfv/pibjsRSaijL0Uuwz9e1o3vlziDDElPgbcBOeyu7jZ8wQZZMopoPq+9zMmn6bpx5/AN4Kyhe+wxDIRjSzMlaTUTB8gidQqqAIYxBRypNQ6PR0e5oe938fUny+59fwk4IHeO+YfCRUUOcxCiUeFSddo5w9vXgRbJlG06fPgBO3x+yGxQP0uirkMMNzk14IH3/T6TCjxBE1Up0Zpltnr3Y0i68GAcXs7RcOL/2HIbmX+2uMDS4EKv+JIS3IBzzESJ5trMH9RRb3JtIu9VTxI0iDNTILQJzgL7HdkQzqX0Yt+foE0dQdhr+j1mNV44j7XZ7hFKxs0h56h+srRFLjnJS4Ity69C9iGBbeX4LIcdyOvCPDJBPNcdtMTDzPd2ZpvSCwctS0/xHs/xyAGQ+W0KijjWriTHg91o2IHYthoxogjirNoSpZl53mvaa0wkAX56Mvr2evOe0j8Is8rugNM7l1YIbX20ANUqlpAGMIErQHJLlN8sL6kGtmW2zbI7MPylMDyO7+6l+sX4SvNNg/u9CH9Q4dKJQ3UNcv7HSU7BmxSPYnI4DPu0QYrmGINci3j4QVH+RppzKImuxO1Cxafere3qAf26KdAIuZC76GWReg6AFA+6V8L4W0GBm+7Aic/5hFuBl4jgW8IETf98iflXVy6Nvo1rX1sHll1wqJKB0Fbun+c+pZxahJt/8iBpKO4MavOM6+1uUo7OC5SX9O04= X-Forefront-Antispam-Report: CIP:192.176.1.74;CTRY:SE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:oa.msg.ericsson.com;PTR:office365.se.ericsson.net;CAT:NONE;SFS:(13230040)(1800799024)(82310400026)(376014)(36860700016)(11063799006)(22082099003)(18002099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: rTdohKbDleZoc1BPyDn4It5srgVOUhWUgTbyOis2VZ4Xs4qn5c+ym9KdGVcx4H4w+Wv3pS3Vt4kw1KVlAvhVMZt4R/IUnNnGB9ZcqZ9MRMm6gOFye6GNSZfIQ18bt3tSs4ruI5RlhqmTRaJclbsRr+Y+Gjvgj6ZWUC7qroBtsaWa6CzJOy42sJyLNkhUuK0cf9Qxov8Kz5VUHPPBZi5VhYPjrtU3JDej+3YH42st8ILbrxXEJ4/IjCcJm1pCdNeseLQg77iJsJCG/K7ziiuUiFM1KEhdyMsxYd28Ci8shCeWzonzww/ZHCTemlgk7swDMWy2K2EnFFeI3LuhuHqA5UyAqLoAL5hIetR1xrmac3ZIXe2ZNyI3E8fPg+iDQSNPonzJSQB9dWo0VVal5iBQph4s55dJ6t6PEeqNleSX7TlLEw/NfrZ048xQwmWuTjlP X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2026 20:29:44.8806 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4e371019-aba4-4c57-6a04-08deb777b20d X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f;Ip=[192.176.1.74];Helo=[oa.msg.ericsson.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF000001A9.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR07MB7160 Content-Type: text/plain; charset="utf-8" 1. Refactor mv88e6352_g2_scratch_port_has_serdes to use the cached scratch config3 value instead of reading it everytime. 2. Remove err<0 check from mv88e6352_phylink_get_caps as it is never true anymore Co-developed-by: Thomas Eckerman Signed-off-by: Thomas Eckerman Signed-off-by: Fidan Aliyeva --- drivers/net/dsa/mv88e6xxx/chip.c | 3 --- drivers/net/dsa/mv88e6xxx/global2_scratch.c | 18 ++++++------------ 2 files changed, 6 insertions(+), 15 deletions(-) diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/c= hip.c index 4ed6f880e02c..63cdcce3d8c7 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -685,9 +685,6 @@ static void mv88e6352_phylink_get_caps(struct mv88e6xxx= _chip *chip, int port, /* Port 4 supports automedia if the serdes is associated with it. */ if (port =3D=3D 4) { err =3D mv88e6352_g2_scratch_port_has_serdes(chip, port); - if (err < 0) - dev_err(chip->dev, "p%d: failed to read scratch\n", - port); if (err <=3D 0) return; diff --git a/drivers/net/dsa/mv88e6xxx/global2_scratch.c b/drivers/net/dsa/= mv88e6xxx/global2_scratch.c index f2f9e7dce1aa..f292ee4db113 100644 --- a/drivers/net/dsa/mv88e6xxx/global2_scratch.c +++ b/drivers/net/dsa/mv88e6xxx/global2_scratch.c @@ -348,26 +348,20 @@ int mv88e6352_g2_cache_global_scratch_config3(struct = mv88e6xxx_chip *chip) } /** - * mv88e6352_g2_scratch_port_has_serdes - indicate if a port can have a se= rdes + * mv88e6352_g2_scratch_port_has_serdes - indicate if a port has serdes * @chip: chip private data * @port: port number to check for serdes * * Indicates whether the port may have a serdes attached according to the - * pin strapping. Returns negative error number, 0 if the port is not - * configured to have a serdes, and 1 if the port is configured to have a - * serdes attached. + * pin strapping, which is cached at reset (scratch config3). Returns 0 if + * the port is not configured to have a serdes, and 1 if the port is + * configured to have a serdes attached. */ int mv88e6352_g2_scratch_port_has_serdes(struct mv88e6xxx_chip *chip, int = port) { - u8 config3, p; - int err; - - err =3D mv88e6xxx_g2_scratch_read(chip, MV88E6352_G2_SCRATCH_CONFIG_DATA3, - &config3); - if (err) - return err; + u8 p; - if (config3 & MV88E6352_G2_SCRATCH_CONFIG_DATA3_S_SEL) + if (chip->g2_scratch_config3 & MV88E6352_G2_SCRATCH_CONFIG_DATA3_S_SEL) p =3D 5; else p =3D 4; -- 2.36.0 From nobody Sun May 24 19:35:41 2026 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11010068.outbound.protection.outlook.com [52.101.69.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B1E7408000; Thu, 21 May 2026 20:29:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.68 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779395399; cv=fail; b=pAmofupEoTe27KFYLBbi5Ng5M7NSWRniGP8FrP7u/aGxTtIng/v1s92X2MrKy9kEf3IPkIA1igDV9IxfSnxEpoNTPLZ3DjLwa3P8/eTGKpNumDaOfhX0kOVjvBXlptiFHbeyMC9Qbs0rrP6QLY8EYQLtcEzgd/scK5b4PEdE2Cw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779395399; c=relaxed/simple; bh=f+NdB16pjGQT5gPgsHKAOsBChoSP6NXsmfVcSiXjnYA=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=h/XECJb0P4UYGC4iQdFCpZXCfuJF2LGaDiFEWoqxA23M1FLDzAud2edSWyyCV2XaDViliqb79lZfFW5R8ognv/zlaOlQ/4mvmKGHXVeK25U172BbTdjKgBlSkA5x+pRSQWaHo8lFHuFI0vg5tHwckUTU5OyP/OTkWZqQcTiOCts= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ericsson.com; spf=pass smtp.mailfrom=ericsson.com; dkim=pass (2048-bit key) header.d=ericsson.com header.i=@ericsson.com header.b=A/Lmh3E2; arc=fail smtp.client-ip=52.101.69.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=ericsson.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ericsson.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ericsson.com header.i=@ericsson.com header.b="A/Lmh3E2" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CakVQcVEItaqmmBn30+3fLY+em7xYD1+pjAyNFSJyxphHRGxpgMqjqGkRkzAvGcdgXUho8jXmfswQkO70GoJq5IjMxiR83kp4ujzTrhLvFy/sPG2gE7USJQI4sTeC7BSWPe897P/ZgYAei2Td4uYm5tk1QKKCAY0ekXghFIfT+XaeppGMDIrOyOhwz9O3SLQQ6koJIPb4BItIY13NhcyCIbNudnpxAgVfGxevpVZkOgwqZDrj0I4mu2GEnDzA23ni4EIQHju3oHZJfOXa3K5IVey7m+kSY3s7Xww0Rg/Dz1Dms3fp83eDaZp2cuGZSmthnkTR94EgMmZOUuKSCD2lQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XgY191dv/rk2IYksD2Emet8ob0K7o0cnwsh3l5pvQiU=; b=FCyzthSeLm0h+WR18LhjWkSry+ArbasrWuUzjnfoVRsjNdDswwHB3UBEqGfJV7sE2tXlm916Ly9170miqK3HCgCA/qkQsTXncgrVb4Yny38IHFWzYvts2b7H/j00N3/IS5O4Atwk8/kTspFnzeywiberiv7Fo6Vi0uFWzDaBcOiRtxrxPY4aVicJLviy+Asj+R1qgHXc9Q9fTlo85P9OaRzbKYaYn/GRk7FFmeU57XEC35Ssq4tjsasRsvBkqX5LQtzUzTCc0vrd4OayJRnRSyp6Y5QjZmYA8kiplLQYFgWEdF9WGWDxO07kxT9AH1JjnxKR/lM6l0Z6fCslK0URoA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.176.1.74) smtp.rcpttodomain=davemloft.net smtp.mailfrom=ericsson.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XgY191dv/rk2IYksD2Emet8ob0K7o0cnwsh3l5pvQiU=; b=A/Lmh3E2zRjNYi0Weqzz6XcqMltaaBWVwazSzl3X3ewdloys5uKX4xPDpdhGymwNQdbnaWpeun0WnTR3aRa71AjJw2Zt8BxOTpTmzxz5GPAcF6CBiVsG6Enp9+eL01XfOTBwIgVOJg+RTlAYdSNclk+T2AsJ5x8/8M/b1FOsgOBmJczif51FvNNXhPTOUDX9TIsLfrYCNLs425qB14yI7+eozSUm1j1Stuws8r5dZ8Zr0tN9KGrMeyaQf6dEsMMkyLASPbMZTNf9GRX452xR7Khwe1o7KkrgeSu9w8v2nLLNf/jhVtEY7jEFqJy1n8WFERGmfEAYYjENjiyyUeYfFw== Received: from DU2P251CA0011.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:230::6) by AMBPR07MB10761.eurprd07.prod.outlook.com (2603:10a6:20b:6aa::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.48.14; Thu, 21 May 2026 20:29:51 +0000 Received: from DB5PEPF00014B8C.eurprd02.prod.outlook.com (2603:10a6:10:230:cafe::56) by DU2P251CA0011.outlook.office365.com (2603:10a6:10:230::6) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.48.17 via Frontend Transport; Thu, 21 May 2026 20:29:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.176.1.74) smtp.mailfrom=ericsson.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ericsson.com; Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates 192.176.1.74 as permitted sender) receiver=protection.outlook.com; client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C Received: from oa.msg.ericsson.com (192.176.1.74) by DB5PEPF00014B8C.mail.protection.outlook.com (10.167.8.200) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.71.7 via Frontend Transport; Thu, 21 May 2026 20:29:49 +0000 Received: from seroius18815.sero.gic.ericsson.se (153.88.142.248) by smtp-central.internal.ericsson.com (100.87.178.60) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Thu, 21 May 2026 22:29:48 +0200 Received: from seroius06448.sero.gic.ericsson.se (seroius06448.sero.gic.ericsson.se [10.117.92.228]) by seroius18815.sero.gic.ericsson.se (Postfix) with ESMTP id E26184020840; Thu, 21 May 2026 22:29:47 +0200 (CEST) Received: by seroius06448.sero.gic.ericsson.se (Postfix, from userid 7434092) id CD8491005D6A; Thu, 21 May 2026 22:29:47 +0200 (CEST) From: Fidan Aliyeva To: , , , , , , CC: , , , Thomas Eckerman Subject: [PATCH net-next v2 4/4] mv88e6xxx: Remove locks for 6352's has_serdes Date: Thu, 21 May 2026 22:29:24 +0200 Message-ID: <20260521202924.727929-5-fidan.aliyeva.ext@ericsson.com> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20260521202924.727929-1-fidan.aliyeva.ext@ericsson.com> References: <20260521202924.727929-1-fidan.aliyeva.ext@ericsson.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB5PEPF00014B8C:EE_|AMBPR07MB10761:EE_ X-MS-Office365-Filtering-Correlation-Id: 3567d085-edde-4862-d2dd-08deb777b4e8 X-SMTP-Server: smtp-central.internal.ericsson.com X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|36860700016|82310400026|376014|1800799024|18002099003|22082099003|56012099003|11063799006; X-Microsoft-Antispam-Message-Info: qhkGyZLtYb6M/H6l5NzAKRKhJPZV6M5R2Tbfoy+9XVwJzhy2jMBoWgfMcygp+mEDWlZjSawHN1a2dnXV9dHdNiYFpDIxr3zf4zN6yi439+d7eMrZEbRC0y5bIIEICbJJfjqZd0myME1VMhEV+r2j6qa54PWnzEq03dCqU9ACbFTlvkC9/77I0Zs7J4YA9Xqtj+6OOxPDChyUGbXPMZY5Pk4U68wHAE9TOYk/sfeerFXJBiYZrlQung7ZIGg4KvZugR1Kem+5h+2JLAHmJ2tScwy2kAZkbZN5WLaolw2dwddnThB0Kq8t8W4DtYRuiS241jmqHOvU7fmA76uM+5Pd//KxjpHFpwpOS9Ag8ASrzObDpIEoqkAuGqVGN6aVM/AZokBK3Zj8fhLAoV4yDl9XF75RpCowrB+TAqJK3VF2wnW6vpQu88gPQrRU+LWOm/Ix+WL5Jr6CzFb/M169sBLzOSnI7lt7/aGRsz1SlY7m2thf+B2BpFaBbLtXFEP3ZI5u/TUJh3MYvW6fF+5Xa+FKrbAH7wOKdOZJjloufdzXdSi+EC23CApDgUdYHAuG648Xn68GnS50Jc8YtwwTPdUvmmNBM9geKV/aMG3q6hb00DRyPV5cHdC94cV1zydDIz6V4W92qxfK5Ii977kWG18QBbSr5JN+7virUFj4GYxipW2TN0DNRjmn0RDTjiSTw66B3Gbw0OLBTmelO/7udhY9/RXOiE4zFeBTPNuazXZhcKM= X-Forefront-Antispam-Report: CIP:192.176.1.74;CTRY:SE;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:oa.msg.ericsson.com;PTR:office365.se.ericsson.net;CAT:NONE;SFS:(13230040)(36860700016)(82310400026)(376014)(1800799024)(18002099003)(22082099003)(56012099003)(11063799006);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: YnE5u8/vPDCmJzEtGN5AkVeY6/MDwcM62X4Gs4tbZ3Mv7243+2TYs4FuzgsHvNSQ7Bb7F2K3Ewa6ldC0k2zE+K/1n4AgkPn7BGVDAhh0ooNW7ZVgHsLUhkzEpNIW767sbrPMngRyx91OTZyME2PJjlOKiTSnOIlhqC8eGApo4UVngvx1HLWkjWC1YURw965UUKaSX8bjewN2cahKVsYIMr6wUNwZXjdTdeVBA4oOpu6hczVmf/5I3/jZH3mWwt7ko+qMZq7frS3s6RH4kB1w6L9qMYr7MFXHzEXokzElXGR2nY/0jOqZQZab64Vv8B7av8yfP+vEPfokqlMnadRagFup5pshJRFmRTjadF2u6tGggjXQDq4GphNobEG7wnQEufiL/UVQniCPAc7SC8dFLLQ7n3B8Td910+lwEUA6oioFXmft+ZHkK9U0lN9ypG/E X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 May 2026 20:29:49.5827 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3567d085-edde-4862-d2dd-08deb777b4e8 X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f;Ip=[192.176.1.74];Helo=[oa.msg.ericsson.com] X-MS-Exchange-CrossTenant-AuthSource: DB5PEPF00014B8C.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AMBPR07MB10761 Content-Type: text/plain; charset="utf-8" There is no register access anymore in mv88e6352_g2_scratch_port_has_serdes. So, remove the locks surrounding the function. Co-developed-by: Thomas Eckerman Signed-off-by: Thomas Eckerman Signed-off-by: Fidan Aliyeva --- drivers/net/dsa/mv88e6xxx/pcs-6352.c | 2 -- drivers/net/dsa/mv88e6xxx/serdes.c | 2 -- 2 files changed, 4 deletions(-) diff --git a/drivers/net/dsa/mv88e6xxx/pcs-6352.c b/drivers/net/dsa/mv88e6x= xx/pcs-6352.c index 9ebf0f89f817..308655d72d52 100644 --- a/drivers/net/dsa/mv88e6xxx/pcs-6352.c +++ b/drivers/net/dsa/mv88e6xxx/pcs-6352.c @@ -326,9 +326,7 @@ static int mv88e6352_pcs_init(struct mv88e6xxx_chip *ch= ip, int port) unsigned int irq; int err; - mv88e6xxx_reg_lock(chip); err =3D mv88e6352_g2_scratch_port_has_serdes(chip, port); - mv88e6xxx_reg_unlock(chip); if (err <=3D 0) return err; diff --git a/drivers/net/dsa/mv88e6xxx/serdes.c b/drivers/net/dsa/mv88e6xxx= /serdes.c index a936ee80ce00..d3d3c121a32d 100644 --- a/drivers/net/dsa/mv88e6xxx/serdes.c +++ b/drivers/net/dsa/mv88e6xxx/serdes.c @@ -202,9 +202,7 @@ int mv88e6352_serdes_get_regs_len(struct mv88e6xxx_chip= *chip, int port) { int err; - mv88e6xxx_reg_lock(chip); err =3D mv88e6352_g2_scratch_port_has_serdes(chip, port); - mv88e6xxx_reg_unlock(chip); if (err <=3D 0) return err; -- 2.36.0