From nobody Sun May 24 19:34:44 2026 Received: from mail-dy1-f172.google.com (mail-dy1-f172.google.com [74.125.82.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B69E9401A3A for ; Thu, 21 May 2026 19:10:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779390621; cv=none; b=H8NhTkWtxtIXnjLSq0kT2agLDE5jtjqEnANsXOL9aixi5AmYyCsqAQc1c/M30dET/pSdnJpVfAl9S/e6GkRg7X2yqyKLGcXYTFXOIKLc1VZTT4FhCbIQtMD7xb1uCS3N3DMypNLfvCY0z+Z7VJcq5Q3ThtU95EAM8dK6l3jrfCE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779390621; c=relaxed/simple; bh=IeC66QzYgmFdVKKJEHJElgU9lwX7T6fKqEf5JgW/36A=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=XKxs9NQxJdIOWGZYcuyvq7DrKNJ+K6HCpd2jqv0W62YEKn8FGGg0sCP/uw7gWukQAULVWw623LcE2c5+iTXmuOBcm0SM2LHApeltcXN4bRXb0uOKZqbIqF2WS2yIFCWXskWbGkfFwWqewjMTqLjUfD7oIp2BkfrnAkIStxpLxhc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=D3iT1cyF; arc=none smtp.client-ip=74.125.82.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D3iT1cyF" Received: by mail-dy1-f172.google.com with SMTP id 5a478bee46e88-3044857f09aso379931eec.1 for ; Thu, 21 May 2026 12:10:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779390619; x=1779995419; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=lxyK9xzIpqzjCgzQbXh+agEAuv/W5UG7h+zwC0bxeck=; b=D3iT1cyFtaBaaYmjGCyisomUwX2XG6665NLaY/iumrh/+uQ78vOj/0tKy8ZH+ebkSK Jjsdha/DVWxeJi/A29B3Ua8ndfK5t7gfvwsTDTpTvYxtRHr9LAV7CWlTMu/kng6H5MBk X2nPyNSq85wt1F5r0kQ0Gv7eCeZbtiZ0pzWorKCX1lnCzUM0k2XPi0EYS00LydklUvlx 1ncrgABUusPXwwb1OnhKiIlW7W9HqY0vm7Kgq5WC0G3b7WsDxBDIfL0y1+r8N2ciOgaX uBudycmD8oaZ96B5a66kO0ODIXTVVL4CPi3QvsKujxYmTGR15xtBsbgSNHD2KjjrhfBR BQkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779390619; x=1779995419; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=lxyK9xzIpqzjCgzQbXh+agEAuv/W5UG7h+zwC0bxeck=; b=dvMoChVoGb2VBNY3za5GncONxZylq/TvDZTR75dzZeTvnpV/cpYMFU/7vBY+5CvR2C 8EwQL7Nl9lgUXGfBMfoHzqK8s+dRyApn9Eim7QP3aYGIZfaXNHkV42SIRVXDbf5Vgc6/ l2zJQw/d6HHyW9wHWZ+A0sAWMAxu08o0udlSgaAFq+8H284UaQ64C6gCIHpJ5IN68efF 05iEvLInsSe+FjgYg1menMAE/pp9/nVV/KoM9pFqP5IAaT74UZMWYZs2f5KQPsMYXPDB NdyrZTFv7uFhlooAInow32/2K9BoQ4JtZYBojqRa0uCIJjVI7X4b6+n4cYGvO05QWAgx eb6Q== X-Forwarded-Encrypted: i=1; AFNElJ9XBlRZr4MJyEEtdDlqYz3QRijvLU/2ELcYMtXYj5pjM/oSYIJeEwFJPwXoq1o1OuOeFGYghd/0GFXCp1U=@vger.kernel.org X-Gm-Message-State: AOJu0YxigOwOnSESlRQLGA81XFBrO3cYUzukt703qrAoIZJxAWwWsihy Oh4Hza7aUjs2wCy5aABTt0djrdUf4cPvM0L9+kHxkHz0VS+PgTLeG5s= X-Gm-Gg: Acq92OEIdHhzQCk7Pc2lMXdrzKO6PZkXkvrTCkbOufKwdUxXyUQ9wkzgsL+a3Gbcisp Ip87m3qCm9AXcF37MkYyhYAfpRu26AjOANlG3xWkdZdYNPtIlETnFWedUJTL8unEmmsMZTzFs8j j7fcucOvWN382/SoGlsK0KWs4o9vmHMM3nLaRZ5lVEpSA3RSBu0PMHy1rcyio2mZouKAtmfkHwR LcjiV8OZaOocn+5SSi2+l8eksAJ3v7yfbse/Hs25QtsuhVNTmHp6mwfLNAT357YJjkYyHrWmJi5 RmBHL5MbM28Hb0qTMHeSjayuoGmHb9oU+riul3aPIi1U2LIj8o0sLgePaxOwJQvomSKPE7qF6Ex DJeqXXEIIf4B+EbGCXozP5Gvv33tisD96LYrpWfHngyOw9lSotq6lIge3rIT1iXp1vFRKp6lH/J Q2dI0m8Dr5VTZiMsDD2i//K+P5mpDYjb+RyjZo//QYkWAc/GjsIsH3PiRb/fmJ X-Received: by 2002:a05:7300:ad2d:b0:2ba:a2fb:403f with SMTP id 5a478bee46e88-30449051b2fmr295935eec.21.1779390618669; Thu, 21 May 2026 12:10:18 -0700 (PDT) Received: from linux-dev ([186.158.238.108]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-304435c10desm1175734eec.27.2026.05.21.12.10.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 12:10:18 -0700 (PDT) From: =?UTF-8?q?Nicol=C3=A1s=20Antinori?= To: igor.korotin@linux.dev Cc: =?UTF-8?q?Nicol=C3=A1s=20Antinori?= , dakr@kernel.org, daniel.almeida@collabora.com, ojeda@kernel.org, boqun@kernel.org, gary@garyguo.net, bjorn3_gh@protonmail.com, lossin@kernel.org, aliceryhl@google.com, tmgross@umich.edu, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] i2c: rust: mark I2cAdapter methods as inline Date: Thu, 21 May 2026 16:08:50 -0300 Message-ID: <20260521190937.248904-1-nico.antinori.7@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable When building the kernel using llvm-19.1.7-rust-1.85.0-x86_64, the following symbols are generated: $ nm vmlinux | grep ' _R'.*I2cAdapter | rustfilt ffffffff817ff380 T ::get ffffffff817ff400 T ::dec_ref ffffffff817ff3e0 T ::inc_ref However, these Rust symbols are trivial wrappers around the `i2c_get_adapter` and `i2c_put_adapter` functions. It doesn't make sense to go through a trivial wrapper for these functions. Link: https://github.com/Rust-for-Linux/linux/issues/1145 Suggested-by: Alice Ryhl Signed-off-by: Nicol=C3=A1s Antinori Reviewed-by: Igor Korotin Reviewed-by: Onur =C3=96zkan --- rust/kernel/i2c.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/rust/kernel/i2c.rs b/rust/kernel/i2c.rs index 7b908f0c5a58..07f9fd53c4e5 100644 --- a/rust/kernel/i2c.rs +++ b/rust/kernel/i2c.rs @@ -397,6 +397,7 @@ pub fn index(&self) -> i32 { } =20 /// Gets pointer to an `i2c_adapter` by index. + #[inline] pub fn get(index: i32) -> Result> { // SAFETY: `index` must refer to a valid I2C adapter; the kernel // guarantees that `i2c_get_adapter(index)` returns either a valid @@ -416,11 +417,13 @@ pub fn get(index: i32) -> Result> { =20 // SAFETY: Instances of `I2cAdapter` are always reference-counted. unsafe impl AlwaysRefCounted for I2cAdapter { + #[inline] fn inc_ref(&self) { // SAFETY: The existence of a shared reference guarantees that the= refcount is non-zero. unsafe { bindings::i2c_get_adapter(self.index()) }; } =20 + #[inline] unsafe fn dec_ref(obj: NonNull) { // SAFETY: The safety requirements guarantee that the refcount is = non-zero. unsafe { bindings::i2c_put_adapter(obj.as_ref().as_raw()) } --=20 2.53.0