From nobody Sun May 24 19:34:45 2026 Received: from mta.al2klimov.de (mta.al2klimov.de [162.55.223.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B8591F419A for ; Thu, 21 May 2026 18:24:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=162.55.223.79 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779387867; cv=none; b=KzRxeSaFTYC/DaAB33T91WzxqAaEt6ByPk67jBa4a2ydsr8+HewuJTZvJpENsjMQcSY7CyrfaYJ7M52BN4QpNKn6dvXRJ1nLUm6JUe6KBhjqp3wYBz+5+X1uCRMGrr/hYF7fjaGk+qYguHBbPJGZTn2KjTxiJ5vHcEMJknlduDc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779387867; c=relaxed/simple; bh=+Nd6ZLTQcww3JB/AwzYyGZx3hmDFvcqbIMoVq4gakGM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=DZZQQqPXMbXZDEfNDm1fdZO/uvuvtJ/0OyhdzdWKAILIroaFmUif5wuNXzyzFlmsVe69JeaV26/WjdHX6qd/a15jPM274k0dyrJ4kNZeXwKFe5BojfeHPdJLwxYWE+8h1bRBJr4YubiYR8HsfmzUr/T4S0iRwc2yURnMn3kKJeQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=al2klimov.de; spf=pass smtp.mailfrom=al2klimov.de; dkim=pass (2048-bit key) header.d=al2klimov.de header.i=@al2klimov.de header.b=fmjB48nD; arc=none smtp.client-ip=162.55.223.79 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=al2klimov.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=al2klimov.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=al2klimov.de header.i=@al2klimov.de header.b="fmjB48nD" DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=default; bh=+Nd6ZLTQcww3 JB/AwzYyGZx3hmDFvcqbIMoVq4gakGM=; h=date:subject:cc:to:from; d=al2klimov.de; b=fmjB48nDOj5PmL6VO9Yzq+aUFENa+ffCkaC1faosTnLGDT4EbJBQ d/YsbHchbi754U9o16hRiliIslJJrXWefF6K4uTdsyYUPydRqiiTYRO5srsjtIIt21Jmag bcaZ6O+Cw8NGEFtplrzc5fVCSgaT+FFz4l4FmmlN4cOm3nW2Vc1Yy/smkhE97KaohnqrJh SEw9hxlOEeFhtBO14YHFiU7Zzfs7v9zou52F/5RB6ARr3xZtFao5MfCk2wOU1944booL+s lfgbzGhfzyqJXczxHGB+5R/DqTk7X5e5yp44yFw205bRyFdLeSwMbNvXEGCmoBnSSLxrk4 qjbuCkKPuQ== Received: from cachy-ak (2a02-2455-18e9-e011-4d8a-aad2-c25c-50e5.dyn6.pyur.net [2a02:2455:18e9:e011:4d8a:aad2:c25c:50e5]) by mta.al2klimov.de (OpenSMTPD) with ESMTPSA id 8b893f2b (TLSv1.3:TLS_CHACHA20_POLY1305_SHA256:256:NO); Thu, 21 May 2026 18:24:22 +0000 (UTC) From: "Alexander A. Klimov" To: Vaibhav Agarwal , Mark Greer , Johan Hovold , Alex Elder , Greg Kroah-Hartman , Pankaj Bharadiya , Viresh Kumar , greybus-dev@lists.linaro.org (moderated list:GREYBUS SUBSYSTEM), linux-staging@lists.linux.dev (open list:STAGING SUBSYSTEM), linux-kernel@vger.kernel.org (open list) Cc: "Alexander A. Klimov" Subject: [PATCH v4] staging: greybus: audio: correct sscanf() return value check Date: Thu, 21 May 2026 20:23:30 +0200 Message-ID: <20260521182331.22685-1-grandmaster@al2klimov.de> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" manager_sysfs_add_store() passes 6 pointers to sscanf(), but required latter to return 7 which always failed the operation. I corrected it to 6. Fixes: 49b9137a6002 ("staging: greybus: audio: remove redundant slot field") Signed-off-by: Alexander A. Klimov --- v2: added "Fixes:" to commit message v3: added all these v2/v3 lines here as requested by Greg KH v3: while on it, replaced title v4: switched my mail client, so that the diff should apply now (fucking T= hunderbird fucking trims fucking whitespace from my fucking patches so I ha= d to fucking switch to fucking git-send-email(1)) drivers/staging/greybus/audio_manager_sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/audio_manager_sysfs.c b/drivers/stagin= g/greybus/audio_manager_sysfs.c index 581791d566e3..3358d0c34f57 100644 --- a/drivers/staging/greybus/audio_manager_sysfs.c +++ b/drivers/staging/greybus/audio_manager_sysfs.c @@ -23,7 +23,7 @@ static ssize_t manager_sysfs_add_store(struct kobject *ko= bj, desc.name, &desc.vid, &desc.pid, &desc.intf_id, &desc.ip_devices, &desc.op_devices); =20 - if (num !=3D 7) + if (num !=3D 6) return -EINVAL; =20 num =3D gb_audio_manager_add(&desc); --=20 2.54.0