[PATCH 00/13] Introduce functionality for NVMe initiator

Karan Tilak Kumar posted 13 patches 3 days ago
drivers/scsi/fnic/Makefile       |    1 +
drivers/scsi/fnic/fcpio.h        |   35 +
drivers/scsi/fnic/fdls_disc.c    |  953 ++++++++------
drivers/scsi/fnic/fdls_fc.h      |   12 +
drivers/scsi/fnic/fip.c          |  117 +-
drivers/scsi/fnic/fip.h          |    2 +-
drivers/scsi/fnic/fnic.h         |  104 +-
drivers/scsi/fnic/fnic_debugfs.c |  101 +-
drivers/scsi/fnic/fnic_fcs.c     |  196 +--
drivers/scsi/fnic/fnic_fdls.h    |   48 +-
drivers/scsi/fnic/fnic_io.h      |   23 +-
drivers/scsi/fnic/fnic_isr.c     |   28 +-
drivers/scsi/fnic/fnic_main.c    |  211 ++-
drivers/scsi/fnic/fnic_nvme.c    | 2079 ++++++++++++++++++++++++++++++
drivers/scsi/fnic/fnic_nvme.h    |  138 ++
drivers/scsi/fnic/fnic_res.c     |   31 +-
drivers/scsi/fnic/fnic_res.h     |   32 +-
drivers/scsi/fnic/fnic_scsi.c    |  249 ++--
drivers/scsi/fnic/fnic_stats.h   |   28 +
drivers/scsi/fnic/fnic_trace.c   |    5 +-
drivers/scsi/fnic/vnic_devcmd.h  |    2 +-
21 files changed, 3617 insertions(+), 778 deletions(-)
create mode 100644 drivers/scsi/fnic/fnic_nvme.c
create mode 100644 drivers/scsi/fnic/fnic_nvme.h
[PATCH 00/13] Introduce functionality for NVMe initiator
Posted by Karan Tilak Kumar 3 days ago
Hi Martin, reviewers,

This series adds functionality for NVMe initiator to the fnic driver.

The changes enable the fnic driver to act as an NVMe initiator over
Fibre Channel (FC-NVMe), allowing the host to discover and communicate
with NVMe targets using the existing fnic infrastructure. The patches
prepare the driver for full FC-NVMe initiator operation while
maintaining existing SCSI/FC functionality.

These are some of the salient patches:

o. Make fnic debug logging usable by SCSI and NVMe initiator roles.
o. Use fnic instance numbers for non-SCSI-facing identifiers.
o. Decode firmware roles for FCP, NVMe, and unsupported targets.
o. Advertise NVMe initiator service parameters during FC discovery.
o. Add FDLS role handling for NVMe initiator discovery flows.
o. Add the NVMe/FC transport path and port registration.
o. Route completions, resets, and LS frames by initiator role.
o. Add NVMe LS timeouts, statistics, and debugfs state reporting.

Even though the patches have been made into a series, some patches are
heavier than others. But, every effort has been made to keep the
purpose of each patch as a single-purpose, and to compile cleanly.
All the individual patches compile cleanly. The compiler used is GCC
14.2.

This patch set has been tested as a whole. Therefore, the tested-by
fields have been added only to one patch in the set.
I've refrained from adding tested-by to most of the patches, so as to
not mislead the reviewer/reader.

A brief note on the unit tests:

o. Configure multipathing, and run link flaps on single link. IOs drop
   briefly, but pick up as expected.
o. Configure multipathing, and run link flaps on two links, with a 30
   second delay in between. IOs drop briefly, but pick up as expected.
o. Repeat the above tests with 1 queue and 64 queues.
o. Perform tests with Netapp and Pure targets.

All tests were successful.

This set of patches was reviewed before submitting upstream,
and the following review comments were incorporated.

Incorporate review comments from Hannes Reinecke:

Decode target roles explicitly and report unsupported roles.
Remove the empty line before the FLOGI completion else block.
Add a short comment for the NVMe ERSP completion case.

Incorporate review comments from Lee Duncan:

Replace the NVMe LS OXID switch with a direct frame-type check.
Rename the NVMe frame helper to follow fnic function naming style.
Convert the NVMe opcode stats helper to a switch statement.
Share NVMe completion stats accounting and compute duration once.

Thanks,
Karan

Karan Tilak Kumar (13):
  scsi: fnic: Make debug logging protocol independent
  scsi: fnic: Use fnic_num for non-SCSI identifiers
  scsi: fnic: Decode firmware role configuration
  scsi: fnic: Advertise NVMe initiator service parameters
  scsi: fnic: Add FDLS role handling for NVMe initiators
  scsi: fnic: Add the NVMe/FC transport path
  scsi: fnic: Route completions and resets by initiator role
  scsi: fnic: Handle NVMe LS frames in FDLS
  scsi: fnic: Send NVMe LS requests through FDLS
  scsi: fnic: Abort timed-out NVMe LS requests
  scsi: fnic: Track NVMe transport statistics
  scsi: fnic: Expose NVMe transport state in debugfs
  scsi: fnic: Bump up version number

 drivers/scsi/fnic/Makefile       |    1 +
 drivers/scsi/fnic/fcpio.h        |   35 +
 drivers/scsi/fnic/fdls_disc.c    |  953 ++++++++------
 drivers/scsi/fnic/fdls_fc.h      |   12 +
 drivers/scsi/fnic/fip.c          |  117 +-
 drivers/scsi/fnic/fip.h          |    2 +-
 drivers/scsi/fnic/fnic.h         |  104 +-
 drivers/scsi/fnic/fnic_debugfs.c |  101 +-
 drivers/scsi/fnic/fnic_fcs.c     |  196 +--
 drivers/scsi/fnic/fnic_fdls.h    |   48 +-
 drivers/scsi/fnic/fnic_io.h      |   23 +-
 drivers/scsi/fnic/fnic_isr.c     |   28 +-
 drivers/scsi/fnic/fnic_main.c    |  211 ++-
 drivers/scsi/fnic/fnic_nvme.c    | 2079 ++++++++++++++++++++++++++++++
 drivers/scsi/fnic/fnic_nvme.h    |  138 ++
 drivers/scsi/fnic/fnic_res.c     |   31 +-
 drivers/scsi/fnic/fnic_res.h     |   32 +-
 drivers/scsi/fnic/fnic_scsi.c    |  249 ++--
 drivers/scsi/fnic/fnic_stats.h   |   28 +
 drivers/scsi/fnic/fnic_trace.c   |    5 +-
 drivers/scsi/fnic/vnic_devcmd.h  |    2 +-
 21 files changed, 3617 insertions(+), 778 deletions(-)
 create mode 100644 drivers/scsi/fnic/fnic_nvme.c
 create mode 100644 drivers/scsi/fnic/fnic_nvme.h

-- 
2.47.1