From nobody Sun May 24 20:33:01 2026 Received: from mail-yx1-f54.google.com (mail-yx1-f54.google.com [74.125.224.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3A25372663 for ; Thu, 21 May 2026 16:14:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779380063; cv=none; b=ECUrH4WyseMxlPvw767Bmkm7VtQgHsh7PE6heqdo/lAt6urrmkLVZjeJoAHDOssyInTDpoqENi3EwPua+ZafDNqWAje8vUgJQ3760x0lzjr5NXJf3PUJD3VcbKRaNQyW3YPjuVRa+9BM57i+x3sgdNhsF1cFeYVDzce2aEBDxv4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779380063; c=relaxed/simple; bh=EvaOvJK7gUYlg9eSrzLdiPePr+0IURW/C6idzGNV3Is=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=A6BP9U87a7M5oWwWIq6Z2dY6lHbWkkwRY7IGp2fXBoBhaTUFOJm9SRH5f7nMOh2Dc0AL0QCelT+7Vp2b5ZDfY0h8/KOCpxh+4bykz4RtDTdVQwFH0JZkraaDx+tvb64Vbo/TXYyTGxHwozQsfi2ct64L+/RtDMzBH8M2gFoygEA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oL6IFDmN; arc=none smtp.client-ip=74.125.224.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oL6IFDmN" Received: by mail-yx1-f54.google.com with SMTP id 956f58d0204a3-65c37eafcbeso6805725d50.1 for ; Thu, 21 May 2026 09:14:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779380060; x=1779984860; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=0dyt1TzRyN36X5hR8tAOgPi+dzA4gZF2bfoIRk7jjmc=; b=oL6IFDmNEDFbOLkKiBJk7piHl+DHZZdJi0RuoFGC9uplQs8lJ7ebjRG49Xf43M3UUo goj1bb7WBsVgPzDnWBFAesQjYroqEpr8wIvh60/C2O12p+lFpGX+I9+vGnEo7XEF7ikc WyhIAGjpwmqfNX3uvINJQzsgCjiGxfzsuHnfeSfJxBh9NxIUWm+HRBJvKhiay+4hLwxA wRa/4zybsbzLPFuGhDHTkOES6vCgDZ3kVgSoGeUQ629MMLuxHLaAGBGIxpmb8NCe2VaN W/ibIZWLFgkg9WVW54rGTJE6jCh+R6tewqgOXXixRH0qycvyqq4m/6pqL5gSgg7a4Bxq NEvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779380060; x=1779984860; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=0dyt1TzRyN36X5hR8tAOgPi+dzA4gZF2bfoIRk7jjmc=; b=p59MWjxh3fEO7zDxnC4mISM31AGZOj551UfgAafl8BRpB9MdbqzIjIukGnZZyGdf51 rK1s0BG/6AJkoMmlzTkBAFiqn/4L0Ik9mJy83HBvzZh+ajS6AaNQj6rcDTJS7pMb39da B8IOheeue8p22JOdnF9Y55yftEBePdOyc0HOwGhHHRnmwTFV/6tQ55eJm5uxDErjaMgN q1DGaozlnuufimAwLOexwgpwnlMXNnR244xtXgyxX2/o/ct+d+3Gx0Ce6cLmFfSLwLR8 hILeJQy+BCa05pVCqbxhkjEocqwog5UyaR/D6rX4x0f9lkM8TeTT9GQmdtasP3/XCcDf W3Hg== X-Forwarded-Encrypted: i=1; AFNElJ/rjLiZgYXXOW5e7wOTbbpoSfVnM3u8xsbAJptF1pd2lwdZV6RNqcLPcoyxFGhpD6MvxiPWOEM588S2fgc=@vger.kernel.org X-Gm-Message-State: AOJu0YxqmvSz0/+CDCZP0meo7rlQP3xi/QYGYPlv5c1hN9R/n3eqweNo FdRW0pNkur4H2QBPq4E5YZRlGGjLzNjHvjqdrxmbFmVBhZXMTwBJh9aX X-Gm-Gg: Acq92OE/Hi6WcAaKaYbynEtK0HhXGuwd3onS+pBu8/yhFbdTB0HL4oVzninp90wVYu3 dGhqE5NQxAFzZnTwMvX70HtX1Y92WiHxF3rnI+WoyI8SV1gOU2nk0I4+J9kDoZD8OlvL9HFLnqd DKF8P/cwMEX7gnbO0FZZD4IWsYmj3TuDKD5gm8iR1lV4/6QOlHOeW1xKh5+8FL0HUEWiG+n5I+J tUGA5QupPp+RP1CEBV4hlHt+igzI4k77nMkI2PK4w84LOKQeQ0dZngAjUaCCjhNHRo5jFmXWwqw ITn1yv9p6d6Ok9MDsd3Tnlx6KaCFxHslXhOT9SHcYnlMVTTTuayMNmZhYs51sXpH5b8QFk+k1bf SWDk+YDCBTmxn9JbV/SEMtp8n+8ybUMTX6NgYNq3GQESTJ5tcHh4IoSj3ur7eN0OtocEtVXxN3J w1uOV6yGKs21ElkMHXbJLPy41qWoiT6gdDITdyLaHFZuZORsA= X-Received: by 2002:a05:690c:9693:b0:7bb:712:a74f with SMTP id 00721157ae682-7d20b08586emr40415707b3.17.1779380059799; Thu, 21 May 2026 09:14:19 -0700 (PDT) Received: from CachyOS.lan ([2600:6c63:417e:cfdc:e26c:e9d6:8bd3:e3fd]) by smtp.gmail.com with ESMTPSA id 00721157ae682-7d2ca76a8cbsm4621827b3.32.2026.05.21.09.14.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 09:14:19 -0700 (PDT) From: Kenny Glowner X-Google-Original-From: Kenny Glowner To: Luis Chamberlain , Petr Pavlu , Daniel Gomez , Sami Tolvanen , Miguel Ojeda Cc: linux-modules@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Kenny Glowner Subject: [PATCH] rust: module_param: add missing newline to pr_warn Date: Thu, 21 May 2026 11:14:05 -0500 Message-ID: <20260521161405.64042-1-SisyphusCode0311@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a trailing newline ('\n') to the pr_warn! call in set_param to ensure the kernel ring buffer flushes the message correctly and prevents log line smearing. Link: https://github.com/Rust-for-Linux/linux/issues/1139 Signed-off-by: Kenny Glowner --- rust/kernel/module_param.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rust/kernel/module_param.rs b/rust/kernel/module_param.rs index 6a8a7a875643..fa26089be2e0 100644 --- a/rust/kernel/module_param.rs +++ b/rust/kernel/module_param.rs @@ -63,7 +63,7 @@ pub trait ModuleParam: Sized + Copy { // to be null here. if val.is_null() { // TODO: Use pr_warn_once available. - crate::pr_warn!("Null pointer passed to `module_param::set_param`"= ); + crate::pr_warn!("Null pointer passed to `module_param::set_param`\= n"); return EINVAL.to_errno(); } =20 --=20 2.54.0