From nobody Sun May 24 20:33:26 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8017813A3F7 for ; Thu, 21 May 2026 15:36:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779377818; cv=none; b=WLxkQN/oMNjYGSZPfMnbZ8q67mirjEpgyUPTmNrf8iLneKYjev6iebd6MeVt87GqAZExmWeAgj6hylRG6KMoO83X1Tob4b0NAC/kjVjnGk2WN16+5y/5Sq+XScuyt5DYUw/kG/i0KYEDTsQb/nvR56XjLx+9W6LWwPugtXrv47E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779377818; c=relaxed/simple; bh=FD8IvK1gXQx5wLqh2EUIHl/A6W3peoBLFvUS6imjxoU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=eP7o/Usa9+xEfga8yF98+nDGoahRzBW/0qs3C8jS+XocO22CBNWUbBcTMJdkWLiihIAjTRX4iX/ADJSTXlfNxGf/Zvzpmt88Nv0boDf/9hqHiVhftD8sBg9wXmZWvZWb4wNPjqAq3Fd/eoKbUVUZIGU3UsRhXUOdRNej92YjgPM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=orLOn2EC; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="orLOn2EC" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-48896199cbaso49188605e9.1 for ; Thu, 21 May 2026 08:36:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779377816; x=1779982616; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=atavLJO9ib3dVO9oXs0ZfRhlR41n5og9pxT0XRvm9dc=; b=orLOn2ECKDOEFtB6WvL4t+HhrcdY49Z5P0pZIVwla/5GYUOYJWYjUNbm+nNqoJVPKs mfsoOzAs7MKUYxZzgs8+t+YVxmD7nYXbRloKM4IkYYsF3OfYqlUcVvBC2oxKixw2UpHp Y7t/W9qGFqfvYONlm+AMHfLPeTwP7kuqdbvEboZLuHgMquVxhQXZ3NhhMQt7FFMnHhMT BNGaaVYTsgk0+FZftShpBaAbM+H/oZ0t1DEAMYDiNWVvdi4xjG6uyhV2Yo2cxB0gkn12 uPVXUBOJ5heeoUPzHbY7Gv8xe0wt1HRn+cfe0QxeeCwwhkR0AkGm7owEWN5rPEHsHf5W P+Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779377816; x=1779982616; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=atavLJO9ib3dVO9oXs0ZfRhlR41n5og9pxT0XRvm9dc=; b=sD+bPsBLi79UGb/WYs17S6n1bCPZskxUISDkQVEqp0eoFLfL/7tFMOuMr4iDPpKVm5 QbhYVHnN2xFMPpEwV3v8uOvqIV52nvmszBSXXmj0ahVs6Uu6oxu2V2+cTZLJv2pKSKdS +YBmvh1DeEPrzuFC3C5v2MBo5wjwCmXQnxIFeancRwER3GUsUhdRYTVW8U+E3j2uu2Tt rzU525LlJosT9q0Uz5y5pdR20s8TKgTkMU4TgbMnirSOIGYsxeVkwoVRNazDpEM0Cvny 6g7yNIEI5cxYIhYmf98a5nKIYWxinpCLAb0IsBuberh4LVDu6hxRlMZB3b7U4h6kvv0/ xkSg== X-Forwarded-Encrypted: i=1; AFNElJ9lOBcy3k+ZuPVEu9qOVJAh3XLnb5DTzSW77bOLRNQJ2JsAURJ6fPR1U8c7d5qjTyQ5HRO/6ve2AtXtyG0=@vger.kernel.org X-Gm-Message-State: AOJu0YyjdvFOxeMuVJdak6ygcEPXMgIIw+mEn2KfwZjb3UMTQaycVT/6 8/uPQ82zEP8MGRo20NuBuTCJ8iQ3wrRicy+0IbeGu0DK7oDbIzrdl25Q X-Gm-Gg: Acq92OEvrLJG6d6qp2KzWtfDou37ol1e3kX4i2Jp3YVaFj2tZ1s9goAmPdA/rTazCt1 gEROY3SjpHyI0cRYCmx8T1j/x1QpOHqLwkz/MBkksEqLzMEku5t5pZulhJUUjnbpWcuGqBm0ynU WX/zzxhTo70F9fa9n+4jcngiJeaf/3NYR8apk6Yzqvibh6dic7coOY0NlsJzm/wRUFeqP8lpEGM A4tAoaf0RI5t2NNPZTpf41nETjTjobZM5NPnUBQ+VNyejCoYtQn4qObSKGx0FFF00DAI5G6Ih/M tprVNqlk0dYVFwJN4Iv5YUrAJgOnmxkod2GE18yU6gJg9TpPdxSlo9hsTb7rX1/nNQV2xG7d6eM g/qk/JgUw7peL1ytJxfAJtrffPw/1JAdyTX7P5HN211zqu8SICC/4MTzvr7x9yAfNF0et6FLb0G FAGE98JKuWG4mfIN+4wXZQF/yR9C9ZkhAQTnr6w7hya26+WV6nOIIN/gaHL+q63CA= X-Received: by 2002:a05:600c:470e:b0:490:3ec9:8711 with SMTP id 5b1f17b1804b1-4903ec98789mr14784095e9.18.1779377815576; Thu, 21 May 2026 08:36:55 -0700 (PDT) Received: from Ansuel-XPS24 (host-79-22-5-99.retail.telecomitalia.it. [79.22.5.99]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-49033d9edcbsm79159825e9.13.2026.05.21.08.36.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 08:36:54 -0700 (PDT) From: Christian Marangi To: Michael Turquette , Stephen Boyd , Brian Masney , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Christian Marangi , Vinod Koul , Neil Armstrong , Lorenzo Bianconi , Felix Fietkau , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org Cc: Krzysztof Kozlowski Subject: [PATCH v9 1/5] dt-bindings: clock: airoha: Add PHY binding for Serdes port Date: Thu, 21 May 2026 17:35:52 +0200 Message-ID: <20260521153645.7028-2-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260521153645.7028-1-ansuelsmth@gmail.com> References: <20260521153645.7028-1-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add PHY cell property for Serdes port selection. Currently supported only for Airoha AN7581 SoC, that support up to 4 Serdes port. The Serdes port can support both PCIe, USB3 or Ethernet mode. - PCIe1 Serdes can support PCIe or Ethernet mode. - PCIe2 Serdes can support PCIe or Ethernet mode. - USB1 Serdes can support USB3 or HSGMII mode. - USB2 Serdes can support USB3 or PCIe mode. Add bindings to permit correct reference of the Serdes ports in DT. Values are just symbolic and enumerates the Serdes port with a specific number for precise reference. The available Serdes port can be selected following the dt-binding header in [2]. [2] Signed-off-by: Christian Marangi Reviewed-by: Krzysztof Kozlowski --- .../devicetree/bindings/clock/airoha,en7523-scu.yaml | 9 +++++++++ include/dt-bindings/soc/airoha,scu-ssr.h | 11 +++++++++++ 2 files changed, 20 insertions(+) create mode 100644 include/dt-bindings/soc/airoha,scu-ssr.h diff --git a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml= b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml index eb24a5687639..913ddc16182b 100644 --- a/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml +++ b/Documentation/devicetree/bindings/clock/airoha,en7523-scu.yaml @@ -23,6 +23,7 @@ description: | =20 All these identifiers can be found in: [1]: . + [2]: . =20 The clocks are provided inside a system controller node. =20 @@ -50,6 +51,12 @@ properties: description: ID of the controller reset line const: 1 =20 + '#phy-cells': + description: + The first cell indicates the serdes phy number, see [2] for the + available serdes port. + const: 1 + required: - compatible - reg @@ -65,6 +72,8 @@ allOf: reg: minItems: 2 =20 + '#phy-cells': false + - if: properties: compatible: diff --git a/include/dt-bindings/soc/airoha,scu-ssr.h b/include/dt-bindings= /soc/airoha,scu-ssr.h new file mode 100644 index 000000000000..33c64844ada3 --- /dev/null +++ b/include/dt-bindings/soc/airoha,scu-ssr.h @@ -0,0 +1,11 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ + +#ifndef __DT_BINDINGS_AIROHA_SCU_SSR_H +#define __DT_BINDINGS_AIROHA_SCU_SSR_H + +#define AIROHA_SCU_SERDES_PCIE1 0 +#define AIROHA_SCU_SERDES_PCIE2 1 +#define AIROHA_SCU_SERDES_USB1 2 +#define AIROHA_SCU_SERDES_USB2 3 + +#endif /* __DT_BINDINGS_AIROHA_SCU_SSR_H */ --=20 2.53.0 From nobody Sun May 24 20:33:26 2026 Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58D56366814 for ; Thu, 21 May 2026 15:36:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.51 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779377822; cv=none; b=mxLPxbd/jiSUYBfFs03r8sqf0zd8OzAmYQlEgXtogus41a3e00vTOcs+g3zJ1zFFGD9ZIdpln9teRMctOvKMB28F3PkcUTrE5mGFfMQXdifOK2ykQbHktJLiuP7Uh7i36NYJZ/s4K1kezqJ4+r3aB+jhVpOnx9PhoNQmRY6SsRE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779377822; c=relaxed/simple; bh=qnJ6lEJILLeq57ziFnJ/tdvg1mnErt8MEYpEx0zbJC0=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Z9cV0qnzcIlQokD6egbQ1mrlptvBCJb9AKINSgLzcvSl/jTwgQ+gWRwO54YLLE4pqUSVw2hglUbzoQSGHLwhfHfE1WvPFBuSDN20EzZF1nndabp6saAxOurp0dc7/R9AEubq1p5cZBe7RMfqSfeRop3rSVC5CXf//GfN9Haw0Ww= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=PMnKmljp; arc=none smtp.client-ip=209.85.128.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="PMnKmljp" Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-49040362e4aso885285e9.0 for ; Thu, 21 May 2026 08:36:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779377818; x=1779982618; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=rIXM1te+ieHNM+6xW1gwzAdkuvYjOEEfP1FJY4/MyNs=; b=PMnKmljpni5bSAgnAmd12bY/0kGesC+W0bZ7T/0tQ/18D0mNv17neyXjg6FuguFFfS o0J5Z4UmHOdaN9630DNQQuzGtUqj6oumbvXgmdLxpQ/s6YEFqxl5Y0yJCn5IjHNyMb8a 2Kg8PUZui6kEVKMZ0k9T1JLq+GIusBpOLm6/k2auobsjPezHkfF/5N5ZR+xVTdhXtnoP z9pGYX9hlCwQNfixV2/UlMZ5RrhlBQXJnTqbZQBwr//3ZI2qrzfAIR41Zakq1DgphxEu IyDNetVvlznotNp5cU06F1xKTlNpbxltRtVZsYL69iA5LDjYpB2xprxKUTz44VIzFN7Y nQ9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779377818; x=1779982618; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=rIXM1te+ieHNM+6xW1gwzAdkuvYjOEEfP1FJY4/MyNs=; b=nhLQe16emkm8us1cDs3LIJuwSWIxQkt/zDtcrA5CWGcXIK1cxrtDQePE3vGw/iGgid NjT1Qaww9m8NiD992D7BIooNgloTmIHkoYLBOAPruK+zKgNunsh4VCUcK0MCa/Q25HN2 Rbqs94HEz7qv+YnTZx9jwtQ6hKo2JagRjfzmlmJg0kbeuwJskowCZAW3+C3JLkUjV7ms jm5ILtrtk/UBoCIEeD5M//b3tXF1oqolhLEAKDy71PSYf0EnG5xgoabEp3s+HtW0rcj2 1Li/hmXavqRwJYihimk0cN7i27Plh4CX0AFVJXdKQZFSpvXQtR150vgh+k7QK+8HWOiX iZkQ== X-Forwarded-Encrypted: i=1; AFNElJ9ArCAfmhuN6wih4xAiojiFYCz/XDaMTq7WCz0fsAHIt+TMLdk6FETM07ArPWPtkPRdEDMhgY9Khe0MXXo=@vger.kernel.org X-Gm-Message-State: AOJu0YzQ11a5L2D4s5gv+VV+WBp/pa803APBvwCZguTB+x4Xdcw8QQeX /0brSWjC1z6ys3BzNmaCt/mPDRXOlVxgWVerizRiWM63xwsqztifK3m4 X-Gm-Gg: Acq92OGBSW9ri2odTEHJpfFqMjR0RroyVOaPB9pMRboEmsiaaZ4LKYTTQQn+2BjPkEi l2nUyPmBF9UxQ4UdGEl2Fkrmbp1DaGIh2aCbGjH0F5g2mVc/J4BpwSadDP5y50WmS8GOa2LhlvG PUUvYYI7brMoUEBxDBtJVyHDrV7kDUo99G8GqXjna3gUQoRjkAAjGmc97Y9RwjG0A/ATOuR70uA pVHUvDoWUEXhWiGP3csRwOhUnV1CUs+oqvscwO6BN550IgLfebo7ibo+8DcTELb8CLCgP4tWQV0 EIOzreLkrcVM85q8AufjB6+3sbBjLbJIuP8+nX+X6P6WvA1VFLWH/UmGGZaCWTVX4UqYRMqFNof b28gLT4UZZYF4czvOsxqAhfiQfHQZ5VHbJrOILsTVIWF45oD9eQRFflitD/a7jm6sUsCTNYMN9C dGkYbqucQ4X/8L1ZZ+Vvn502IK2g2Vv7vuwquYgi0i22uUT5DD0xGFkem7F6g9pa8= X-Received: by 2002:a05:600c:1f8d:b0:489:5022:39a4 with SMTP id 5b1f17b1804b1-49036041cbdmr49662045e9.9.1779377817541; Thu, 21 May 2026 08:36:57 -0700 (PDT) Received: from Ansuel-XPS24 (host-79-22-5-99.retail.telecomitalia.it. [79.22.5.99]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-49033d9edcbsm79159825e9.13.2026.05.21.08.36.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 08:36:56 -0700 (PDT) From: Christian Marangi To: Michael Turquette , Stephen Boyd , Brian Masney , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Christian Marangi , Vinod Koul , Neil Armstrong , Lorenzo Bianconi , Felix Fietkau , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org Subject: [PATCH v9 2/5] dt-bindings: phy: Add documentation for Airoha AN7581 USB PHY Date: Thu, 21 May 2026 17:35:53 +0200 Message-ID: <20260521153645.7028-3-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260521153645.7028-1-ansuelsmth@gmail.com> References: <20260521153645.7028-1-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add documentation for Airoha AN7581 USB PHY that describe the USB PHY for the USB controller. Airoha AN7581 SoC support a maximum of 2 USB port. The USB 2.0 mode is always supported. The USB 3.0 mode is optional and depends on the Serdes mode currently configured on the system for the relevant USB port. To correctly calibrate, the USB 2.0 port require correct value in "airoha,usb2-monitor-clk-sel" property. Both the 2 USB 2.0 port permit selecting one of the 4 monitor clock for calibration (internal clock not exposed to the system) but each port have only one of the 4 actually connected in HW hence the correct value needs to be specified in DT based on board and the physical port. Normally it's monitor clock 1 for USB1 and monitor clock 2 for USB2. To correctly setup the Serdes mode attached to the USB 3.0 mode, a phys property is required with the phandle pointing to the correct Serdes port provided by the SCU node. Providing the phys property is optional if USB 3.0 is not used. Signed-off-by: Christian Marangi Reviewed-by: Krzysztof Kozlowski --- .../bindings/phy/airoha,an7581-usb-phy.yaml | 62 +++++++++++++++++++ MAINTAINERS | 6 ++ 2 files changed, 68 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/airoha,an7581-usb= -phy.yaml diff --git a/Documentation/devicetree/bindings/phy/airoha,an7581-usb-phy.ya= ml b/Documentation/devicetree/bindings/phy/airoha,an7581-usb-phy.yaml new file mode 100644 index 000000000000..f42e3d49a61f --- /dev/null +++ b/Documentation/devicetree/bindings/phy/airoha,an7581-usb-phy.yaml @@ -0,0 +1,62 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/airoha,an7581-usb-phy.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Airoha AN7581 SoC USB PHY + +maintainers: + - Christian Marangi + +description: > + The Airoha AN7581 SoC USB PHY describes the USB PHY for the USB controll= er. + + Airoha AN7581 SoC support a maximum of 2 USB port. The USB 2.0 mode is + always supported. The USB 3.0 mode is optional and depends on the Serdes + mode currently configured on the system for the relevant USB port. + +properties: + compatible: + const: airoha,an7581-usb-phy + + reg: + maxItems: 1 + + airoha,usb2-monitor-clk-sel: + description: Describe what oscillator across the available 4 + should be selected for USB 2.0 Slew Rate calibration. + $ref: /schemas/types.yaml#/definitions/uint32 + enum: [0, 1, 2, 3] + + phys: + items: + - description: phandle to Serdes PHY. Optional if USB 3.0 is not use= d. + + '#phy-cells': + description: The cell contains the mode, PHY_TYPE_USB2 or PHY_TYPE_USB= 3, + as defined in dt-bindings/phy/phy.h. + const: 1 + +required: + - compatible + - reg + - airoha,usb2-monitor-clk-sel + - '#phy-cells' + +additionalProperties: false + +examples: + - | + #include + + phy@1fac0000 { + compatible =3D "airoha,an7581-usb-phy"; + reg =3D <0x1fac0000 0x10000>; + + airoha,usb2-monitor-clk-sel =3D <1>; + phys =3D <&scu AIROHA_SCU_SERDES_USB1>; + + #phy-cells =3D <1>; + }; + diff --git a/MAINTAINERS b/MAINTAINERS index 21c0ef0b9ce5..932044785a39 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -771,6 +771,12 @@ S: Maintained F: Documentation/devicetree/bindings/spi/airoha,en7581-snand.yaml F: drivers/spi/spi-airoha-snfi.c =20 +AIROHA USB PHY DRIVER +M: Christian Marangi +L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) +S: Maintained +F: Documentation/devicetree/bindings/phy/airoha,an7581-usb-phy.yaml + AIRSPY MEDIA DRIVER L: linux-media@vger.kernel.org S: Orphan --=20 2.53.0 From nobody Sun May 24 20:33:26 2026 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F6F8368D50 for ; Thu, 21 May 2026 15:37:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779377823; cv=none; b=BDfpFcX959Fd2A74IjCXpp1kDBelhboX1HZ4Movk2qJl9SWeCgwCxBLzOfRZe9z/4K7o91o8OdMieQO5+Mgpw8fjBnJate1bO7LQgYHAnyLMVMmex+9ui9L5Hj1xDxjNB7UHND6F0nsldP2Uj99B9zTEsDQ4I+yyibiHvziQUzI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779377823; c=relaxed/simple; bh=AUrwy4VG7i1vxV+aY9+U6sgvejCDhS730W8Tn29xvzc=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Wb+CyR4BVPRv6E1jQK1gVKNN1c6ZlJmCSCNB5wK6LaJQV61uzKrKwOy1o5iJcT7QWrdv4owF2qyG2tVUW357KroXaLnTOL0L+HBEuIt1xmUDPcAxx8l1QgEEwNBn3I4cb+1Jtfs0Vkf4cEyBiuI/1vYS1kmZbymCJLadrxlUtl8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IyGeN33L; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IyGeN33L" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-490388fd0dbso7886125e9.0 for ; Thu, 21 May 2026 08:37:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779377820; x=1779982620; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=xW4ciKbbQRnX/OjD6z0+5b7UCtG5NvYvPMF/2Ve0g6c=; b=IyGeN33LJ3fSeS8SqlZZjHOtiZl0A5VJE1R6LGqR3lSECfaoj76IO1dsom5i1EWxzp kRK9ipaK5EcgiL1vsNK+SxOItRQHzLDwdH5FgZmu7QJ3Ve02OYMhDFuAZ73hWi8egaZq sWZ9uhZyaY66EhYYo8js0/UEoqocAoBeyh0tIRozdjSXl+kFSTjbYHVLg7X/rxssuoiA dnuiLjGuPUVhOjYTqVs5BDHlSv9KW+wgEXaCn5Z5v/RJTSqvo2cKtFNbGNzFbajEXatH bvXuDdEeCdSZCzqJ5DYpZLZGbqp5cHMg8e5RLierJPkgoNTEtFx7f4X7uJz3XWYZmiZ9 z22g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779377820; x=1779982620; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=xW4ciKbbQRnX/OjD6z0+5b7UCtG5NvYvPMF/2Ve0g6c=; b=HPKRQXD5888JBwhPgSuOdxb9zTWkInxHV35ukmbZf+ZRAICmM7J/K4lkdL3lgWkF/R VvX9H4O7vplM8y2QRm+OksRpCmP7M724EiSFVnrfUQw3EUqzPtwTdvKVVHJszv+yBew4 AiHxItXMK7y8RBvFcbm5BU7q5AXYYtwQYx4w/vEKD1jRBBs40yGZH3WNk9vviwQYWfLd zsXI+Ym3GujqfldFNhgt3QT7ExiPGvGcDr8gPIC+L7PhmBTboEcpJYtDSug/MV1L2LnL DiY5/46AUcE1j12QRY22Vjvhd7uBTi/bQfndzLZt8lu8nZxjeoidPhdQSrvNcVqNKhfL jeLQ== X-Forwarded-Encrypted: i=1; AFNElJ/m9/jVZpx9q01+9iuzyPJ5btqP9/dUjyFP1Km0YrOUz87jS85aqfGn20UUgOo2kmjtdk8AXZdX1pw7jhk=@vger.kernel.org X-Gm-Message-State: AOJu0YzLr2dla4/ZzZTitjpiPk1zncccDnt16oe3G3MhezZVsURX+35R rr1pmUgDa+t5plKaKXcPPgumxmhtFqno+QbNdOBeXqGDg+wMrCv72r4s X-Gm-Gg: Acq92OEUlPMpLaKV3nxCg0Zv6noiZtFMiW7vJiLNDcwB6RmXC6IAtOYmtYmeySCbe2w D+/tb5MlAwo+LggCye44KUyFXBkXz6T2zc+aXn75JalplM8QgH5Zwk1LEOS/j3BN5N5Uuqaz6e5 xHAKQ8njcwRoxfxAhBcqi2w8GOWCjBSsviaaW9M5702XtebMS/mdZaD0IYDVQg7TiB+rmXYDq8O gLtsGwnynOTXeT3+c8X7m59hfh4/BHu0xMpCKtc+PQTnxy9T7Mv5Egg5YY1+7VS13TXVYcDTfdT cCztsIVg+2IDAtU8p3l/oh4m+iICOnt47i4dKonbNYtz7tlJheHD1bRTiM3DsdkwETto2o3Qd3z /VVvokT7cSKm8XnyW8pc2KlQP3lDOwvsUeNAZqFZQF0pczwGtmIExA1adWrohZiN6Dzbz4ijl10 ACJ6SBkzIgH+ajtXZhPhLzW9yuDs4QxpVBsqum8/+he7uc7YrRY8rnivmFrMQcDZ0= X-Received: by 2002:a05:600c:49a2:b0:48f:d5b8:5b07 with SMTP id 5b1f17b1804b1-4903608937bmr31486225e9.20.1779377820234; Thu, 21 May 2026 08:37:00 -0700 (PDT) Received: from Ansuel-XPS24 (host-79-22-5-99.retail.telecomitalia.it. [79.22.5.99]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-49033d9edcbsm79159825e9.13.2026.05.21.08.36.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 08:36:58 -0700 (PDT) From: Christian Marangi To: Michael Turquette , Stephen Boyd , Brian Masney , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Christian Marangi , Vinod Koul , Neil Armstrong , Lorenzo Bianconi , Felix Fietkau , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org Subject: [PATCH v9 3/5] clk: en7523: Add support for selecting the Serdes port in SCU Date: Thu, 21 May 2026 17:35:54 +0200 Message-ID: <20260521153645.7028-4-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260521153645.7028-1-ansuelsmth@gmail.com> References: <20260521153645.7028-1-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In the SCU register for clock and reset, there are also some register to select the Serdes port mode. The Airoha AN7581 SoC have 4 different Serdes that can switch between PCIe, USB or Ethernet mode. Add a simple PHY provider that expose the .set_mode OP to toggle the requested mode for the Serdes port. Reviewed-by: Brian Masney Signed-off-by: Christian Marangi --- drivers/clk/Kconfig | 1 + drivers/clk/clk-en7523.c | 218 ++++++++++++++++++++++++++++++++++++++- 2 files changed, 216 insertions(+), 3 deletions(-) diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig index b2efbe9f6acb..e60a824b5117 100644 --- a/drivers/clk/Kconfig +++ b/drivers/clk/Kconfig @@ -221,6 +221,7 @@ config COMMON_CLK_EN7523 bool "Clock driver for Airoha/EcoNet SoC system clocks" depends on OF depends on ARCH_AIROHA || ECONET || COMPILE_TEST + select GENERIC_PHY default ARCH_AIROHA help This driver provides the fixed clocks and gates present on Airoha diff --git a/drivers/clk/clk-en7523.c b/drivers/clk/clk-en7523.c index 1ab0e2eca5d3..183cf7fe4bda 100644 --- a/drivers/clk/clk-en7523.c +++ b/drivers/clk/clk-en7523.c @@ -6,14 +6,18 @@ #include #include #include +#include +#include #include #include #include +#include #include #include #include #include #include +#include =20 #define RST_NR_PER_BANK 32 =20 @@ -40,9 +44,22 @@ #define REG_HIR_MASK GENMASK(31, 16) /* EN7581 */ #define REG_NP_SCU_PCIC 0x88 +#define REG_NP_SCU_SSR3 0x94 +#define REG_SSUSB_HSGMII_SEL_MASK BIT(29) +#define REG_SSUSB_HSGMII_SEL_HSGMII FIELD_PREP_CONST(REG_SSUSB_HSGMII_SEL_= MASK, 0x0) +#define REG_SSUSB_HSGMII_SEL_USB FIELD_PREP_CONST(REG_SSUSB_HSGMII_SEL_MAS= K, 0x1) #define REG_NP_SCU_SSTR 0x9c #define REG_PCIE_XSI0_SEL_MASK GENMASK(14, 13) +#define REG_PCIE_XSI0_SEL_PCIE FIELD_PREP_CONST(REG_PCIE_XSI0_SEL_MASK, 0= x0) +#define REG_PCIE_XSI0_SEL_XFI FIELD_PREP_CONST(REG_PCIE_XSI0_SEL_MASK, 0x= 1) +#define REG_PCIE_XSI0_SEL_HSGMII FIELD_PREP_CONST(REG_PCIE_XSI0_SEL_MASK, = 0x2) #define REG_PCIE_XSI1_SEL_MASK GENMASK(12, 11) +#define REG_PCIE_XSI1_SEL_PCIE FIELD_PREP_CONST(REG_PCIE_XSI1_SEL_MASK, 0= x0) +#define REG_PCIE_XSI1_SEL_XFI FIELD_PREP_CONST(REG_PCIE_XSI1_SEL_MASK, 0x= 1) +#define REG_PCIE_XSI1_SEL_HSGMII FIELD_PREP_CONST(REG_PCIE_XSI1_SEL_MASK, = 0x2) +#define REG_USB_PCIE_SEL_MASK BIT(3) +#define REG_USB_PCIE_SEL_PCIE FIELD_PREP_CONST(REG_USB_PCIE_SEL_MASK, 0x0) +#define REG_USB_PCIE_SEL_USB FIELD_PREP_CONST(REG_USB_PCIE_SEL_MASK, 0x1) #define REG_CRYPTO_CLKSRC2 0x20c /* EN751221 */ #define EN751221_REG_SPI_DIV 0x0cc @@ -81,6 +98,8 @@ enum en_hir { HIR_MAX =3D 14, }; =20 +#define EN_SERDES_PHY_NUM 4 + struct en_clk_desc { int id; const char *name; @@ -113,6 +132,18 @@ struct en_rst_data { struct reset_controller_dev rcdev; }; =20 +struct en_serdes_phy_instance { + struct phy *phy; + unsigned int serdes_port; +}; + +struct en_clk_priv { + void __iomem *base; + /* protect SCU register */ + spinlock_t lock; + struct en_serdes_phy_instance *serdes_phys[EN_SERDES_PHY_NUM]; +}; + struct en_clk_soc_data { u32 num_clocks; const struct clk_ops pcie_ops; @@ -830,12 +861,179 @@ static int en7581_reset_register(struct device *dev,= void __iomem *base, return devm_reset_controller_register(dev, &rst_data->rcdev); } =20 +static int en7581_serdes_phy_set_mode(struct phy *phy, enum phy_mode mode, + int submode) +{ + struct en_serdes_phy_instance *instance =3D phy_get_drvdata(phy); + struct en_clk_priv *priv =3D dev_get_drvdata(phy->dev.parent); + u32 reg, mask, sel, val; + unsigned long flags; + + switch (instance->serdes_port) { + case AIROHA_SCU_SERDES_PCIE1: + reg =3D REG_NP_SCU_SSTR; + mask =3D REG_PCIE_XSI0_SEL_MASK; + + if (mode !=3D PHY_MODE_ETHERNET && mode !=3D PHY_MODE_PCIE) + return -EINVAL; + + if (mode =3D=3D PHY_MODE_ETHERNET) { + switch (submode) { + case PHY_INTERFACE_MODE_USXGMII: + case PHY_INTERFACE_MODE_10GBASER: + sel =3D REG_PCIE_XSI0_SEL_XFI; + break; + case PHY_INTERFACE_MODE_SGMII: + case PHY_INTERFACE_MODE_1000BASEX: + case PHY_INTERFACE_MODE_2500BASEX: + sel =3D REG_PCIE_XSI0_SEL_HSGMII; + break; + default: + return -EINVAL; + } + } else { + sel =3D REG_PCIE_XSI0_SEL_PCIE; + } + + break; + case AIROHA_SCU_SERDES_PCIE2: + reg =3D REG_NP_SCU_SSTR; + mask =3D REG_PCIE_XSI1_SEL_MASK; + + if (mode !=3D PHY_MODE_ETHERNET && mode !=3D PHY_MODE_PCIE) + return -EINVAL; + + if (mode =3D=3D PHY_MODE_ETHERNET) { + switch (submode) { + case PHY_INTERFACE_MODE_USXGMII: + case PHY_INTERFACE_MODE_10GBASER: + sel =3D REG_PCIE_XSI1_SEL_XFI; + break; + case PHY_INTERFACE_MODE_SGMII: + case PHY_INTERFACE_MODE_1000BASEX: + case PHY_INTERFACE_MODE_2500BASEX: + sel =3D REG_PCIE_XSI1_SEL_HSGMII; + break; + default: + return -EINVAL; + } + } else { + sel =3D REG_PCIE_XSI1_SEL_PCIE; + } + + break; + case AIROHA_SCU_SERDES_USB1: + reg =3D REG_NP_SCU_SSR3; + mask =3D REG_SSUSB_HSGMII_SEL_MASK; + + if (mode !=3D PHY_MODE_ETHERNET && mode !=3D PHY_MODE_USB_DEVICE && + mode !=3D PHY_MODE_USB_DEVICE_SS) + return -EINVAL; + + if (mode =3D=3D PHY_MODE_ETHERNET) + sel =3D REG_SSUSB_HSGMII_SEL_HSGMII; + else + sel =3D REG_SSUSB_HSGMII_SEL_USB; + + break; + case AIROHA_SCU_SERDES_USB2: + reg =3D REG_NP_SCU_SSTR; + mask =3D REG_USB_PCIE_SEL_MASK; + + if (mode !=3D PHY_MODE_PCIE && mode !=3D PHY_MODE_USB_DEVICE && + mode !=3D PHY_MODE_USB_DEVICE_SS) + return -EINVAL; + + if (mode =3D=3D PHY_MODE_PCIE) + sel =3D REG_USB_PCIE_SEL_PCIE; + else + sel =3D REG_USB_PCIE_SEL_USB; + + break; + default: + return -EINVAL; + } + + spin_lock_irqsave(&priv->lock, flags); + val =3D readl(priv->base + reg); + val &=3D ~mask; + val |=3D sel; + writel(val, priv->base + reg); + spin_unlock_irqrestore(&priv->lock, flags); + + return 0; +} + +static const struct phy_ops en7581_serdes_phy_ops =3D { + .set_mode =3D en7581_serdes_phy_set_mode, + .owner =3D THIS_MODULE, +}; + +static struct phy *en7581_serdes_phy_xlate(struct device *dev, + const struct of_phandle_args *args) +{ + struct en_clk_priv *priv =3D dev_get_drvdata(dev); + struct en_serdes_phy_instance *instance; + unsigned int serdes_port; + + if (args->args_count !=3D 1) { + dev_err(dev, "invalid number of cells in 'phy' property\n"); + return ERR_PTR(-EINVAL); + } + + serdes_port =3D args->args[0]; + if (serdes_port >=3D EN_SERDES_PHY_NUM) { + dev_err(dev, "invalid serdes port: %d\n", serdes_port); + return ERR_PTR(-EINVAL); + } + + instance =3D priv->serdes_phys[serdes_port]; + if (!instance) { + dev_err(dev, "failed to find appropriate serdes phy\n"); + return ERR_PTR(-EINVAL); + } + + return instance->phy; +} + +static int en7581_serdes_phy_register(struct device *dev) +{ + struct en_clk_priv *priv =3D dev_get_drvdata(dev); + struct phy_provider *phy_provider; + int i; + + for (i =3D 0; i < EN_SERDES_PHY_NUM; i++) { + struct en_serdes_phy_instance *instance; + + instance =3D devm_kzalloc(dev, sizeof(*instance), + GFP_KERNEL); + if (!instance) + return -ENOMEM; + + instance->phy =3D devm_phy_create(dev, NULL, + &en7581_serdes_phy_ops); + if (IS_ERR(instance->phy)) + return dev_err_probe(dev, PTR_ERR(instance->phy), "failed to create phy= \n"); + + instance->serdes_port =3D i; + priv->serdes_phys[i] =3D instance; + + phy_set_drvdata(instance->phy, instance); + } + + phy_provider =3D devm_of_phy_provider_register(dev, en7581_serdes_phy_xla= te); + + return PTR_ERR_OR_ZERO(phy_provider); +} + static int en7581_clk_hw_init(struct platform_device *pdev, struct clk_hw_onecell_data *clk_data) { + struct en_clk_priv *priv =3D platform_get_drvdata(pdev); struct regmap *map; void __iomem *base; u32 val; + int ret; =20 map =3D syscon_regmap_lookup_by_compatible("airoha,en7581-chip-scu"); if (IS_ERR(map)) @@ -845,6 +1043,8 @@ static int en7581_clk_hw_init(struct platform_device *= pdev, if (IS_ERR(base)) return PTR_ERR(base); =20 + priv->base =3D base; + en7581_register_clocks(&pdev->dev, clk_data, map, base); =20 val =3D readl(base + REG_NP_SCU_SSTR); @@ -853,9 +1053,12 @@ static int en7581_clk_hw_init(struct platform_device = *pdev, val =3D readl(base + REG_NP_SCU_PCIC); writel(val | 3, base + REG_NP_SCU_PCIC); =20 - return en7581_reset_register(&pdev->dev, base, en7581_rst_map, - ARRAY_SIZE(en7581_rst_map), - en7581_rst_ofs); + ret =3D en7581_reset_register(&pdev->dev, base, en7581_rst_map, + ARRAY_SIZE(en7581_rst_map), en7581_rst_ofs); + if (ret) + return ret; + + return en7581_serdes_phy_register(&pdev->dev); } =20 static enum en_hir get_hw_id(void __iomem *np_base) @@ -962,16 +1165,25 @@ static int en7523_clk_probe(struct platform_device *= pdev) struct device_node *node =3D pdev->dev.of_node; const struct en_clk_soc_data *soc_data; struct clk_hw_onecell_data *clk_data; + struct en_clk_priv *priv; int r; =20 soc_data =3D device_get_match_data(&pdev->dev); =20 + priv =3D devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + spin_lock_init(&priv->lock); + clk_data =3D devm_kzalloc(&pdev->dev, struct_size(clk_data, hws, soc_data->num_clocks), GFP_KERNEL); if (!clk_data) return -ENOMEM; =20 + platform_set_drvdata(pdev, priv); + clk_data->num =3D soc_data->num_clocks; r =3D soc_data->hw_init(pdev, clk_data); if (r) --=20 2.53.0 From nobody Sun May 24 20:33:26 2026 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D026F36A027 for ; Thu, 21 May 2026 15:37:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779377826; cv=none; b=bPuc8jIUSK+jH0Fne3wzpAWnItbSArkJxzHm0g4Zd5wzmzBQhFxspkUFqcIllhheprbk/kB5rxklUL6d6ASskFuMuZ6P5fvnCOLI15Y/B4xXlnDmnAa6Uz0ciqkqo0+QkXFr1LgOGQE1yFzVCESyiieSMynK94/xNv/EGQmwkt0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779377826; c=relaxed/simple; bh=m5DUnXaSNzM04LXhJuLXRbwAToGbpkmQqYhcor9mmeI=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IkUCUWBECZGqHT8Gt0Qdm2WIFC9QAYkbuip52gKUTMx6CS9uxWJOL+HKdPDTf3jncBrWQ+3WaSurX5IbLW9YpynZxsVYxayErFGazgyqtzmwQukW/Dh8ATrsvwhe9RMu9AnGpVuZywIxgVHpWXoubn5JC1uGAUfDVU9JTJUuOwQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=s6kliwG/; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="s6kliwG/" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-48d146705b4so69474775e9.3 for ; Thu, 21 May 2026 08:37:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779377823; x=1779982623; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=MIB28TKX46XSJ6UoBivfsKflmRaG92nOEG3Dee2rX0k=; b=s6kliwG/PVEIDukxj1rNUYcib9Ox+Z3tlBoH4W8FC00b1TCa+D43o0yArbS4SBjfOJ mNnIX9IgIJDn6UI1SMSaiUsv0TZjYBquZxq/WHXcK7oRhm1Z/jk2mRbTL4rbnEtiuJ2p adPjiRrik1tsgw0T7Rrd9VQN+k/pKGns+GTOi+mziAcYAq5OyLnYnvAwQHnVgEN33Erb w6ZFmvqRqWyLkTPzTZ927FP73l/R02DTLGJfXSFnFX3tQnLeRc39hs/oKUi6p32mEWJd GsYCcyHq0Zkkwhs7Z49oTVEJjAuc2o0NkbapELO3W9Lq6uDJKKJf7sOOB3Azfo5B42uP l1Jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779377823; x=1779982623; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=MIB28TKX46XSJ6UoBivfsKflmRaG92nOEG3Dee2rX0k=; b=CHiqfIwWiy4rgIMZG3AJE//xwPp6xj6WvkcyQWpaFiSPvjSFEKYmN88ndf/TBv7kwg zza8HzVFgiXK8aPiWKN9s66VDWikN1DvepCVvfISvz6TOObWOHYp7j1FtdS5HQQHfKjo TSuIJalMY+eDs15WvmlLfOpvwfymPU8S84kcK2NTPpze1pEh6jaWsF6vXcMzoXJ0lWsK NybYcKQiz5sGsNx9ULgssrujsV1iL+m3foOOQjBsN7bYGNEtZB/Nb7W+omeMZ3y5ob2w idrFGSOtCiLWvPZ2g9IfOzHzljm+CFpDSt+h7lhMmauNxPTkPabfa/+iCOn8mTxqZvHb 9BjQ== X-Forwarded-Encrypted: i=1; AFNElJ9VCUfKYdZ1eaYS/1Ca1NDvyS6Gh3fac2zv7BkUDk0dYwX3CEQYORjmYOaUUR0p1AUlUJFmBXYJ32KcS44=@vger.kernel.org X-Gm-Message-State: AOJu0YyySLdlkxJCV45J5CnfCTcJE2dzl7HCpB9Qf6WP8CDWpkYuXpSH J3Vzgww/h+vLawdA0lhgUlnG0UDe6aLCl/9fdbH3uCONd9t/jarx19Q0 X-Gm-Gg: Acq92OHY1bzT85Kjs6TUF6UqYLAcWCKQ4HI1bnsFfeMM69xTUcEH3s86Ww6o746AvcX HW2iDSMLomM0HmV320OGoEREdCWAUY2cvN1uXYyeAVJyBjNFNuLyyt7UmNcbCwSAyg3jZgb+Vni Sx29T4POg5uwClbsy+Nb1ilpvMpzgQry6HAFfefcOjZ0uMnvMawgMbYgoeHkNJ8V12fXEsIpYdV 9QJWBFuGcKRHdtEsFM1lEqwpDFD3vCNJ5oUP4EFaeGTyY6wmdrgZKfiBRPy7bU+weAVNKYjFlu+ zpIqMy4yW4o9lTB+IiwYsriotDYpAdMC11kKa5rYS8qTCTyPWK97sLl167uiqPBEC5bVAEoR8ZX Gj/efvZl9bUKkBRcb9Ltml0ZhEwpH6n13udr0wFR/oddQTQZ3RoptVePljmbGHi50iYnnZunpI1 TOrB5/n74SXkuDOm9PkyToMcmaFuBpRXwfcHBCQ/81sdv3bVzO55fiMzvRkj3qThU= X-Received: by 2002:a05:600c:4c24:b0:485:30d4:6b9e with SMTP id 5b1f17b1804b1-490360a373bmr29483185e9.21.1779377822804; Thu, 21 May 2026 08:37:02 -0700 (PDT) Received: from Ansuel-XPS24 (host-79-22-5-99.retail.telecomitalia.it. [79.22.5.99]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-49033d9edcbsm79159825e9.13.2026.05.21.08.37.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 08:37:01 -0700 (PDT) From: Christian Marangi To: Michael Turquette , Stephen Boyd , Brian Masney , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Christian Marangi , Vinod Koul , Neil Armstrong , Lorenzo Bianconi , Felix Fietkau , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org Subject: [PATCH v9 4/5] phy: move and rename Airoha PCIe PHY driver to dedicated directory Date: Thu, 21 May 2026 17:35:55 +0200 Message-ID: <20260521153645.7028-5-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260521153645.7028-1-ansuelsmth@gmail.com> References: <20260521153645.7028-1-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" To keep the generic PHY directory tidy, move the PCIe PHY driver for Airoha AN7581 SoC to a dedicated directory. Also rename the driver and add the relevant SoC name to the .c and .h file in preparation for support of PCIe and USB PHY driver for Airoha AN7583 SoC that use a completely different implementation and calibration for PHYs and will have their own dedicated drivers. The rename permits to better identify the specific usage of the driver in the future once the airoha PHY directory will have multiple driver for multiple SoC. The config is changed from PHY_AIROHA_PCIE to PHY_AIROHA_AN7581_PCIE. Signed-off-by: Christian Marangi Acked-by: Lorenzo Bianconi --- MAINTAINERS | 4 ++-- drivers/phy/Kconfig | 11 +---------- drivers/phy/Makefile | 4 ++-- drivers/phy/airoha/Kconfig | 13 +++++++++++++ drivers/phy/airoha/Makefile | 3 +++ .../phy-an7581-pcie-regs.h} | 2 +- .../{phy-airoha-pcie.c =3D> airoha/phy-an7581-pcie.c} | 6 +++--- 7 files changed, 25 insertions(+), 18 deletions(-) create mode 100644 drivers/phy/airoha/Kconfig create mode 100644 drivers/phy/airoha/Makefile rename drivers/phy/{phy-airoha-pcie-regs.h =3D> airoha/phy-an7581-pcie-reg= s.h} (99%) rename drivers/phy/{phy-airoha-pcie.c =3D> airoha/phy-an7581-pcie.c} (99%) diff --git a/MAINTAINERS b/MAINTAINERS index 932044785a39..7bea8c620da8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -759,8 +759,8 @@ M: Lorenzo Bianconi L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) S: Maintained F: Documentation/devicetree/bindings/phy/airoha,en7581-pcie-phy.yaml -F: drivers/phy/phy-airoha-pcie-regs.h -F: drivers/phy/phy-airoha-pcie.c +F: drivers/phy/airoha/phy-an7581-pcie-regs.h +F: drivers/phy/airoha/phy-an7581-pcie.c =20 AIROHA SPI SNFI DRIVER M: Lorenzo Bianconi diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index 227b9a4c612e..f9cd765a3ccc 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -46,16 +46,6 @@ config GENERIC_PHY_MIPI_DPHY Provides a number of helpers a core functions for MIPI D-PHY drivers to us. =20 -config PHY_AIROHA_PCIE - tristate "Airoha PCIe-PHY Driver" - depends on ARCH_AIROHA || COMPILE_TEST - depends on OF - select GENERIC_PHY - help - Say Y here to add support for Airoha PCIe PHY driver. - This driver create the basic PHY instance and provides initialize - callback for PCIe GEN3 port. - config PHY_CAN_TRANSCEIVER tristate "CAN transceiver PHY" select GENERIC_PHY @@ -133,6 +123,7 @@ config PHY_XGENE help This option enables support for APM X-Gene SoC multi-purpose PHY. =20 +source "drivers/phy/airoha/Kconfig" source "drivers/phy/allwinner/Kconfig" source "drivers/phy/amlogic/Kconfig" source "drivers/phy/apple/Kconfig" diff --git a/drivers/phy/Makefile b/drivers/phy/Makefile index f49d83f00a3d..84062279fa63 100644 --- a/drivers/phy/Makefile +++ b/drivers/phy/Makefile @@ -7,7 +7,6 @@ obj-$(CONFIG_PHY_COMMON_PROPS) +=3D phy-common-props.o obj-$(CONFIG_PHY_COMMON_PROPS_TEST) +=3D phy-common-props-test.o obj-$(CONFIG_GENERIC_PHY) +=3D phy-core.o obj-$(CONFIG_GENERIC_PHY_MIPI_DPHY) +=3D phy-core-mipi-dphy.o -obj-$(CONFIG_PHY_AIROHA_PCIE) +=3D phy-airoha-pcie.o obj-$(CONFIG_PHY_CAN_TRANSCEIVER) +=3D phy-can-transceiver.o obj-$(CONFIG_PHY_GOOGLE_USB) +=3D phy-google-usb.o obj-$(CONFIG_USB_LGM_PHY) +=3D phy-lgm-usb.o @@ -17,7 +16,8 @@ obj-$(CONFIG_PHY_PISTACHIO_USB) +=3D phy-pistachio-usb.o obj-$(CONFIG_PHY_SNPS_EUSB2) +=3D phy-snps-eusb2.o obj-$(CONFIG_PHY_XGENE) +=3D phy-xgene.o =20 -obj-$(CONFIG_GENERIC_PHY) +=3D allwinner/ \ +obj-$(CONFIG_GENERIC_PHY) +=3D airoha/ \ + allwinner/ \ amlogic/ \ apple/ \ broadcom/ \ diff --git a/drivers/phy/airoha/Kconfig b/drivers/phy/airoha/Kconfig new file mode 100644 index 000000000000..9a1b625a7701 --- /dev/null +++ b/drivers/phy/airoha/Kconfig @@ -0,0 +1,13 @@ +# SPDX-License-Identifier: GPL-2.0-only +# +# Phy drivers for Airoha devices +# +config PHY_AIROHA_AN7581_PCIE + tristate "Airoha AN7581 PCIe-PHY Driver" + depends on ARCH_AIROHA || COMPILE_TEST + depends on OF + select GENERIC_PHY + help + Say Y here to add support for Airoha AN7581 PCIe PHY driver. + This driver create the basic PHY instance and provides initialize + callback for PCIe GEN3 port. diff --git a/drivers/phy/airoha/Makefile b/drivers/phy/airoha/Makefile new file mode 100644 index 000000000000..912f3e11a061 --- /dev/null +++ b/drivers/phy/airoha/Makefile @@ -0,0 +1,3 @@ +# SPDX-License-Identifier: GPL-2.0 + +obj-$(CONFIG_PHY_AIROHA_AN7581_PCIE) +=3D phy-an7581-pcie.o diff --git a/drivers/phy/phy-airoha-pcie-regs.h b/drivers/phy/airoha/phy-an= 7581-pcie-regs.h similarity index 99% rename from drivers/phy/phy-airoha-pcie-regs.h rename to drivers/phy/airoha/phy-an7581-pcie-regs.h index 58572c793722..b938a7b468fe 100644 --- a/drivers/phy/phy-airoha-pcie-regs.h +++ b/drivers/phy/airoha/phy-an7581-pcie-regs.h @@ -1,4 +1,4 @@ -/* SPDX-License-Identifier: GPL-2.0-only */ +// SPDX-License-Identifier: GPL-2.0-only /* * Copyright (c) 2024 AIROHA Inc * Author: Lorenzo Bianconi diff --git a/drivers/phy/phy-airoha-pcie.c b/drivers/phy/airoha/phy-an7581-= pcie.c similarity index 99% rename from drivers/phy/phy-airoha-pcie.c rename to drivers/phy/airoha/phy-an7581-pcie.c index 56e9ade8a9fd..81ddf0e7638b 100644 --- a/drivers/phy/phy-airoha-pcie.c +++ b/drivers/phy/airoha/phy-an7581-pcie.c @@ -13,7 +13,7 @@ #include #include =20 -#include "phy-airoha-pcie-regs.h" +#include "phy-an7581-pcie-regs.h" =20 #define LEQ_LEN_CTRL_MAX_VAL 7 #define FREQ_LOCK_MAX_ATTEMPT 10 @@ -1279,12 +1279,12 @@ MODULE_DEVICE_TABLE(of, airoha_pcie_phy_of_match); static struct platform_driver airoha_pcie_phy_driver =3D { .probe =3D airoha_pcie_phy_probe, .driver =3D { - .name =3D "airoha-pcie-phy", + .name =3D "airoha-an7581-pcie-phy", .of_match_table =3D airoha_pcie_phy_of_match, }, }; module_platform_driver(airoha_pcie_phy_driver); =20 -MODULE_DESCRIPTION("Airoha PCIe PHY driver"); +MODULE_DESCRIPTION("Airoha AN7581 PCIe PHY driver"); MODULE_AUTHOR("Lorenzo Bianconi "); MODULE_LICENSE("GPL"); --=20 2.53.0 From nobody Sun May 24 20:33:26 2026 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E14436CE1C for ; Thu, 21 May 2026 15:37:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779377829; cv=none; b=nOZRyQ43d3Evk6cPwlh1s970cIdhF1ZgSuuUV4+GPeMiOqhgcRbXDeiT/103YBgjtBd+u+ybFw8Ix+MmLCbekC3gq1YEhrHynx1RpPhwsP806CQE95cV6x4VHsNp0F4YK9pwGWwUFxYfn4X6vHFKHKH8FpsPd0g4HWLA5rihVO8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779377829; c=relaxed/simple; bh=Vxvdqw1q6DAskCji6+sor031lBmeXgSmiFlcXFK30Qs=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=m51D99EazX3Z4n3sUYGckvK+hJQU2ucfLjm/6LO/ZBbqWnJXTeDliLdtBTneAZePWnR7UQFViba2RfnXd7gmBt5lcTVdhck/4KELbSiY+xWAbmPukiDMMbDV6HSLTYmeQK4DjIrqOz3KdIB28S57eKOFlKDltrvncZIXfGcRmNg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NzOaeREe; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NzOaeREe" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-488ab2db91aso65911765e9.3 for ; Thu, 21 May 2026 08:37:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779377825; x=1779982625; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:from:to:cc:subject:date:message-id :reply-to; bh=u4D/Toe9OrktYTT5kMgr5gT7L+rK4sqVZxpqU+HmEkk=; b=NzOaeREe7rQ8mPj2EE3SWoJP5h8a6zN5FVsSRT7YKBoMeBCEBO2Bn2VFoPBB6lM5vH ucLtDlWz5R2NPF2MwIfv+rCX/uEv0Ljdoepnjl/i0JUvAVh/wf4SkdOsH1YpfXH5MH93 dptQJrLK2/oWDj8Gv/7MFgrpGDV2LdEo0sUINj1rsCJGJ6aE3iHo8OsIerIg5fvYmdqJ /qm7LLsGjTayklmd0CdCpPUgulBAepTWY01KU2AcpyvzV1SFNb32Hm7m/7LRPZT1cMpj TERLdWuS2DbjjMRI8XDXtRXycJA5v6dCQHIRzSmiFva4fvmcbWR1oflrbU4z3dh/VrH2 4uwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779377825; x=1779982625; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:from:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=u4D/Toe9OrktYTT5kMgr5gT7L+rK4sqVZxpqU+HmEkk=; b=g3kSwSk70QXf5n2fHkQECiwAtsL1kQiDDFuwVtqPi2GK0gI3M9wwkFKDMaQDO6OVDz EA2Zkg4xbo2uKp/Go71KRMKJpCLjKX0VbH0TgDMg2lThVGFGAfaCemFB1zwBsgo/akff uYP9W4kSbxP78RizIM42NthVt0IjP7ORAsB3F5ZyTiWt9ko5EEHTto19pmCmRWxkQKwc W23ORdXp3YER0RPkA4NWeD1hAeI3tow77rbal2elKz/4cqDMPtddMls5GQJ/VJeVbCvJ D4KQVaHe6PgPxwkyEO6Avt7HuBlSfGvG0x7HFBFJ/lTQH83/dAWhtaZFaFW4yrQdWKkv R1gg== X-Forwarded-Encrypted: i=1; AFNElJ9W2VJOOuqrY8pwfZUJ1Qzo+gVObDqnwcv3zQXrrs1uOPbWOhSAiemxDcwTppdI/iysVX+FdSWr69yu4sA=@vger.kernel.org X-Gm-Message-State: AOJu0YyhXbZtMH/dHl5RndyI+5Hxpp0YT+QlHGlE4BpsIcCgRIgyEVMX sCAANL17aE3GUfd7Qxre1oYr4TGXGvVljBeZZnzS+17bEiM671GzZMQn X-Gm-Gg: Acq92OHrx2Hn0Ipo5pcN8rEqqECnik+ewbuVwgJE9hseoq7iSwy+7sQD/UU/8ZzIhYs iVotoCgOfmHbAwMJsDkcXkIS46uhEi3t7+TNJolZXsH3QP1H6JsMrGWaTPF6gluaGw5zwQ555Ud ttO8BhstmwtWqXpI2fNbOrkFkqjYl3E6pLdDYb509LcOmZLRunQDuoELEftyMsNHUGjV6l5NaPd Aqgo3Gn19z3Ec3WHht0BH9w6sD8I6hB0f5ezVDkzVXt6nM/6gBU5noDKOT2ai1B34tIgrMDbuCr nq3WTBP8fexNSkpvU+YfKteu3qAVPJo51Y5i06VGqXvj3njQjPAmfWl6ScWdVWW17XfUO+NN65e j0pufkCiUiPxX4wDgso6ByjjU9Jvjt60c3brtiUtjTZY+FtDNS4d2tqR2mvPAsjX3/PWTOqKAph kgfvGhIGNttDtw8eS7xuRPKNJcmq1cQzlY9KZGddvlU24P7asE7z3qwlBKqvjgV90= X-Received: by 2002:a05:600c:8b34:b0:490:3d27:94f4 with SMTP id 5b1f17b1804b1-4903d2797c3mr28992525e9.7.1779377825109; Thu, 21 May 2026 08:37:05 -0700 (PDT) Received: from Ansuel-XPS24 (host-79-22-5-99.retail.telecomitalia.it. [79.22.5.99]) by smtp.googlemail.com with ESMTPSA id 5b1f17b1804b1-49033d9edcbsm79159825e9.13.2026.05.21.08.37.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 08:37:04 -0700 (PDT) From: Christian Marangi To: Michael Turquette , Stephen Boyd , Brian Masney , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Christian Marangi , Vinod Koul , Neil Armstrong , Lorenzo Bianconi , Felix Fietkau , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-phy@lists.infradead.org Subject: [PATCH v9 5/5] phy: airoha: Add support for Airoha AN7581 USB PHY Date: Thu, 21 May 2026 17:35:56 +0200 Message-ID: <20260521153645.7028-6-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260521153645.7028-1-ansuelsmth@gmail.com> References: <20260521153645.7028-1-ansuelsmth@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add support for Airoha AN7581 USB PHY driver. AN7581 supports up to 2 USB port with USB 2.0 mode always supported and USB 3.0 mode available only if the Serdes port is correctly configured for USB 3.0. If the USB 3.0 mode is not configured, the modes needs to be also disabled in the xHCI node or the driver will report unsable clock and fail probe. For USB 2.0 Slew Rate calibration, airoha,usb2-monitor-clk-sel is mandatory and is used to select the monitor clock for calibration. Normally it's 1 for USB port 1 and 2 for USB port 2. Signed-off-by: Christian Marangi --- MAINTAINERS | 1 + drivers/phy/airoha/Kconfig | 11 + drivers/phy/airoha/Makefile | 1 + drivers/phy/airoha/phy-an7581-usb.c | 559 ++++++++++++++++++++++++++++ 4 files changed, 572 insertions(+) create mode 100644 drivers/phy/airoha/phy-an7581-usb.c diff --git a/MAINTAINERS b/MAINTAINERS index 7bea8c620da8..2f05faa44503 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -776,6 +776,7 @@ M: Christian Marangi L: linux-arm-kernel@lists.infradead.org (moderated for non-subscribers) S: Maintained F: Documentation/devicetree/bindings/phy/airoha,an7581-usb-phy.yaml +F: drivers/phy/airoha/phy-an7581-usb.c =20 AIRSPY MEDIA DRIVER L: linux-media@vger.kernel.org diff --git a/drivers/phy/airoha/Kconfig b/drivers/phy/airoha/Kconfig index 9a1b625a7701..634448ee39b5 100644 --- a/drivers/phy/airoha/Kconfig +++ b/drivers/phy/airoha/Kconfig @@ -11,3 +11,14 @@ config PHY_AIROHA_AN7581_PCIE Say Y here to add support for Airoha AN7581 PCIe PHY driver. This driver create the basic PHY instance and provides initialize callback for PCIe GEN3 port. + +config PHY_AIROHA_AN7581_USB + tristate "Airoha AN7581 USB PHY Driver" + depends on ARCH_AIROHA || COMPILE_TEST + depends on OF + select GENERIC_PHY + select REGMAP_MMIO + help + Say 'Y' here to add support for Airoha AN7581 USB PHY driver. + This driver create the basic PHY instance and provides initialize + callback for USB port. diff --git a/drivers/phy/airoha/Makefile b/drivers/phy/airoha/Makefile index 912f3e11a061..944bf842deba 100644 --- a/drivers/phy/airoha/Makefile +++ b/drivers/phy/airoha/Makefile @@ -1,3 +1,4 @@ # SPDX-License-Identifier: GPL-2.0 =20 obj-$(CONFIG_PHY_AIROHA_AN7581_PCIE) +=3D phy-an7581-pcie.o +obj-$(CONFIG_PHY_AIROHA_AN7581_USB) +=3D phy-an7581-usb.o diff --git a/drivers/phy/airoha/phy-an7581-usb.c b/drivers/phy/airoha/phy-a= n7581-usb.c new file mode 100644 index 000000000000..92c5e5c2fbf3 --- /dev/null +++ b/drivers/phy/airoha/phy-an7581-usb.c @@ -0,0 +1,559 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * Author: Christian Marangi + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +/* U2PHY */ +#define AIROHA_USB_PHY_FMCR0 0x100 +#define AIROHA_USB_PHY_MONCLK_SEL GENMASK(27, 26) +#define AIROHA_USB_PHY_MONCLK_SEL0 FIELD_PREP_CONST(AIROHA_USB_PHY_MONC= LK_SEL, 0x0) +#define AIROHA_USB_PHY_MONCLK_SEL1 FIELD_PREP_CONST(AIROHA_USB_PHY_MONC= LK_SEL, 0x1) +#define AIROHA_USB_PHY_MONCLK_SEL2 FIELD_PREP_CONST(AIROHA_USB_PHY_MONC= LK_SEL, 0x2) +#define AIROHA_USB_PHY_MONCLK_SEL3 FIELD_PREP_CONST(AIROHA_USB_PHY_MONC= LK_SEL, 0x3) +#define AIROHA_USB_PHY_FREQDET_EN BIT(24) +#define AIROHA_USB_PHY_CYCLECNT GENMASK(23, 0) +#define AIROHA_USB_PHY_FMMONR0 0x10c +#define AIROHA_USB_PHY_USB_FM_OUT GENMASK(31, 0) +#define AIROHA_USB_PHY_FMMONR1 0x110 +#define AIROHA_USB_PHY_FRCK_EN BIT(8) + +#define AIROHA_USB_PHY_USBPHYACR4 0x310 +#define AIROHA_USB_PHY_USB20_FS_CR GENMASK(10, 8) +#define AIROHA_USB_PHY_USB20_FS_CR_MAX FIELD_PREP_CONST(AIROHA_USB_PHY_U= SB20_FS_CR, 0x0) +#define AIROHA_USB_PHY_USB20_FS_CR_NORMAL FIELD_PREP_CONST(AIROHA_USB_PH= Y_USB20_FS_CR, 0x2) +#define AIROHA_USB_PHY_USB20_FS_CR_SMALLER FIELD_PREP_CONST(AIROHA_USB_P= HY_USB20_FS_CR, 0x4) +#define AIROHA_USB_PHY_USB20_FS_CR_MIN FIELD_PREP_CONST(AIROHA_USB_PHY_U= SB20_FS_CR, 0x6) +#define AIROHA_USB_PHY_USB20_FS_SR GENMASK(2, 0) +#define AIROHA_USB_PHY_USB20_FS_SR_MAX FIELD_PREP_CONST(AIROHA_USB_PHY_U= SB20_FS_SR, 0x0) +#define AIROHA_USB_PHY_USB20_FS_SR_NORMAL FIELD_PREP_CONST(AIROHA_USB_PH= Y_USB20_FS_SR, 0x2) +#define AIROHA_USB_PHY_USB20_FS_SR_SMALLER FIELD_PREP_CONST(AIROHA_USB_P= HY_USB20_FS_SR, 0x4) +#define AIROHA_USB_PHY_USB20_FS_SR_MIN FIELD_PREP_CONST(AIROHA_USB_PHY_U= SB20_FS_SR, 0x6) +#define AIROHA_USB_PHY_USBPHYACR5 0x314 +#define AIROHA_USB_PHY_USB20_HSTX_SRCAL_EN BIT(15) +#define AIROHA_USB_PHY_USB20_HSTX_SRCTRL GENMASK(14, 12) +#define AIROHA_USB_PHY_USBPHYACR6 0x318 +#define AIROHA_USB_PHY_USB20_BC11_SW_EN BIT(23) +#define AIROHA_USB_PHY_USB20_DISCTH GENMASK(7, 4) +#define AIROHA_USB_PHY_USB20_DISCTH_400 FIELD_PREP_CONST(AIROHA_USB_PHY_= USB20_DISCTH, 0x0) +#define AIROHA_USB_PHY_USB20_DISCTH_420 FIELD_PREP_CONST(AIROHA_USB_PHY_= USB20_DISCTH, 0x1) +#define AIROHA_USB_PHY_USB20_DISCTH_440 FIELD_PREP_CONST(AIROHA_USB_PHY_= USB20_DISCTH, 0x2) +#define AIROHA_USB_PHY_USB20_DISCTH_460 FIELD_PREP_CONST(AIROHA_USB_PHY_= USB20_DISCTH, 0x3) +#define AIROHA_USB_PHY_USB20_DISCTH_480 FIELD_PREP_CONST(AIROHA_USB_PHY_= USB20_DISCTH, 0x4) +#define AIROHA_USB_PHY_USB20_DISCTH_500 FIELD_PREP_CONST(AIROHA_USB_PHY_= USB20_DISCTH, 0x5) +#define AIROHA_USB_PHY_USB20_DISCTH_520 FIELD_PREP_CONST(AIROHA_USB_PHY_= USB20_DISCTH, 0x6) +#define AIROHA_USB_PHY_USB20_DISCTH_540 FIELD_PREP_CONST(AIROHA_USB_PHY_= USB20_DISCTH, 0x7) +#define AIROHA_USB_PHY_USB20_DISCTH_560 FIELD_PREP_CONST(AIROHA_USB_PHY_= USB20_DISCTH, 0x8) +#define AIROHA_USB_PHY_USB20_DISCTH_580 FIELD_PREP_CONST(AIROHA_USB_PHY_= USB20_DISCTH, 0x9) +#define AIROHA_USB_PHY_USB20_DISCTH_600 FIELD_PREP_CONST(AIROHA_USB_PHY_= USB20_DISCTH, 0xa) +#define AIROHA_USB_PHY_USB20_DISCTH_620 FIELD_PREP_CONST(AIROHA_USB_PHY_= USB20_DISCTH, 0xb) +#define AIROHA_USB_PHY_USB20_DISCTH_640 FIELD_PREP_CONST(AIROHA_USB_PHY_= USB20_DISCTH, 0xc) +#define AIROHA_USB_PHY_USB20_DISCTH_660 FIELD_PREP_CONST(AIROHA_USB_PHY_= USB20_DISCTH, 0xd) +#define AIROHA_USB_PHY_USB20_DISCTH_680 FIELD_PREP_CONST(AIROHA_USB_PHY_= USB20_DISCTH, 0xe) +#define AIROHA_USB_PHY_USB20_DISCTH_700 FIELD_PREP_CONST(AIROHA_USB_PHY_= USB20_DISCTH, 0xf) +#define AIROHA_USB_PHY_USB20_SQTH GENMASK(3, 0) +#define AIROHA_USB_PHY_USB20_SQTH_85 FIELD_PREP_CONST(AIROHA_USB_PHY_US= B20_SQTH, 0x0) +#define AIROHA_USB_PHY_USB20_SQTH_90 FIELD_PREP_CONST(AIROHA_USB_PHY_US= B20_SQTH, 0x1) +#define AIROHA_USB_PHY_USB20_SQTH_95 FIELD_PREP_CONST(AIROHA_USB_PHY_US= B20_SQTH, 0x2) +#define AIROHA_USB_PHY_USB20_SQTH_100 FIELD_PREP_CONST(AIROHA_USB_PHY_U= SB20_SQTH, 0x3) +#define AIROHA_USB_PHY_USB20_SQTH_105 FIELD_PREP_CONST(AIROHA_USB_PHY_U= SB20_SQTH, 0x4) +#define AIROHA_USB_PHY_USB20_SQTH_110 FIELD_PREP_CONST(AIROHA_USB_PHY_U= SB20_SQTH, 0x5) +#define AIROHA_USB_PHY_USB20_SQTH_115 FIELD_PREP_CONST(AIROHA_USB_PHY_U= SB20_SQTH, 0x6) +#define AIROHA_USB_PHY_USB20_SQTH_120 FIELD_PREP_CONST(AIROHA_USB_PHY_U= SB20_SQTH, 0x7) +#define AIROHA_USB_PHY_USB20_SQTH_125 FIELD_PREP_CONST(AIROHA_USB_PHY_U= SB20_SQTH, 0x8) +#define AIROHA_USB_PHY_USB20_SQTH_130 FIELD_PREP_CONST(AIROHA_USB_PHY_U= SB20_SQTH, 0x9) +#define AIROHA_USB_PHY_USB20_SQTH_135 FIELD_PREP_CONST(AIROHA_USB_PHY_U= SB20_SQTH, 0xa) +#define AIROHA_USB_PHY_USB20_SQTH_140 FIELD_PREP_CONST(AIROHA_USB_PHY_U= SB20_SQTH, 0xb) +#define AIROHA_USB_PHY_USB20_SQTH_145 FIELD_PREP_CONST(AIROHA_USB_PHY_U= SB20_SQTH, 0xc) +#define AIROHA_USB_PHY_USB20_SQTH_150 FIELD_PREP_CONST(AIROHA_USB_PHY_U= SB20_SQTH, 0xd) +#define AIROHA_USB_PHY_USB20_SQTH_155 FIELD_PREP_CONST(AIROHA_USB_PHY_U= SB20_SQTH, 0xe) +#define AIROHA_USB_PHY_USB20_SQTH_160 FIELD_PREP_CONST(AIROHA_USB_PHY_U= SB20_SQTH, 0xf) + +#define AIROHA_USB_PHY_U2PHYDTM1 0x36c +#define AIROHA_USB_PHY_FORCE_IDDIG BIT(9) +#define AIROHA_USB_PHY_IDDIG BIT(1) + +#define AIROHA_USB_PHY_GPIO_CTLD 0x80c +#define AIROHA_USB_PHY_C60802_GPIO_CTLD GENMASK(31, 0) +#define AIROHA_USB_PHY_SSUSB_IP_SW_RST BIT(31) +#define AIROHA_USB_PHY_MCU_BUS_CK_GATE_EN BIT(30) +#define AIROHA_USB_PHY_FORCE_SSUSB_IP_SW_RST BIT(29) +#define AIROHA_USB_PHY_SSUSB_SW_RST BIT(28) + +#define AIROHA_USB_PHY_U3_PHYA_REG0 0xb00 +#define AIROHA_USB_PHY_SSUSB_BG_DIV GENMASK(29, 28) +#define AIROHA_USB_PHY_SSUSB_BG_DIV_2 FIELD_PREP_CONST(AIROHA_USB_PHY_S= SUSB_BG_DIV, 0x0) +#define AIROHA_USB_PHY_SSUSB_BG_DIV_4 FIELD_PREP_CONST(AIROHA_USB_PHY_S= SUSB_BG_DIV, 0x1) +#define AIROHA_USB_PHY_SSUSB_BG_DIV_8 FIELD_PREP_CONST(AIROHA_USB_PHY_S= SUSB_BG_DIV, 0x2) +#define AIROHA_USB_PHY_SSUSB_BG_DIV_16 FIELD_PREP_CONST(AIROHA_USB_PHY_S= SUSB_BG_DIV, 0x3) +#define AIROHA_USB_PHY_U3_PHYA_REG1 0xb04 +#define AIROHA_USB_PHY_SSUSB_XTAL_TOP_RESERVE GENMASK(25, 10) +#define AIROHA_USB_PHY_U3_PHYA_REG6 0xb18 +#define AIROHA_USB_PHY_SSUSB_CDR_RESERVE GENMASK(31, 24) +#define AIROHA_USB_PHY_U3_PHYA_REG8 0xb20 +#define AIROHA_USB_PHY_SSUSB_CDR_RST_DLY GENMASK(7, 6) +#define AIROHA_USB_PHY_SSUSB_CDR_RST_DLY_32 FIELD_PREP_CONST(AIROHA_USB_= PHY_SSUSB_CDR_RST_DLY, 0x0) +#define AIROHA_USB_PHY_SSUSB_CDR_RST_DLY_64 FIELD_PREP_CONST(AIROHA_USB_= PHY_SSUSB_CDR_RST_DLY, 0x1) +#define AIROHA_USB_PHY_SSUSB_CDR_RST_DLY_128 FIELD_PREP_CONST(AIROHA_USB= _PHY_SSUSB_CDR_RST_DLY, 0x2) +#define AIROHA_USB_PHY_SSUSB_CDR_RST_DLY_216 FIELD_PREP_CONST(AIROHA_USB= _PHY_SSUSB_CDR_RST_DLY, 0x3) + +#define AIROHA_USB_PHY_U3_PHYA_DA_REG19 0xc38 +#define AIROHA_USB_PHY_SSUSB_PLL_SSC_DELTA1_U3 GENMASK(15, 0) + +#define AIROHA_USB_PHY_U2_FM_DET_CYCLE_CNT 1024 +#define AIROHA_USB_PHY_REF_CK 20 +#define AIROHA_USB_PHY_U2_SR_COEF 28 +#define AIROHA_USB_PHY_U2_SR_COEF_DIVISOR 1000 + +#define AIROHA_USB_PHY_DEFAULT_SR_CALIBRATION 0x5 +#define AIROHA_USB_PHY_FREQDET_SLEEP 1000 /* 1ms */ +#define AIROHA_USB_PHY_FREQDET_TIMEOUT (AIROHA_USB_PHY_FREQDET_SLEEP * 10) + +struct an7581_usb_phy_instance { + struct phy *phy; + u32 type; +}; + +enum an7581_usb_phy_instance_type { + AIROHA_PHY_USB2, + AIROHA_PHY_USB3, + + AIROHA_PHY_USB_MAX, +}; + +struct an7581_usb_phy_priv { + struct device *dev; + struct regmap *regmap; + + unsigned int monclk_sel; + + struct phy *serdes_phy; + struct an7581_usb_phy_instance *phys[AIROHA_PHY_USB_MAX]; +}; + +static void an7581_usb_phy_u2_slew_rate_calibration(struct an7581_usb_phy_= priv *priv) +{ + u32 fm_out =3D 0; + u32 srctrl; + + /* Enable HS TX SR calibration */ + regmap_set_bits(priv->regmap, AIROHA_USB_PHY_USBPHYACR5, + AIROHA_USB_PHY_USB20_HSTX_SRCAL_EN); + + usleep_range(1000, 1500); + + /* Enable Free run clock */ + regmap_set_bits(priv->regmap, AIROHA_USB_PHY_FMMONR1, + AIROHA_USB_PHY_FRCK_EN); + + /* Select Monitor Clock */ + regmap_update_bits(priv->regmap, AIROHA_USB_PHY_FMCR0, + AIROHA_USB_PHY_MONCLK_SEL, + FIELD_PREP(AIROHA_USB_PHY_MONCLK_SEL, + priv->monclk_sel)); + + /* Set cyclecnt */ + regmap_update_bits(priv->regmap, AIROHA_USB_PHY_FMCR0, + AIROHA_USB_PHY_CYCLECNT, + FIELD_PREP(AIROHA_USB_PHY_CYCLECNT, + AIROHA_USB_PHY_U2_FM_DET_CYCLE_CNT)); + + /* Enable Frequency meter */ + regmap_set_bits(priv->regmap, AIROHA_USB_PHY_FMCR0, + AIROHA_USB_PHY_FREQDET_EN); + + /* Timeout can happen and we will apply workaround at the end */ + regmap_read_poll_timeout(priv->regmap, AIROHA_USB_PHY_FMMONR0, fm_out, + fm_out, AIROHA_USB_PHY_FREQDET_SLEEP, + AIROHA_USB_PHY_FREQDET_TIMEOUT); + + /* Disable Frequency meter */ + regmap_clear_bits(priv->regmap, AIROHA_USB_PHY_FMCR0, + AIROHA_USB_PHY_FREQDET_EN); + + /* Disable Free run clock */ + regmap_clear_bits(priv->regmap, AIROHA_USB_PHY_FMMONR1, + AIROHA_USB_PHY_FRCK_EN); + + /* Disable HS TX SR calibration */ + regmap_clear_bits(priv->regmap, AIROHA_USB_PHY_USBPHYACR5, + AIROHA_USB_PHY_USB20_HSTX_SRCAL_EN); + + usleep_range(1000, 1500); + + /* Frequency was not detected, use default SR calibration value */ + if (!fm_out) { + srctrl =3D AIROHA_USB_PHY_DEFAULT_SR_CALIBRATION; + dev_err(priv->dev, "Frequency not detected, using default SR calibration= .\n"); + } else { + /* (1024 / FM_OUT) * REF_CK * U2_SR_COEF (round to the nearest digits) */ + srctrl =3D AIROHA_USB_PHY_REF_CK * AIROHA_USB_PHY_U2_SR_COEF; + srctrl =3D (srctrl * AIROHA_USB_PHY_U2_FM_DET_CYCLE_CNT) / fm_out; + srctrl =3D DIV_ROUND_CLOSEST(srctrl, AIROHA_USB_PHY_U2_SR_COEF_DIVISOR); + dev_dbg(priv->dev, "SR calibration applied: %x\n", srctrl); + } + + regmap_update_bits(priv->regmap, AIROHA_USB_PHY_USBPHYACR5, + AIROHA_USB_PHY_USB20_HSTX_SRCTRL, + FIELD_PREP(AIROHA_USB_PHY_USB20_HSTX_SRCTRL, srctrl)); +} + +static void an7581_usb_phy_u2_init(struct an7581_usb_phy_priv *priv) +{ + regmap_update_bits(priv->regmap, AIROHA_USB_PHY_USBPHYACR4, + AIROHA_USB_PHY_USB20_FS_CR, + AIROHA_USB_PHY_USB20_FS_CR_MIN); + + regmap_update_bits(priv->regmap, AIROHA_USB_PHY_USBPHYACR4, + AIROHA_USB_PHY_USB20_FS_SR, + AIROHA_USB_PHY_USB20_FS_SR_NORMAL); + + /* FIXME: evaluate if needed */ + regmap_update_bits(priv->regmap, AIROHA_USB_PHY_USBPHYACR6, + AIROHA_USB_PHY_USB20_SQTH, + AIROHA_USB_PHY_USB20_SQTH_130); + + regmap_update_bits(priv->regmap, AIROHA_USB_PHY_USBPHYACR6, + AIROHA_USB_PHY_USB20_DISCTH, + AIROHA_USB_PHY_USB20_DISCTH_600); + + /* Enable the USB port and then disable after calibration */ + regmap_clear_bits(priv->regmap, AIROHA_USB_PHY_USBPHYACR6, + AIROHA_USB_PHY_USB20_BC11_SW_EN); + + an7581_usb_phy_u2_slew_rate_calibration(priv); + + regmap_set_bits(priv->regmap, AIROHA_USB_PHY_USBPHYACR6, + AIROHA_USB_PHY_USB20_BC11_SW_EN); + + usleep_range(1000, 1500); +} + +/* + * USB 3.0 mode can only work if USB serdes is correctly set. + * This is validated in xLate function. + */ +static void an7581_usb_phy_u3_init(struct an7581_usb_phy_priv *priv) +{ + regmap_update_bits(priv->regmap, AIROHA_USB_PHY_U3_PHYA_REG8, + AIROHA_USB_PHY_SSUSB_CDR_RST_DLY, + AIROHA_USB_PHY_SSUSB_CDR_RST_DLY_32); + + regmap_update_bits(priv->regmap, AIROHA_USB_PHY_U3_PHYA_REG6, + AIROHA_USB_PHY_SSUSB_CDR_RESERVE, + FIELD_PREP(AIROHA_USB_PHY_SSUSB_CDR_RESERVE, 0xe)); + + regmap_update_bits(priv->regmap, AIROHA_USB_PHY_U3_PHYA_REG0, + AIROHA_USB_PHY_SSUSB_BG_DIV, + AIROHA_USB_PHY_SSUSB_BG_DIV_4); + + regmap_set_bits(priv->regmap, AIROHA_USB_PHY_U3_PHYA_REG1, + FIELD_PREP(AIROHA_USB_PHY_SSUSB_XTAL_TOP_RESERVE, 0x600)); + + regmap_update_bits(priv->regmap, AIROHA_USB_PHY_U3_PHYA_DA_REG19, + AIROHA_USB_PHY_SSUSB_PLL_SSC_DELTA1_U3, + FIELD_PREP(AIROHA_USB_PHY_SSUSB_PLL_SSC_DELTA1_U3, 0x43)); +} + +static int an7581_usb_phy_init(struct phy *phy) +{ + struct an7581_usb_phy_instance *instance =3D phy_get_drvdata(phy); + struct an7581_usb_phy_priv *priv =3D dev_get_drvdata(phy->dev.parent); + int ret; + + switch (instance->type) { + case PHY_TYPE_USB2: + an7581_usb_phy_u2_init(priv); + break; + case PHY_TYPE_USB3: + ret =3D phy_set_mode(priv->serdes_phy, PHY_MODE_USB_DEVICE_SS); + if (ret) + return ret; + + an7581_usb_phy_u3_init(priv); + break; + default: + return -EINVAL; + } + + return 0; +} + +static int an7581_usb_phy_u2_power_on(struct an7581_usb_phy_priv *priv) +{ + regmap_clear_bits(priv->regmap, AIROHA_USB_PHY_USBPHYACR6, + AIROHA_USB_PHY_USB20_BC11_SW_EN); + + usleep_range(1000, 1500); + + return 0; +} + +static int an7581_usb_phy_u3_power_on(struct an7581_usb_phy_priv *priv) +{ + regmap_clear_bits(priv->regmap, AIROHA_USB_PHY_GPIO_CTLD, + AIROHA_USB_PHY_SSUSB_IP_SW_RST | + AIROHA_USB_PHY_MCU_BUS_CK_GATE_EN | + AIROHA_USB_PHY_FORCE_SSUSB_IP_SW_RST | + AIROHA_USB_PHY_SSUSB_SW_RST); + + usleep_range(1000, 1500); + + return 0; +} + +static int an7581_usb_phy_power_on(struct phy *phy) +{ + struct an7581_usb_phy_instance *instance =3D phy_get_drvdata(phy); + struct an7581_usb_phy_priv *priv =3D dev_get_drvdata(phy->dev.parent); + + switch (instance->type) { + case PHY_TYPE_USB2: + an7581_usb_phy_u2_power_on(priv); + break; + case PHY_TYPE_USB3: + an7581_usb_phy_u3_power_on(priv); + break; + default: + return -EINVAL; + } + + return 0; +} + +static int an7581_usb_phy_u2_power_off(struct an7581_usb_phy_priv *priv) +{ + regmap_set_bits(priv->regmap, AIROHA_USB_PHY_USBPHYACR6, + AIROHA_USB_PHY_USB20_BC11_SW_EN); + + usleep_range(1000, 1500); + + return 0; +} + +static int an7581_usb_phy_u3_power_off(struct an7581_usb_phy_priv *priv) +{ + regmap_set_bits(priv->regmap, AIROHA_USB_PHY_GPIO_CTLD, + AIROHA_USB_PHY_SSUSB_IP_SW_RST | + AIROHA_USB_PHY_FORCE_SSUSB_IP_SW_RST); + + usleep_range(1000, 1500); + + return 0; +} + +static int an7581_usb_phy_power_off(struct phy *phy) +{ + struct an7581_usb_phy_instance *instance =3D phy_get_drvdata(phy); + struct an7581_usb_phy_priv *priv =3D dev_get_drvdata(phy->dev.parent); + + switch (instance->type) { + case PHY_TYPE_USB2: + an7581_usb_phy_u2_power_off(priv); + break; + case PHY_TYPE_USB3: + an7581_usb_phy_u3_power_off(priv); + break; + default: + return -EINVAL; + } + + return 0; +} + +static int an7581_usb_phy_u2_set_mode(struct an7581_usb_phy_priv *priv, + enum phy_mode mode) +{ + u32 val; + + /* + * For Device and Host mode, enable force IDDIG. + * For Device set IDDIG, for Host clear IDDIG. + * For OTG disable force and clear IDDIG bit while at it. + */ + switch (mode) { + case PHY_MODE_USB_DEVICE: + val =3D AIROHA_USB_PHY_FORCE_IDDIG | + AIROHA_USB_PHY_IDDIG; + break; + case PHY_MODE_USB_HOST: + val =3D AIROHA_USB_PHY_FORCE_IDDIG; + break; + case PHY_MODE_USB_OTG: + val =3D 0; + break; + default: + return 0; + } + + regmap_update_bits(priv->regmap, AIROHA_USB_PHY_U2PHYDTM1, + AIROHA_USB_PHY_FORCE_IDDIG | + AIROHA_USB_PHY_IDDIG, val); + + return 0; +} + +static int an7581_usb_phy_set_mode(struct phy *phy, enum phy_mode mode, in= t submode) +{ + struct an7581_usb_phy_instance *instance =3D phy_get_drvdata(phy); + struct an7581_usb_phy_priv *priv =3D dev_get_drvdata(phy->dev.parent); + + switch (instance->type) { + case PHY_TYPE_USB2: + return an7581_usb_phy_u2_set_mode(priv, mode); + default: + return 0; + } +} + +static struct phy *an7581_usb_phy_xlate(struct device *dev, + const struct of_phandle_args *args) +{ + struct an7581_usb_phy_priv *priv =3D dev_get_drvdata(dev); + struct an7581_usb_phy_instance *instance =3D NULL; + unsigned int index, phy_type; + + if (args->args_count !=3D 1) { + dev_err(dev, "invalid number of cells in 'phy' property\n"); + return ERR_PTR(-EINVAL); + } + + phy_type =3D args->args[0]; + if (!(phy_type =3D=3D PHY_TYPE_USB2 || phy_type =3D=3D PHY_TYPE_USB3)) { + dev_err(dev, "unsupported device type: %d\n", phy_type); + return ERR_PTR(-EINVAL); + } + + for (index =3D 0; index < AIROHA_PHY_USB_MAX; index++) + if (priv->phys[index] && + phy_type =3D=3D priv->phys[index]->type) { + instance =3D priv->phys[index]; + break; + } + + if (!instance) { + dev_err(dev, "failed to find appropriate phy\n"); + return ERR_PTR(-EINVAL); + } + + if (instance->type =3D=3D PHY_TYPE_USB3 && !priv->serdes_phy) { + dev_err(dev, "missing serdes phy for USB 3.0\n"); + return ERR_PTR(-EINVAL); + } + + return instance->phy; +} + +static const struct phy_ops airoha_phy =3D { + .init =3D an7581_usb_phy_init, + .power_on =3D an7581_usb_phy_power_on, + .power_off =3D an7581_usb_phy_power_off, + .set_mode =3D an7581_usb_phy_set_mode, + .owner =3D THIS_MODULE, +}; + +static const struct regmap_config an7581_usb_phy_regmap_config =3D { + .reg_bits =3D 32, + .val_bits =3D 32, + .reg_stride =3D 4, +}; + +static int an7581_usb_phy_probe(struct platform_device *pdev) +{ + struct phy_provider *phy_provider; + struct an7581_usb_phy_priv *priv; + struct device *dev =3D &pdev->dev; + unsigned int index; + void __iomem *base; + int ret; + + priv =3D devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + + priv->dev =3D dev; + + ret =3D of_property_read_u32(dev->of_node, "airoha,usb2-monitor-clk-sel", + &priv->monclk_sel); + if (ret) + return dev_err_probe(dev, ret, "Monitor clock selection is mandatory for= USB PHY calibration\n"); + + if (priv->monclk_sel > 3) + return dev_err_probe(dev, -EINVAL, "only 4 Monitor clock are selectable = on the SoC\n"); + + base =3D devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(base)) + return PTR_ERR(base); + + priv->regmap =3D devm_regmap_init_mmio(dev, base, &an7581_usb_phy_regmap_= config); + if (IS_ERR(priv->regmap)) + return PTR_ERR(priv->regmap); + + platform_set_drvdata(pdev, priv); + + for (index =3D 0; index < AIROHA_PHY_USB_MAX; index++) { + struct an7581_usb_phy_instance *instance; + u32 phy_type; + + switch (index) { + case AIROHA_PHY_USB2: + phy_type =3D PHY_TYPE_USB2; + break; + case AIROHA_PHY_USB3: + phy_type =3D PHY_TYPE_USB3; + break; + } + + if (phy_type =3D=3D PHY_TYPE_USB3) { + priv->serdes_phy =3D devm_phy_optional_get(dev, NULL); + if (IS_ERR(priv->serdes_phy)) + return dev_err_probe(dev, PTR_ERR(priv->serdes_phy), "error on serdes = phy for USB 3.0\n"); + } + + instance =3D devm_kzalloc(dev, sizeof(*instance), GFP_KERNEL); + if (!instance) + return -ENOMEM; + + instance->type =3D phy_type; + priv->phys[index] =3D instance; + + instance->phy =3D devm_phy_create(dev, NULL, &airoha_phy); + if (IS_ERR(instance->phy)) + return dev_err_probe(dev, PTR_ERR(instance->phy), "failed to create phy= \n"); + + phy_set_drvdata(instance->phy, instance); + } + + phy_provider =3D devm_of_phy_provider_register(&pdev->dev, an7581_usb_phy= _xlate); + + return PTR_ERR_OR_ZERO(phy_provider); +} + +static const struct of_device_id airoha_phy_id_table[] =3D { + { .compatible =3D "airoha,an7581-usb-phy" }, + { }, +}; +MODULE_DEVICE_TABLE(of, airoha_phy_id_table); + +static struct platform_driver an7581_usb_driver =3D { + .probe =3D an7581_usb_phy_probe, + .driver =3D { + .name =3D "airoha-an7581-usb-phy", + .of_match_table =3D airoha_phy_id_table, + }, +}; + +module_platform_driver(an7581_usb_driver); + +MODULE_DESCRIPTION("Airoha AN7581 USB PHY driver"); +MODULE_AUTHOR("Christian Marangi "); +MODULE_LICENSE("GPL"); --=20 2.53.0