From nobody Sun May 24 20:34:45 2026 Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9746E32E696 for ; Thu, 21 May 2026 14:45:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779374728; cv=none; b=LlwyBVqwHv5Y5Ug5MUXh5Q4u/y+wnmB0L7FEnksvCNyAO4832c9dE/Bu2NIuz9vOah9r0uKX6rPdPEL6ukkEatstSixGW0SVIUgBDyr17nxG+uodqeSXmII0Y1Ifhe2c1G3NC2TsXJbrmR03TENfYDBx0ZwqMNjZ3OBnTQfAhrU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779374728; c=relaxed/simple; bh=b6mxPe1PgHSHl/JBn/LEYt56zbFs/Pa6hnarJQDBGFc=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=aY9MWXYa/xwc5DtkUbZkx+hgeuIHjF9aATMemqfN+x0fu9DWY6dVakdzoHr7SbapYa4CC3DR/q+IWguFAWH5n90/TltGljTTpsyWbOPvJRN3rLq8F+5f/+hM+KyzkBydVWHbKc8eMVATXNge/3tBp4/fdauj5ca+q/Y/5J/dZ7s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T6VKx1lz; arc=none smtp.client-ip=209.85.221.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T6VKx1lz" Received: by mail-wr1-f50.google.com with SMTP id ffacd0b85a97d-453903ee4adso3034750f8f.3 for ; Thu, 21 May 2026 07:45:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779374726; x=1779979526; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:from:to:cc:subject:date:message-id:reply-to; bh=H2yWVwJxTaScCgj+pdDqJvd1+BNm6/dyL9FgYCmk8UQ=; b=T6VKx1lzxaSTmBduYYVFS5MisKeQyiiXSQHbvCepa1Tu8GrEAxg1Uu7d84u+l7FXGY qBvAunQyWH3Ps5KvnAcUOGT1zjBu/HOFU0q1g1kPgyoRtAN0svbSEwQb7G+0lJJbWvUv BOTT7QHdSbAbWnRiRRcaAfeLUQXnkZi7kZZztq/ZQorU0lCHruK6zJL0DT7ycHrO+a4w FmMVqoU9DdTXaFv4sZJSuPFLoEVrCeiEm+cJjIH2DxgfsaEwey6wJTvk6snDSPSf0ONP eY9LcjGWDR3F9MvkvlsW1kSVB7QQGZ+ezxvIu9029Tgz/XFSz+Vg3RtIgjSVkjWGc+zI 0EVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779374726; x=1779979526; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=H2yWVwJxTaScCgj+pdDqJvd1+BNm6/dyL9FgYCmk8UQ=; b=L2fgKFD4W+Wj6YmGQyiBSgRoE1ltlGdoj25qKAu5qV0THBR0y5c8RnK+SMTt+OtznU P0P/6mB/yXnFwrbWdIb7u6SYP+46uqZa/leJapjYD51dw7PltiM7QBi6BOlbEdv8DKj2 NQZurK5/yi1SfIS+ujRvU9kQ80+o0LmQPvrRZIDe6a6gPaDlLxH6WIIUwvgdPTNdTlw1 nGfpYfQecznI5XtmpcVUTur9XVo0F1Vyms06tFVquQ14K54ibF77b31wSSo6hpdfde5e bMRwdYUgeywnxWY2Wb5b5UFdmHXdbVzsZbWsD6ROCBXcVkhRwGGXWgevzJGEmSMXGJPE 5nvg== X-Forwarded-Encrypted: i=1; AFNElJ/iTl6gsawT3sHgBj0EB8uFsxNtSF1xjS5F7jRIG3TpHjpdlNptZF8udBp/z7ocD3iO2Ib6DH5rCX2mQeo=@vger.kernel.org X-Gm-Message-State: AOJu0YxM9V9PPCTsmc4ENEFq/HAaUT35w5m65eqcBHgH/NjJE+AbdHgC vWAZ+aOP5f06cf28nH5q4usYvgmQRmXhogstlGzLiqBpVbto63IJVZqc X-Gm-Gg: Acq92OFOFowg6vRv5a8EiYg8L4gXEEbL1aWaIfmETA8fodR+/RA7Un1yp2shoDXznGZ BqmW0CML8uOLgfhjy29KkmklZXHJd3LcKO7jvB7Rs+fAB/2Z30ImLnhtKiCDtQsFukgN23a4GQY ZTVxNZu43Q5wUBXG8hpuothXuXQW8kBBPLeCS0gVrZ5HCItcfayg9jmZLqAlINbbGGIm802GHLd DKmEhXFJ4lsGWD01fffEtppTbW5TkwhJQ1NCTDk+PzvuxdirbDkaOBgveKtdcpzbCyL0ffP+YRQ hSwQK2sDxn9nCN8E/5MsjiudVJpTCsk+vxtd13CCZAzk8LsE+pA7QjUqBStAM6AQFLMw2zZTqGm WFLINJtRkvIpQzMPcrfHAyQS55lDpYz/kPVL7oPrEkCLIgEWLK6VoAhqWv4apZeHF5qzCIsZYe3 5BQGHfBznc7jbBZnCpGhPvFirXChP0zDIuJsNdBNjfId9DlBXD6MGmAtQ= X-Received: by 2002:a05:6000:2403:b0:45e:655d:6f7 with SMTP id ffacd0b85a97d-45ea3ae887emr5723344f8f.24.1779374725641; Thu, 21 May 2026 07:45:25 -0700 (PDT) Received: from nixos-office (195-23-151-163.net.novis.pt. [195.23.151.163]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45eaa7da46esm3699744f8f.14.2026.05.21.07.45.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 07:45:24 -0700 (PDT) Sender: Julian Braha From: Julian Braha To: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, tursulin@ursulin.net, airlied@gmail.com, simona@ffwll.ch Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Julian Braha Subject: [PATCH] drm/i915: use 'depends on' with visible DEBUG_OBJECTS for DRM_I915_DEBUG and DRM_I915_SW_FENCE_DEBUG_OBJECTS Date: Thu, 21 May 2026 15:45:18 +0100 Message-ID: <20260521144518.410717-1-julianbraha@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" A previous version of this patch[1] accidentally introduced an unmet dependency bug, because DRM_I915_DEBUG selects DRM_I915_SW_FENCE_DEBUG_OBJECTS without also depending on DEBUG_OBJECTS. DRM_I915_SW_FENCE_DEBUG_OBJECTS currently selects DEBUG_OBJECTS even though DEBUG_OBJECTS is visible to users. Other config options use 'depends on' for DEBUG_OBJECTS, so let's do the same here. In this new version of the patch, let's also add the dependency on DEBUG_OBJECTS to DRM_I915_DEBUG, to prevent the unmet dependency. This select-visible Kconfig misusage was detected by Kconfirm, a static analysis tool for Kconfig. Link 1: https://lore.kernel.org/all/20260502191932.4491-1-julianbraha@gmail.com/ Signed-off-by: Julian Braha --- drivers/gpu/drm/i915/Kconfig.debug | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kcon= fig.debug index 3562a02ef7ad..657cdf49181e 100644 --- a/drivers/gpu/drm/i915/Kconfig.debug +++ b/drivers/gpu/drm/i915/Kconfig.debug @@ -35,6 +35,7 @@ config DRM_I915_REPLAY_GPU_HANGS_API =20 config DRM_I915_DEBUG bool "Enable additional driver debugging" + depends on DEBUG_OBJECTS depends on DRM_I915 depends on EXPERT # only for developers depends on !COMPILE_TEST # never built by robots @@ -153,7 +154,7 @@ config DRM_I915_TRACE_GTT config DRM_I915_SW_FENCE_DEBUG_OBJECTS bool "Enable additional driver debugging for fence objects" depends on DRM_I915 - select DEBUG_OBJECTS + depends on DEBUG_OBJECTS default n help Choose this option to turn on extra driver debugging that may affect --=20 2.53.0