soc: qcom: ice: Support IP version beyond v3

[PATCH] soc: qcom: ice: Support IP version beyond v3

Posted by Manivannan Sadhasivam 3 days, 6 hours ago

From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>

This driver currently supports Inline Crypto Engine (ICE) IP version 3 and
4. But this driver fully supports v5 and should support upcoming versions
as well. So extend the version check to support versions 3 and beyond.

Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
---
 drivers/soc/qcom/ice.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/qcom/ice.c b/drivers/soc/qcom/ice.c
index b203bc685cad..d3348b1fe85f 100644
--- a/drivers/soc/qcom/ice.c
+++ b/drivers/soc/qcom/ice.c
@@ -121,8 +121,8 @@ static bool qcom_ice_check_supported(struct qcom_ice *ice)
 	int minor = FIELD_GET(GENMASK(23, 16), regval);
 	int step = FIELD_GET(GENMASK(15, 0), regval);
 
-	/* For now this driver only supports ICE version 3 and 4. */
-	if (major != 3 && major != 4) {
+	/* Support ICE version 3 and above. */
+	if (major < 3) {
 		dev_warn(dev, "Unsupported ICE version: v%d.%d.%d\n",
 			 major, minor, step);
 		return false;
-- 
2.43.0

Re: [PATCH] soc: qcom: ice: Support IP version beyond v3

Posted by Konrad Dybcio 2 days, 9 hours ago

On 5/21/26 3:12 PM, Manivannan Sadhasivam wrote:
> From: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
> 
> This driver currently supports Inline Crypto Engine (ICE) IP version 3 and
> 4. But this driver fully supports v5 and should support upcoming versions
> as well. So extend the version check to support versions 3 and beyond.
> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad