From nobody Sun May 24 20:33:27 2026 Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2DD62346FDA for ; Thu, 21 May 2026 12:30:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779366602; cv=none; b=Xk/aQNEUpi71Y2PsT18Jjovlat4317q+1gSgb2anevWrbkw0r7eDV9IC9XCPxUFBJGw5Pv/GaIxBELu2e2893KD3GHbnJT6iu3Nczkvf0oAAF5P0DQO8Msp+eu6HmjL5T9IbFgqG14MHVRRYquM1lRPirk0EMZJZh4jPBfLfB5g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779366602; c=relaxed/simple; bh=hP2QHObYV/AGwyrFZlEGl3ZzwoELcoz/pASe9Ez5DuY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RPP3iFx+03eAfYEQevko4ofElkfctLfbEGbBKwvlmp3UfPByheaoLa6njGA/L5F73oAe6HVX5Z8RxRxh+zHEBzTUvnOm4/wH9JAJfZKboZdCcm9U4CnY+bahSyp1bK58iEOtDXqByna3GkXf5v4ug7LePxBN8C9qtmJG5TkCB3g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=WibCPUm9; arc=none smtp.client-ip=209.85.210.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WibCPUm9" Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-835386ff122so6205486b3a.3 for ; Thu, 21 May 2026 05:30:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779366600; x=1779971400; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=aA7WgIDiCQ5x0h8SvcBCCp0yTYb+FeSe1qj3JxGxTdw=; b=WibCPUm9d3zn9NztJSiiLtURVXI2vBr3aFkq8gHoAwU2wXxPeFdxe7oWxIMKTQhYQd DMEjPiqdYK9zLQHl4HzlIdAQGMDJj4YKazZpOZTTQu+de1DY00zCPZNxZa+dgCAuLYqF UTJIfwiTbczvDGC7TNZh6lIjHd1civ1ZCTesfoVnxW9mdOjVxxBUUcsZ6+VMuh9uW7Wb 6r+2IL0t/W2p7hKX6Q3eBZczxS/6yWkP+BAiGiFUkIY7rABX0tCFawTpn0gEHwnj6k/N h913co5h84jp/l+vCaoDbdLErZm+CETR/YR53eSrMGEH2Bg2ns8128yG9V3LQsd2KPay TNbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779366600; x=1779971400; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=aA7WgIDiCQ5x0h8SvcBCCp0yTYb+FeSe1qj3JxGxTdw=; b=Otr8RC+p/2lFL/h0+47Oq5IdpAoqwi5kEWD27OOGR/wWtv6/j284uPtJnZjyS+2JX/ ScjlkXIp6DpzEa110wBY9KUpb5A1sgSp6IVo8DYKF9InoHV37ygcsep0jZUXIeQQ8zJ8 yC4YzisBlfD9dcmpiGDa+oGdQreYnzLQ84b3V+I+mlMuwJ890uhwyCrendWDlxo11T6e eZwUij0HKhGnlJiAvYx5S1Mfh+SoXuHj63HX/WVeKCRZ3s1qryJzXZoPJOXoEZGaUmxi iZAlxdVda2NBSSv5a46XEX2jsx7Ub7PjJ7khtIYoD8g8Hz6YpsxaNDv65KV6GX20Wgaa gC2g== X-Forwarded-Encrypted: i=1; AFNElJ9MqVvXsJDuNuietzZ0H6tSVqq+DSZGg7Wgwu5kVwf9kq+LZCwLAYpV6EZuSUr1sP+ef9VXyTBhq84sAQM=@vger.kernel.org X-Gm-Message-State: AOJu0YwY6Rr56wno3Ctdmeoin0AOa7A7HtZbCGAEj1WDTpPdGqiPN3Dt nb1zJH3Jr6j46GCRUkZn34LuYDUuU+IhtBq9NF0kwYnDBKxNfbvFowmH1BkpsZdm5QpafqwI X-Gm-Gg: Acq92OFjZsbCX6IPypvCBKf2aLqg42+77bkgV5dCYMH8hJdobHPRA53btR9FJuw0D0+ FEgxJTwbZeNhD890gH5dL7/mvxeL2FpOjrsBTGvI3LNtRRIwFvHgCnTHmsX2qFTPYadr+PsBlOq HliRqg/Ehs7hSKzOFyR4cA0EvgZRQd13DZ45KGEOCBLvt+FKVuaKAijAbkFNQYJkSG3fg/y+LMX hhimUKBUC7z6HHcgoPR6PdSTLxVzfZ0HfStL5ftPk7qec4JlAtu3Wh5IWsmiJTsl/80U8tGxi17 GE2aLh2jvvummKvwrlSejpBSAxTF8BpcAXhpFLTT2NH+SxGsfdKy/U3obdjlWP3DyftcgTR3byR eExLr67UMiSS5m32YcI+30RSzE+M0qotmIpwmwB6P66zqTGPRPzotfsfFyyF4JA/0j/RGHfjbMZ OeSIuvVGENSW5X5xPhSa/FHuhSQCYqgcgqz0TMtL4eTz1Z2Dj1/hCDhA== X-Received: by 2002:a05:6a00:6018:b0:82f:5051:f024 with SMTP id d2e1a72fcca58-8414adf6980mr3151339b3a.27.1779366600533; Thu, 21 May 2026 05:30:00 -0700 (PDT) Received: from Collin-Windows.taila26705.ts.net ([104.28.163.94]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84154a000bcsm1026374b3a.16.2026.05.21.05.29.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 05:30:00 -0700 (PDT) From: KangNing Liao To: linux-btrfs@vger.kernel.org Cc: clm@fb.com, dsterba@suse.com, eadavis@qq.com, linux-kernel@vger.kernel.org Subject: [PATCH] btrfs: protect sb_write_pointer() with invalidate lock Date: Thu, 21 May 2026 20:29:45 +0800 Message-ID: <20260521122945.524890-1-lkangn.kernel@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" sb_write_pointer() reads the super block from the block device page cache using read_cache_page_gfp(). This has the same race with BLKBSZSET as the one fixed by commit 3f29d661e568 ("btrfs: sync read disk super and set block size"). Take the mapping invalidate lock around read_cache_page_gfp() to serialize the read against block size changes. Signed-off-by: KangNing Liao Reviewed-by: Qu Wenruo --- fs/btrfs/zoned.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/btrfs/zoned.c b/fs/btrfs/zoned.c index 16dd87aa06f2..5f75cf0e14b9 100644 --- a/fs/btrfs/zoned.c +++ b/fs/btrfs/zoned.c @@ -131,8 +131,10 @@ static int sb_write_pointer(struct block_device *bdev,= struct blk_zone *zones, u64 bytenr =3D ALIGN_DOWN(zone_end, BTRFS_SUPER_INFO_SIZE) - BTRFS_SUPER_INFO_SIZE; =20 + filemap_invalidate_lock(mapping); page[i] =3D read_cache_page_gfp(mapping, bytenr >> PAGE_SHIFT, GFP_NOFS); + filemap_invalidate_unlock(mapping); if (IS_ERR(page[i])) { if (i =3D=3D 1) btrfs_release_disk_super(super[0]); --=20 2.54.0