From nobody Sun May 24 20:33:34 2026 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACA423B8BCB for ; Thu, 21 May 2026 11:37:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779363441; cv=none; b=GxpA/ZVMAEK2deZRFMGH5255QYjxhCSwOJOC2WsOjzHDJF6lt+MSpGYhn+x6tuAG8YdbHalB+Nabm8eqgGL6PMm5Y+eDMltQynUN7y/qeynfk62Y9dntfReBMM3QVX0OhmBvqKq9HEgXho23hejzlLHvMKtN4G/Nd1/N75RZ93k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779363441; c=relaxed/simple; bh=LgWxFixDPwbNrZmuomo2jW5rDbuQrIzIeNbv251Fgqw=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=qGr88AAV7I+OHnN8m84H3v2kYpGUc0r9oyuTiNGGMd5KDlkxnnpHs16Cm/TXYjnuxOeYQpeVl6KfOca9K1w6IblRIv8NZ3hxDWUq4U5HKvhMNWXlpX6rYeWXjeMGyoDomAZzeDaMimojjfwIhYVTXvYwaPUoSddtey1dGTmx6Wc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=nYZIkzXu; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="nYZIkzXu" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-8353c9f24d2so3070104b3a.3 for ; Thu, 21 May 2026 04:37:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779363440; x=1779968240; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=N4V/zI/uDaBusVGWv8CyZy9v6gpCugV+8fpO+TgRX1I=; b=nYZIkzXuu62bS7bcGLeDaP8g/h1uIpZZlz0o988Djc/PmouZup2vbm4Mo5mzZn2Xj8 589+ORlpHAluGEGc6WGn5vn74wVATBX/wsYCuAh6jbIOAq37ThmSwyxZZtkF3mKCB9eR 4a7JzpOgeE8xTAdLqSyfU43jJ3yxmjqfj/W1p8QrNDn4lYeKgN2ujscr5RkCVRkSuhkW RyIFtqaVUvTBeDTjqCzedTE7ZF6/MfiLiC0K+pb4orrmVNRGCts+IPIv9TrkWLCAyyYj TdNEORNzFLidsmlokTI8ABNzWFyeUfsy9YxXNGTp8vlk9+XkS6w5gIVK8tNtcxRbjdT4 BW5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779363440; x=1779968240; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=N4V/zI/uDaBusVGWv8CyZy9v6gpCugV+8fpO+TgRX1I=; b=Zo0p+1J3PKCaM6InUyW0WWe47ZHF3DQw2Dt2ifa/+WYEZ69KIZ7MOdXmGKIHV6eij4 QEjRmaqGwm3rdB9SpPbb0PCOOiglDn2NI+pSw8wEAFuCoHZM304VC8yZBvH2VgkelJNy /W21sMAhAI7/5kJ5RdW6bBfwVhqSDgkuawOY11wZcBf3wS/yFhBWx7sqVNE4NjO/hCs1 YVg3SUb3CJx8YF8t4ECJZC2Ac2stEj4aR0ymLXKkfhWLSFTHKzQWxu4yxnpp+g+/T1Tz UpzHKxOruaChkj4O4WcZm4sXliu6lzGmTJ82LWBI645wczw4YN6MJYMVR6dXNSTaRklx CxQA== X-Forwarded-Encrypted: i=1; AFNElJ9NJKvkgjre7sEfvukwUIa/tO0cIp+TRu542DmM3bh0MKWOh1s30iW1vIqVAcFClArJMxbcKmkXXcjXXJc=@vger.kernel.org X-Gm-Message-State: AOJu0Yx2a9JlqZsTDkPYyWTjX3ExytDCxP345N7IMbH6L7LD4EyY4cdr zbhXWoEo+H5KEsUH7OIpVOgLisM57o/3llYAUQ1suKzXCgEyL5CGZcGhkvYNbbXI X-Gm-Gg: Acq92OHmbFZluy4CT5v80OwZBBTSgMFsLx0BWT3OwmjStl6085LMRupVkB0Yd/1I2Cx H+7oXgegemCyDaP2hR4W8Yn8zDgwtTgFCbZM6F3Nz0tNQcElAOG+DnboEnLgJMy1cSGKG3z11N0 llyMD4tO4yEse+EAmFR2SJCCAQvzTrmJEqVryuIXdgFsKVJBHn/zwNJO7ZwV27a65ueKnekg+EL iBG2hUi9FNczYCNTD2y+evP6bFalohikE2ckL/nHlUVQYeBZVdKeuUU03dHnmMa9I4EkkHDcy72 +EwuE6WzXbWpf0WqwY6SVw7mRjNsRJVXsqYkYf7LVcheQcaSy4QpKTJPHF3TzdpmVD+FXko5vX8 dEK3N7PcaSdYWhNAjPG7LCVIo9D7NHY9qE/IUyWU+PNNxZUSnrwMj1HVKRd1aLFibc4urIKWW16 O3HkuznWmHDBiA49uVu8oC0Xus7oZBe1Dx3ag/HSasXQ6joTZG54MIDg== X-Received: by 2002:a05:6a20:9148:b0:3b2:a8cd:ef4d with SMTP id adf61e73a8af0-3b30874de2fmr3156921637.29.1779363439795; Thu, 21 May 2026 04:37:19 -0700 (PDT) Received: from name2965-Precision-7820-Tower.. ([14.48.8.61]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c85198f508bsm131591a12.20.2026.05.21.04.37.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 04:37:19 -0700 (PDT) From: Jeongjun Park To: Shenghao Ding , Kevin Lu , Baojun Xu , Liam Girdwood , Mark Brown Cc: Jaroslav Kysela , Takashi Iwai , Kuninori Morimoto , Charles Keepax , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, stable@kernel.org, Jeongjun Park Subject: [PATCH] ASoC: codecs: pcm512x: fix null-ptr dereference in pcm512x_overclock_xxx_put() Date: Thu, 21 May 2026 20:37:12 +0900 Message-Id: <20260521113712.227438-1-aha310510@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" In the pcm512x chipset driver, pcm512x_overclock_xxx_put() is defined as a general mixer kcontrol instead of a DAPM kcontrol, so struct snd_soc_dapm_context must not be accessed via snd_soc_dapm_kcontrol_to_dapm(). This causes a NULL pointer dereference, so it must be modified to use snd_soc_component_to_dapm(). Cc: stable@kernel.org Closes: https://github.com/raspberrypi/linux/issues/7242 Fixes: 02dbbb7e982a ("ASoC: codecs: pcm512x: convert to snd_soc_dapm_xxx()") Signed-off-by: Jeongjun Park --- sound/soc/codecs/pcm512x.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/codecs/pcm512x.c b/sound/soc/codecs/pcm512x.c index d4c1d8d45af3..348752722bd6 100644 --- a/sound/soc/codecs/pcm512x.c +++ b/sound/soc/codecs/pcm512x.c @@ -235,7 +235,7 @@ static int pcm512x_overclock_pll_put(struct snd_kcontro= l *kcontrol, struct snd_ctl_elem_value *ucontrol) { struct snd_soc_component *component =3D snd_kcontrol_chip(kcontrol); - struct snd_soc_dapm_context *dapm =3D snd_soc_dapm_kcontrol_to_dapm(kcont= rol); + struct snd_soc_dapm_context *dapm =3D snd_soc_component_to_dapm(component= ); struct pcm512x_priv *pcm512x =3D snd_soc_component_get_drvdata(component); =20 switch (snd_soc_dapm_get_bias_level(dapm)) { @@ -264,7 +264,7 @@ static int pcm512x_overclock_dsp_put(struct snd_kcontro= l *kcontrol, struct snd_ctl_elem_value *ucontrol) { struct snd_soc_component *component =3D snd_kcontrol_chip(kcontrol); - struct snd_soc_dapm_context *dapm =3D snd_soc_dapm_kcontrol_to_dapm(kcont= rol); + struct snd_soc_dapm_context *dapm =3D snd_soc_component_to_dapm(component= ); struct pcm512x_priv *pcm512x =3D snd_soc_component_get_drvdata(component); =20 switch (snd_soc_dapm_get_bias_level(dapm)) { @@ -293,7 +293,7 @@ static int pcm512x_overclock_dac_put(struct snd_kcontro= l *kcontrol, struct snd_ctl_elem_value *ucontrol) { struct snd_soc_component *component =3D snd_kcontrol_chip(kcontrol); - struct snd_soc_dapm_context *dapm =3D snd_soc_dapm_kcontrol_to_dapm(kcont= rol); + struct snd_soc_dapm_context *dapm =3D snd_soc_component_to_dapm(component= ); struct pcm512x_priv *pcm512x =3D snd_soc_component_get_drvdata(component); =20 switch (snd_soc_dapm_get_bias_level(dapm)) { --