From nobody Sun May 24 21:40:09 2026 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49F25383981 for ; Thu, 21 May 2026 11:05:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779361534; cv=none; b=WbD13reIlU+mO4UBS7Nv+YmMeiFFT3cMJTuzBygNHrxPAH4eaR8mX4qIDjR8QxjCGWBpdwBJ7GFNji1xTe1EdFrA/0EC7UG4owiywYpiT7Rkm7ezI+zBka0EcV0n/DizU7EPYBTKApjBjUjK6vvr2kH4wSxWXhMM0PIJfj9oT24= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779361534; c=relaxed/simple; bh=yYVX5uFk3iu6L/juK+t+Au5Ku/o3pgm4j+pQ6uzoAN0=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Oinm4woaDa3QgoFogavOFGHzFiFEVPdSIYi0umxCPDUKohLO+CotwKj44vakFvFMxxAt4UGKIDYAhiociP2sHdPU6jamLWgz2G/laIZ/y7EjxW5tP+k7/LAS6Ij1nLCD2B24geQqvccFqHkli3HG7suOCqYLu0vJxkZE9qj0+Ek= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=l5T8wbAp; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="l5T8wbAp" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-36a3dd2e66eso516765a91.0 for ; Thu, 21 May 2026 04:05:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779361532; x=1779966332; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=OP1QEUlOQim7PDu0CGt9x/Vst5DkA2CeqgWEhYZxdEM=; b=l5T8wbApOQzOV+2FLEmlpCUYdJTu7Y2KD8ILAJVEbehhR9IgB2dsWbjYksdRsP+haa HvRAilD6OE8b+qBMmshqTpux6D3AvBIhJXIV5QSL1+EphjDqa8wNue/bzBERDw5EIkUg lfyL9ul+SiHtd0iKxSxhW7GhqWnuUafXStZ1JZFSQKxyn/UPYURpUeXQS9vpUXJdJKGh dv/uRvSexX9+AaoeouaS4wqYK9tveDmux9xWIh9Kqu3Q/CPxmHvKgB2Ee2VREiK534OK rVW675sz17WilfiE27BqJguYyzucwOcnsMx14BTv5g0HnF1FfxyOJeKaSfm8Wp1HYFPd Ef0A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779361532; x=1779966332; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=OP1QEUlOQim7PDu0CGt9x/Vst5DkA2CeqgWEhYZxdEM=; b=MfJDmnTJnmbE11cY+NNt8LbBjpNBxAcpOAvZ6kWddTxaL9gOflfttyv7vUWO5ULYNW lewP4xFYVsqBCx7p6t3yyK+yvVQS3iC+gcyuA+g85neyITHoTo4FIEqWFV4qRbreC8qs 90wkgu39mHSBQl+2vDoYtD1pCiJ2P5bESoD96kXpT/qX76/aipi7VCVYS9wuk+AN3cwV WLhcf3X8kCpNEZpdvIopQcwNatcX06JkZetZuJdFtw5yXKz57T3pGCcY/l0Od6UyD/YM Qaw0V2DvA/XO41UCHAMbsNxOupu73QPGyWcTDH84MdBWwGKhDqKwh6JCYXMqMIqiIHgv jBsw== X-Forwarded-Encrypted: i=1; AFNElJ/362m37cdCrph3SXHJc5C1pEU+K66+O26UM7ERBa5XfC+oTZJLQx4QW0HHUX/3eTLsIv5PL0AR2O2QyjQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzM+vhCPK05a7yVjMZ/mMoXETBoj+akWEMdg+l29fhj99/1NBMD ih0aOamTj7nrhFhe/omS87qV/MXlKcRYQN1ZbfP80ExVt09ruOsCdLYG X-Gm-Gg: Acq92OFe8VWhpbyy2+QoNp+8o0wUjHA/80PhEz5PCINM8DGkykkhUWZX8pSSmi2eqoG SyYLFRTwx2EmFOGzraD0Z0oZzkoXvEvJR+AwG4lnrfR3SG6thCo/LSQDvduleDVNqmR3RsIz3Dc LwZz1mfKLaDnD+kZX/XTzDaqBbvvFEchFdMSjtUnq6QEF2ADRnh7JFrtm4jk+O+447zsS5CDmRz JYP1JDrg2UjPfKQTw7jGy9Lj1UDFMFVgvOmDhNOunZ5xyyMpXM4s6CP40zicD/or0kcV7IHAQo3 GUHzS8uWWYKyKvCNkbP+elHJ10h5VK/XtGB3WW6Pa1t3aVIR/0EHAAK9FjKELW7E/BO5RsgtDCt y4FAE0kttTxgoEaD/UgGiKQXIT/ZWPV/R2Mfpt95neos4NedIpbKcC5QJ9xBb+7REF9aDYYH6Qw hCvvzlLAHxoawHzHXv+WsrNDYgMZn/JzrkcCMLZrjU436XnYP5eSQgV/3rBZNAoMioZ7ZF8w== X-Received: by 2002:a17:90b:2803:b0:369:73a:3266 with SMTP id 98e67ed59e1d1-36a45183b74mr2557975a91.10.1779361532453; Thu, 21 May 2026 04:05:32 -0700 (PDT) Received: from qiwenjie-ThinkCentre-M760t.mioffice.cn ([43.224.245.241]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c851995590esm10181a12.29.2026.05.21.04.05.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 04:05:32 -0700 (PDT) From: Wenjie Qi X-Google-Original-From: Wenjie Qi To: jaegeuk@kernel.org, chao@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, qiwenjie@xiaomi.com, qwjhust@gmail.com Subject: [PATCH] f2fs: reject setattr writes on large folio files Date: Thu, 21 May 2026 19:05:26 +0800 Message-ID: <20260521110526.1967583-1-qiwenjie@xiaomi.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" F2FS large folio support is read-only. It rejects writable opens and mmap writes when an inode mapping supports large folios, but setattr can still reach the inode without going through those checks. For immutable large-folio files, clearing the immutable flag keeps the cached inode and its large-folio mapping alive until the inode is dropped. A path-based truncate(2) can then call f2fs_setattr() with ATTR_SIZE and change the file size without opening the file for write. The user.fadvise path adds another visible case: after the file is reopened with large folios, chmod(WRITE) is documented to fail, but f2fs_setattr() currently allows ATTR_MODE to add write bits back. Reject size changes and mode changes that enable write permissions while the mapping still supports large folios. Read-only mode changes and unrelated metadata updates remain allowed. Fixes: 05e65c14ea59 ("f2fs: support large folio for immutable non-compresse= d case") Signed-off-by: Wenjie Qi --- fs/f2fs/file.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c index 71385ca4163d..3880ff5e6740 100644 --- a/fs/f2fs/file.c +++ b/fs/f2fs/file.c @@ -1097,6 +1097,11 @@ int f2fs_setattr(struct mnt_idmap *idmap, struct den= try *dentry, ATTR_GID | ATTR_TIMES_SET)))) return -EPERM; =20 + if (mapping_large_folio_support(inode->i_mapping) && + ((attr->ia_valid & ATTR_SIZE) || + ((attr->ia_valid & ATTR_MODE) && (attr->ia_mode & 0222)))) + return -EOPNOTSUPP; + if ((attr->ia_valid & ATTR_SIZE)) { if (!f2fs_is_compress_backend_ready(inode) || IS_DEVICE_ALIASING(inode)) --=20 2.43.0