From nobody Sun May 24 21:38:44 2026 Received: from mail-m19731102.qiye.163.com (mail-m19731102.qiye.163.com [220.197.31.102]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB0F1395D8F for ; Thu, 21 May 2026 10:32:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.102 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779359557; cv=none; b=otDO0FuJEGWstSPpoEVFuvrUh6Je7329jWLRUpmYIA6hifbwwZcM9Mv12pOHJ0S75lrHpp7QAkayezQB7bidU+WGLkt7mWnnuPN4WGVOv2fsKXUYTR2KoFD49azLdV9twy7aklDiSZQj3JzRcbSBDEmrSYtnucLFbtSKp6LT+QM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779359557; c=relaxed/simple; bh=svxK635uAEvaIkdxXa0rB667mI6RGBlomlyMyvQeyiQ=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=LmsHnVmQ7VF3XBJva2bd3eH/qOfzuIWoQvdt96exd4yzXWSjg7fdShYMyuQZ6UaqwvHaR3QOKymmKAoR8Kvh22hY4oF4IfR4/B5TFK3bOhhCZnabTiOf6siuWkRMTe6lHLE7SxpmlepASFu4haTYXVCdDa79Ut3Nx31EP+kTnhk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com; spf=pass smtp.mailfrom=rock-chips.com; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b=f5SUmz2W; arc=none smtp.client-ip=220.197.31.102 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rock-chips.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=rock-chips.com header.i=@rock-chips.com header.b="f5SUmz2W" Received: from zyb-HP-ProDesk-680-G2-MT.. (unknown [61.154.14.86]) by smtp.qiye.163.com (Hmail) with ESMTP id 3f4e1cf0d; Thu, 21 May 2026 18:27:19 +0800 (GMT+08:00) From: Damon Ding To: andrzej.hajda@intel.com, neil.armstrong@linaro.org, rfoss@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch Cc: Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se, jernej.skrabec@gmail.com, luca.ceresoli@bootlin.com, dmitry.baryshkov@oss.qualcomm.com, heiko@sntech.de, m.szyprowski@samsung.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Damon Ding Subject: [PATCH v1] drm/bridge: analogix_dp: Convert status check functions to bool Date: Thu, 21 May 2026 18:27:16 +0800 Message-Id: <20260521102716.1373519-1-damon.ding@rock-chips.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-HM-Tid: 0a9e4a134eda03a3kunm9bb0eb6d711e8 X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWRgWCB1ZQUpXWS1ZQUlXWQ8JGhUIEh9ZQVkZQhlMVkNKGUtOTRgZTEgaSVYVFA kWGhdVEwETFhoSFyQUDg9ZV1kYEgtZQVlNSlVKTk9VSk9VQ01ZV1kWGg8SFR0UWUFZT0tIVUpLSU 9PT0hVSktLVUpCS0tZBg++ DKIM-Signature: a=rsa-sha256; b=f5SUmz2W5gYAVStKjo7qAkjdW4p08Dc9Cb9ZzK4N6kDaFniMCjFuRD7aRIkVaq9sY2fkiaEP6xy9TpXJpY1Bkq5G3vEY5WdbIS/XXUgBos7LODxVvXQGD1ZECHlsfeq71P42v334bretDbteKgMLbL7MJuYdCldp4lib53MgKS0=; c=relaxed/relaxed; s=default; d=rock-chips.com; v=1; bh=XtwCByr+wKG5Y+gmLOm1LXw98pacruXWBpNBN0qDn4c=; h=date:mime-version:subject:message-id:from; Content-Type: text/plain; charset="utf-8" Convert analogix_dp_is_slave_video_stream_clock_on() and analogix_dp_is_video_stream_on() from int to bool return type. This makes the code more readable and aligns with kernel best practices for boolean status checks, while simplifying the callers by removing unnecessary "=3D=3D 0" comparisons. Signed-off-by: Damon Ding Reviewed-by: Luca Ceresoli --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 ++-- drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 4 ++-- drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 14 +++++++------- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/g= pu/drm/bridge/analogix/analogix_dp_core.c index 8cf6b73bceac..573900c2cefc 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -619,7 +619,7 @@ static int analogix_dp_config_video(struct analogix_dp_= device *dp) =20 for (;;) { timeout_loop++; - if (analogix_dp_is_slave_video_stream_clock_on(dp) =3D=3D 0) + if (analogix_dp_is_slave_video_stream_clock_on(dp)) break; if (timeout_loop > DP_TIMEOUT_LOOP_COUNT) { dev_err(dp->dev, "Timeout of slave video streamclk ok\n"); @@ -647,7 +647,7 @@ static int analogix_dp_config_video(struct analogix_dp_= device *dp) =20 for (;;) { timeout_loop++; - if (analogix_dp_is_video_stream_on(dp) =3D=3D 0) { + if (analogix_dp_is_video_stream_on(dp)) { done_count++; if (done_count > 10) break; diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h b/drivers/g= pu/drm/bridge/analogix/analogix_dp_core.h index 17347448c6b0..94348c4e3623 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h @@ -211,7 +211,7 @@ void analogix_dp_reset_macro(struct analogix_dp_device = *dp); void analogix_dp_init_video(struct analogix_dp_device *dp); =20 void analogix_dp_set_video_color_format(struct analogix_dp_device *dp); -int analogix_dp_is_slave_video_stream_clock_on(struct analogix_dp_device *= dp); +bool analogix_dp_is_slave_video_stream_clock_on(struct analogix_dp_device = *dp); void analogix_dp_set_video_cr_mn(struct analogix_dp_device *dp, enum clock_recovery_m_value_type type, u32 m_value, @@ -220,7 +220,7 @@ void analogix_dp_set_video_timing_mode(struct analogix_= dp_device *dp, u32 type); void analogix_dp_enable_video_master(struct analogix_dp_device *dp, bool enable); void analogix_dp_start_video(struct analogix_dp_device *dp); -int analogix_dp_is_video_stream_on(struct analogix_dp_device *dp); +bool analogix_dp_is_video_stream_on(struct analogix_dp_device *dp); void analogix_dp_config_video_slave_mode(struct analogix_dp_device *dp); void analogix_dp_enable_scrambling(struct analogix_dp_device *dp); void analogix_dp_disable_scrambling(struct analogix_dp_device *dp); diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c b/drivers/gp= u/drm/bridge/analogix/analogix_dp_reg.c index 38fd8d5014d2..f84c1d48d671 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c @@ -713,7 +713,7 @@ void analogix_dp_set_video_color_format(struct analogix= _dp_device *dp) writel(reg, dp->reg_base + ANALOGIX_DP_VIDEO_CTL_3); } =20 -int analogix_dp_is_slave_video_stream_clock_on(struct analogix_dp_device *= dp) +bool analogix_dp_is_slave_video_stream_clock_on(struct analogix_dp_device = *dp) { u32 reg; =20 @@ -724,7 +724,7 @@ int analogix_dp_is_slave_video_stream_clock_on(struct a= nalogix_dp_device *dp) =20 if (!(reg & DET_STA)) { dev_dbg(dp->dev, "Input stream clock not detected.\n"); - return -EINVAL; + return false; } =20 reg =3D readl(dp->reg_base + ANALOGIX_DP_SYS_CTL_2); @@ -735,10 +735,10 @@ int analogix_dp_is_slave_video_stream_clock_on(struct= analogix_dp_device *dp) =20 if (reg & CHA_STA) { dev_dbg(dp->dev, "Input stream clk is changing\n"); - return -EINVAL; + return false; } =20 - return 0; + return true; } =20 void analogix_dp_set_video_cr_mn(struct analogix_dp_device *dp, @@ -816,7 +816,7 @@ void analogix_dp_start_video(struct analogix_dp_device = *dp) writel(reg, dp->reg_base + ANALOGIX_DP_VIDEO_CTL_1); } =20 -int analogix_dp_is_video_stream_on(struct analogix_dp_device *dp) +bool analogix_dp_is_video_stream_on(struct analogix_dp_device *dp) { u32 reg; =20 @@ -826,10 +826,10 @@ int analogix_dp_is_video_stream_on(struct analogix_dp= _device *dp) reg =3D readl(dp->reg_base + ANALOGIX_DP_SYS_CTL_3); if (!(reg & STRM_VALID)) { dev_dbg(dp->dev, "Input video stream is not detected.\n"); - return -EINVAL; + return false; } =20 - return 0; + return true; } =20 void analogix_dp_config_video_slave_mode(struct analogix_dp_device *dp) --=20 2.34.1