From nobody Sun May 24 21:38:04 2026 Received: from mail-vs1-f54.google.com (mail-vs1-f54.google.com [209.85.217.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C828B307AC6 for ; Thu, 21 May 2026 10:13:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.217.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779358404; cv=none; b=iUeyQpPxg660du7QxtgEsTGXCSGgZ7vZzSu+JyCCgzYm4P/91xvNlGYCkHaxJonaYjksmQTRFzL39BPfaqXwQk74A03GdXHEx2Lhe3Xo6wXulc3G18pDHU63+oq6FN1MOIC86talMxPMPvxHWC6qTcWjJWprSeBZPrsGTBPVNc0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779358404; c=relaxed/simple; bh=pXAe+04j2eMYEsuO1Kozb9RLm594EvCDTCHbKJOOy6g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=M3vF2tO9b1z81Q0HYfqMr3yyLnZhfL+GPAOMkh9qJC9YkYlPGeaC1fdKYAe71wmyuvelUo3mNk54ua4ZEF0Qfc0WT+VJXWWIdaRgETGL/azD/NSoDKVIiMsrsmLyzUlSfuZ4jySpJM/1mCr5d1v/ZKee8YtfOyBXNAVCU+TvfOc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AKupnoa5; arc=none smtp.client-ip=209.85.217.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AKupnoa5" Received: by mail-vs1-f54.google.com with SMTP id ada2fe7eead31-63319183a49so2123389137.2 for ; Thu, 21 May 2026 03:13:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779358402; x=1779963202; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rILg+oMh1z0s8sO4ABPHVZeTYgFcKY4qxnY9gNQ6FeI=; b=AKupnoa59XzrVsU7b/UokBhHJmjV+SN2jtiiFHS5q0QWg/6N7EOmLZPltiDdO0ykvP L3YUYoklbRY7Zvre/ZiOk8VCe7gUqW9i0IbTxh+cm2KkJ42ISYYz8qaBJeh8w31o/eKl 5s2kX22C0xKFu+1cniRkNexGdmI2DLiBSWV/C/7uhsh0KYjkBUYtFVMOQIFpJ8dhL1/a jF4l2Mtz9XjQ1C4qU9qmqfDiaaUOG43qUyImaqJlpLBBKTKKCJEnuYqwJawdrN4ulNnw tpxwetVDDr46HnbKF0KaJn1xDWSDHHgt/EzzEBRU0vPeSOgCNasRSHWVQtsRg3ncs50I VSCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779358402; x=1779963202; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rILg+oMh1z0s8sO4ABPHVZeTYgFcKY4qxnY9gNQ6FeI=; b=V/sjZcWwKVI3jan9rkRJtcQ01thLNnL0SjGKqdxZ0SRKPXc4EgOcpAKlI++06WWMxh zSuNi987x9YvcM4a/W7gvOjK9PdpfOcNSwoeGIHXdgUtcj57TZShkHj/ZxheEg8L0hLQ SQ32vFeNfipfn9D6eqUZL5XF8eGnLOMaW5OO4unjKqd587vIvfg7bIBAUScufc+tb8Y5 LliQnqHARBi3sQdobhpJClq+W1DGPLSU39OeZM7IrEysnRx94Rvh5/b4HmQKEGODjvOt JGCY6b16ItALYv9923fxf3bqLYB+eV0xGn2S+l9ZFv4/u8Zan4bHbGC466KMHN/WYh4L Ug/g== X-Forwarded-Encrypted: i=1; AFNElJ9xP54lhgEJQSEPo/hQTTdxNbvQYYqzcgxf6Gi2oVv/My2R52jf+K+uoZXxwGc7DK/2kSFD3UpKKT97RQM=@vger.kernel.org X-Gm-Message-State: AOJu0YxGSJ3zr2dP0fGLMTcyQXl0xTeJvtrOxvVHP/VQVlme57y1fJhb HJKTe7Zg+18rZRJMhjkMKgpp6JelfpdT/Qih4mDMdEUxijs8YEeuROWr X-Gm-Gg: Acq92OHH6/Wqtc0fDsWPutdEJV5qkoUHjjECHtLcuiV+R2+bydhuZONzLSd5cZ0ZN1p tGpGMja2BFFUTz4l7oevD8oKoSXCxEfVBq4VNkjJmqFSfHzJOV5oHrZxg0HZ/Ym5Ny+9Cqk/gZX 3T/hdPQH0uojIL4DY1T3nbToIBQ7tY6Sf11bdWHuYirJ6kXh0qYZxCr4RPOSoHY/v7kuYAsaN7G wGX5ddkZkFGWIyYfTn5d8iwjmQ8BB10Mjfbul4Nae/3GVFdxu/FysuKIStc+GRftEBWzlzrMS2M ylgsizCJKcGSv+x7cvPd7B02lGmAxkyhdu9MNulxU+A4nKGEhEok9iVIRAEgGxF5yjJgOfQy8xG 4kLNQrSRtB84FHSinkJ9j45F2ILumTNnOu20RqsGWsPWTbjBmy+YWxLEMlbTIL34FIs5pprAZL/ 8BgwoKZV3zdhS3LLzhpb23y2PF0p0cA5Q= X-Received: by 2002:a05:6102:3ec5:b0:650:aa33:5dd7 with SMTP id ada2fe7eead31-6738b86eb96mr974309137.2.1779358401570; Thu, 21 May 2026 03:13:21 -0700 (PDT) Received: from arch ([186.195.35.248]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-5857361b267sm136686e0c.11.2026.05.21.03.13.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 03:13:20 -0700 (PDT) From: Luiz Carlos To: David Lin Cc: Johan Hovold , Alex Elder , Greg Kroah-Hartman , greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Luiz Carlos Subject: [PATCH v2] staging: greybus: uart: document locking and fix indentation Date: Thu, 21 May 2026 07:12:45 -0300 Message-ID: <20260521101245.5540-1-luizcarlosmdea@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <2026052154-spearmint-eleven-1121@gregkh> References: <2026052154-spearmint-eleven-1121@gregkh> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add comments describing what the lock fields in struct gb_tty protect, and fix the indentation of the wait_for_completion_timeout() call. Signed-off-by: Luiz Carlos --- drivers/staging/greybus/uart.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c index 7d060b4cd33d..85586e9a4341 100644 --- a/drivers/staging/greybus/uart.c +++ b/drivers/staging/greybus/uart.c @@ -50,12 +50,12 @@ struct gb_tty { unsigned int minor; unsigned char clocal; bool disconnected; - spinlock_t read_lock; - spinlock_t write_lock; + spinlock_t read_lock; /* protects iocount and oldcount for TIOCMIWAIT */ + spinlock_t write_lock; /* protects write_fifo and credits */ struct async_icount iocount; struct async_icount oldcount; wait_queue_head_t wioctl; - struct mutex mutex; + struct mutex mutex; /* protects disconnected during lookup and removal */ u8 ctrlin; /* input control lines */ u8 ctrlout; /* output control lines */ struct gb_uart_set_line_coding_request line_coding; @@ -318,7 +318,7 @@ static int gb_uart_wait_for_all_credits(struct gb_tty *= gb_tty) return 0; =20 ret =3D wait_for_completion_timeout(&gb_tty->credits_complete, - msecs_to_jiffies(GB_UART_CREDIT_WAIT_TIMEOUT_MSEC)); + msecs_to_jiffies(GB_UART_CREDIT_WAIT_TIMEOUT_MSEC)); if (!ret) { dev_err(&gb_tty->gbphy_dev->dev, "time out waiting for credits\n"); --=20 2.54.0