From nobody Sun May 24 21:40:05 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D53E1342CBA for ; Thu, 21 May 2026 07:19:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779347964; cv=none; b=CJftfxrUjud3stJmUuW0K6QGAgswMcZ+hNHLgdguzPFyaKTdHOuhrDXl0qyud9Wd0hTb+mSJxoddiw6+WGd2jbBy12hz2wU8oBlwUgegj0XHAnC3g2RJmcQ7Oi8wRvzENzh1IAZZ3QQeEYpp8PjDY4eDbqcLSFIVTOc4vSTQixY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779347964; c=relaxed/simple; bh=3NyQcX6UtkQinDdPKnEDpzF+Nwl4fBqZnu+f+acQlPs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JGenXhCnLTn1u47dFDXnMxgwEeg59SkKV677M84Ag4+vgglCUclEHw6qBWKVmqzAMHfxCyjP9YfhAVSOtMDrN5hLk+nHkW3ePXjFqfaNfI3xRU6LFgbs123BOi/4j7/hfY+6IdWX0yNsDTV+/nAVABan9+OZJntv/HhEekEz4g4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jYw1drq3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=EIIJVXTX; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jYw1drq3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="EIIJVXTX" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64L6LwUk1798400 for ; Thu, 21 May 2026 07:19:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=qcppdkim1; bh=nN956VWUpzaipasyvgQamUM/S2X7TTAO6ec b5GJgO9w=; b=jYw1drq37Aa8pNMI4dzSEE8mYokUb9i9XcsW2AJywqngw/X5t+x 9WAYNSboIZS+bK+L/ylJKwL64H3eyAD6fxq3oVp+LO8gmXKHSxc/pau1Y8ZDwMgE HYKoGf6BZS5jvRSiaK2SqYPdCseTZvDCn0T59kUVlneBMv69O5vqdcRamNTxylH8 7WeVdAHeEMQvqbnkdjrHNdyQA/D0QU2SuOs2r1EQp/JSCgI+Ur+m8zZT5unkp7rA P0HR/Ouu3U06sA2IthWJhcueLlvlmXEFZhvQIYmRqRMBtIH+cjp2bAtldXnt0SKV hnT1B2lfEEMshOXrX8sx9wCyeYNABKxgdhg== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e9dxu3q25-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 21 May 2026 07:19:22 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-366015bca9bso5170041a91.1 for ; Thu, 21 May 2026 00:19:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779347961; x=1779952761; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=nN956VWUpzaipasyvgQamUM/S2X7TTAO6ecb5GJgO9w=; b=EIIJVXTXQsot58o68W9dQeO2/j9JBjY7scZAULu/WUh5aqGuXqTQWwO4hhcQ6kWXee lqmknoku/rr2xOE52dhciqJ1PNdVm29dw5u2xh3Yoo9d5Au5q662bwDEB+LD0b7wPjfL I+tPcXCJSXb6L6KW6DSgqZqHbSPoQv2TwfHvm4Jv3tEW/7WYzNfQpssgoZa1YTK9qOql VdbY7jgGYudyEaU1EXTEcBddXNTRw8dd80ARQCuTsaMVB5TGyGTXvatrfYrxi++8X1o8 KYSkEzEuOW3DB/hXZ+KNrpYDR03xwxrLCpcVc7rl8L9TVrbiliW89WYSmTNg135j+xPE PFag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779347961; x=1779952761; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nN956VWUpzaipasyvgQamUM/S2X7TTAO6ecb5GJgO9w=; b=KFTzIKh0ytqikULfNCYTneT2rI7pstBDCI/ZCcr7G878lWoFWITCcki08MuDW6Izz9 pjU/LlADfJxzbl6JJsXgXYzqc5xSUbCAqa4AVwpJ+I9M6XKHMnTOA5CDFulxWeLly8UC Hr+HhX7uETJCmh98vdYcyasPvMrbk7rRbwqENqv6pKA9Zbj17mAcoGZ7su2MWxaFyLw/ AXpG9eCAM6nRNrhIJCJMzrqAcHma5ypOlamiMFvAjKV5ufE6b6G8JKWmymTLpy0nwoQ4 TxiQXyvO2JxydLq3QvbTnV0b9NasojUISQGOiGGO8gLn4Ciyc3AXvZeu+gnuzGs5EJMr v7Kw== X-Forwarded-Encrypted: i=1; AFNElJ+VgiLVm/SipqguRkN/HQDqyQWrY/R5q8RyyGCpDEQCDYKyLCfwcZEOjnEehH2+N2HfZsb4CP6QgWRufdI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw3KieMDrt3j6dYbcMJ3V5qrGhC/+rwO/ie4XaS7rAi5uvtcud4 mSTz4krAGm+szhTDMDZdRx44rZD/pbjUuuEyPgYb19K8mInLEHGXRn6/OsaDTwLiFOy8NNq1xdE LjdsQVKl3CAocsAu+rmsVR9tkXhtBcix+K5ntjQjq766KDgYsuAIR5GGq8zdQ1rbi6Pw= X-Gm-Gg: Acq92OF6GKoE2Hru6Ueo+0a7MbpUTtNlRlIQ3N6mDDiK5u+FSBoqMvkvun8PHbSapaW I+DR2oSS+NCie+CE8mCu5jUDHC7fqQ7oL7RpjVe6ix17PM6Fs4gexsCp7ugldu43fJ01mcbgqHN HEysdbCTNyoqmoaZ9arcxZA67YgimsvAbAWdVei5RYhQ+DzjAwG4fXns4Tsm8L7an5CzGoJTtec 1AoRvNXqJSFKSwbcWHUzGnctAa/w4/ESFmHif2urY+ZfQVtyDnoFCqs7mZr4w2eIvCSHtVrYFNl T100P7ek0/udmuXn/FA9fA8v50gA11oe3qIfPn7cpJPMXSE4pRB+L5maaCSQ5UjQS0S9qYy/Sao 67qzsu5OnNg6TYVeB/rNZGHHHNIBGPOnwwP8q9y4Rkg2XQlCssom6zpbuvA== X-Received: by 2002:a17:903:3bd0:b0:2ba:5f24:caeb with SMTP id d9443c01a7336-2bea229bfd5mr15735445ad.19.1779347961091; Thu, 21 May 2026 00:19:21 -0700 (PDT) X-Received: by 2002:a17:903:3bd0:b0:2ba:5f24:caeb with SMTP id d9443c01a7336-2bea229bfd5mr15734965ad.19.1779347960462; Thu, 21 May 2026 00:19:20 -0700 (PDT) Received: from work.lan ([2409:4091:a0f4:6806:ef8d:de79:6e34:4a35]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bea98eca29sm468475ad.41.2026.05.21.00.19.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 00:19:20 -0700 (PDT) From: Manivannan Sadhasivam To: lpieralisi@kernel.org, kwilczynski@kernel.org, mani@kernel.org, ryder.lee@mediatek.com, jianjun.wang@mediatek.com Cc: bhelgaas@google.com, robh@kernel.org, linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Manivannan Sadhasivam , stable@vger.kernel.org, Caleb James DeLisle Subject: [PATCH] PCI: mediatek: Free IRQ domains while freeing Root Ports Date: Thu, 21 May 2026 12:49:07 +0530 Message-ID: <20260521071907.13614-1-manivannan.sadhasivam@oss.qualcomm.com> X-Mailer: git-send-email 2.51.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIxMDA2OSBTYWx0ZWRfXzgSglRlztSGr aJlrgxo6AZPsaXE2blHPCnA5cGGb3Tl8nRvMZv9Lws/YECOwnA1VrVd0LDA+VZ0xQuyzzZiyyKD jme3aYi0jYGwsdV2Nbtiwv3xpFNJpWJLw9VLKyboN8Zi5aeqIKX6z2XR49in6HYxeUSKjWpByt4 HPGIyIfOx/9li1RQ4U5H8AODN3bM72euwNhHbJNxcS/qUmixtdot18HI7K7NLqa4XDyaJx4umSr GMvLlSwFnRtQ0YIao/qLrQTBg7uJYh/J4mdlY6C1u/2v8tRNAUcnnE87yDIf09k3a+aqPNDkxm0 wVe1N5tMUayJdJg+xqk+7bMMBwFE6xDFB8IO85GOvhtxffNgjT3iEIxqyEgbv+KNeC4SoSPHKdH q/gUsHHmicvbkzjx7cSHN+dcvHszjiqutZ6kwYIXa0JgBTWRKGglbaVioBdG51JiKn43EuvprKa UZMuqaziGslLH88okqg== X-Authority-Analysis: v=2.4 cv=Zckt8MVA c=1 sm=1 tr=0 ts=6a0eb1fa cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=xqWC_Br6kY4A:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=0GrS9vw-3MyE2OudUf0A:9 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: LKvp-5uNtbzMGnrXrRXvQ52NpLYpXX1d X-Proofpoint-ORIG-GUID: LKvp-5uNtbzMGnrXrRXvQ52NpLYpXX1d X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-20_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 priorityscore=1501 malwarescore=0 clxscore=1015 phishscore=0 bulkscore=0 lowpriorityscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605210069 Content-Type: text/plain; charset="utf-8" Currently, the driver frees the IRQ domains only during driver remove(). But when mtk_pcie_enable_port() fails for some reason, the domains are not freed. This leads to resource leakage. Hence, free the IRQ domains inside mtk_pcie_port_free() helper which gets called in the error path of mtk_pcie_enable_port() and also during driver removal. This issue was flagged by Sashiko when reviewing the EcoNet EN7528 SoC support series. Cc: stable@vger.kernel.org # 5.10 Cc: Caleb James DeLisle Fixes: b099631df160 ("PCI: mediatek: Add controller support for MT2712 and = MT7622") Signed-off-by: Manivannan Sadhasivam --- drivers/pci/controller/pcie-mediatek.c | 35 +++++++++++--------------- 1 file changed, 14 insertions(+), 21 deletions(-) diff --git a/drivers/pci/controller/pcie-mediatek.c b/drivers/pci/controlle= r/pcie-mediatek.c index c503fbd774d0..c45baf681cf5 100644 --- a/drivers/pci/controller/pcie-mediatek.c +++ b/drivers/pci/controller/pcie-mediatek.c @@ -250,6 +250,20 @@ static void mtk_pcie_port_free(struct mtk_pcie_port *p= ort) struct mtk_pcie *pcie =3D port->pcie; struct device *dev =3D pcie->dev; =20 + if (port->irq) { + irq_set_chained_handler_and_data(port->irq, NULL, NULL); + + if (port->irq_domain) + irq_domain_remove(port->irq_domain); + + if (IS_ENABLED(CONFIG_PCI_MSI)) { + if (port->inner_domain) + irq_domain_remove(port->inner_domain); + } + + irq_dispose_mapping(port->irq); + } + devm_iounmap(dev, port->base); list_del(&port->list); devm_kfree(dev, port); @@ -531,25 +545,6 @@ static void mtk_pcie_enable_msi(struct mtk_pcie_port *= port) writel(val, port->base + PCIE_INT_MASK); } =20 -static void mtk_pcie_irq_teardown(struct mtk_pcie *pcie) -{ - struct mtk_pcie_port *port, *tmp; - - list_for_each_entry_safe(port, tmp, &pcie->ports, list) { - irq_set_chained_handler_and_data(port->irq, NULL, NULL); - - if (port->irq_domain) - irq_domain_remove(port->irq_domain); - - if (IS_ENABLED(CONFIG_PCI_MSI)) { - if (port->inner_domain) - irq_domain_remove(port->inner_domain); - } - - irq_dispose_mapping(port->irq); - } -} - static int mtk_pcie_intx_map(struct irq_domain *domain, unsigned int irq, irq_hw_number_t hwirq) { @@ -1186,8 +1181,6 @@ static void mtk_pcie_remove(struct platform_device *p= dev) pci_remove_root_bus(host->bus); mtk_pcie_free_resources(pcie); =20 - mtk_pcie_irq_teardown(pcie); - mtk_pcie_put_resources(pcie); } =20 --=20 2.51.0