From nobody Sun May 24 21:39:32 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CC4935F172 for ; Thu, 21 May 2026 05:45:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779342351; cv=none; b=TQLd+NgoYLWc1OlkUCvLo2FC2LB0w8g7IEbOu4b+HUa/2xYP3eAVy1Sc98f12wI91i5Toef+uYU8Zme1LQXH4k8ahq8nyfC7FfhfOxaNl1Ksd2PpajQofLPagNK2dB4f9tVQbayCfxigME1JJpnabbzh4lVxll5evTijZ3pLp7Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779342351; c=relaxed/simple; bh=piLYdD9sfLzUWIAhuoTrNVSPwdPYc9JpO7ZO/zYiMIk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Sq9X3iE3LBXmK6FPeJJuJ8UWP0/aYxFdIVvcsVzvk1XbT2lzvJWdWQN7mWBkgmNgR9lU97wjzhpG0MUXdprR9Z9Xc7p9wos2r1tbXbjsXB+IAT0BCE/FftTWqE3goNSJfc0VOUvTAAqS+9P7GDgdiiJEJjE9GNEZy16uZiaF/rM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=TyumxlXq; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=i1+rXva+; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="TyumxlXq"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="i1+rXva+" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64L2SwVC3815917 for ; Thu, 21 May 2026 05:45:49 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=hmDUYWP981+ QEsAdC4yYWGwxCIUyaTrbIpAPDTEiCGc=; b=TyumxlXq0YuiU1vHhbZ3KhNYWdZ gUJ35ZvQyZ+isC3km2aRsmKlk3NkJ1DMCksumlahLciUmw1JntOwUie+ZiC2eVzw yFIiJHhshAMg3PqZgcQsdOYBpq0zK+nYdb31RX9qvCWrA7SM4krQsArdna/fAVNl bL4e3fKfm/7f1bUVSI0sLgYhMVuE0nWwJz5bMtvWkAEEvM9q7ZbyKFhb0f/KFl3A Hbr4y56PeERuDATqfnJxkWNuwbXJZGtlI4fqHhidCCVtGatCEBfwi4s/6StiIa+y rrHn2fZrGPMtT0C1jlg/6DH75UuQ8BZGpQh3tt4c3rb+BWlAlOSXOsyowIQ== Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e9saa0kfp-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 21 May 2026 05:45:49 +0000 (GMT) Received: by mail-pg1-f198.google.com with SMTP id 41be03b00d2f7-c802545ae0eso3614835a12.2 for ; Wed, 20 May 2026 22:45:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779342349; x=1779947149; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=hmDUYWP981+QEsAdC4yYWGwxCIUyaTrbIpAPDTEiCGc=; b=i1+rXva+SsxPEkppPyo2W3nrjUBj1vz9VIQlY2SfaJHqoJ1mVSlh3elYIXEROoHlmy IYG+H0830nQnK/G3rw3LdDGXsuBIh5H5Grufuze7HVjQnokMv0AOH+VnsCCuHSMeD8J7 Ffd4EqIf35ToB1Fugiu22skayee4uvHYHKA+FvSsh6oJo9CyWjesBxYtmXM32SFiEeon tBWGKKxNPwdYyL8fuAeaI7rIRzH6Uxx32whU4XgyWyhgeQ8g8/p/UTJZE8HFTpVIMN7c sIDqpJkXsn9C6DG8ehIbFHCh/73sIo4uUSBoq+5xICcNSYJDl8wbDyc/M5tzvcKIWcch SRrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779342349; x=1779947149; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=hmDUYWP981+QEsAdC4yYWGwxCIUyaTrbIpAPDTEiCGc=; b=ceHY7Lu5v+bpoOcMH+OWwnTO7Bgbreombh2UPuSZXh0jn3oNZUeS7C7hzNtj4ow6Mv 67tlVsumJDtfTVOqk1sO6vCetzxw6wht35tpbB9g/ZSXfXEXGUMLrmuEQ8cbEbpxG+lF FzL5Uc93thxUJ8rU6WrkFF3Y+Ob7Q83GFeDA/oKj1bsWA8Xs9Uz5rBiCqrjFGH+gLB5f AVrHBCu8QvLx0NHOWuyj1KOlavAS53wGrRf5oGcRZSL08NKbOddfzU7cMSm1cijWEUqw E7H81SxR3MS0G8u8+PHtI46RfB+Ys1EMDZpM7sFUkHDRP2yvo837g5KykCNk0Ge9GOAt qy9g== X-Forwarded-Encrypted: i=1; AFNElJ99xcq7rAqXO2rXLNOuiNT9oAv4QRPGPTBjn8g1v/EtYKWLW6bYKs4F9kGNY1KKStNEN5bCxmv6cxO3Ljk=@vger.kernel.org X-Gm-Message-State: AOJu0Yx/Crl9ZFUSFmu22p+xrUpT87ZiLEpphLSEymPN/l1LJT/lFwy6 AwcMYBdlG5eWu/1+hOzo+GfMGd4gEmWMnLBoAG1I08KiMS9TDS45y3KC/DIX6Zj7UeK9qi1qH+D VegaU5IW9/yk16evCQM+G7LIJjGcM+r1tRhF5KEW5Fy8zL8oOM/NxTRKPdeO+29Mtin0= X-Gm-Gg: Acq92OHkapA35OIsc5u/dtt07qBxy2dyDp5tP89vhwV1EsMil1fVnLiQUAho+zMySg2 UUe9RVHzw7I/CajEEtT0+L8n/q60NIoL2b6t+/ij45aW0+EgxwoNSNCl3cYlacPhBJ+07w1sD4k B3vhgjZbopFJHuhwobXHHgtG4l6VjAgNdiTJdHZvuFwU5LfiAfC8Wo8DecOg5p2HXoPDceBivOn K5TkGYXVmQuFRrQd65hXaB/O+lYjnbEdROqTO2zwU0gO/lITcU6RAP/yJQN3MVGsQUIYDzlFknP YGmJsGxZ0ZMT9I3uqWMfP2Qvv+XJCPyXIGKCSf0G6El2WbeFx1SB8cytHweoztJkJQ00N3Yj/I4 V4d1nFX0UFYgjUq+btl+RiXpLnWmFA6W3pEQXHUJ6wcZpqCdMQnBdPpDyWTVMLUX/ X-Received: by 2002:a17:90b:4ed0:b0:369:932a:2b8b with SMTP id 98e67ed59e1d1-36a451a6651mr1415906a91.11.1779342349015; Wed, 20 May 2026 22:45:49 -0700 (PDT) X-Received: by 2002:a17:90b:4ed0:b0:369:932a:2b8b with SMTP id 98e67ed59e1d1-36a451a6651mr1415881a91.11.1779342348496; Wed, 20 May 2026 22:45:48 -0700 (PDT) Received: from hu-ekangupt-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36a3cb323e3sm1474847a91.4.2026.05.20.22.45.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 22:45:48 -0700 (PDT) From: Ekansh Gupta To: srini@kernel.org, linux-arm-msm@vger.kernel.org Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, arnd@arndb.de, dmitry.baryshkov@oss.qualcomm.com Subject: [PATCH v12 1/4] misc: fastrpc: Move fdlist to invoke context structure Date: Thu, 21 May 2026 11:15:36 +0530 Message-Id: <20260521054539.128651-2-ekansh.gupta@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260521054539.128651-1-ekansh.gupta@oss.qualcomm.com> References: <20260521054539.128651-1-ekansh.gupta@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIxMDA1MiBTYWx0ZWRfX6J+xZeMJRvVW 2MnK+YCPMziNMAKxL4E//WD8oEQA2/23Q2MZmkyPnhGaZ3628pe1lvpat5KjPYhwSxAxkuXmGts ir3NyF9TAyOlOoiMqhYd1PTquXtPz4tivDOdYdBwdrj+kJS3ZXFqj/CE3+y5B8cjIXtlZ7Z7yBh XcL4FXWhr5naXecs9BVEAwulYAvUw2vOyWnGS4h1JKVRqJs57YBNCIVV091A3oWxU84670E1meF jPBa5K2HWBsxY+QBQP8ekNreCbIra66lOVhCHdTQNbSXPj/flxVW8wEd3AZua3e3zhMfwLuecL6 4PGKHOJ1U9TzUsrtRbAnA+t3NzWfhsfrlQSdFZVUQzjSvA9dlBylXO1ILtDLAr54Z5NWcMYQtBT SfCteNr0dun+GK0DTJYJg7P2YKW8XF6NZd3h8JlWJkcqOZGhQD8wly1r1k1v3wZi1agwUhrgdCn IrCjwqcmp6gHtKCd+wg== X-Authority-Analysis: v=2.4 cv=Qe9WeMbv c=1 sm=1 tr=0 ts=6a0e9c0d cx=c_pps a=Qgeoaf8Lrialg5Z894R3/Q==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=HL6mAI18knL3XnPGOeUA:9 a=x9snwWr2DeNwDh03kgHS:22 X-Proofpoint-ORIG-GUID: jhQU7gUV2uqBHC08ol8QRbuGtRch1AYH X-Proofpoint-GUID: jhQU7gUV2uqBHC08ol8QRbuGtRch1AYH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-20_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 phishscore=0 suspectscore=0 clxscore=1015 impostorscore=0 bulkscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605210052 Content-Type: text/plain; charset="utf-8" The fdlist is currently part of the meta buffer which is set during fastrpc_get_args(), this fdlist is getting recalculated during fastrpc_put_args(). Move fdlist to the invoke context structure to improve maintainability and reduce redundancy. This centralizes its handling and simplifies meta buffer preparation and reading logic. Reviewed-by: Dmitry Baryshkov Signed-off-by: Ekansh Gupta --- drivers/misc/fastrpc.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index 1080f9acf70a..a9f507a88c67 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -233,6 +233,7 @@ struct fastrpc_invoke_ctx { int pid; int client_id; u32 sc; + u64 *fdlist; u32 *crc; u64 ctxid; u64 msg_sz; @@ -1016,6 +1017,7 @@ static int fastrpc_get_args(u32 kernel, struct fastrp= c_invoke_ctx *ctx) rpra =3D ctx->buf->virt; list =3D fastrpc_invoke_buf_start(rpra, ctx->nscalars); pages =3D fastrpc_phy_page_start(list, ctx->nscalars); + ctx->fdlist =3D (u64 *)(pages + ctx->nscalars); args =3D (uintptr_t)ctx->buf->virt + metalen; rlen =3D pkt_size - metalen; ctx->rpra =3D rpra; @@ -1118,18 +1120,11 @@ static int fastrpc_put_args(struct fastrpc_invoke_c= tx *ctx, union fastrpc_remote_arg *rpra =3D ctx->rpra; struct fastrpc_user *fl =3D ctx->fl; struct fastrpc_map *mmap =3D NULL; - struct fastrpc_invoke_buf *list; - struct fastrpc_phy_page *pages; - u64 *fdlist; - int i, inbufs, outbufs, handles; + u64 *fdlist =3D ctx->fdlist; + int i, inbufs; int ret =3D 0; =20 inbufs =3D REMOTE_SCALARS_INBUFS(ctx->sc); - outbufs =3D REMOTE_SCALARS_OUTBUFS(ctx->sc); - handles =3D REMOTE_SCALARS_INHANDLES(ctx->sc) + REMOTE_SCALARS_OUTHANDLES= (ctx->sc); - list =3D fastrpc_invoke_buf_start(rpra, ctx->nscalars); - pages =3D fastrpc_phy_page_start(list, ctx->nscalars); - fdlist =3D (uint64_t *)(pages + inbufs + outbufs + handles); =20 for (i =3D inbufs; i < ctx->nbufs; ++i) { if (!ctx->maps[i]) { --=20 2.34.1 From nobody Sun May 24 21:39:32 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBC2633A9CF for ; Thu, 21 May 2026 05:45:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779342356; cv=none; b=WpPwk7RwtkU5WqbDsY2UuJqoGRetNt41FS2OQ4eQbzhJZ9O92JLBLR+ijDmaAc0c8YsJO8TkWK5gNGzJpsWMmbsCxRf4itNTyVkq0bCHnDQQJrPW/P7lTsSIHD52bPQpDgykeB+k/ewiTCV3aDw40XJDdWXJSAhPV+kaulAHtpk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779342356; c=relaxed/simple; bh=1ddE0U7h9weXbIaT7HOzewRICM+9yO0cSWfl91aUt5Y=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=O4k8Nhi4AM+XLwIn+m/Hex+jHzOAVeCUdDiibOfMf/ChmoOSZGKuMR8VH1MxhvleubQAiUwR9fjNg9A39OVcH9boGRHyoJSBRoEYKSjfOJimA8Ds0065ZVrzOab57Lk/1B5Rq2wB7dQADgmcFbuwFGlPwU7bmbxcw9FM1wcD0jk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZfwPBGFz; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=NXUw1FwJ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZfwPBGFz"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="NXUw1FwJ" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64KNAhHG963772 for ; Thu, 21 May 2026 05:45:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=JIaEBu2fXti OblnnO/rwwIoef8J83XO0Fyvu0X3nK9Q=; b=ZfwPBGFzxho5X5ZszEUmmAM3mJG 3nZGqVTg2yNReTyiPavbYj3iuf3xS4B7wur88ig2Hg/uKKmTVJYdk/bpMdUNIG6W lZTP3XntY2wIrIFI1IzNesbI6HEbJVXTjxq4RSLrE0acS7RRUWEzr0L5WMj4PBSS Bglm7/FWPBjSY2WDvLuEwT37DOm2xnZPSUT8OQV2z4E6a8qYzwEqc7s4EY0mg2Ak yF3ixCQIPtMs5DNVBE7YYFIMLiRGk7Kvg+5JE+1YPfcOEZ/QMt8XbT+BY3DrgfR6 bXP7Ho+6N8110kQquJiOa4s1qybiV6EM3j4sdTSyDpNRN/+47LVAGuPAm8w== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e9ejh37nm-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 21 May 2026 05:45:53 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b9fe2d6793so134918835ad.0 for ; Wed, 20 May 2026 22:45:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779342353; x=1779947153; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JIaEBu2fXtiOblnnO/rwwIoef8J83XO0Fyvu0X3nK9Q=; b=NXUw1FwJqMuzcuUSaXjfO7nCvz9NTmjjC/Xut+qdCLaSJ62IVPBMOAuQI7Xnq6WnEA pz78ixLultNJiehQDVHGMUeA1jTnqldFdUFoInaA9MU93UWxDXKkQJBeuqOnTiii1gcA uuVyeQa93Rg17MK/LUn6hyAEcWpR0ItiVUI9c/HIAzPP2k83JVzlpNPJ8XqyVt8AfsXV FCuRyuN7gFlBeCSM/Z5N177uxqhTMyVgEAxxGq8DrXje2E1w/Lpa1wzd1aIUQB4ViJpT TGejtkKUwuW4y4LM2lr4SmiSvsLDs+juGJAjaoGHlTTckscVoaV9vYelPgmP6JIJx8Ny yAFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779342353; x=1779947153; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=JIaEBu2fXtiOblnnO/rwwIoef8J83XO0Fyvu0X3nK9Q=; b=PPgwEf50u50Z2+SVD8n1gWj+HbJtXceNGCl2j+rkYPIKsWbCPQN5ki9QPsPxfh7qbQ 5PQwz86cvC/Z58/IWsK5T1a35LMeFiXQrzPjuFMCWVmeZD4h02Z9GevFXcNr/xfP2AvE XdCDn+P2d3zb+3duzGms94APxEJpmiJ6D3aDhIstmprFWQw8MT76az53daVXdqVw/Maa v5kmoA/PMAsK0qnNEUh9KFBCUlHkUfDX6a3bz0FJLDhgQzK1IccYdGah+FYz7YpXOl2b HaAifwLSgQ5mY+EgM9ME12WERCgX4wtc22NQZz8vOGxjlBQ/2Fe/I61C79HYzEHy4MZJ QMWw== X-Forwarded-Encrypted: i=1; AFNElJ+gqOYGMtQgyQHRtYjlNrwBZBms2Sjo5vJlNnyV4XcVxOaoUW04AqDp/wG45FU2zktHmC+4QyRd/8Fz3jQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/2zUUhBymTCedkK1R6f50FeHWqkIp+lzKzE7UJo7qp3X8M5cZ q639OT9YcXDnxMlOFrZuYxVJ8OWZzx4xtrHPIBJZC8xSG16xsHsWfJnbWzJTcN9FN1mjnSKVcYo YyAL97F697NltJf61IaHCY7yVVlJGeGbgc5BA/rVhJN5HbzxJsM//cOjXEXXeamhBQkE= X-Gm-Gg: Acq92OEX3WMqlIht4oc03X+fIfUPZPhgtpAEn2xFLeYAaNbtQB0FDYldjasEbhHUXal 1x+9UYAFqJ72UaJ7a4Xjf/OJ031/P/aU/jIyCz/D7wNc507iI0ty6zT7SS4Ow/gHQxVd93EvYvL V37tFlNGG0WwNkbYqSXSilYb1USm6Cj5S3zlMO+gULc/rYCMD1XjgcUMgCxElo0+6cZVjGbugiD Y0TzUTWfGi94iNrPQdxPS1ZHsVMFKUp6tgla6VOOSNPu2vK7YhMWtcXakZ1jY9/I1JO1oHeVu1i mtG1au/xTy+tpFmAK53ti9TugFVSR1EGAgxRTxPNXszaZiuVqmPs5SqtW3SVWsAUj/J9CMDv/zK 02a5KSHw+F1ASnCHA2RSQZP3PvZ/YQHEKVhKfkyH8n3GtCSbYZEbVZA== X-Received: by 2002:a17:90b:2f43:b0:35e:3e86:e2d1 with SMTP id 98e67ed59e1d1-36a451488fbmr1504405a91.7.1779342352873; Wed, 20 May 2026 22:45:52 -0700 (PDT) X-Received: by 2002:a17:90b:2f43:b0:35e:3e86:e2d1 with SMTP id 98e67ed59e1d1-36a451488fbmr1504375a91.7.1779342352434; Wed, 20 May 2026 22:45:52 -0700 (PDT) Received: from hu-ekangupt-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36a3cb323e3sm1474847a91.4.2026.05.20.22.45.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 22:45:52 -0700 (PDT) From: Ekansh Gupta To: srini@kernel.org, linux-arm-msm@vger.kernel.org Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, arnd@arndb.de, dmitry.baryshkov@oss.qualcomm.com, Konrad Dybcio Subject: [PATCH v12 2/4] misc: fastrpc: Replace hardcoded ctxid mask with GENMASK Date: Thu, 21 May 2026 11:15:37 +0530 Message-Id: <20260521054539.128651-3-ekansh.gupta@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260521054539.128651-1-ekansh.gupta@oss.qualcomm.com> References: <20260521054539.128651-1-ekansh.gupta@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=QptuG1yd c=1 sm=1 tr=0 ts=6a0e9c11 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=HL6mAI18knL3XnPGOeUA:9 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIxMDA1MiBTYWx0ZWRfX1VwHrLnt1zke KwyG8KKtRNvM/Y/v2F3z3mwE/+1aDfJz2lPweso1HX1TBQQWXE/rqY0pB4ZvuIVEpMzKZ1dZZyx 91Q2bpoxekF0e4Zs4n4APixYcQm3q8O80z4Y65sNjYZhnk+Jtm4X3ZSO6JoyP2f2Zj16zY+AaTy VJz0vFwv2Q1toXtjFAciSrDmmfXUHvC+ol/MOv9nqTN6uVzLkaP53+UEpisY06Bo6AfSTRGuQ/7 SXHA/RXLO013URZDk4a3FSLSJCeW39sNG0j9ZwWvZ/cOAePp4l3GSw8XQq8Asm5nvC3tA0acusE jJv3Uw670/m+WBsvsPnC/1N5IyRqhJupvdYTxIiPxzmdJrXFjL4+wGF+DjzEAhmwZpeXrSD9USY fDULI7e+3tUA2aSN24ufQy+Q75CnYabdTqT8RrWDWOLV1F7L74M6CdydFPEuqvgwMgmRm/E3Lwo 2LC+OHGk3g/+wdwBHEQ== X-Proofpoint-GUID: MxWrybGrIau2Ld3HKG4DOLt9fuu9GokS X-Proofpoint-ORIG-GUID: MxWrybGrIau2Ld3HKG4DOLt9fuu9GokS X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-20_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 bulkscore=0 lowpriorityscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 phishscore=0 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605210052 Content-Type: text/plain; charset="utf-8" Replace the hardcoded context ID mask (0xFF0) with GENMASK(11, 4) to improve readability and follow kernel bitfield conventions. Use FIELD_PREP and FIELD_GET instead of manual shifts for setting and extracting ctxid values. Reviewed-by: Konrad Dybcio Reviewed-by: Dmitry Baryshkov Signed-off-by: Ekansh Gupta --- drivers/misc/fastrpc.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index a9f507a88c67..3f5d5d73be5a 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -23,6 +23,7 @@ #include #include #include +#include =20 #define ADSP_DOMAIN_ID (0) #define MDSP_DOMAIN_ID (1) @@ -37,7 +38,7 @@ #define FASTRPC_CTX_MAX (256) #define FASTRPC_INIT_HANDLE 1 #define FASTRPC_DSP_UTILITIES_HANDLE 2 -#define FASTRPC_CTXID_MASK (0xFF0) +#define FASTRPC_CTXID_MASK GENMASK(11, 4) #define INIT_FILELEN_MAX (2 * 1024 * 1024) #define INIT_FILE_NAMELEN_MAX (128) #define FASTRPC_DEVICE_NAME "fastrpc" @@ -515,7 +516,7 @@ static void fastrpc_context_free(struct kref *ref) fastrpc_buf_free(ctx->buf); =20 spin_lock_irqsave(&cctx->lock, flags); - idr_remove(&cctx->ctx_idr, ctx->ctxid >> 4); + idr_remove(&cctx->ctx_idr, FIELD_GET(FASTRPC_CTXID_MASK, ctx->ctxid)); spin_unlock_irqrestore(&cctx->lock, flags); =20 kfree(ctx->maps); @@ -649,7 +650,7 @@ static struct fastrpc_invoke_ctx *fastrpc_context_alloc( spin_unlock_irqrestore(&cctx->lock, flags); goto err_idr; } - ctx->ctxid =3D ret << 4; + ctx->ctxid =3D FIELD_PREP(FASTRPC_CTXID_MASK, ret); spin_unlock_irqrestore(&cctx->lock, flags); =20 kref_init(&ctx->refcount); @@ -2508,7 +2509,7 @@ static int fastrpc_rpmsg_callback(struct rpmsg_device= *rpdev, void *data, if (len < sizeof(*rsp)) return -EINVAL; =20 - ctxid =3D ((rsp->ctx & FASTRPC_CTXID_MASK) >> 4); + ctxid =3D FIELD_GET(FASTRPC_CTXID_MASK, rsp->ctx); =20 spin_lock_irqsave(&cctx->lock, flags); ctx =3D idr_find(&cctx->ctx_idr, ctxid); --=20 2.34.1 From nobody Sun May 24 21:39:32 2026 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6BB43546D9 for ; Thu, 21 May 2026 05:45:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779342360; cv=none; b=AX4o4piE23A21NAva595ARllRTIZN2zf0YHvWQjUa8Zjd3v4Mk0Qd8Iq7u12pK6N5o6f+Rb2J2g2sOo8ThoIPsz3QPZyWryaALujQVu1lHwPBmioI3YBkeWOVFp0ML17whyvwE3tsBB94v0iDM5Tyc+w9hVVWn2gN3zW6B2L77E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779342360; c=relaxed/simple; bh=wLHY1YKwTOtJ5TMOu7Sc4w4rQ5+KEfPEjuD58JrY/gw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=h4AOj8N6I1YHN7w4/FH1SebtdhmbRPTZEg+/VqJ9Rkvks+PWPxPkzY6Rtm6wFtmHW220ZIhSTIGB2KXKF3Svm3SqcUCEj/831VOk/Dlbd8nRUVZhxWVf4icQi9agVjwSPqXE9e7tXddlPW8AQnCgbK+sBjwqXdLthnQpE3KoXyY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dpTzfy0M; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=QXlT3Ors; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dpTzfy0M"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="QXlT3Ors" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64L5h0UN3084906 for ; Thu, 21 May 2026 05:45:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=tFUu7w/Mdhl BRhU4Ur6TRUhTba4EbTByy053HqbjsgU=; b=dpTzfy0MDrYxCzoOjM4DFdgB0Ed 1h2kkQrHkhtDaZ7aHB/xRq7sNFWYXp3yZM9GAvrIi1PIIJBtzu3gNcNyMb3ynrRW dSlGwiNQki5fuw3PeQIeghZZg2OkI2w5nyFiB9gCOEcstRAVhm9miNYrLzI4gzOn EW+7vj4kQ1RkctB4Q1o21CJOXp6Ewj1a8QkrT9xEKztNQls5XAVpJAzDV0vipZ7V 8FwhobQs4Jp+IqDYND1fObtmGQhUMIMNJ7AhuRgZQJHA1yt8nVzcN9jO8qM6GPRe oCyImXXMCBKywCDa7IVvY5X8yI63R2rGvXgw98FLvJvZsOE+DT+JUzSGWvg== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e9c7f3sjr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 21 May 2026 05:45:57 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-36641bb3d97so3488124a91.3 for ; Wed, 20 May 2026 22:45:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779342357; x=1779947157; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tFUu7w/MdhlBRhU4Ur6TRUhTba4EbTByy053HqbjsgU=; b=QXlT3OrsaiavuzR4syVZVnFsC66DHl/7zAenb+6nJw6NEgouB0AMwpIV5yuUh3A0Vh DQQTU/Y288vS3HC8GycELk8AdALiO3DMEYbAu1er5vxXPPN4zsoPR0kiLxFpQfPX2+X8 FWbZ3zf1mjp1EJ4Jn5aSxBnFnGGKtapjAfKEVgIKuWYf98bpEWHr+MtHb1mpF5lAojoT i+5pARkNFt7Uex1BaLcfFJrExYlLsTdUg/nrhifxKJIIzCMKctOS7Ujf7nUGKd75AqiQ chO3AbzzQ/pgdIfEbrWHXwrTKwSm5MenapWi0M6J9wJvEiAcQ6TuEuLpV9O4XWklPp3/ wGKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779342357; x=1779947157; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=tFUu7w/MdhlBRhU4Ur6TRUhTba4EbTByy053HqbjsgU=; b=j9Vh1Z4vRMoybcspItxo0Bh64ZNHRuiw1pPRtjg6wKJcQoOqQi6ggh3iBQCLsZF3Ej pW+hULadWvuaatawfwu29eEsq6jYExm8qZAsnEA6gpmMQOz7EJPX7GTefIVjby7qn/SY QBwqAQ7fCabGhDMPFGC25irjN+v840tc3pVDJ1k9DIq6bGvx5eLosSryI5WCsC76wYwj 02EBag1G6B7LKQP0SAnkli+Yygm8FNWfRddyuSeCACZGDlEPJKhdYyvAV8rql2s0mvDy vHNvCCyLxEclysOqDruVOzJ6ARZ6UZ3wObB7MfB27Ds2xAJYq9e+inDO0N1foFwgG3Mb sCEA== X-Forwarded-Encrypted: i=1; AFNElJ9wJ4Jl25Qlkdi6vktRKk232G1Mc0np+xsSPksHNr8YcGkkmgJKnCo79WaDz238YbnuvXebc/SmDDUqrVw=@vger.kernel.org X-Gm-Message-State: AOJu0YxuLnS11L8CU1oCrUtRaquQ9VF5VKZuziZiLOuqB7fAM8IcSF/A v7V5pcjVxdlodtV1VbvIGWNZ0SzqghFG7HBZ7cnlrip6GcOO6tE+qBOg5aaa4XwOJoajLgZwR3k LD2uuFyS/gVf2r9yaC5KbaDYXK3kheKwhN7L7Ai2aZBAR0fwshdBRRI8cfroEn4fGJ9k= X-Gm-Gg: Acq92OHGspDg6QHukGjYT1XHQYu6UyB/HD5GmkoJoiNmcDYx3RvcA8fG3vVCijVm+lj TA6mlgvmrg7QN3+YC0hEIjnNBgr0dOI/BYk/zwPue6Q5H61lfB8/d83wBWcq8SIsb33xtRTwGTw nT0B2u79bXhHd4GXBhgsY3cwCotJ9uJ4NSEA0oDenzldtVc6W35LGTBOvbpllwe386pFwqvxqfH ELOmZ7Ilgo1n0lHnIQxq4a7YEG36xsfKaMZ5EyRRBAhcI9dN2QNzCtqEbAkC2pqQAuBLXt2Eu4V uOEok730jqb6qcBgG8EIFn/StoVXEEyL9vVm9mllsHqr/PaFcB9AQ0zkTSk0dS+Pn/EgL1vNYCL dBZEFDWtWxw2mAoRM2SBlu8t877VSzVNEHdQZVXXjfp//1qGiHCfikA== X-Received: by 2002:a17:90a:dfce:b0:369:a962:8cc1 with SMTP id 98e67ed59e1d1-36a45130fadmr1415880a91.2.1779342356654; Wed, 20 May 2026 22:45:56 -0700 (PDT) X-Received: by 2002:a17:90a:dfce:b0:369:a962:8cc1 with SMTP id 98e67ed59e1d1-36a45130fadmr1415857a91.2.1779342356200; Wed, 20 May 2026 22:45:56 -0700 (PDT) Received: from hu-ekangupt-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36a3cb323e3sm1474847a91.4.2026.05.20.22.45.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 22:45:55 -0700 (PDT) From: Ekansh Gupta To: srini@kernel.org, linux-arm-msm@vger.kernel.org Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, arnd@arndb.de, dmitry.baryshkov@oss.qualcomm.com Subject: [PATCH v12 3/4] misc: fastrpc: Expand context ID mask for DSP polling mode support Date: Thu, 21 May 2026 11:15:38 +0530 Message-Id: <20260521054539.128651-4-ekansh.gupta@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260521054539.128651-1-ekansh.gupta@oss.qualcomm.com> References: <20260521054539.128651-1-ekansh.gupta@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=c/ibhx9l c=1 sm=1 tr=0 ts=6a0e9c15 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=JTa3dIKMUYn8LlmgGFYA:9 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-GUID: FJ_EK4-Cp7cJ3-rXN1RiSpLMZaMrcKDo X-Proofpoint-ORIG-GUID: FJ_EK4-Cp7cJ3-rXN1RiSpLMZaMrcKDo X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIxMDA1MiBTYWx0ZWRfX2CpBR+5bx07F esQKackwSZn+Kk4izIS7OLf2R2dGaRpNJt6ddd/CdjL/AGyr7SVtQvAW0XXiN2q2IiuoWPvgxBr lqkjxvGKFqJjwYiJP8swaSDo3cMQkrhLyA9q4L5SKxwTypvUgn9tcQrQOFoYhzJ/Y45vH0sryMZ HhZ+yiHd4zRSgjutpo8hWt2843xPi1/7ttTftKQAeMxNS2lcy3T4NskUSFb0hHy2Pw6Go04g9ZF a/fhLKQLTyE1RZvVa7vQBCQXRI2cmCndwmJZ+gBpa45gc4Wq65siHquDkb+6J5prk6fQf+h8bKb XmjO92rPIzG30MpVohirL7TgHYkemcWivBJmieysE+MNCUgDE016IPmP8eCEdJXMyGlgbEtAY7B jfhStAm/3z34Z6dyP5dProkCK6uqwuzWTaQ24np6Dvj8s4lXaDuRICbtRVATlUVT4VsJqHum76J ddPocXzOXIn5Z3uwMtg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-20_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 spamscore=0 priorityscore=1501 phishscore=0 bulkscore=0 clxscore=1015 malwarescore=0 adultscore=0 suspectscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605210052 Content-Type: text/plain; charset="utf-8" Current FastRPC context uses a 12-bit mask: [ID(8 bits)][PD type(4 bits)] =3D GENMASK(11, 4) This works for normal calls but fails for DSP polling mode. Polling mode expects a 16-bit layout: [15:8] =3D context ID (8 bits) [7:5] =3D reserved [4] =3D async mode bit [3:0] =3D PD type (4 bits) If async bit (bit 4) is set, DSP disables polling. With current mask, odd IDs can set this bit, causing DSP to skip poll updates. Update FASTRPC_CTXID_MASK to GENMASK(15, 8) so IDs occupy upper byte and lower byte is left for DSP flags and PD type. Reserved bits remain unused. This change is compatible with polling mode and does not break non-polling behavior. Bit layout: [15:8] =3D CCCCCCCC (context ID) [7:5] =3D xxx (reserved) [4] =3D A (async mode) [3:0] =3D PPPP (PD type) Reviewed-by: Dmitry Baryshkov Signed-off-by: Ekansh Gupta --- drivers/misc/fastrpc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index 3f5d5d73be5a..c4a3547a5c7f 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -38,7 +38,7 @@ #define FASTRPC_CTX_MAX (256) #define FASTRPC_INIT_HANDLE 1 #define FASTRPC_DSP_UTILITIES_HANDLE 2 -#define FASTRPC_CTXID_MASK GENMASK(11, 4) +#define FASTRPC_CTXID_MASK GENMASK(15, 8) #define INIT_FILELEN_MAX (2 * 1024 * 1024) #define INIT_FILE_NAMELEN_MAX (128) #define FASTRPC_DEVICE_NAME "fastrpc" --=20 2.34.1 From nobody Sun May 24 21:39:32 2026 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24A7D332913 for ; Thu, 21 May 2026 05:46:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779342363; cv=none; b=biNxNEXQVIth4FyIGpZkLyrZX0k1v+5RZ5QnYS/wT9KEreDq7gyYojWGFu+AJ42IvZ6tC85SyYEHRVOv/AjVc0SBuY3b63CcWhQNARyzUEeberEXlyOB7sorFtwLxeaUBzbfj8a4UmD5RJh9P3H6Frz0+pnDXVUyiuPBo99Uv50= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779342363; c=relaxed/simple; bh=gAg4E1J+Stzmvgfs035XR4jZLx9mUr5n6oPruK7SS0o=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=tFWpmt9/NGjQqcdpQllqu+smpWO/HHZnnvdllulXgd18T05/TM2QKIS/AGHomtd7kL7OJwNLXEezE+7tGmJTwnPJLfEPpQJmm+8+17mtRa7XfJeKgXyJaVW7IhBDsI0VaVG4sAHB8HFT7dRYqZJd65Wtz+w5ZQwFsiiAcSs2Sms= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RtWSaYoN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ekPEn7Op; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RtWSaYoN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ekPEn7Op" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64KKldpW2157919 for ; Thu, 21 May 2026 05:46:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:date:from:in-reply-to:message-id :mime-version:references:subject:to; s=qcppdkim1; bh=in0dxS6n0Go rPPg0Z1EiapWwjJJdUyQdBupNhQkB8N8=; b=RtWSaYoNIUQ1RLnz3/2fmNXzFwl W2kIFcRMsCqK++jAW0/7Kjr5UPQ9uK/ZzX12BeK+5ramHYOT+Gr+9x+bIlMQfgnw Y98iw+0s3uqSjp5r5WF/bpVX1pPSFvSIGelvxLZmpfM5NNbl+3p7vdq6M9AnDhcV OOLbGQXf8HfyFASiupYcHk0Ek0uIIvVW+4+1VAJZQTvSDa2NI9DglPihRPtE+sB0 Mmc9Q5F1devxYB3ZxhGZaVc6W0mdmHVFsrMO+8Kw9F5BUvVq4MuiYNfAtWr2fI4T mLtc9XiOjO4TQw2mbCMV71qDyDsCydszXsSO9W4wnJSFZ7w6DBbxsX2WZuQ== Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e9ma41jwr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 21 May 2026 05:46:01 +0000 (GMT) Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-3663cbff31cso14262851a91.2 for ; Wed, 20 May 2026 22:46:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779342360; x=1779947160; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=in0dxS6n0GorPPg0Z1EiapWwjJJdUyQdBupNhQkB8N8=; b=ekPEn7OpHykdYs0yj81Z5twBF21bxIoluAyGcGWc/0hta3yVb7V1SdhdvX34VBLtJ6 usr8BmSQv4+HSF7C8Shv27UqrPdPoppmpvSw6NJhRAg+jjJ5U9ORdA2aDtz5A/RHiRkS YM4FuT03xlaRKKsvnuYpDHxbt5CpE/rz4GEOLJZ4xQh8jVxIE0V4Tj349pMpnv8grP/+ YuDkOoDxArH1ZLFTM2vGkmtmu1bYeqO0NTQj99LecCS0IHt/1opeLtwyBNrgrieLUyH2 hQtJNIcBtuMcA3Y9mLgC4FDK0zn1uqEJ4NfuhRASQwtW+s0lNDCjlRRjdbaTDvosqKMx 7JSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779342360; x=1779947160; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=in0dxS6n0GorPPg0Z1EiapWwjJJdUyQdBupNhQkB8N8=; b=alYW3O7Tj/SXZD/Tz9SGQRAP5pzRHT6zRYq/euy41Imy0PlN66CwbQrSORRYHD4LLn kuWPZxIqLD4PmoFbXEKRcB+5BGvyoRY7Tvf+XlhO5fftLT3xQaGPMXl986kfuqn2Hrfp gkiRM/f2e9/HFWVaPrhdtvgeplEsaPbCViKakKQYHWjG7ITSnJMCl9afiCjBh+H5YRc1 3eepZ8qwc8SB7mgYNTpjQLe4K3UqlIJXZfTZOb65c3R8BX/rPE9xRxOucpbN4pH70Bnr 1xQ9QLYYK6iHznbiFXfKRhs7SZPYp0sXWvIPkMKVvccOELro0heqHXLpDt3xRuzJAPGT PwHg== X-Forwarded-Encrypted: i=1; AFNElJ+0q9MO3zhp3OGvUZzxbxyP7BRjvFwnl+IZ81lmQ7G4l68WNURf+bhmPZB645WiZXYRenwLFp8cDOT0sZU=@vger.kernel.org X-Gm-Message-State: AOJu0YwYWOxHLnFe35a4kwvtdbgyHYQVxxKFIHydiltb5wtc5WcPpURO ow/f3uKzVtxpXUNKNLQvY1GmTvDi++Ki2EfmAM9nIdNE5on0p2t2H5LiuG7PdRzo1vaOLO+RfBo /uM6vZrF4bkusCK+Zr/ufscvDNJnRhudfjV3YC53vRuV3BVDcR/8gIIOkLUoUjzB6JnA= X-Gm-Gg: Acq92OERCbpWrgFWzfzpv3TOT9Wt+fi0PcmCUWvsuJttFVFJ/Ej+usoDaPx2Rersj0s WKhNVoLb71bHpVd+zR57pFmtrfjZpmQBPaTEn6LY4ky+cEwRPWnqs8Vr8c9gkAx16VVss+chTAG RwbXUJJuKPX5j/EqGajDU/oFNSBOt2ihXkqEtMH4lvcHoP3CZZPoVVmWdwtvXlmFPGQgAqptmqC LSRDIm4US1tIFCr5M0eqcqGwUZHucJ8+hKttpJQaR5TqAv9MW+2LaYPbukrVGVhiiGWOjudM+/Y r1wsGv3TIYotL1nfy5zkXnR9hNhNOq/ootgNopU1BFxpHVzvybXD9S8vzWKeUQny9Wk+dDtIRM1 ffYpd1aDj8BjEQglOM2xfPzyUdLv2hVvYgYX4CR+fb1idgfajqiHdxA== X-Received: by 2002:a17:90b:2c8d:b0:36a:2a9b:3fb2 with SMTP id 98e67ed59e1d1-36a45600421mr1467414a91.16.1779342360418; Wed, 20 May 2026 22:46:00 -0700 (PDT) X-Received: by 2002:a17:90b:2c8d:b0:36a:2a9b:3fb2 with SMTP id 98e67ed59e1d1-36a45600421mr1467396a91.16.1779342359955; Wed, 20 May 2026 22:45:59 -0700 (PDT) Received: from hu-ekangupt-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36a3cb323e3sm1474847a91.4.2026.05.20.22.45.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 22:45:59 -0700 (PDT) From: Ekansh Gupta To: srini@kernel.org, linux-arm-msm@vger.kernel.org Cc: gregkh@linuxfoundation.org, quic_bkumar@quicinc.com, linux-kernel@vger.kernel.org, quic_chennak@quicinc.com, dri-devel@lists.freedesktop.org, arnd@arndb.de, dmitry.baryshkov@oss.qualcomm.com Subject: [PATCH v12 4/4] misc: fastrpc: Add polling mode support for fastRPC driver Date: Thu, 21 May 2026 11:15:39 +0530 Message-Id: <20260521054539.128651-5-ekansh.gupta@oss.qualcomm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20260521054539.128651-1-ekansh.gupta@oss.qualcomm.com> References: <20260521054539.128651-1-ekansh.gupta@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Authority-Analysis: v=2.4 cv=K9kS2SWI c=1 sm=1 tr=0 ts=6a0e9c19 cx=c_pps a=UNFcQwm+pnOIJct1K4W+Mw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=Xak7btDuadOZULdqBEwA:9 a=uKXjsCUrEbL0IQVhDsJ9:22 X-Proofpoint-GUID: MefLghbTw-b0CBtIj0UWE10Ovng6h6Nf X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIxMDA1MiBTYWx0ZWRfX/flWJMHgQnSy sy0ByPsg/5e0EEeewNan2JCTy32XErgBJNS+PbNNp+vYrldPS3yef/i9T2b2jjNfKoI1ZI4mDm6 9jXl+QomhD4cHjrYfUAwO0pzEGS/Du9X/kg9imBsBdTmjYsmxmGW2SW/YPl9QndGPiYGt1r+Wwy y/8fEpji/99WsRLKdgJ9rH7oxOCr2nf8Q2Jrf+0jdAMWQWb3m0UjBYdqjdYcCLOf3z2ggopCIPK bJPj/E8qqlTT+nrLzhx2ohcaIi3wn1PB4ayvc09VRRQ0hTLWmRTuJa2NVDIHaDbN+wNk4N2Bizd K8Id0HVjkZ3BVBqqrLY3YADe4L/ghckTtndsMAViZ8bHuXKohAf6FG3nJrckjLJW+qmMAyLjTg2 GOm4mZicFg327daJ2ETGLYTmswDVPFkpKrIjoDrTa5aHoOCXyERaDH7WU3Ffxm4S1r/mNjGAM9K WnTFrSe3OENsau3dRKA== X-Proofpoint-ORIG-GUID: MefLghbTw-b0CBtIj0UWE10Ovng6h6Nf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-20_03,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 bulkscore=0 adultscore=0 priorityscore=1501 impostorscore=0 malwarescore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605210052 Content-Type: text/plain; charset="utf-8" For any remote call to DSP, after sending an invocation message, fastRPC driver waits for glink response and during this time the CPU can go into low power modes. This adds latency to overall fastrpc call as CPU wakeup and scheduling latencies are included. Add polling mode support with which fastRPC driver will poll continuously on a memory after sending a message to remote subsystem which will eliminate CPU wakeup and scheduling latencies and reduce fastRPC overhead. In case poll timeout happens, the call will fallback to normal RPC mode. Poll mode can be enabled by user by using FASTRPC_IOCTL_SET_OPTION ioctl request with FASTRPC_POLL_MODE request id. Signed-off-by: Ekansh Gupta --- drivers/misc/fastrpc.c | 167 ++++++++++++++++++++++++++++++++++-- include/uapi/misc/fastrpc.h | 29 +++++++ 2 files changed, 189 insertions(+), 7 deletions(-) diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c index c4a3547a5c7f..f0311395a686 100644 --- a/drivers/misc/fastrpc.c +++ b/drivers/misc/fastrpc.c @@ -24,6 +24,8 @@ #include #include #include +#include +#include =20 #define ADSP_DOMAIN_ID (0) #define MDSP_DOMAIN_ID (1) @@ -38,6 +40,12 @@ #define FASTRPC_CTX_MAX (256) #define FASTRPC_INIT_HANDLE 1 #define FASTRPC_DSP_UTILITIES_HANDLE 2 +/* + * Maximum handle value for static handles. + * Static handles are pre-defined, fixed numeric values statically assigned + * in the IDL file or FastRPC framework. + */ +#define FASTRPC_MAX_STATIC_HANDLE (20) #define FASTRPC_CTXID_MASK GENMASK(15, 8) #define INIT_FILELEN_MAX (2 * 1024 * 1024) #define INIT_FILE_NAMELEN_MAX (128) @@ -106,6 +114,12 @@ =20 #define miscdev_to_fdevice(d) container_of(d, struct fastrpc_device, miscd= ev) =20 +/* Poll response number from remote processor for call completion */ +#define FASTRPC_POLL_RESPONSE (0xdecaf) + +/* Polling mode timeout limit */ +#define FASTRPC_POLL_MAX_TIMEOUT_US (10000) + struct fastrpc_phy_page { dma_addr_t addr; /* dma address */ u64 size; /* size of contiguous region */ @@ -236,8 +250,14 @@ struct fastrpc_invoke_ctx { u32 sc; u64 *fdlist; u32 *crc; + /* Poll memory that DSP updates */ + u32 *poll_addr; u64 ctxid; u64 msg_sz; + /* work done status flag */ + bool is_work_done; + /* process updates poll memory instead of glink response */ + bool is_polled; struct kref refcount; struct list_head node; /* list of ctxs */ struct completion work; @@ -263,6 +283,7 @@ struct fastrpc_soc_data { u32 sid_pos; u32 dma_addr_bits_cdsp; u32 dma_addr_bits_default; + bool poll_mode_supported; }; =20 struct fastrpc_channel_ctx { @@ -285,6 +306,7 @@ struct fastrpc_channel_ctx { struct list_head invoke_interrupted_mmaps; bool secure; bool unsigned_support; + bool poll_mode_supported; u64 dma_mask; const struct fastrpc_soc_data *soc_data; }; @@ -308,6 +330,8 @@ struct fastrpc_user { int client_id; int pd; bool is_secure_dev; + /* Flags poll mode state */ + bool poll_mode; /* Lock for lists */ spinlock_t lock; /* lock for allocations */ @@ -923,7 +947,8 @@ static int fastrpc_get_meta_size(struct fastrpc_invoke_= ctx *ctx) sizeof(struct fastrpc_invoke_buf) + sizeof(struct fastrpc_phy_page)) * ctx->nscalars + sizeof(u64) * FASTRPC_MAX_FDLIST + - sizeof(u32) * FASTRPC_MAX_CRCLIST; + sizeof(u32) * FASTRPC_MAX_CRCLIST + + sizeof(u32); =20 return size; } @@ -1019,6 +1044,9 @@ static int fastrpc_get_args(u32 kernel, struct fastrp= c_invoke_ctx *ctx) list =3D fastrpc_invoke_buf_start(rpra, ctx->nscalars); pages =3D fastrpc_phy_page_start(list, ctx->nscalars); ctx->fdlist =3D (u64 *)(pages + ctx->nscalars); + ctx->poll_addr =3D (u32 *)((uintptr_t)ctx->fdlist + sizeof(u64) * FASTRPC= _MAX_FDLIST + + sizeof(u32) * FASTRPC_MAX_CRCLIST); + args =3D (uintptr_t)ctx->buf->virt + metalen; rlen =3D pkt_size - metalen; ctx->rpra =3D rpra; @@ -1188,6 +1216,71 @@ static int fastrpc_invoke_send(struct fastrpc_sessio= n_ctx *sctx, =20 } =20 +static u32 fastrpc_read_poll_addr(struct fastrpc_invoke_ctx *ctx) +{ + dma_rmb(); + return READ_ONCE(*ctx->poll_addr); +} + +static int poll_for_remote_response(struct fastrpc_invoke_ctx *ctx) +{ + u32 val; + int ret; + + /* + * Poll until DSP writes FASTRPC_POLL_RESPONSE into *ctx->poll_addr + * or until another path marks the work done. + */ + ret =3D read_poll_timeout_atomic(fastrpc_read_poll_addr, val, + (val =3D=3D FASTRPC_POLL_RESPONSE) || ctx->is_work_done, 1, + FASTRPC_POLL_MAX_TIMEOUT_US, false, ctx); + + if (!ret && val =3D=3D FASTRPC_POLL_RESPONSE) { + /* + * DSP writes FASTRPC_POLL_RESPONSE to signal successful + * completion via the poll path. + */ + ctx->is_work_done =3D true; + ctx->retval =3D 0; + } + + if (ret =3D=3D -ETIMEDOUT) + ret =3D -EIO; + + return ret; +} + +static inline int fastrpc_wait_for_response(struct fastrpc_invoke_ctx *ctx, + u32 kernel) +{ + int err =3D 0; + + if (kernel) { + if (!wait_for_completion_timeout(&ctx->work, 10 * HZ)) + err =3D -ETIMEDOUT; + } else { + err =3D wait_for_completion_interruptible(&ctx->work); + } + + return err; +} + +static int fastrpc_wait_for_completion(struct fastrpc_invoke_ctx *ctx, + u32 kernel) +{ + int err; + + if (ctx->is_polled) { + err =3D poll_for_remote_response(ctx); + if (!err) + return 0; + /* If polling timed out or failed, move to normal response mode */ + ctx->is_polled =3D false; + } + + return fastrpc_wait_for_response(ctx, kernel); +} + static int fastrpc_internal_invoke(struct fastrpc_user *fl, u32 kernel, u32 handle, u32 sc, struct fastrpc_invoke_args *args) @@ -1223,13 +1316,14 @@ static int fastrpc_internal_invoke(struct fastrpc_u= ser *fl, u32 kernel, if (err) goto bail; =20 - if (kernel) { - if (!wait_for_completion_timeout(&ctx->work, 10 * HZ)) - err =3D -ETIMEDOUT; - } else { - err =3D wait_for_completion_interruptible(&ctx->work); - } + /* + * Set message context as polled if the call is for a user PD + * dynamic module and user has enabled poll mode. + */ + if (handle > FASTRPC_MAX_STATIC_HANDLE && fl->pd =3D=3D USER_PD && fl->po= ll_mode) + ctx->is_polled =3D true; =20 + err =3D fastrpc_wait_for_completion(ctx, kernel); if (err) goto bail; =20 @@ -1813,6 +1907,35 @@ static int fastrpc_get_info_from_kernel(struct fastr= pc_ioctl_capability *cap, return 0; } =20 +static int fastrpc_set_option(struct fastrpc_user *fl, char __user *argp) +{ + struct fastrpc_ioctl_set_option opt =3D {0}; + int i; + + if (copy_from_user(&opt, argp, sizeof(opt))) + return -EFAULT; + + for (i =3D 0; i < ARRAY_SIZE(opt.reserved); i++) { + if (opt.reserved[i] !=3D 0) + return -EINVAL; + } + + if (opt.request_id !=3D FASTRPC_POLL_MODE) + return -EINVAL; + + if (!fl->cctx->poll_mode_supported) + return -EOPNOTSUPP; + + if (opt.value =3D=3D FASTRPC_POLL_MODE_ENABLE) + fl->poll_mode =3D true; + else if (opt.value =3D=3D FASTRPC_POLL_MODE_DISABLE) + fl->poll_mode =3D false; + else + return -EINVAL; + + return 0; +} + static int fastrpc_get_dsp_info(struct fastrpc_user *fl, char __user *argp) { struct fastrpc_ioctl_capability cap =3D {0}; @@ -2168,6 +2291,9 @@ static long fastrpc_device_ioctl(struct file *file, u= nsigned int cmd, case FASTRPC_IOCTL_MEM_UNMAP: err =3D fastrpc_req_mem_unmap(fl, argp); break; + case FASTRPC_IOCTL_SET_OPTION: + err =3D fastrpc_set_option(fl, argp); + break; case FASTRPC_IOCTL_GET_DSP_INFO: err =3D fastrpc_get_dsp_info(fl, argp); break; @@ -2323,6 +2449,7 @@ static const struct fastrpc_soc_data kaanapali_soc_da= ta =3D { .sid_pos =3D 56, .dma_addr_bits_cdsp =3D 34, .dma_addr_bits_default =3D 32, + .poll_mode_supported =3D true, }; =20 static const struct fastrpc_soc_data default_soc_data =3D { @@ -2331,6 +2458,29 @@ static const struct fastrpc_soc_data default_soc_dat= a =3D { .dma_addr_bits_default =3D 32, }; =20 +/* + * Exception list for older platforms that use default_soc_data but whose + * DSP firmware supports FastRPC polling mode. + * + * NOTE: This list is intentionally closed. + * Do NOT add new platforms here. New SoCs must advertise polling mode + * support via their soc_data. + */ + +static const struct of_device_id fastrpc_poll_supported_machines[] __maybe= _unused =3D { + { .compatible =3D "qcom,milos" }, + { .compatible =3D "qcom,qcs8300" }, + { .compatible =3D "qcom,sa8775p" }, + { .compatible =3D "qcom,sar2130p" }, + { .compatible =3D "qcom,sm8450" }, + { .compatible =3D "qcom,sm8550" }, + { .compatible =3D "qcom,sm8650" }, + { .compatible =3D "qcom,sm8750" }, + { .compatible =3D "qcom,x1e80100" }, + { .compatible =3D "qcom,x1p42100" }, + {}, +}; + static int fastrpc_rpmsg_probe(struct rpmsg_device *rpdev) { struct device *rdev =3D &rpdev->dev; @@ -2397,6 +2547,8 @@ static int fastrpc_rpmsg_probe(struct rpmsg_device *r= pdev) secure_dsp =3D !(of_property_read_bool(rdev->of_node, "qcom,non-secure-do= main")); data->secure =3D secure_dsp; data->soc_data =3D soc_data; + data->poll_mode_supported =3D soc_data->poll_mode_supported || + of_machine_get_match(fastrpc_poll_supported_machines); =20 switch (domain_id) { case ADSP_DOMAIN_ID: @@ -2521,6 +2673,7 @@ static int fastrpc_rpmsg_callback(struct rpmsg_device= *rpdev, void *data, } =20 ctx->retval =3D rsp->retval; + ctx->is_work_done =3D true; complete(&ctx->work); =20 /* diff --git a/include/uapi/misc/fastrpc.h b/include/uapi/misc/fastrpc.h index c6e2925f47e6..ba1ea5ed426c 100644 --- a/include/uapi/misc/fastrpc.h +++ b/include/uapi/misc/fastrpc.h @@ -16,6 +16,7 @@ #define FASTRPC_IOCTL_INIT_CREATE_STATIC _IOWR('R', 9, struct fastrpc_init= _create_static) #define FASTRPC_IOCTL_MEM_MAP _IOWR('R', 10, struct fastrpc_mem_map) #define FASTRPC_IOCTL_MEM_UNMAP _IOWR('R', 11, struct fastrpc_mem_unmap) +#define FASTRPC_IOCTL_SET_OPTION _IOWR('R', 12, struct fastrpc_ioctl_set_o= ption) #define FASTRPC_IOCTL_GET_DSP_INFO _IOWR('R', 13, struct fastrpc_ioctl_cap= ability) =20 /** @@ -67,6 +68,28 @@ enum fastrpc_proc_attr { /* Fastrpc attribute for memory protection of buffers */ #define FASTRPC_ATTR_SECUREMAP (1) =20 +/** + * FASTRPC_POLL_MODE - Enable/disable poll mode for FastRPC invocations + * + * Poll mode is an optimization that allows the CPU to poll shared memory + * for completion instead of waiting for an interrupt-based response. + * This reduces latency for fast-completing operations. + * + * Restrictions: + * - Only supported for USER_PD (User Protection Domain) + * - Only applies to dynamic modules (handle > 20) + * - Static modules always use interrupt-based completion + * + * Values: + * - 0: Disable poll mode (use interrupt-based completion) + * - 1: Enable poll mode (poll shared memory for completion) + */ +#define FASTRPC_POLL_MODE (1) + +/* Values for FASTRPC_POLL_MODE request */ +#define FASTRPC_POLL_MODE_DISABLE 0 +#define FASTRPC_POLL_MODE_ENABLE 1 + struct fastrpc_invoke_args { __u64 ptr; __u64 length; @@ -133,6 +156,12 @@ struct fastrpc_mem_unmap { __s32 reserved[5]; }; =20 +struct fastrpc_ioctl_set_option { + __u32 request_id; /* Request type (e.g., FASTRPC_POLL_MODE) */ + __u32 value; /* Request-specific value */ + __s32 reserved[6]; +}; + struct fastrpc_ioctl_capability { __u32 unused; /* deprecated, ignored by the kernel */ __u32 attribute_id; --=20 2.34.1