From nobody Sun May 24 21:39:30 2026 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 80C9735F5EC for ; Thu, 21 May 2026 03:16:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779333389; cv=none; b=OdDNET7cgdNGm1al1OP0FSSxPjxdEBEVW4dmb0+jMSLS70mFpVoyWCo0nmLBPUiw9gn+y0guHGOXD3np1d6aEQ20A9Nphb0CUOp3XgbJUCRFUHvqBXUe9jiX3bOr0MHHPOmYZVgW/neqOe2da/v7MG2/EphfbRUCInuVE8xxdJg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779333389; c=relaxed/simple; bh=myBNa2wH8gadvimyWgwBo2INIyCT8YWkv5QPeSr5zKM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Rz48C+ekQxlrytNwlbXPTvxT2UI8oJnJSn9uBquZjWD8kTdZ2V/zDvTjdkKB+SdSejrlkiVnCT5FhP3wjgerpLiXyHNEp8xZwsf9rzhNKksTSignZpkFUBG7rt3nhZ9Agx4X4+YYJTrmud/sEbPfHhvvqhESyd3DdS7PaQPU1dQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=YJz7TJ3S; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="YJz7TJ3S" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-2ba0fc8b1f0so38119745ad.3 for ; Wed, 20 May 2026 20:16:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779333385; x=1779938185; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=EKjh9nPNMD7rWtFqw8faB+5LtmT286jBIqF2tedz39g=; b=YJz7TJ3SLm9Rr+jnjemBeudaBcd3UOivpG/rmfBm2+d01UuInF8LHdxyHz2Cmi+/aZ cFYDtZcipoEFmDZI5pnZTDcLeejOT/EgGjm55ATZYxFa8tDEYfSGPi2MmM3yvVzjDOgS byUgELMEL20cCdsCA+rSn1JH69iaJOhAdPzhaqKJ/xVGAK4MEe1cBuTUMWh9Z6i+dGec YJ2WCMjHu6pOpQ1urEcpRWsIfPXM6GrXsiN3+dNnvapWQNlTdrlBtIxdXDnOJb/ja+Dm /yFJ/cltJDBSxnle3fxMKsEhuNcHhKoeF9rDcLdjrREN89wCNBilo/pq/7Mtb4xaRmzv 01kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779333385; x=1779938185; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=EKjh9nPNMD7rWtFqw8faB+5LtmT286jBIqF2tedz39g=; b=ZbaUBIfDoSu3Z4U5MTdl5xhPRCPB78+tX4CfvieBadqw1hTBSoDEPwvbvfC5QXpD8R Tf3IeWSfcRUfqsIQmOlqndPZ56B30y96mV3OyomuodxjTfAnsAw602TgbvvhVt5FRtMF Ac1yBTDJSYAdLxnjeg6BxABtNTLAT9uaI7ULIYcZFIGwMH+snXC8NURvpoKsnMHYex1t yWqQt99qrepOuEZF6/5q/qMhCQmJMcd8r9BmUEYmhcls9CrhUW29yNVVG9kxovxeQieY lOuztMdplAL7AIR53wn21CgNGtRw13aG3A01cQms3b+COeZm9ObwvVS4HrM+DQ1v1H04 ZAzg== X-Forwarded-Encrypted: i=1; AFNElJ/vnmPJ4Pqm3P0Sej32ukFqG+g5iQOi9o1n1r4fzNdA2QqUuMbb5AQYwwQ6m+LDV30mLbXAQyEU8va0Ugg=@vger.kernel.org X-Gm-Message-State: AOJu0Yyxj5NdIEC49mC+MJEZo62PxwLedEKgnnKGVl4V2ubFp5U9+iBP BvHe/EgdF1upPXqKewypGs96xDLkdwseaTmgTkMTltP3eyQw5Gh1UplWX8fPaMZiVhs= X-Gm-Gg: Acq92OGt08eU57XfJ1APZteOQQau+1mhmVSoivwHGtHWrcalOqJOCIFavPYtUtP5gS4 hknrctnH3RZy8+CWSjc3rVJ/tml2ik4xlssoJ+RSsJc5zAEyw5IwlCBY5W+8QHEwx8dm+6mnoiF 0JyTKzMbWUJarI9tiABKbG42P+hW2ejhWhisoL7v5f4VpB4wznYp6ThY7Ua4alT3habyuRDgH2y u/QRHsIiFAfVjw/4wFHZxMV3vhY+Uu/rDNksH55Wcs92SAoN+TmTM1hhPxGM1nlYS7heOoC0s0t avG2JyyRiPv3P+/YDxyC4Ed/AWRFrOY58PxdgApUZ1WdvacDf0iX0pzMTpv47Ir3Xl0QCezUWaZ bh1xnGiWb3/6w1xoWIbWyHpzrELdbyfk5r57gfSIINnnFScKn1N1Mkx4HxPgj8FpwSQWTkamF0s F6cY4CE4S3JzCUK7LlmpEAf64V73udrYwLhRNX4+OSI0jIlf5IruJzgrgSAFE= X-Received: by 2002:a17:902:ea06:b0:2bd:9067:58f with SMTP id d9443c01a7336-2bea304cfe3mr10136385ad.22.1779333384705; Wed, 20 May 2026 20:16:24 -0700 (PDT) Received: from qiwenjie-ThinkCentre-M760t.mioffice.cn ([43.224.245.241]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2bd5bd5fe44sm240471285ad.11.2026.05.20.20.16.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 20:16:24 -0700 (PDT) From: Wenjie Qi X-Google-Original-From: Wenjie Qi To: jaegeuk@kernel.org, chao@kernel.org Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, qiwenjie@xiaomi.com, qwjhust@gmail.com Subject: [PATCH] f2fs: validate compress cache inode only when enabled Date: Thu, 21 May 2026 11:16:18 +0800 Message-ID: <20260521031618.1734199-1-qiwenjie@xiaomi.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" F2FS_COMPRESS_INO() uses NM_I(sbi)->max_nid as the synthetic inode number for the compressed page cache inode. That inode only exists when the compress_cache mount option is enabled. When compress_cache is disabled, max_nid is outside the valid inode range. A corrupted directory entry that points to ino =3D=3D max_nid should therefore be rejected by f2fs_check_nid_range(). However, is_meta_ino() currently treats F2FS_COMPRESS_INO() as a meta inode unconditionally, so f2fs_iget() bypasses do_read_inode() and its nid range check, and instantiates a fake internal inode instead. Gate the compressed cache inode case on COMPRESS_CACHE, matching f2fs_init_compress_inode(). With compress_cache disabled, ino =3D=3D max_nid now follows the normal inode path and is rejected as an out-of-range nid. Fixes: 6ce19aff0b8c ("f2fs: compress: add compress_inode to cache compresse= d blocks") Signed-off-by: Wenjie Qi Reviewed-by: Chao Yu --- fs/f2fs/inode.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c index 12f982f87f1..c6623d70e28 100644 --- a/fs/f2fs/inode.c +++ b/fs/f2fs/inode.c @@ -564,8 +564,13 @@ static int do_read_inode(struct inode *inode) =20 static bool is_meta_ino(struct f2fs_sb_info *sbi, unsigned int ino) { - return ino =3D=3D F2FS_NODE_INO(sbi) || ino =3D=3D F2FS_META_INO(sbi) || - ino =3D=3D F2FS_COMPRESS_INO(sbi); + if (ino =3D=3D F2FS_NODE_INO(sbi) || ino =3D=3D F2FS_META_INO(sbi)) + return true; +#ifdef CONFIG_F2FS_FS_COMPRESSION + if (test_opt(sbi, COMPRESS_CACHE) && ino =3D=3D F2FS_COMPRESS_INO(sbi)) + return true; +#endif + return false; } =20 static void f2fs_mapping_set_large_folio(struct inode *inode) --=20 2.43.0