From nobody Sun May 24 22:33:50 2026 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D7A830B53E for ; Thu, 21 May 2026 01:42:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779327755; cv=none; b=MAlPTCcSwuELmulP4WtZYrsIZhsIIOIIZ39JRBSEs5bSVOD2bwAZik4K75SGUTKz/bH7XTYdoy0dexm35lR2gKBvWi7FsNsh0zdSANJooVcFP5x3d7EyVeEUYoHMqX2cwHiYke7AtGMwr1Zaram9xUhw0fqNLmauAS5WZH5rRgg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779327755; c=relaxed/simple; bh=6JoQIiAIGXqqZ0vwdOHhCj00rky64V9x71tQ6RgnMRY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=gFuAqtiKP7RAF9LAw5ryMS6Upil3T/l0AacPvjZbP2EWZFwRyCd11PUv5IDTR8xa8HkpM9smKR2kBXAZBemRdABUTTEKa9Omvaw8txXGBIznsBgYgHCESJDy4CWMXkpO2/xtsOmj9KUgo22Ok793yeSzDjvkArsZy7NE9qny1fM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ahX57yQc; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ahX57yQc" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-82f8b60e485so2320088b3a.0 for ; Wed, 20 May 2026 18:42:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779327748; x=1779932548; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FvAmAAUyg29fjUnqu9RUZPsKZgJ6HPQPiJ0VSPtg5Wk=; b=ahX57yQcW8++OL2hyFQ0cjTHmy77YVQHG6ZENvC9uk1ywVAcSkN9ifRiU2Cbn2bXKJ EspqkjzjsRVn5XwQPbmpGN+KQDTmfsr+qEkw7FG+9B6A8NG3EPIXJDGE+QBC4CfVxlf9 qRTDuUq+xM3uJipLhosx5BIqdpZGNahs4TgsMaT3Ei5qproWi7GUZILPCfAQxVfhpRh+ tyTd2iIImK23FwcimovZsbqt8aAEetNdvzKnje/BJ1NB/3VTtOMCU2rolV1gut2JriNJ cqzJHvAGwdcA+lFsjy3fqxtHJhBXcuxxNHCVYH44geGMZHqgNj15Bldjg0QeWVTndHVH 2lzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779327748; x=1779932548; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FvAmAAUyg29fjUnqu9RUZPsKZgJ6HPQPiJ0VSPtg5Wk=; b=b+tePx2CCqwsS0qC5xmmMCrb0Ln7NILh/h/ZPD5jRsKFi9mOgR2c1Csvg/QewzqBWp h8NWXTXI3PvO6NMq78mEw7fHsLrzVLdOUxZSUMtvT1PPxuyo7MYYDYKVZxAXkpvLSeGH I5uFuWCwhP9FKApgWRBPdpa7qUqNIwkl1T16D6V32GAwggR4sikxwsIUnn9BNYqZC29n 649EKqhgxN4BNIMHKSZJtU3soH7qPzLX5ucAoImvHOxz45gpaIE+VWjjac+joXHQTH4R Q8TR1h6Lm4WKdetxJlw5U+UtOl1wvfhQrhOWVi7YlWwQyLjt3dEw/fqzZNKJZqI3E5hO UHHw== X-Forwarded-Encrypted: i=1; AFNElJ/AVZDezRvdku61jyhrzL3RR7cwgUhlXpQk4psMDjUoSZNZ5pwCMXf1vewnHgnB324t1gk//6WeoQ1Myls=@vger.kernel.org X-Gm-Message-State: AOJu0YxJpo6U42fg7QlhcIQ1klilBoMckW+fuGYPUqBG9FL+7gjBFVVM U90jiWcM9j6ujhVCX+FdD0qNQn0Y92WPHn2gB8NI3CsJOr9OK+9pYu0I X-Gm-Gg: Acq92OEla+/UdB+EIutiQo9Y60HcOLpo53Zm47+JiDNhiWHteej35D3+6MVUAe2tlrM qnbI5g/afMNkkPaIdGVOqvPU4UUvyFa1vSO21FeUUNzFkg/KfnTPAS/5l+5cBzSdxqcxo6Rl9ic E9grJxsDZ+eel38+z8mmEdifC83UvQFF5DrUNv+IaurNqiwzJbUCWAbLta/IGP+YXxjbVCzR77X 1U1zPhjzvx9O48xOk3A9Vc1ricdveVuuAuKbpAzbTPbPCm/SEcHyNmMna6tJuYoboix6RXdAq/P dJTy6QgP8iFceLM7n3yNTqF/SSqpqDlhXsruSBmBTPVituDqHmmETiBYqi5oAtW0lTX1hyR0WH4 O61Y8xi5QuApq5cJH/ZNnF2SfIsraaO9uVJcnmmytpQnDCigvJed9LCCWa2vTSW0YudQMgkjXMa p/VC02dD4AeqrgPq3m0qQNtUtTubT5Vnwws6abw06tPiWa9PsAxX4WTdwyh2QMzyj9bQ0ml5FAj 9T8V+jLqkU+mBxtyg3JQC4= X-Received: by 2002:a05:6a00:950b:b0:835:405a:7e72 with SMTP id d2e1a72fcca58-8414ac97e9dmr829518b3a.11.1779327748515; Wed, 20 May 2026 18:42:28 -0700 (PDT) Received: from localhost.localdomain (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f19fa869esm26411475b3a.61.2026.05.20.18.42.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 18:42:28 -0700 (PDT) From: Joey Lu To: mturquette@baylibre.com, sboyd@kernel.org Cc: ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Joey Lu , Brian Masney Subject: [PATCH v3 1/3] clk: nuvoton: ma35d1: fix ignored div_u64 return values in PLL freq calculation Date: Thu, 21 May 2026 09:42:18 +0800 Message-ID: <20260521014220.77955-2-a0987203069@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260521014220.77955-1-a0987203069@gmail.com> References: <20260521014220.77955-1-a0987203069@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" div_u64() does not modify its argument in place; the return value must be assigned. Both ma35d1_calc_smic_pll_freq() and ma35d1_calc_pll_freq() called div_u64() and discarded the result, leaving pll_freq holding the undivided product and thus returning a frequency orders of magnitude too high. Fixes: 691521a367cf ("clk: nuvoton: Add clock driver for ma35d1 clock contr= oller") Reviewed-by: Brian Masney Signed-off-by: Joey Lu --- drivers/clk/nuvoton/clk-ma35d1-pll.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/nuvoton/clk-ma35d1-pll.c b/drivers/clk/nuvoton/clk= -ma35d1-pll.c index 4620acfe47e8..bfedd45bd04b 100644 --- a/drivers/clk/nuvoton/clk-ma35d1-pll.c +++ b/drivers/clk/nuvoton/clk-ma35d1-pll.c @@ -92,7 +92,7 @@ static unsigned long ma35d1_calc_smic_pll_freq(u32 pll0_c= tl0, p =3D FIELD_GET(SPLL0_CTL0_OUTDIV, pll0_ctl0); outdiv =3D 1 << p; pll_freq =3D (u64)parent_rate * n; - div_u64(pll_freq, m * outdiv); + pll_freq =3D div_u64(pll_freq, m * outdiv); return pll_freq; } =20 @@ -110,7 +110,7 @@ static unsigned long ma35d1_calc_pll_freq(u8 mode, u32 = *reg_ctl, unsigned long p =20 if (mode =3D=3D PLL_MODE_INT) { pll_freq =3D (u64)parent_rate * n; - div_u64(pll_freq, m * p); + pll_freq =3D div_u64(pll_freq, m * p); } else { x =3D FIELD_GET(PLL_CTL1_FRAC, reg_ctl[1]); /* 2 decimal places floating to integer (ex. 1.23 to 123) */ --=20 2.43.0 From nobody Sun May 24 22:33:50 2026 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C26D1264617 for ; Thu, 21 May 2026 01:42:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779327760; cv=none; b=bBIuISoZV4VA+DSidPSICANpgcr226osMuC6aYN9W5r+hcQHKfMMATmDASH/KycgTf1/tGhj/5Vb8JYLW8DVf992TBKDcSOgEVy5mbn598XHzuAPS7Q+qv/MSh03U++/4/h8j4EMbDtTqJ9J9QDNJayATP6jGilssmz+WRmZr2E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779327760; c=relaxed/simple; bh=y0eLfdlKOsnXKLcqHgoMoE6tZoZpJ5wRnAmYHP8/7DA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IfJK8HCoFR9ScDqLI2BzPqSSD4eaqAzCoRUqB3X05rSizLYk74+LQnlK6rZ4cPVifc7iBkzCynipYx+4gnJ3eYBxoVmEdnPxyAFYF/IITGdGNPV1poFUDPRNb7wevcFJnWO7/mDDexcmRNNQIlgs6U7QQ2I6IFJU1t817kIvYkI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=L1BK6VZx; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="L1BK6VZx" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-82f8893bff3so2551274b3a.2 for ; Wed, 20 May 2026 18:42:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779327751; x=1779932551; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XQHAOKYoNq3MrKqMcGhimP9jof0s1tqXQowtY/BWP0g=; b=L1BK6VZx19VgAMtp65r9FWnqF7rP1jOl0JYYjN+Tt4HRrum/ClJ3HCvDrXduYkNlnJ Dq0SPZazzpE4I33zmPGut+mglgPsfw0OfZkGADudCLd99wQPSOIQorITloL5L/tJkpkA m95kUIL8NhDdnuqjBg03MIQFdyC9W0osynyAI27cqYPr/Jajn0Mj2UB1vozz3GeDVC9e ULHpN/V48l4EIvXztKWeMOZx93edWx7kmqi9v4lr9CcIte/thtPK0fG5OgEMzo2kx+cL P7yph36LPIXwh8YibohcjJSe1dKzzj/K4oDW6ij+GJwKQ6KqMofry5fKyV2dWKALpag7 mRjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779327751; x=1779932551; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=XQHAOKYoNq3MrKqMcGhimP9jof0s1tqXQowtY/BWP0g=; b=KtaqJdJv42vQKeb4HaGKk+mFjZqOAEt4+abvgQyvBp2QB/V1OheKCVqDbm9ZwCSKjj XJ5DQqB0ioUC89vWHdV+QK5s9glbH1SoY+/kFxaYYUB0OC6E6QnnL4ovdv+GcaGVLtzo z0lYJDo/X4oAb5p67Dp7eI7HBGoHC7p0v5t10MWpIkv5foPjua+uPrYpmzW/Br2d3+sS QwbUsupi/51cLtHUBPOsK/mePNbJvqfp0sYlFcG07dATz/WaePpjljMfO6ol/NFvsBKb LHmkVwMG9/pwB0rqPcXiuD9DM6HG79WeDghQLhCOnSimdmaH99AOR5347nsfQ88pPdyV YB0w== X-Forwarded-Encrypted: i=1; AFNElJ/CoXsSx35e01CpkMrLXOXgUf/l/1mVrT6LQl4dAGit7A4VOvbcR8N0rSCUJYRZRBGB6kdMc0oIkDLLgIE=@vger.kernel.org X-Gm-Message-State: AOJu0YxxKn3djpHQvGfACM7rLk4qUvS0ofO1kdFzxEyrI314s9M/MEib /+qM9RRyVH/GW7dsSuMvF06FxFO9xwN12elFelAHJgOm4DncQMbL6Gi5 X-Gm-Gg: Acq92OGghex/QAW1eMy10rvLYF8w6Dr9jR0BnVH6H13i9rQm4MqOv92ifSbABSrmn9l mFRrxeiS9hiRFI+M34iWxv7EMTDofdOLYSWZlD6k0opEPpKAIat9tnVcsqx5D+tN1Z5WL+L2IQs 6grixv0+tyVJje9qG49RPXR2n6i4yTGt3m29tJN93esyaapl93U+jYNw2HhfxS6fboazSbiE5tW rtkNj5FELqsta6JJDbfLjrYjTZtllcWnNy8s66tRB/fAJx1RNfe8odJJUWx+rB5VM3m+3ayaDP/ wq9KmG/sXM+uOl70reQIWs79Oaej3kEbPvJ9aAfyOadlZzPty+ozsz1sk8vIT7zuC01f2g8vjbV OZ34ttdQtsy7LA1fKGiBRWdrB+pXM/mBhURC7umKdumKAlHv8gpBQYePdB7mHsvA0ZjHDdLxFdb 0zKaYAkJG65c5ctz0FZOcMWnBnqzct4IiPD/jfHNBgdGSaJtGUXjEvVGqnx/zHe1osa/wPEslsI kl45iP9qASG X-Received: by 2002:a05:6a00:2e9e:b0:82f:61f5:1d7 with SMTP id d2e1a72fcca58-8414ade9c4dmr784283b3a.25.1779327750726; Wed, 20 May 2026 18:42:30 -0700 (PDT) Received: from localhost.localdomain (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f19fa869esm26411475b3a.61.2026.05.20.18.42.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 18:42:30 -0700 (PDT) From: Joey Lu To: mturquette@baylibre.com, sboyd@kernel.org Cc: ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Joey Lu Subject: [PATCH v3 2/3] clk: nuvoton: ma35d1: fix PLL_CTL1_FRAC bit field width and fractional calc Date: Thu, 21 May 2026 09:42:19 +0800 Message-ID: <20260521014220.77955-3-a0987203069@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260521014220.77955-1-a0987203069@gmail.com> References: <20260521014220.77955-1-a0987203069@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" PLL_CTL1_FRAC was defined as GENMASK(31, 24), covering only 8 bits. The hardware fractional field occupies bits [31:8] (24 bits), so the mask must be GENMASK(31, 8). The previous fractional-mode calculation used FIELD_MAX(PLL_CTL1_FRAC) as the denominator to obtain 2 decimal places. With the corrected 24-bit mask the old divisor is wrong; replace the arithmetic with a proper 24-bit fixed-point rounding to 3 decimal places using the kernel's DIV_ROUND_CLOSEST_ULL helper: n_frac =3D n * 1000 + DIV_ROUND_CLOSEST_ULL(x * 1000, 1 << 24) Fixes: 691521a367cf ("clk: nuvoton: Add clock driver for ma35d1 clock contr= oller") Signed-off-by: Joey Lu --- drivers/clk/nuvoton/clk-ma35d1-pll.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/clk/nuvoton/clk-ma35d1-pll.c b/drivers/clk/nuvoton/clk= -ma35d1-pll.c index bfedd45bd04b..eb9d69d2077b 100644 --- a/drivers/clk/nuvoton/clk-ma35d1-pll.c +++ b/drivers/clk/nuvoton/clk-ma35d1-pll.c @@ -48,7 +48,7 @@ #define PLL_CTL1_PD BIT(0) #define PLL_CTL1_BP BIT(1) #define PLL_CTL1_OUTDIV GENMASK(6, 4) -#define PLL_CTL1_FRAC GENMASK(31, 24) +#define PLL_CTL1_FRAC GENMASK(31, 8) #define PLL_CTL2_SLOPE GENMASK(23, 0) =20 #define INDIV_MIN 1 @@ -113,9 +113,9 @@ static unsigned long ma35d1_calc_pll_freq(u8 mode, u32 = *reg_ctl, unsigned long p pll_freq =3D div_u64(pll_freq, m * p); } else { x =3D FIELD_GET(PLL_CTL1_FRAC, reg_ctl[1]); - /* 2 decimal places floating to integer (ex. 1.23 to 123) */ - n =3D n * 100 + ((x * 100) / FIELD_MAX(PLL_CTL1_FRAC)); - pll_freq =3D div_u64(parent_rate * n, 100 * m * p); + /* convert 24-bit fraction to 3 decimal digits, rounding to closest */ + n =3D n * 1000 + DIV_ROUND_CLOSEST_ULL((u64)x * 1000, 1ULL << 24); + pll_freq =3D div_u64((u64)parent_rate * n, 1000 * m * p); } return pll_freq; } --=20 2.43.0 From nobody Sun May 24 22:33:50 2026 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19F6E306779 for ; Thu, 21 May 2026 01:42:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779327763; cv=none; b=CvpNNigyTQvHJslheCSQ/Y+yDXdaop7B51g4DKiYRuYOP5wePSajgM0NGDajud0lZ/w5b7WV5PdBJ62L91QUMI+0bL2mXrNYOVGvRtAvfZjKFRKBT8M1rmVrta20yj+Sm/iSBkCosLXHl+yq7T77anHanc9u2148l2wYvTIpZ/g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779327763; c=relaxed/simple; bh=3QjoFwvYtFGSj7HucuLDgEEIU1vwshWyt15pjIaKNU4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=CYO/TISQkcDyU2+JDbSAOs696c+Qd6AQWQc2CKcXMM7hV9YNA54SkYuy5H87iU70zbY+6NdU6b8ZY6m/SeDo5hSKLuFP2u3aw8dVj/SRVrOc3GkLYVB6XY8uDB8+ABlDKPMvUaF9EetpRLLCd2Tsv1cljfF4fNlb111MBpFVUYs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=irKk8JrO; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="irKk8JrO" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-82fbf5d4dc2so3862245b3a.1 for ; Wed, 20 May 2026 18:42:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779327753; x=1779932553; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xBzG8ZBOhqwEqdTqOTAwTbc1kw7Fn4SE9BojLVsipUQ=; b=irKk8JrO0IjqURTeLF/UrOvY4U8X/hWJHG/39evelLl8UUYcrkPCC/UA6WU/pKh+pO qmE0P5EoeJtKCrlibuIqDdxwP9DhzVC6v+jTI+vSBX4+A9TVrKSh1S6T5yl/Jfv8jNcN f5SCBoKqKlKu2Hmb7DZaiJGiUesRaPB5bFV75uYvp0MV4MzId5bQJ/T38u7jVBFXeUT/ VQ/j+yF/K7MaWJazBSFjgqD56vuTyCrnSgp4KiLcK5J7ZCgdjlP7267Cn/iBqFT3uwZS kqbMMdzzhsYCkas7vQ+xok0bjgfNI9aOlGr1KSgb3gRvIm8DCetGHNJyeSlzIjh5JTYs WGHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779327753; x=1779932553; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xBzG8ZBOhqwEqdTqOTAwTbc1kw7Fn4SE9BojLVsipUQ=; b=MkBk/dzoRi0vugZdnPs6elHa1OxNO/2AwNkOcxcdxCLk4ZfmGi8pnUMlReTiFfYE+z oeFzXZw7p+uQ3RhaQDi40tzLuNUFY0IqPWG5IaIB59bOtEet/nYTzGjHj2ipUqoQ4w4a CGetloe9xNudHjpQ1E87Dm/hD0cdkv2n6uZYJDl6QjLwwr4Z6WtWM3mFrPkL5SwwUTev /JtQ10EbLz4GDDzRNWacKtDbI+Nq1AIFFiWqjwA4UnDD16WrKL14UrNlDxS7UgkkYDXW s+65EgNrf3fiKPqAmSW/RpAQs08kBoylwLQd8O5GVSxh1p0nrWzigAv7LduuEOnhKbRk +u8Q== X-Forwarded-Encrypted: i=1; AFNElJ9C1nL2Ic6Wgvi0x3yguMNKmZqEcPKvp6nOGMBAGT/k5G60PsdOgRQWFPjeiCJbpqAdBvTf1xMvLaTa8Qc=@vger.kernel.org X-Gm-Message-State: AOJu0YxmiDX1sjfWZ0C38NuANRDD7zZIcAtmszeUMNmlWKuTnrnz9kav PxaxxG81BEIkP5RgX2sTlyBN03txon30l26LvaJcFs66ItSB520vKfRt X-Gm-Gg: Acq92OGA5ITWm74dho/RiTUg/SYbp2AovFvuut45DKt8TcS5t3N/0MRDx4ZLp343uoK jEdHtzH/T1PyxNsQsS8Qb4HAftv3kZ2uQt5JsgWs+jztpO54PUSLgK7a8KuRNKinzdpdklptlCy 2A7iC70s/HbFO+24+tfcjl1tQ70idu8uYHzjw1TPqjBC6qsYgJlK2y1RZowzyPVdNtSUBM5w7eN zsz9o+RWbCQHgW+7aLf7AUqrIAA7hhSukc6/C0Kv0IlguzbZb1oaB7fKC+/mYQEyTrLX7SMLpM1 BhXlhqH/Vuqhkp9fEodOEGqoiL6N2PxcoAaz1Z/DOZLSmzwdBmP5KN4zAcZ4vPmZgBF94rzNPPK kdcmbwf8UtXPY1dADB87r1xGXHmYaBXFoK1ERE2O0KFHGSF5H+EKu3GxzfnGEnnEdQnPV3JW4mX r2tedpoeR1/AVuJ1lgJ4KWDWHSC/aNBNEaZlEPzBod+x0QizMHS3HkhsAdHxeUGPhi6gAVnHfA/ WyyXVBMVL2a X-Received: by 2002:a05:6a00:94fe:b0:83e:d996:92fa with SMTP id d2e1a72fcca58-8414acbacc9mr918900b3a.11.1779327752983; Wed, 20 May 2026 18:42:32 -0700 (PDT) Received: from localhost.localdomain (60-250-196-139.hinet-ip.hinet.net. [60.250.196.139]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f19fa869esm26411475b3a.61.2026.05.20.18.42.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 18:42:32 -0700 (PDT) From: Joey Lu To: mturquette@baylibre.com, sboyd@kernel.org Cc: ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Joey Lu Subject: [PATCH v3 3/3] clk: nuvoton: ma35d1: fix ma35d1_clk_pll_determine_rate logic Date: Thu, 21 May 2026 09:42:20 +0800 Message-ID: <20260521014220.77955-4-a0987203069@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260521014220.77955-1-a0987203069@gmail.com> References: <20260521014220.77955-1-a0987203069@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ma35d1_clk_pll_determine_rate() called ma35d1_pll_find_closest() unconditionally before the switch statement, and then every case branch overwrote pll_freq by reading the current hardware registers. For CAPLL and DDRPLL this means find_closest() ran unnecessarily (and incorrectly, since those PLLs are read-only) and its result was silently discarded. Fix by moving the find_closest() call inside the APLL/EPLL/VPLL branch where it belongs. Group CAPLL and DDRPLL together as read-only PLLs that simply report their current rate; handle them with an explicit if/else to keep the CAPLL (SMIC design) and DDRPLL (standard design) paths distinct. Fixes: 691521a367cf ("clk: nuvoton: Add clock driver for ma35d1 clock contr= oller") Signed-off-by: Joey Lu --- drivers/clk/nuvoton/clk-ma35d1-pll.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/clk/nuvoton/clk-ma35d1-pll.c b/drivers/clk/nuvoton/clk= -ma35d1-pll.c index eb9d69d2077b..c7c0dc91a012 100644 --- a/drivers/clk/nuvoton/clk-ma35d1-pll.c +++ b/drivers/clk/nuvoton/clk-ma35d1-pll.c @@ -255,32 +255,32 @@ static int ma35d1_clk_pll_determine_rate(struct clk_h= w *hw, if (req->best_parent_rate < PLL_FREF_MIN_FREQ || req->best_parent_rate > = PLL_FREF_MAX_FREQ) return -EINVAL; =20 - ret =3D ma35d1_pll_find_closest(pll, req->rate, req->best_parent_rate, - reg_ctl, &pll_freq); - if (ret < 0) - return ret; - switch (pll->id) { case CAPLL: + case DDRPLL: + /* Read-only PLLs: return current rate */ reg_ctl[0] =3D readl_relaxed(pll->ctl0_base); - pll_freq =3D ma35d1_calc_smic_pll_freq(reg_ctl[0], req->best_parent_rate= ); + if (pll->id =3D=3D CAPLL) { + pll_freq =3D ma35d1_calc_smic_pll_freq(reg_ctl[0], req->best_parent_rat= e); + } else { + reg_ctl[1] =3D readl_relaxed(pll->ctl1_base); + pll_freq =3D ma35d1_calc_pll_freq(pll->mode, reg_ctl, req->best_parent_= rate); + } req->rate =3D pll_freq; - return 0; - case DDRPLL: case APLL: case EPLL: case VPLL: - reg_ctl[0] =3D readl_relaxed(pll->ctl0_base); - reg_ctl[1] =3D readl_relaxed(pll->ctl1_base); - pll_freq =3D ma35d1_calc_pll_freq(pll->mode, reg_ctl, req->best_parent_r= ate); + /* Configurable PLLs: find closest achievable rate */ + ret =3D ma35d1_pll_find_closest(pll, req->rate, req->best_parent_rate, + reg_ctl, &pll_freq); + if (ret < 0) + return ret; req->rate =3D pll_freq; - return 0; } =20 req->rate =3D 0; - return 0; } =20 --=20 2.43.0