From nobody Sun May 24 20:37:34 2026 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4BD7127144B; Thu, 21 May 2026 16:32:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779381168; cv=none; b=ePejU64Vz/9205XYsTIRq8Mri2f5kwjISEULEjRkzVkEfrlM7aWLOWdPaHTimeOw5ASxgZa01ghQOr1vVj3EVEMJ504zFrGHRA7KlgJHYScBujYpd9aLI2/yQbjqk7P+WflGR2xJ9MDf5pAwdNHZ/YQQmePALCGRMktgLKmtuDc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779381168; c=relaxed/simple; bh=z3v6YO+0Wv56+AsTvqL7AMaNeB9qSJnJg6uwyLqlCXQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=Org022fU10gJ2UQsn+cFkaSZBWODbnLMynu30jdw1yFaV3SbCkWbzoMPIIKHzF3kQPi2T2BDrkP/eGMTDnAusnqqn9nOzhI6xul5fkHMvjHzcU5Nb60rWAi8yoZ2yULd8JECfYa/XV+mKsA5SD43nI2MKCyz9NCkDpdOwNrixbs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LT8oEfb9; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LT8oEfb9" Received: by smtp.kernel.org (Postfix) with ESMTPS id CD768C2BCB4; Thu, 21 May 2026 16:32:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779381167; bh=z3v6YO+0Wv56+AsTvqL7AMaNeB9qSJnJg6uwyLqlCXQ=; h=From:Date:Subject:To:Cc:Reply-To:From; b=LT8oEfb9sI945gIfNB7Ll7i8odp/msHWe6c1V0v2SbCfPy5l4EAQkotx9Dudz3bCO fcaL6onQCErdJZQZqWTUEWnnLvItCuEXY4JKKGHgDvP/6p7Kv8wYi8pygIxfewy/UN PRJxNY8Dg1L8s/Vm1k+sWUfY4NqicvnoUBTb7w1DhfPK5hQ8EEhRfpl+h6xX3m1P/I VlqWHbBJ0Nwwot6a1Y+t0ZRbE1Znq9c+rJtvCgElNglIic8at5gZ2kGjs4KsIgilrk 2obsJiYVWJzQPCyJPoH29Y/a9rfGMQOBVcXLE1UodFW44w+c0ASPjhVNoLxSDxnsjc fhYSuNK2oa8Rw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id C320CCD5BAF; Thu, 21 May 2026 16:32:47 +0000 (UTC) From: Abid Ali via B4 Relay Date: Thu, 21 May 2026 16:32:46 +0000 Subject: [PATCH v2] net: stmmac: mmc: Remove duplicate mmc_rx crc Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260521-xgmac-mmc_rx_crc-cleanup-v2-1-7d9de09f5898@gmail.com> X-B4-Tracking: v=1; b=H4sIAK0zD2oC/42NUQ6CMBBEr0L67RpaAoJf3sMQsq5b2IQCaZVgS O9u5QR+vsnMm10F9sJBXbNdeV4lyDwlMKdM0YBTzyDPxMrkpspLk8PWOyRwjjq/deQJaGSc3gu gJcbKItb4UGm+eLayHep7m3iQ8Jr953ha9S/9Q7pq0HDRRWFL09RlY2+pKeOZZqfaGOMX/Bkb+ 8AAAAA= To: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Maxime Coquelin , Alexandre Torgue Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Abid Ali X-Mailer: b4 0.13.0 X-Developer-Signature: v=1; a=ed25519-sha256; t=1779381166; l=1735; i=dev.taqnialabs@gmail.com; s=20260425; h=from:subject:message-id; bh=YT6MwxbT32LmsJ0Q4toXiSUGLZ0LUkCCQs3ZtA9Xc6A=; b=4nb99cKuWhzcka7MVU0baeVQGR1KS14hPy/Qj6o+FR+zkwGaooEwyN2rZln4L5Ctvpa4Fl4/0 VoiHf/eHZF6CxH9tbvd1DO3g0ClGL8324bUtCG3NHSJgcWl2owhEIwL X-Developer-Key: i=dev.taqnialabs@gmail.com; a=ed25519; pk=4Syx51HH/MOySSUpi79M2ToLOdwt1yiNb338eKZBJNk= X-Endpoint-Received: by B4 Relay for dev.taqnialabs@gmail.com/20260425 with auth_id=752 X-Original-From: Abid Ali Reply-To: dev.taqnialabs@gmail.com From: Abid Ali MMC_XGMAC_RX_CRC_ERR is clear-on-read, and just a single read would update the mmc_rx_crc_error counter. [1] commit b6cdf09 ("net: stmmac: xgmac: Implement MMC counters"). The duplicate read appears to have been unintentionally introduced in the intial MMC counter implementation. The databook does not mention MMC_XGMAC_RX_CRC_ERR needing the additional read. Fixes: b6cdf09 ("net: stmmac: xgmac: Implement MMC counters") Signed-off-by: Abid Ali Reviewed-by: Andrew Lunn --- Changes in v2: - Updated why the redundant read is removed based on feedback. - Link to v1: https://lore.kernel.org/r/20260520-xgmac-mmc_rx_crc-cleanup-v= 1-1-7133f529859f@gmail.com --- drivers/net/ethernet/stmicro/stmmac/mmc_core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/mmc_core.c b/drivers/net/e= thernet/stmicro/stmmac/mmc_core.c index 1b3b114e7..d81581dfa 100644 --- a/drivers/net/ethernet/stmicro/stmmac/mmc_core.c +++ b/drivers/net/ethernet/stmicro/stmmac/mmc_core.c @@ -479,8 +479,6 @@ static void dwxgmac_mmc_read(void __iomem *mmcaddr, str= uct stmmac_counters *mmc) &mmc->mmc_rx_multicastframe_g); dwxgmac_read_mmc_reg(mmcaddr, MMC_XGMAC_RX_CRC_ERR, &mmc->mmc_rx_crc_error); - dwxgmac_read_mmc_reg(mmcaddr, MMC_XGMAC_RX_CRC_ERR, - &mmc->mmc_rx_crc_error); mmc->mmc_rx_run_error +=3D readl(mmcaddr + MMC_XGMAC_RX_RUNT_ERR); mmc->mmc_rx_jabber_error +=3D readl(mmcaddr + MMC_XGMAC_RX_JABBER_ERR); mmc->mmc_rx_undersize_g +=3D readl(mmcaddr + MMC_XGMAC_RX_UNDER); --- base-commit: 028ef9c96e96197026887c0f092424679298aae8 change-id: 20260520-xgmac-mmc_rx_crc-cleanup-afcea6faa8ab Best regards, --=20 Abid Ali