From nobody Sun May 24 19:35:20 2026 Received: from mail-oo1-f52.google.com (mail-oo1-f52.google.com [209.85.161.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8DC5195811 for ; Fri, 22 May 2026 01:25:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779413143; cv=none; b=O6C8nbiJ2sdxwGvJiRClceaA27gnlX1j1Qxf0mRxUWwOvumX2UELuF5ROI7nft2cwjoG5WLK0yrvf0MDWH68vm08JhSHDiQ2iVQUyGksB/oZdWbj6XqtossvX+/av2zFRSzhxUgfdbD7CURA2Yclk7I9q19f1os8VLMs8FPYNh0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779413143; c=relaxed/simple; bh=meNlnmmcCErRmtN5Q8uakEi614HtX8GhsUthztF+AeI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=t3kAOObhBteWw5EnihvBbrlvpfD5VP1bt92LQg2Rg/QP92tN5LBK0T63pLCy/B7TGT/5XukzgRpiPptQWsSa9gkcyNNKwD6c8UX4fVh3qdpqSqKvIMiJf7dbJtawleglSUeqTQx9JZoPKYIxQTCPij4VQIbOUrMpZczz6GV4DnM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b=aFvd+aP1; arc=none smtp.client-ip=209.85.161.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre.com header.i=@baylibre.com header.b="aFvd+aP1" Received: by mail-oo1-f52.google.com with SMTP id 006d021491bc7-69d7f4cc61aso145544eaf.0 for ; Thu, 21 May 2026 18:25:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre.com; s=google; t=1779413140; x=1780017940; darn=vger.kernel.org; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:from:to:cc:subject:date:message-id:reply-to; bh=hA2gvcZ3PxG/BnJk7WhvBYIZEP6nJl42pt/2zxF+RLk=; b=aFvd+aP1yUL2FbfI4mS4s29i4B5we+AifWgPlRBre4qqrFvgqf44lMl0fsVB6wSmjk XDfUBhRztwPKF08zs+TLrLzShUeI/eSwVRT34b/d0WCkGUTwk6+npeyGLT37lXBiPN7u 2jsb8bTa38bjkSiThr079H11PSo+CoFlZNMRphrHTBeqEfrFIWXpYlFbe1xDjakSkc07 LT0X/4vyHSxRT7bF5rMJRGI+oP9gw4UFcj1Sd4bABgYqi7ac8D0ndW7ODhhsCFQgcB3v YWwoBcWPm6s2rDGLx3RmPAvYwQJggVkMOHinKyZ+ECH7sy904Yi+jmkplxOTQdEq6uaX M1HQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779413140; x=1780017940; h=cc:to:message-id:content-transfer-encoding:mime-version:subject :date:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hA2gvcZ3PxG/BnJk7WhvBYIZEP6nJl42pt/2zxF+RLk=; b=nLXecIB34X3Nk9pPCzpEmue2ybOGneUIb0LModVcjllvlY5m8uHJzF5uolLx4uN/ik qLyw8Ji2jR6xCpmxT8opWpUXo8iBgxelEqWp2EYU7h/GSG+mfNcoI5JzDQBaeU6QDKC1 d0bsVmTxFo8/H7d0Rjcq+7VP9sB+U2Q99VaxaC0c494Q+TcWO4cI80tTbtiijBvP4uvj mxQMeNiy2MsqJU/zPtjvLaqxKnROpdkEZfuskvN4A7ikUg9x+EiDOymJF7onO71uCuVv U0UltTwz+ZczlLfHMjf1BuVEhldH+ye85FyjfR9+PxR8tOwMZYzvyz1bza3zR9C+f+nz R/Qg== X-Forwarded-Encrypted: i=1; AFNElJ+qsXmjw1VK4rRV8isWSwpUTJF3iXY9SuR47mU1IuHLe6sKykF82o8+IG2OAf9XGe5FZChRP8vmMFJktfk=@vger.kernel.org X-Gm-Message-State: AOJu0Yw/441ctKA+XJ81P28uLZd4wnZymzEst45sJjNRHyex/fsfbp8T EWIRNTT1iAt4oeDEkaXCbxYy8EL7G9PufEGcxDipJ1QS1tgCdRrpA6uzDfFIP0WoLfA= X-Gm-Gg: Acq92OEUT+Oxfi7JSop1gDi+LqU8vpRQPEIEPabxRzDhniY7qo/97b2FVQg7jKTwdiH bf1PFtr12mV60cGB0touV4tbLssvhOKCPqNt40BDvXjE4GZ0zruxt5MBVqxov7M49QannOZrSpY mHiLrW2VOW9qKBRnkhyebgWt6ItihkbWz1/6GEZAiItyByZem/5kNECj0Ojnn/ZD4XDoej5II/I ngOduF8C1MkOpJh+Uanpd2JPGz8ybKtMcxj4DETZorodlsA4Y/ILhqQr+ASXKWyMgfHXbl2Le5P W/UfDroc8xj8Ag1wzHmr2yhZ8ezm4m5sKr0DeNazCp0yhtJ4bjzaB9LbXY9xUWl/gufPIWYMtNB 3zBuW2EqpFZNTTWl7jWsKahuZq2KZt1MibRIGD8Ou78WXswigSoH5bv5HLcPcicN4Gob+spXNyu 5CzDZ/EaSnVBlDEk9eBt07S5qspmhW X-Received: by 2002:a05:6820:498b:b0:694:a2c9:2d50 with SMTP id 006d021491bc7-69d7ece3888mr708153eaf.59.1779413139688; Thu, 21 May 2026 18:25:39 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:500:569b:86c6:c367:5139]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-69d83a4eee4sm121768eaf.10.2026.05.21.18.25.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 May 2026 18:25:39 -0700 (PDT) From: David Lechner Date: Thu, 21 May 2026 20:25:29 -0500 Subject: [PATCH] iio: humidity: ens210: remove compiler warning workaround Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20260521-iio-humidity-ens210-remove-hack-v1-1-9528ac1b384b@baylibre.com> X-B4-Tracking: v=1; b=H4sIAAAAAAAC/yXNQQ6CMBBA0auQWTtJ29ASvYpxUcpIB0NrOkA0h Ltbdfk2/+8gVJgELs0OhTYWzqlCnxoI0aeRkIdqMMo4ZY1G5oxxnXng5Y2UxGiFhea8EUYfHtg F6117drbtAtTKs9CdX7/D9fa3rP1EYflm4Tg+7UE1U4MAAAA= X-Change-ID: 20260521-iio-humidity-ens210-remove-hack-7c5a6496547c To: Jonathan Cameron , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, David Lechner X-Mailer: b4 0.16-dev X-Developer-Signature: v=1; a=openpgp-sha256; l=1710; i=dlechner@baylibre.com; h=from:subject:message-id; bh=meNlnmmcCErRmtN5Q8uakEi614HtX8GhsUthztF+AeI=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBqD7CLamtm2lN/Csp2zizg2L4IAAZQLddI4kk1c IiufwMQ3A6JATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCag+wiwAKCRDCzCAB/wGP wF+XB/4sDrBd7LGuFHAYXYRco83eA0WmtcQbAM8GP6AVJf4LtchXth2sDtCCcz9Im0q6UIL0mQT BJQ6ExlWIRjJC/dnqAaMUeaKYNwRUf5k9bbaKm6wb58C8PEUhcgFQkdqL388VEYzMI1cMyzd5jW hObn7UzcKmFcSFU+2yMI5dX4RaVNMaTniLcow2c8g4ZcoRe0KYe+tamdkbVolk1e5lFU8XrQKkm IDuPFV1LNC6zFeAt2VxuafF7CKRLM43TSlb3bc18NDR0BBVs5wi4l53wxkYNLUoexZ7pxfUq26f Bzf+D7bm6vM8DK0Qg6iKn7F1t4/jpFj5NthGkTfUevjBBioF X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Rewrite IIO_CHAN_INFO_RAW case to avoid needing to add unreachable code to work around a compiler warning. When scoped_guard() was first introduced, compilers could not see when it returned unconditionally from inside the hidden for loop. This has since been fixed in the macro definition. So removing the `return -EINVAL` should be enough. Still, we can improve readability, decrease indentation and avoid the hidden for loop by rewriting the case without scoped_guard(). Signed-off-by: David Lechner --- drivers/iio/humidity/ens210.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/iio/humidity/ens210.c b/drivers/iio/humidity/ens210.c index 22ad208e6aa6..49543fc389bf 100644 --- a/drivers/iio/humidity/ens210.c +++ b/drivers/iio/humidity/ens210.c @@ -149,15 +149,16 @@ static int ens210_read_raw(struct iio_dev *indio_dev, int ret; =20 switch (mask) { - case IIO_CHAN_INFO_RAW: - scoped_guard(mutex, &data->lock) { - ret =3D ens210_get_measurement( - indio_dev, channel->type =3D=3D IIO_TEMP, val); - if (ret) - return ret; - return IIO_VAL_INT; - } - return -EINVAL; /* compiler warning workaround */ + case IIO_CHAN_INFO_RAW: { + guard(mutex)(&data->lock); + + ret =3D ens210_get_measurement(indio_dev, channel->type =3D=3D IIO_TEMP, + val); + if (ret) + return ret; + + return IIO_VAL_INT; + } case IIO_CHAN_INFO_SCALE: if (channel->type =3D=3D IIO_TEMP) { *val =3D 15; --- base-commit: e1a29334a9c043defe7a9363fa76d399d3fdfbec change-id: 20260521-iio-humidity-ens210-remove-hack-7c5a6496547c Best regards, -- =20 David Lechner